From: Bruce Richardson <bruce.richardson@intel.com>
To: Ankur Dwivedi <adwivedi@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
ferruh.yigit@intel.com
Subject: Re: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec
Date: Thu, 10 Feb 2022 11:31:57 +0000 [thread overview]
Message-ID: <YgT3rY7mhhvm1iim@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <DM5PR1801MB1884389D393E9374679DB47DDD2F9@DM5PR1801MB1884.namprd18.prod.outlook.com>
On Thu, Feb 10, 2022 at 10:04:22AM +0000, Ankur Dwivedi wrote:
> Hi Bruce,
>
> Please see my comment inline.
>
> Regards,
> Ankur
>
> >-----Original Message-----
> >From: Bruce Richardson <bruce.richardson@intel.com>
> >Sent: Thursday, February 10, 2022 2:42 PM
> >To: Ankur Dwivedi <adwivedi@marvell.com>
> >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>;
> >Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori
> ><skori@marvell.com>; Satha Koteswara Rao Kottidi
> ><skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran
> ><jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree
> >Kondoj <ktejasree@marvell.com>
> >Subject: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote:
> >> Adds telemetry function for inline ipsec in net CNXK driver.
> >>
> >> This series depends on the following patch series:
> >>
> >> Series: Adding new features and improvements in cnxk crypto PMD
> >> https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_p
> >> roject_dpdk_list_-3Fseries-
> >3D21433&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r
> >>
> >=ILjiNF3GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=szcLmV4s_NiVroE4B
> >vC5yW6
> >>
> >litxm6Pfo2ymX7QhE1qDSpKTa56lnfmMqfnohRfI6&s=VtKHr9SAo3R0g7lGPoSJlg
> >xVxn
> >> r2t_TYhHbfH7rS4sE&e=
> >>
> >> Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for cn9k
> >> net/cnxk: add telemetry for inline IPsec for cn10k
> >>
> >Out of interest, is there any of this telemetry that could be made generic and
> >apply at a device-class or library level rather than being tied to the cnxk driver
> >only?
> I could think of that the callback function registered in rte_telemetry_register_cmd() can be a generic one. The net device (eth_dev) may have ops registered, which can be called depending on dev->tx_offloads and dev->rx_offloads flags. However the data to be returned by telemetry might depend on the PMD.
> Please let me know if this is possible.
Thanks. So if I understand you correctly, the information returned would
vary based on the offload flags only? If that is the case, it does sound
like it could be generic, where the offload flags field in the return
information identify what other fields are present in the reply. That would
then make the telemetry generic and possible to implement at the ethdev
level. Is that all correct?
next prev parent reply other threads:[~2022-02-10 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:53 Ankur Dwivedi
2022-02-10 6:53 ` [PATCH 1/2] net/cnxk: add telemetry for inline IPsec for cn9k Ankur Dwivedi
2022-02-17 17:51 ` Jerin Jacob
2022-02-10 6:53 ` [PATCH 2/2] net/cnxk: add telemetry for inline IPsec for cn10k Ankur Dwivedi
2022-02-10 9:12 ` [PATCH 0/2] add telemetry for inline IPsec Bruce Richardson
2022-02-10 10:04 ` [EXT] " Ankur Dwivedi
2022-02-10 11:31 ` Bruce Richardson [this message]
2022-02-10 13:29 ` Ankur Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgT3rY7mhhvm1iim@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ktejasree@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).