From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19850A00BE; Thu, 10 Feb 2022 15:08:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F33D342707; Thu, 10 Feb 2022 15:08:05 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E95BD4013F; Thu, 10 Feb 2022 15:08:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644502084; x=1676038084; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xjmjhBHG1iwY3B3vKJlK2ddtPpLOLuvZ8N+yEI7vM2E=; b=H1M+egWgEbgUXQf4jmugwPLq5Gw/nkoj00RSrbzv4Dn47jB4fI88Bno7 kXQw4QUqBd8eHbxINcIWnRRka5XgfNdwVBIiPA1PxM/CzQV5wogJyvqVS zr/yr5jQLjtZFW94mZEExg1H/AYoHaq5W7qNYUXqtbywHOl6o7fYTeoET HctZfqa8gTqIXtjMU9P4IEW4Fp+PBjX8VsFNfDoD86Xkeyniu/XifWEt8 N9XMFkqkL0zcNrwTSy8ycNfRoxU/8/x3LFuqsKgTWKfaOFqJYscp3i4Rf C8v4cOFuweakiUTyyiEEiX+hxezKVBxnbqIiB8y1Eg0LFw+eTPLy7dGb2 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="229463968" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="229463968" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 06:08:03 -0800 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="541622430" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.92]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Feb 2022 06:08:00 -0800 Date: Thu, 10 Feb 2022 14:07:57 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Joyce Kong , dpdk stable , Honnappa Nagarahalli , Ola Liljedahl , Gavin Hu , Konstantin Ananyev , Jerin Jacob Subject: Re: [PATCH v2 1/7] eal: fix header build with C++ Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220210120257.585822-1-bruce.richardson@intel.com> <20220210120257.585822-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 10, 2022 at 01:57:09PM +0100, David Marchand wrote: > On Thu, Feb 10, 2022 at 1:03 PM Bruce Richardson > wrote: > > > > C++ files could not include some headers because: > > > > * "new" is a keyword in C++, so can't be a variable name > > * there is no automatic casting to/from void * > > > > Fixes: 184104fc6121 ("ticketlock: introduce fair ticket based locking") > > Fixes: ebaee6409702 ("trace: simplify trace point headers") > > rte_strcpy was moved in this commit. > This is more about: > Fixes: 032a7e5499a0 ("trace: implement provider payload") > Thank you, I missed that even though I did some searching beyond the commit I referenced, which I suspected was only moving things! Unfortunately, I didn't see this before I did up a v3 to fix the CI issues. If necessary I'll do a v4 to correct, once I check there are no other CI problems. /Bruce