From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E2BCA00BE; Thu, 10 Feb 2022 16:21:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3694D42704; Thu, 10 Feb 2022 16:21:08 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0941F426EE for ; Thu, 10 Feb 2022 16:21:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644506467; x=1676042467; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6iB/lDHKK8RmTnVN1Iu0Ua8VMqccV36aQ9xDBVzhEQc=; b=BE7TBZ4SuBRHlKlglCSfO3KzVmjwEx300LNhHFYXC5O2Y27vQbaSVscY xOnVYB40V6AJO63VeFP2vjUkQl6FQHx0RAfonvRY7YnsEDYDT6939gQld y8JxuKRRaixHgrXStoEId7H/iF9BhJY89Tc4oNndfpfBjAOvCQTKnrCnK Z3UlZzfpY3elxW4oVnAdTKGA7MYZSoYypEk2bwe7/ffuFYOebNabfYPpT Dj6HnNHWjFfXYwaVX+Q2t1RcMsa+KQWc3f+sRUO1vuT1cCG96mFx0yQ3l vTDwoSz3qms/JMWMhl2R0F1Vh2P2nnO0sr1IBDLyaoveWakqv3UeM9mJc Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="248344490" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="248344490" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 07:21:05 -0800 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="485717032" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.92]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Feb 2022 07:21:03 -0800 Date: Thu, 10 Feb 2022 15:21:00 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Aaron Conole , Michael Santana , Thomas Monjalon Subject: Re: [PATCH v3 7/7] buildtools/chkincs: test headers for C++ compatibility Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220210140355.586399-1-bruce.richardson@intel.com> <20220210140355.586399-8-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 10, 2022 at 03:37:04PM +0100, David Marchand wrote: > On Thu, Feb 10, 2022 at 3:05 PM Bruce Richardson > wrote: > > > > Add support for checking each of our headers for issues when included in > > a C++ file. > > > > Signed-off-by: Bruce Richardson > > --- > > .ci/linux-build.sh | 1 + > > buildtools/chkincs/main.cpp | 4 ++++ > > buildtools/chkincs/meson.build | 20 ++++++++++++++++++++ > > 3 files changed, 25 insertions(+) > > create mode 100644 buildtools/chkincs/main.cpp > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index c10c1a8ab5..67d68535e0 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -74,6 +74,7 @@ fi > > > > if [ "$BUILD_32BIT" = "true" ]; then > > OPTS="$OPTS -Dc_args=-m32 -Dc_link_args=-m32" > > + OPTS="$OPTS -Dcpp_args=-m32 -Dcpp_link_args=-m32" > > export PKG_CONFIG_LIBDIR="/usr/lib32/pkgconfig" > > fi > > > > Even though check_includes=true is not forced for 32bits in > test-meson-builds.sh, I sometimes enable more checks for some targets. > Can this change be applied to test-meson-builds.sh too? > > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n249 > Yes, will do.