From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02138A00C5; Mon, 14 Feb 2022 11:46:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2D5A40DDA; Mon, 14 Feb 2022 11:45:59 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 755A64068C for <dev@dpdk.org>; Mon, 14 Feb 2022 11:45:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644835558; x=1676371558; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NsnRDRFdTbrjnlk06p79yXh4mpSOuI3B9BQp9NxNyh8=; b=U2FZ6DDMXzXDndjsXIeUpy09hHtrv0trBzLj0+llt7gvY3d04IyCtP0F jaN10heHKXVtQij7Iybpng5/gVyaxCRfVxlJhmp+QOjn2RTj0hDNvFN4u 0gFlkTUmfjS65ply2urtg/byCweJ3Z0Lf46lQ4yYZ93++meXWJWRXo+04 DbX4tkMZpCDPj4a8YlK0h7OLjm8U9sfBHTyw2VloWoFZQudf/uQKQraF/ FM+0c/JavloaifYUxS7UGwOkrwjT2YSyFoRkTz8aSqKLhihhZ5NzpQFfx 4c2aShirnlA3ADoLqaCmEdMhZ4nR1KA4fbTJBwDj12zd/XbaaaJpltgWB w==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="313342901" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="313342901" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 02:45:57 -0800 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="543431877" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.94]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Feb 2022 02:45:55 -0800 Date: Mon, 14 Feb 2022 10:45:52 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, dev@dpdk.org, ocardona@microsoft.com, roretzla@microsoft.com, david.marchand@redhat.com, ferruh.yigit@intel.com Subject: Re: out of tree driver builds broken with C++ Message-ID: <Ygoy4Fy4X84N1Iqs@bricha3-MOBL.ger.corp.intel.com> References: <20220214091350.GA2793@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <3450334.eFTFzoEnKi@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3450334.eFTFzoEnKi@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thomas Monjalon wrote: > 14/02/2022 10:13, Tyler Retzlaff: > > while the driver api is "internal" we agreed some time ago that drivers > > could be built external to the dpdk tree. by enabling the meson setup > > option -Denable_driver_sdk=true. > > > > it was agreed that the driver api was internal and would attract no > > binary compatibility support which was fine. this change has now > > imposed a further restriction that out of tree drivers have to be > > authored in C only as non-C++ compatible code will invariably leak into > > the internal structures. > > > > you won't allow us to build C++ drivers in the dpdk tree and it seems > > now you are preventing building of C++ drivers outside of the tree too. > > That's the problem of non-written assumptions, they are unknown or forgotten. > Did we agree to support out-of-tree drivers in C++? > > We really need to make things clear and written in documentation. > > > could we please re-evaluate this. > > Yes we can re-evaluate. > What is the list of impacted files? > Hacking meson files a bit, the list of SDK header files is reported as below. /Bruce Message: SDK headers: Message: ethdev_driver.h Message: ethdev_pci.h Message: ethdev_vdev.h Message: cryptodev_pmd.h Message: eventdev_pmd.h Message: eventdev_pmd_pci.h Message: eventdev_pmd_vdev.h Message: eventdev_trace.h Message: event_timer_adapter_pmd.h Message: rte_dmadev_pmd.h Message: vdpa_driver.h