From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A01A034C; Mon, 14 Feb 2022 12:52:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8032D4114E; Mon, 14 Feb 2022 12:52:04 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 430EE410F3 for ; Mon, 14 Feb 2022 12:52:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644839523; x=1676375523; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=j+cxzxUx9ysuoMjFOkqQqWxHSGtB62V0A1dzqP0YS04=; b=OPZWPW5MsUWQxFX8fVV59hxVe94LHet9atuoiu0SND+SozfWVH82rlNS Mw9QmVv+JwXW52yuT7uOWrq20fwIfKuUkWOEI4xkz4YgvAnQL+Zjvov5R 0V+uk3AVo3HlEp0yqGKPFeqCBMpdS52SoQQMoq5tRpAlcl7K9LaiX0EZr SUXvo8N064/G9k556rcr+335JdEKGozESLHe/hzpMX6ImuoveTKy3WQUY o02Er8EWjOwDvNrWit16ivdaFVNxy9y+BwCNNzqpcLtk1ylqnzB9bLKAh 2zyBQmEd0BtFnu5iZthW+Zwo37kKUsBG/0O7oEBFy6YW46dn0wzEazbDR g==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="233621642" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="233621642" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 03:52:02 -0800 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="495497916" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.94]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Feb 2022 03:52:01 -0800 Date: Mon, 14 Feb 2022 11:51:57 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: Stephen Hemminger , dev@dpdk.org Subject: Re: [PATCH v2 0/2] rte_dump_stack: improvements Message-ID: References: <20220129011039.264377-1-stephen@networkplumber.org> <20220212184433.66791-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35D86E9B@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E9B@smartserver.smartshare.dk> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 14, 2022 at 12:10:30PM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Saturday, 12 February 2022 19.45 > > > > This is update to earlier RFC. Add some more comments and changes > > to have common code for Linux and FreeBSD > > > > Stephen Hemminger (2): > > eal_debug: do not use malloc in rte_dump_stack > > eal: common rte_dump_stack for both Linux and FreeBSD > > > > lib/eal/freebsd/eal_debug.c | 43 ------------------------ > > lib/eal/freebsd/meson.build | 1 - > > lib/eal/linux/eal_debug.c | 43 ------------------------ > > lib/eal/linux/meson.build | 1 - > > lib/eal/unix/eal_debug.c | 65 +++++++++++++++++++++++++++++++++++++ > > lib/eal/unix/meson.build | 5 +-- > > 6 files changed, 68 insertions(+), 90 deletions(-) > > delete mode 100644 lib/eal/freebsd/eal_debug.c > > delete mode 100644 lib/eal/linux/eal_debug.c > > create mode 100644 lib/eal/unix/eal_debug.c > > > > -- > > 2.34.1 > > > > The dladdr() man page mentions that linking with -ldl is required; I assume this is already part of the DPDK EAL build system? > Yes, we should be already linking against dl because of the use of dlopen for loading drivers dynamically.