From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4243AA034C; Fri, 25 Feb 2022 16:50:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2A9A4115C; Fri, 25 Feb 2022 16:50:57 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A51A34068B; Fri, 25 Feb 2022 16:50:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645804256; x=1677340256; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QuV1tx49UBII/YuzqKAtgDktI4f7j0ubPmitlyEbTr0=; b=Xdxy6yEx5bmbgxJozJUrhsxq1Hd72wF6d64EFgGpzl/7j6I17BEYrVkr khW0Y5O0NE/NVpsCooUqho1AGaz1RWJjM3iVJmbG86GVSpYM+JyHIo1fY SS2mzQ7bJRcUFgwYKL/CF1yZyy4lSMuZykp7Xv9T/9BUOLwsjWlQrMWIC /1JnxIOwwyPiLX+1UlnkUScCI39wYozQNKPBdluzwh/DLohAkqM8S7AsL 7HzkwrjbgPgVB8Ev+lprhvtOpO/30J9tFsWVq+LElKaQzKhgoyOB32qZd OffA3q0puTOwh1jk6+f41jskMiiVtABLG1/YxPBqSoBjBhsKI1axHDQRh w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="315735588" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="315735588" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 07:50:54 -0800 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="533612622" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.25.244]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 Feb 2022 07:50:52 -0800 Date: Fri, 25 Feb 2022 15:50:49 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Xiaoyun Li , Aman Singh , Yuying Zhang , Ajit Khaparde Subject: Re: [PATCH] app/testpmd: fix build without drivers Message-ID: References: <20220225152653.72437-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225152653.72437-1-thomas@monjalon.net> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: > When ixgbe and bnxt are disabled, compilation was failing: > > app/test-pmd/cmdline.c:9396:11: error: > variable 'vf_rxmode' set but not used > > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > --- > app/test-pmd/cmdline.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index b4ba8da2b0..7ab0575e64 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result, > } > > RTE_SET_USED(is_on); > + RTE_SET_USED(vf_rxmode); > Checking the code, I see the issue and the fix looks correct. However, doing some basic builds disabling the relevant drivers, and all drivers, in fact, I fail to reproduce the actual error message. Does this error only occur at lower optimization levels, or only using clang or similar? Acked-by: Bruce Richardson