From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28FCCA0350; Mon, 28 Feb 2022 10:46:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0C1641157; Mon, 28 Feb 2022 10:46:31 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 64BCD4068C for ; Mon, 28 Feb 2022 10:46:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646041590; x=1677577590; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ehXX6b8Vb1LObLcOSEWZRkyMeaaGtN5BYEQajHo51co=; b=HPi/skhp1i6vOeYY3TJov5OITLENUBsot/LFOwFcxt1mWuBVYFuJH3dO MV9MuJ7y8NO4d7/8FqdRvciwk2AjiQnoXjzZM6J8+oq5LmoC5f2dKhJd6 orEJRZGOyayUx/bmQ4VOgXpiTBUQHgpakG0lY8B6xYNJpL0y4zgCBy4J4 xs7GXgVg27YdgI8HGJar4RFRWHUzWXUkBsN6rE8u4ofvXkwQYE5s5Crbf zkkqRgL0wwtJMEOixmhemK108GC5jIemUBght9W41hUw1u7nnDx/Ah7r/ ZzmhTZNbkiXaMzbPZYlbVRHKYpe1rh1LL5Ab9SnQzbjNLIYxv4zZgX4qu w==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="316061210" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="316061210" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 01:46:29 -0800 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="550171625" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.27.47]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Feb 2022 01:46:28 -0800 Date: Mon, 28 Feb 2022 09:46:25 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Aaron Conole , Michael Santana Subject: Re: [PATCH] ci: remove redundant drivers enabling Message-ID: References: <20220226183651.2165304-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220226183651.2165304-1-thomas@monjalon.net> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote: > No need to explicitly enable drivers bus/vdev and mempool/ring. > > bus/vdev is always enabled since > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > mempool/ring is always enabled since > commit 81c2337e044d ("build: make ring mempool driver mandatory") > > Signed-off-by: Thomas Monjalon One comment inline below. Acked-by: Bruce Richardson > --- > .ci/linux-build.sh | 2 +- > devtools/test-meson-builds.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index 67d68535e0..77c0d1976b 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB" > OPTS="$OPTS --buildtype=debugoptimized" > OPTS="$OPTS -Dcheck_includes=true" > if [ "$MINI" = "true" ]; then > - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null" > + OPTS="$OPTS -Denable_drivers=net/null" > OPTS="$OPTS -Ddisable_libs=*" > fi > meson build --werror $OPTS > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index c07fd16fdc..a653b253cb 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -221,7 +221,7 @@ for c in gcc clang ; do > done > > build build-mini cc skipABI $use_shared -Ddisable_libs=* \ > - -Denable_drivers=bus/vdev,mempool/ring,net/null > + -Denable_drivers=net/null Do we even need this enabled for a mini-build. Would disable_drivers=*/* not work better to truly have a minimal build? > > # test compilation with minimal x86 instruction set > # Set the install path for libraries to "lib" explicitly to prevent problems > -- > 2.34.1 >