DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Ben Magistro" <koncept1@gmail.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	dev@dpdk.org, ben.magistro@trinitycyber.com,
	stefan.baranoff@trinitycyber.com, stable@dpdk.org,
	"Luca Boccassi" <bluca@debian.org>,
	"Christian Ehrhardt" <christian.ehrhardt@canonical.com>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>,
	"Kevin Traynor" <ktraynor@redhat.com>
Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump
Date: Wed, 6 Apr 2022 09:33:56 +0200	[thread overview]
Message-ID: <Yk1CZGhnsOZcoxQr@arsenic.home> (raw)
In-Reply-To: <3423184.iIbC2pHGDl@thomas>

Hi,

On Tue, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote:
> 04/04/2022 12:33, Kevin Traynor:
> > On 04/04/2022 07:15, Morten Brørup wrote:
> > >> From: Ben Magistro [mailto:koncept1@gmail.com]
> > >> Sent: Monday, 4 April 2022 02.57
> > >>
> > >> Enable printing of the outer vlan if flags indicate it is present.
> > >>
> > >> Signed-off-by: Ben Magistro <koncept1@gmail.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> > >>
> > >> ---
> > >>
> > >> While troubleshooting some QinQ offloads with various Intel i40e
> > >> firmware[1], it was
> > >> helpful to expose the outer vlan in the dump mbuf calls.  This should
> > >> be straightforward
> > >> to backport and happy to do the work if accepted. I understand that
> > >> this may not be a
> > >> widely supported capability at this time, so we are okay if this is not
> > >> accepted and
> > >> we just maintain a local patch.
> > > 
> > > Features are usually not backported, only bug fixes.
> > > 
> > > However, since this patch proved helpful finding a bug, and it is very simple, it could be considered by the LTS maintainers.
> > 
> > 
> > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is 
> > requested for stable branches. It will be caught by stable maintainer 
> > filters when it is time for backports and can be discussed further then.
> 
> I think it is a bug.
> What was introduced first? the function or the field?
> Please find the commit where it should have been done
> and mark it with "Fixes:" syntax + Cc:stable.

The vlan dump was introduced by commit 5b6eaea8ea7c ("mbuf: display more
fields in dump"), but I don't think we can say it's a bug. To me, it is
an enhancement that could be backported, because there is a benefit with
a very low risk.

  reply	other threads:[~2022-04-06  7:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04  0:56 Ben Magistro
2022-04-04  6:15 ` Morten Brørup
2022-04-04 10:33   ` Kevin Traynor
2022-04-05 15:51     ` Thomas Monjalon
2022-04-06  7:33       ` Olivier Matz [this message]
2022-04-12 16:11         ` Ben Magistro
2022-04-13 12:02           ` Thomas Monjalon
2022-04-13 12:59             ` Morten Brørup
2022-06-01  9:18               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk1CZGhnsOZcoxQr@arsenic.home \
    --to=olivier.matz@6wind.com \
    --cc=ben.magistro@trinitycyber.com \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=koncept1@gmail.com \
    --cc=ktraynor@redhat.com \
    --cc=mb@smartsharesystems.com \
    --cc=stable@dpdk.org \
    --cc=stefan.baranoff@trinitycyber.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).