From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03FD8A0509; Wed, 6 Apr 2022 09:33:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9FAC40DF6; Wed, 6 Apr 2022 09:33:57 +0200 (CEST) Received: from smtpservice.6wind.com (unknown [185.13.181.2]) by mails.dpdk.org (Postfix) with ESMTP id 5A6DD40689; Wed, 6 Apr 2022 09:33:56 +0200 (CEST) Received: from 6wind.com (unknown [10.17.250.37]) by smtpservice.6wind.com (Postfix) with ESMTP id 3EE3D6000E; Wed, 6 Apr 2022 09:33:56 +0200 (CEST) Date: Wed, 6 Apr 2022 09:33:56 +0200 From: Olivier Matz To: Thomas Monjalon Cc: Ben Magistro , Morten =?iso-8859-1?Q?Br=F8rup?= , dev@dpdk.org, ben.magistro@trinitycyber.com, stefan.baranoff@trinitycyber.com, stable@dpdk.org, Luca Boccassi , Christian Ehrhardt , "Xueming(Steven) Li" , Kevin Traynor Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump Message-ID: References: <20220404005634.2657-1-koncept1@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D86F9B@smartserver.smartshare.dk> <95d923da-0216-9a66-2713-17f0a6442a0c@redhat.com> <3423184.iIbC2pHGDl@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3423184.iIbC2pHGDl@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On Tue, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote: > 04/04/2022 12:33, Kevin Traynor: > > On 04/04/2022 07:15, Morten Brørup wrote: > > >> From: Ben Magistro [mailto:koncept1@gmail.com] > > >> Sent: Monday, 4 April 2022 02.57 > > >> > > >> Enable printing of the outer vlan if flags indicate it is present. > > >> > > >> Signed-off-by: Ben Magistro Acked-by: Olivier Matz > > >> > > >> --- > > >> > > >> While troubleshooting some QinQ offloads with various Intel i40e > > >> firmware[1], it was > > >> helpful to expose the outer vlan in the dump mbuf calls. This should > > >> be straightforward > > >> to backport and happy to do the work if accepted. I understand that > > >> this may not be a > > >> widely supported capability at this time, so we are okay if this is not > > >> accepted and > > >> we just maintain a local patch. > > > > > > Features are usually not backported, only bug fixes. > > > > > > However, since this patch proved helpful finding a bug, and it is very simple, it could be considered by the LTS maintainers. > > > > > > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is > > requested for stable branches. It will be caught by stable maintainer > > filters when it is time for backports and can be discussed further then. > > I think it is a bug. > What was introduced first? the function or the field? > Please find the commit where it should have been done > and mark it with "Fixes:" syntax + Cc:stable. The vlan dump was introduced by commit 5b6eaea8ea7c ("mbuf: display more fields in dump"), but I don't think we can say it's a bug. To me, it is an enhancement that could be backported, because there is a benefit with a very low risk.