From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F320A00BE; Tue, 19 Apr 2022 10:45:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B6614068E; Tue, 19 Apr 2022 10:45:13 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 482FA40687 for ; Tue, 19 Apr 2022 10:45:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650357911; x=1681893911; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/bFpJPOt24A0OXTrP2rf/a1J2Ul2fAIGvefAO0hcn6Q=; b=gua0VOzvTAyCQ4jdZSZP8qbSREXppEkUCS+iHLALi0iBwebFpujcKgrC xjvdUfZndTyTPgWm8+UsfvOD9AKKYtRrvY1ARZNw1LtADaQXnjgN+iO1r /7e7kjVLlTJXPmAyWbOAoOe3cpzzeOgr3RM9ddkeRewbJL7SjamjU3bAx 9xTwBDG5aeEkOq+6iffKh80V+jCOKWgJ+2YLzFr5H1PVDdbPe4OnLxoeZ 5sRTm33CkKL+wrtiE6akSquRF4qC+Ao0TbUiKh5SVuG9vlCV5yXksikP9 dLS+0KDmevcuunbWz47752wiYwqSDmMc1z9wqzRIlkRxqZ6Pem/Z7KQaH w==; X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="262573720" X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="262573720" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 01:45:08 -0700 X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="510062062" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Apr 2022 01:45:06 -0700 Date: Tue, 19 Apr 2022 09:45:03 +0100 From: Bruce Richardson To: fengchengwen Cc: thomas@monjalon.net, kevin.laatz@intel.com, dev@dpdk.org Subject: Re: [PATCH v2 3/4] examples/dma: support enqueue drop statistic Message-ID: References: <20220411025634.33032-1-fengchengwen@huawei.com> <20220411121459.23898-1-fengchengwen@huawei.com> <20220411121459.23898-4-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Apr 16, 2022 at 02:19:24PM +0800, fengchengwen wrote: > DMA is a memcopy engine, and from that perspective, I think it's appropriate > to use copy_failures when dma_enqueue fails. > > The newly added enqueue_failures is mainly used for rte_ring_enqueue_burst > failures. > > Since the app doesn't have a command line, I think adding this field can > immediately identify where it failed. > So one stat is for the HW path and the other is for the SW one? If that is the case, only one stat should probably be printed out by the app depending on the mode is it in. > On 2022/4/13 23:01, Bruce Richardson wrote: > > On Mon, Apr 11, 2022 at 08:14:58PM +0800, Chengwen Feng wrote: > >> The copy drop statistic counted in two scenarios: DMA copy failures and > >> enqueue failures. so it is difficult to locate the problem. > >> > > > > Is the app actually tracking copy failures? From a quick glance at the code > > it looks to me like the only "copy_failures" are the enqueue failures, in > > which case the stat should just be renamed. > > > >> This patch adds enqueue drop statistic to fix the it. > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> examples/dma/dmafwd.c | 14 +++++++++----- > >> 1 file changed, 9 insertions(+), 5 deletions(-) > >> > > > > . > > >