From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BE28A034C; Fri, 8 Apr 2022 16:49:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CE9D410EC; Fri, 8 Apr 2022 16:49:37 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CB8364003F; Fri, 8 Apr 2022 16:49:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649429376; x=1680965376; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jMQEFow+/hlx56EiyVy7KwETzbFhFZux5KO/ZgafxhM=; b=m27Pi/0JbV0nJbRq6jSrsJLnyKtmHRkDPA0xr7ATZjywcHi+5VZxcd9J ceRf8A9jVdK7Z0YtQWZPOBW33aoZ7IMXpicfViOG8kSG4ZYD3EAPaSo+z jRbeSisU4JcHxzb14umBKDcvAcC79K8UfbKce8I0htaNMt7XUV1eMXjv4 CVkzKZRAZtLnASXdvUWitld4W9fQIJueOBUKw2EFevqm5KqwJ8qLBjBqB m8CZs9njo7b/DVB4MV7KRpDjJpxOtVdyNlg1ckbOEjn5r0/lK7uBm4k35 G2xD2iK9SSQf9agG/REBDmBzBK+HjcHG6wFZQ/wm/r2XOtebc4tf0R+hk A==; X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="249138249" X-IronPort-AV: E=Sophos;i="5.90,245,1643702400"; d="scan'208";a="249138249" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2022 07:49:34 -0700 X-IronPort-AV: E=Sophos;i="5.90,245,1643702400"; d="scan'208";a="525399835" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.224.53]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Apr 2022 07:49:33 -0700 Date: Fri, 8 Apr 2022 15:49:30 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, stable@dpdk.org, Xingguang He , Conor Walsh Subject: Re: [PATCH 1/5] dma/idxd: fix memory leak in pci close Message-ID: References: <20220408141504.1319913-1-kevin.laatz@intel.com> <20220408141504.1319913-2-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408141504.1319913-2-kevin.laatz@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 08, 2022 at 03:15:00PM +0100, Kevin Laatz wrote: > ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev' > struct. > > This is fixed by free'ing the struct when the last queue on the PCI > device is being closed. > > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Cc: stable@dpdk.org > Cc: bruce.richardson@intel.com > > Reported-by: Xingguang He > Signed-off-by: Kevin Laatz > --- Acked-by: Bruce Richardson