From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 010D0A0506; Tue, 12 Apr 2022 10:39:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4C8D41611; Tue, 12 Apr 2022 10:39:07 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 24216410E1 for ; Tue, 12 Apr 2022 10:39:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649752746; x=1681288746; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yAGK9mNCO6mHK1rkDbU9xSdecPY8HkPrB0UCOCya2pA=; b=O73jwiahxViZk5+oD7PV7Y1GFVKFe54gF0cPnbSlXXVYT0IUE0xG7qK8 uY4+q1lUrjwlFT5DRGfTT4nwnoSBJPmvRQaQMmh8xSQ6PfsNMUV4VZ5Y2 rDm/htI+1C08ZB/yD73naG9n46qklCOzxNIYcKg7HPwg4F/xmbzbloaIy FauQ9zV4RhOwTqAOS49cl1lTeAm4h13Dg2cpI5ChYlxfFB40oleiiYbom nu7XakFieDBDLHC5bB859HG9r4G6ZIkN4oKXkNk3dxO3NeCnQEXNdfCdX +6RH69wK/eCQBke49Ul2dVyh7pr2Kz4Q13/rxiG7o9Dc6cKrMW2w/atIq g==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="242904803" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="242904803" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 01:39:03 -0700 X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="551606253" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.40]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Apr 2022 01:39:02 -0700 Date: Tue, 12 Apr 2022 09:38:58 +0100 From: Bruce Richardson To: zhichaox.zeng@intel.com Cc: haiyue.wang@intel.com, dev@dpdk.org Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols Message-ID: References: <20220412142706.831243-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412142706.831243-1-zhichaox.zeng@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote: > From: zhichao zeng > > Remove expired experimental symbols. > > Signed-off-by: zhichao zeng > --- > drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++--------------- > drivers/net/ixgbe/version.map | 10 +++++----- > 2 files changed, 10 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h > index eef6f6661c..4f1fe6029d 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h > @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port); > * - (-ENODEV) if *port* invalid. > * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed > */ > -__rte_experimental > -int > -rte_pmd_ixgbe_mdio_lock(uint16_t port); > +int rte_pmd_ixgbe_mdio_lock(uint16_t port); > I don't see the value in rewriting the prototypes to be all on one line as part of this change. Just remove the experimental tag line in this patch, to keep the diff as small as possible. /Bruce