From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 15E48A050A;
	Tue, 12 Apr 2022 15:36:57 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A1F3040DF6;
	Tue, 12 Apr 2022 15:36:56 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by mails.dpdk.org (Postfix) with ESMTP id 8DE054014F
 for <dev@dpdk.org>; Tue, 12 Apr 2022 15:36:54 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1649770614; x=1681306614;
 h=date:from:to:cc:subject:message-id:references:
 mime-version:in-reply-to;
 bh=DFrLgCwnWSOLfKA492aSOkxaJWS7saHU3GVPxjfYMUk=;
 b=U7CLKB8gMFDb2NBgVaUtz4k2DN4juboIjotJEUzJxbf2u55rJtx65yAC
 rHWPDbj56H4iAoS/LquPrfY9u1pBanPHFkxBd8BgMvF7QqYkly+P1NG37
 gTmmjvEGXcIHJMk65iPIRRYN3k3MlMH7reYZdKWOz+RBs0F6lrl80Tr2o
 +MTISeA5oaSweGr/yYipPcpTacz8NjuVVVSBzfgRi8BpfvxFkr4F37EDQ
 ooZZmJQlw/pss+6RI+eWvUzKy7SXdSTZ+zXk0GoeD9CA5eBf5X7RQnnV7
 YSsVjJUGq46erRZ1iItJYTKgVrt6tQrTmHLiXjUmdONZkqkNW8lTCjMG5 g==;
X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="325285538"
X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="325285538"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Apr 2022 06:36:53 -0700
X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="551713733"
Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.40])
 by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 12 Apr 2022 06:36:52 -0700
Date: Tue, 12 Apr 2022 14:36:48 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, Xiaoyun Li <xiaoyun.li@intel.com>,
 Aman Singh <aman.deep.singh@intel.com>,
 Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH 4/5] app/testpmd: stop and close dmadevs at exit
Message-ID: <YlWAcAKVV0zQ3oRU@bricha3-MOBL.ger.corp.intel.com>
References: <20220408141504.1319913-1-kevin.laatz@intel.com>
 <20220408141504.1319913-5-kevin.laatz@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220408141504.1319913-5-kevin.laatz@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Apr 08, 2022 at 03:15:03PM +0100, Kevin Laatz wrote:
> DMA devices are created during PCI probe in EAL init. In order to
> perform cleanup for those devices, they need to be stopped and closed.
> This patch adds the necessary cleanup to ensure clean exit.
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
>  app/test-pmd/testpmd.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index fe2ce19f99..438749c5b8 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -45,6 +45,7 @@
>  #include <rte_pci.h>
>  #include <rte_ether.h>
>  #include <rte_ethdev.h>
> +#include <rte_dmadev.h>

This addition triggers a build error for me, as the header is not found.
Does dmadev need to be added as a testpmd dependency in this case?