From: Bruce Richardson <bruce.richardson@intel.com>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: thomas@monjalon.net, kevin.laatz@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2 3/4] examples/dma: support enqueue drop statistic
Date: Wed, 13 Apr 2022 16:01:00 +0100 [thread overview]
Message-ID: <YlblrCi/7uaaumOW@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220411121459.23898-4-fengchengwen@huawei.com>
On Mon, Apr 11, 2022 at 08:14:58PM +0800, Chengwen Feng wrote:
> The copy drop statistic counted in two scenarios: DMA copy failures and
> enqueue failures. so it is difficult to locate the problem.
>
Is the app actually tracking copy failures? From a quick glance at the code
it looks to me like the only "copy_failures" are the enqueue failures, in
which case the stat should just be renamed.
> This patch adds enqueue drop statistic to fix the it.
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> examples/dma/dmafwd.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2022-04-13 15:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 2:56 [PATCH 0/4] bugfix and enhance features for DMA example Chengwen Feng
2022-04-11 2:56 ` [PATCH 1/4] examples/dma: fix MTU configuration Chengwen Feng
2022-04-11 2:56 ` [PATCH 2/4] examples/dma: fix Tx drop statistic is not collected Chengwen Feng
2022-04-11 2:56 ` [PATCH 3/4] examples/dma: support enqueue drop statistic Chengwen Feng
2022-04-11 2:56 ` [PATCH 4/4] examples/dma: add minimal copy size parameter Chengwen Feng
2022-04-11 9:27 ` Bruce Richardson
2022-04-11 12:23 ` fengchengwen
2022-04-11 12:14 ` [PATCH v2 0/4] bugfix and enhance features for DMA example Chengwen Feng
2022-04-11 12:14 ` [PATCH v2 1/4] examples/dma: fix MTU configuration Chengwen Feng
2022-04-11 12:14 ` [PATCH v2 2/4] examples/dma: fix Tx drop statistic is not collected Chengwen Feng
2022-04-13 14:57 ` Bruce Richardson
2022-04-11 12:14 ` [PATCH v2 3/4] examples/dma: support enqueue drop statistic Chengwen Feng
2022-04-13 15:01 ` Bruce Richardson [this message]
2022-04-16 6:19 ` fengchengwen
2022-04-19 8:45 ` Bruce Richardson
2022-04-19 12:09 ` fengchengwen
2022-04-24 3:55 ` fengchengwen
2022-04-11 12:14 ` [PATCH v2 4/4] examples/dma: add force minimal copy size parameter Chengwen Feng
2022-04-13 15:04 ` Bruce Richardson
2022-04-24 6:07 ` [PATCH v3 0/3] bugfix and enhance features for DMA example Chengwen Feng
2022-04-24 6:07 ` [PATCH v3 1/3] examples/dma: fix MTU configuration Chengwen Feng
2022-05-11 2:26 ` fengchengwen
2022-04-24 6:07 ` [PATCH v3 2/3] examples/dma: fix Tx drop statistic is not collected Chengwen Feng
2022-04-27 10:54 ` Kevin Laatz
2022-04-24 6:07 ` [PATCH v3 3/3] examples/dma: add force minimal copy size parameter Chengwen Feng
2022-04-27 10:54 ` Kevin Laatz
2022-06-06 21:35 ` [PATCH v3 0/3] bugfix and enhance features for DMA example Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlblrCi/7uaaumOW@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).