From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77978A050D; Wed, 13 Apr 2022 17:01:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12E6B40694; Wed, 13 Apr 2022 17:01:14 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6D1A94068E for ; Wed, 13 Apr 2022 17:01:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649862072; x=1681398072; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ch9lSshz2ho7XJY2tCywMMxXa8ZtVqGrPoCu5+qdVH0=; b=oGoqOmr1hfDRqawN9dcuGGtARq19qMqKIv5V9IdYHh5lYvdRtyrL/1eu o0IrNTWsdse2GgEmFOuxHjCyYd9vjVM0wYC+rqyyyPWi39Q7UzTuJU9MB gdo2ynArR6i8xmtDic5/KaHf+wQgkfNE1LBdvJ2ui4gJaSucBZKFLimQf 0qYhK+YH/0srMP+MaDLPIs3+NQrHNOKCstdVrWrgSLRu3DOKiO/WsJVz7 MJr5DC9PUngln+WL7bV6k2lN9udBf2ItgpPN8n4jn84Ql2CYuyXzan7Zs uqGV9AsiJxtfOl9Zl/nK5o1IWC1U5rocQuBNsblr3ctz3hiWGpy/hDXnc g==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="349125242" X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="349125242" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 08:01:08 -0700 X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="724933404" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Apr 2022 08:01:06 -0700 Date: Wed, 13 Apr 2022 16:01:00 +0100 From: Bruce Richardson To: Chengwen Feng Cc: thomas@monjalon.net, kevin.laatz@intel.com, dev@dpdk.org Subject: Re: [PATCH v2 3/4] examples/dma: support enqueue drop statistic Message-ID: References: <20220411025634.33032-1-fengchengwen@huawei.com> <20220411121459.23898-1-fengchengwen@huawei.com> <20220411121459.23898-4-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411121459.23898-4-fengchengwen@huawei.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 11, 2022 at 08:14:58PM +0800, Chengwen Feng wrote: > The copy drop statistic counted in two scenarios: DMA copy failures and > enqueue failures. so it is difficult to locate the problem. > Is the app actually tracking copy failures? From a quick glance at the code it looks to me like the only "copy_failures" are the enqueue failures, in which case the stat should just be renamed. > This patch adds enqueue drop statistic to fix the it. > > Signed-off-by: Chengwen Feng > --- > examples/dma/dmafwd.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) >