From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA38A00C4; Tue, 26 Apr 2022 10:32:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1023427F9; Tue, 26 Apr 2022 10:32:36 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2117.outbound.protection.outlook.com [40.107.94.117]) by mails.dpdk.org (Postfix) with ESMTP id 8EC6940040 for ; Thu, 21 Apr 2022 13:14:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACMJR9odAf4G3iqDGWURyH9vGN+jMG/2CdlrRM18NHgkC48hYB7fLDeduBbyuuYUGRma50d0kf0VsFxFie8idkIzN6cdMkBcWPOc5sGb+CmqUBSjgCivZ/DFNxZghn4a68lh53gksHUW99TnuKTXnKfuVvy4TZKczEV8VsDEfZVsLk4aKXZPTZz8X2nLEzbed56HhsRP+A/7VVBasRE/IyB+2EGDPhnRgqux7/I2XSo1usXdm+5vGG5OoaSvF6uC+H/mAd5G17NCuT4sLld7CY21Ue/SKGxKrTpEUhSEfi9RTGudRRwTMJxef2eOGLJILaxh8p4JDO6zBswK9YQLbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5YTTqiDBJsowhSHGpJcWFcCtu8jeLnViG326QZFYOq4=; b=DANo+gaUxL1t2KD04YtUOw6ruT4vzjFQg4OwCSC35SGO0dGHENKLeLkXRs3LTu+ihUsSPXKgxuPE2H7fGkj711LhaiVr1GrUpebqsxaOtOiyq3AUdPVYUt8DECeu9cYKzQEbnEHsxiVxM9oN9DU9eTI9OqJTxF8pyWmow2Qpaza4IlZlutqyTFFalAWo9WkBWSdbJnwtwa+ykMJieCxiH7x+Ih1sbU9tKrOEJCGDOu5F6WwOLdxOlu3H/8sPw6fL+RNEeDrmuEcK+8ZgTCv+tVbq2Y7E5ff/wMuAb/CRC+R/E9I4oqPvzQwkT5PQFnAJZoRDujWQlxrZnlfrSOdUpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5YTTqiDBJsowhSHGpJcWFcCtu8jeLnViG326QZFYOq4=; b=tVXbkggvTBJ+EGMx3bsxYlqW17iYSY6p1BMTdJIn4iDbxL73I7tmPJO80qIuLz2zBaVGlewT8M4vePZ0e62Nz2dIrf+Rw9SgmQXU7k295EYwAYPX0QNFEAL+8CJ9Y1INCEaTBUglsYse/95IhzeFuqkWqcMEFTHdcv4QiR8tVnI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by BN6PR13MB2995.namprd13.prod.outlook.com (2603:10b6:405:79::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.7; Thu, 21 Apr 2022 11:14:32 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::5d58:265b:1ec7:6203]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::5d58:265b:1ec7:6203%9]) with mapi id 15.20.5206.006; Thu, 21 Apr 2022 11:14:32 +0000 Date: Thu, 21 Apr 2022 13:14:16 +0200 From: Niklas Soderlund To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH] net/nfp: remove unneeded header inclusion Message-ID: References: <20220408094116.6542-1-david.marchand@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220408094116.6542-1-david.marchand@redhat.com> X-ClientProxiedBy: GV3P280CA0067.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::32) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 638c4a88-904c-4d6e-1b57-08da23881c5c X-MS-TrafficTypeDiagnostic: BN6PR13MB2995:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A/SphK4jUwnIIrMPqtE89cowJddNq+nZ94SvfGoKzBpk3U1YgpTOOV0BKaU1mJVsqUfw/rUCrgRM7M3P/zu+XCCs/JpySeHyP2v0dSnuL/D7qwL6NGdW29ffUeKIHE1qn/7lsS/N0z4vfd6Mfq+EMmm+y1FSuvVMYhZHkjdWXnGePVJX0DvtqAOktGJ+kkcxQioSKI+G7kE1RbAFfHET6nk0b6CCmXmSbkQCTZJEspcRX7jK4alB2C4Ame4S5gS3XHs8W1choKP09eqxRmee2bjQqoLn0dE6If8BZeholLjZ4OVjBlle/87oTtLB885m2FjzPXIBalEkAPcMQJ1SCEpIHT6q9sCpXyWtIOgws5H8U8M2vZOY9bqk1SfAT5JTheJIytEDZf2wyVLjRdY2skBWfF6I5OXof1DJUAiN/cJETKH3sd/Jb6cLDd6KmFv8YeFYxL8lJUH4AhGksPhDrDIp0gujMvHr3bRZml+gmo7ITZFhInyIc+V/SytZjKqPjVEnjA1CyrqIj6m0SF+ECICqfZ+XIuPErUeX5O1MfTUlDQhgTXfk5fwbC7lvQ/Ozqe+feQJ25wxjWl86oJQcJaL5UYjLyMJUIxmI/QqTCIvZ5DeN7ORKPhYL8S9IZRNmlZw+SGQUmF6m7IeYPrjrjnrJSUTuLXaQIdCjIaVaH7k2drgI3iNtbjs4G0yy72FpiAzrz0uvOeiMP11GqLbR+O1cko6RcKLjFVgy2Gm1AeXEd65GoiGwWljBM1WxX0jf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(346002)(39840400004)(376002)(136003)(366004)(396003)(26005)(6512007)(6666004)(9686003)(66556008)(66946007)(55236004)(6486002)(53546011)(52116002)(6506007)(4326008)(5660300002)(8676002)(66476007)(38100700002)(38350700002)(186003)(2906002)(86362001)(508600001)(8936002)(4744005)(44832011)(6916009)(316002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?EsKOuTXiqXMJ28I91Q+3YiI5bL1QyLttzbutR5H8XSDqnjhDwsBxPYnj0v?= =?iso-8859-1?Q?8AGQr6hZ0B6MZVaNReS/DW/o43Q/+GdWa8yTAOlZXzecZAAoMw3DOA4/Tv?= =?iso-8859-1?Q?axZBLBiRgH8MGor8B/inrgxvXEcvBAO0p5HN6ED6CnYxpOP0UPq6VyRO26?= =?iso-8859-1?Q?jo+EOlBACMFoPX3KJbp0HYensd3+Q/9A8g3jm+JB2TRuJXCufpCHIVySxn?= =?iso-8859-1?Q?P381TaSvtzo1vLWSWeFE0hMBSQ1hG5flZt4akUL8c1wUcYbiyER+v9umPu?= =?iso-8859-1?Q?lsUrU+MtGYqE8udUuG5LvtlLfu9jrDoCh0SmtXq0V4pZBg1YWKFR34AVUJ?= =?iso-8859-1?Q?jDeF06r45AWHUy/lGckTPmrF28iVTTy0GVJF/SWo3VZcZIsBac17E7sPax?= =?iso-8859-1?Q?G4vg92o+HUawIvmoyb9Q8RSr7SOH/PfhueocFWtsG5OAVH6AIh99ny39Sx?= =?iso-8859-1?Q?0NP5SDUtUBnusLbxxf52KffyAFohma52UeK7ou9zOTd5OM98ZFXmLeADkw?= =?iso-8859-1?Q?6ZCh1IBfX/9dTTVTFjyZMnaB16vHm8kF9ksQQtkAGs8R5BFDBfq0n3dRBg?= =?iso-8859-1?Q?YsXZgW22JW/3wIUpEicuG4Md4gd1UNZUfmfCb9NNkFM2w7qz3ju7Kwj70Z?= =?iso-8859-1?Q?cMWeadD6n16TDJMl9Y2Je1pvav4QX9c1MX7084y5KN0xwfLHmNhp1OG+pQ?= =?iso-8859-1?Q?j/vBQYF046gp4U2vJNRzHQBAd01xnrZqKL2eumEdl8NmFAz03SGcHXWbEx?= =?iso-8859-1?Q?0ZB1hUbevaZn2FpcaaHic/CaGe6L8e1n2NeaYfp20EbxCfE0zK7f1XsHn+?= =?iso-8859-1?Q?TK14snLpwicY3mHEptrfrpGaMbk6cJ6FQPtui2XfRok9b5gNG0gk24J0NX?= =?iso-8859-1?Q?wpxkpOdRpzOYUy+XB9Nk2hT03UbLD5+7hmvip/b+k83uchlexsNBJJJg7I?= =?iso-8859-1?Q?PSfel9pGPXS06btF3UWoLcASUYXUcHhH4OhHu8nolk9x+bfVgbCYn471yv?= =?iso-8859-1?Q?It6K3eqaCdqB0c47gcArfhqTc8QW9CPGxloC/hwAnWlG+61YmZjggpaWhB?= =?iso-8859-1?Q?oHUtlEzV/EKmbdsDsYrCIyycsn8UjxZz5MUD6fauAsgqs/Kj7TEV/fx9AH?= =?iso-8859-1?Q?XWamFrQiQM2zIy12E7jeyaybRqkjZVCIJpRwIpR3Zuqm+YTr2csdFsLpAu?= =?iso-8859-1?Q?PjYs1+omWEoWMo6M/UgshoS3Gh1xFQA+wcWvxH/lCsxBBFvTo2TEkvUVnY?= =?iso-8859-1?Q?0K3mp0zu5IgrZZqFvP+ZMN1x+jArvnJAtwDRrj/VCJqqgW9IgTe5hjspNH?= =?iso-8859-1?Q?Q5GIqZWlhZa0jGHgmB8/evkbkf5OyvxWKQbJSUQstenRsI4FZLhGS6kb5b?= =?iso-8859-1?Q?gKBeGsa7x981bCmtNDeOuYsRub5G8zaDDu/EwuXbMwsvizOQPzMzry0Kw9?= =?iso-8859-1?Q?Vv161huIGB+wu2CHPuKBS2K5S5U0PXKKDhhThquzjqY45ldjykYdHtgHLy?= =?iso-8859-1?Q?OMM2BtWgv2vaDgsMBC+9aKvQtSVNH6wurdJfzVYwHCYcYRjd7+P3u6aMYz?= =?iso-8859-1?Q?eo1556cVQ8x114ZVVAj/IRX9UGrf8h/Le2AALkuZmQpjRzfuCx+3YyrNxQ?= =?iso-8859-1?Q?Z6hnO19cxajOgukpzVr3QmgGFe7G7juKm9T8GcrGCIjiB2ThOOa1K6l0Ex?= =?iso-8859-1?Q?2cnZogVCpX2iiQQH92lyuXlopJygxZyXaoyCDGEJE1EC1akNYeNggHVV1A?= =?iso-8859-1?Q?Ie53j9P87sfMlp46J6QaT8G9jJ6FAdiATjfqE0nsJgSYeEmZ6hFzt2BFIp?= =?iso-8859-1?Q?DjivC8itBppjW5I5LZ2cLK025YKg1ss=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 638c4a88-904c-4d6e-1b57-08da23881c5c X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 11:14:32.5450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kTbo3JsNPYwckV2RFQJRcLLMTVQo5K1SB0UpsVjx/qs73B3YNMl9WB6sBMKugb2diWipQbHCYohC1H+J4TnZ72h6lI3JoW29EpXj454ErzA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB2995 X-Mailman-Approved-At: Tue, 26 Apr 2022 10:32:34 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, Thanks for your work. On 2022-04-08 11:41:16 +0200, David Marchand wrote: > Looking at this driver history, there was never a need for including > execinfo.h. > > Signed-off-by: David Marchand Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > index bad80a5a1c..08bc4e8ef2 100644 > --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > @@ -16,9 +16,6 @@ > > #include > #include > -#if defined(RTE_BACKTRACE) > -#include > -#endif > #include > #include > #include > -- > 2.23.0 > -- Kind Regards, Niklas Söderlund