From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD2DDA034C; Wed, 27 Apr 2022 20:05:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 834BA40E78; Wed, 27 Apr 2022 20:05:53 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2095.outbound.protection.outlook.com [40.107.236.95]) by mails.dpdk.org (Postfix) with ESMTP id 1E42040691 for ; Wed, 27 Apr 2022 20:05:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKP75ZqCRin/nZWYhi8ekmAxkhcNgHLaSfCYYUitG2ca8v/P880m95yrz740wF57gTz7yLQPB4XhOUzRFaePXXJGLdZD+Iz5MdtEQB0MobWp95+rvMevI3+Z82vL9YowWJOSm69vZ4Yy7alQK2yGhj94G74BIpWV8PIxYHu2I2CeZU6kqtgzTn3GxiTdtiPKgbw28G+TYAkK0mTFwLQ2WHE4oMeNtmCnOVktvRrdfJl9VAL25Xno2j0qTW+ISwPUxdc0lOOuOj+nxQcJbAojIPotRnzC1oJUZ+iDgTySqqDzLlpxndlgMhMUbZITezILHtifGqz6qX1Es0YMZqqAqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WaBlrvH9S5ANeDtzcu/qir2EqqxJf6PBo0CtVpIozdk=; b=PuooxsfAdOpPhoH8hirXhaOxTW7OWiGIi5hH6iMd3Kr16vAr1MlPySHf3ALCWV3eBAvnJVBW2zfVlwImYvNSfRgaFAdfxNPzykh11y//JhuQ2G5nawifFkaOSyZn7M5vLiI/FQpPmPn7sOoQjHOQTH9+hliAeFHprvwOxPkm1UxSmVQKe4H5ict+u7m0fKhMnf+xy6QKdtdozop6eHBp0ulwQ+GpqIDc1qaYrGZxq2f12e0ssqMay9VbZ5+CEd2lBY8UHW8hU2/MlBW8sgunb6k95RyPVLTdd0tnfakBeg8Tptpm9jNBDWgausrAyPfkaAHvCajc0fjjf2WF8aDjjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WaBlrvH9S5ANeDtzcu/qir2EqqxJf6PBo0CtVpIozdk=; b=rooqdEHwHudbBVsAA7o0EbEivu9DyYnO7OM8PDsaIRQnZ5MMS8U8UVDG8om5k/NSBxIryhPwZgHIzzECzrg6qj5c2G45alSVgh/tXJpiZH/wMIDFVXTKD4BYV8u3Wqe+iJ+09Ra4Q4GUdn+grRIF6Wu1EfOnJtTxJlzHvlgNtOo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by CO3PR13MB5797.namprd13.prod.outlook.com (2603:10b6:303:17e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.8; Wed, 27 Apr 2022 18:05:49 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::5d58:265b:1ec7:6203]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::5d58:265b:1ec7:6203%9]) with mapi id 15.20.5206.013; Wed, 27 Apr 2022 18:05:49 +0000 Date: Wed, 27 Apr 2022 20:05:40 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Ferruh Yigit Cc: dev@dpdk.org, Louis Peens , Chaoyong He , Richard Donkin , Walter Heymans Subject: Re: [PATCH v2] net/nfp: update how MAX MTU is read Message-ID: References: <20220420134638.24010-1-walter.heymans@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: GV3P280CA0062.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::18) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80c9f5be-45a4-4897-6a96-08da28788f41 X-MS-TrafficTypeDiagnostic: CO3PR13MB5797:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EP6uFZBUnqVlnJez9y592GxAwX0aIJFlbjv3hs/ysxCqv3CJf/N+MAD43Wde9GlWlJdc+vyZJWHleJHuejZSwbE2Rkz9UNER77dphDX/zyZp9vvlG/mECLWs/zoOz5xDhrbYvWCJJtF/VSj6a89Md9v6bxHmSGAI791sR3Wm4cLmCc2q2Jb605aoP0ReG3UUZq0z+F0lsnNmocHhELRV7n+I2G4qo6g8hKxLX/k2OY3fbA1XmCenjX/tPk2N34Xn/L6ch5sze4sO+zW3EP0Lub9yS1DPlYiBGfqfKdZEb0ZoKP7hgGsNrn9wBocz3W/2ky5BQMMYOUManoU5dDVFAetbA+ROFsoIGzFTH6eXQDzGfQ9kD0jERQ0uH/maiqI/JvrRIVqTpAGdUBtpiUkdJ9Hip0Wtk4ll2qXa+ra2xGQK+ImsTempvRPYszjSZzuOonyvvQcT3OJwM4iTX0wudnE/738z6D/LRkthdcasn2JnreUkM2XLahTsaz6SzpLGLKJfuHvYDK3ejE9C1gxNUMSlkxwPkaBA0Lhm7gaHYRlA7Ep+o8EGx+/XbxMrptt11v/movU0nHsm7Tzs0f218mU8SqKJQC861U5e0kpYpeSEx1KXuRObyqbcspd9h5Dc94eVPhU27mmnKsrzyBvvXCyEIpgED27Dbk1bfp5Mz6o5t21/yPqf9FzB/FteZhVW7viRoOlscMDRkXcz4iI0thxwBne/duTVKL6DrF/Vu0R1+NfKkfbctSglzKXFinC7RwnjGTUJNbT9Gsid1ZXS9aLgu4/kEAmyPyAfGmyXoz2N6oK0c89Uf2F0HgxRD1gOzBBUS1EY/xT5oC1P2P5TVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(376002)(346002)(366004)(396003)(39830400003)(136003)(66556008)(6512007)(9686003)(66476007)(4326008)(316002)(508600001)(26005)(66946007)(8676002)(15650500001)(38100700002)(55236004)(38350700002)(53546011)(2906002)(186003)(5660300002)(6666004)(8936002)(86362001)(83380400001)(52116002)(966005)(6486002)(6916009)(66574015)(54906003)(107886003)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?xCFUIUpL7rgpoyQ1J+36A1Tgg3QJrQAQFhWu2LyOOFVvggcLAHX9PD5Htb?= =?iso-8859-1?Q?jRHSiB52K0Z7fMS4HSIgllxL1Uz8tboLxv+rHe18sIQ9ApdzAuVD+GJBeC?= =?iso-8859-1?Q?BBvfHSpktmTANrDR6YjXTDplIM3yWExxbeNzuxYcwbHWMe8IfcImcSXYOx?= =?iso-8859-1?Q?yhOL2ejnohN3w+xl5llCXNIBDx3M6PxAAmIvpWCgo6D8MqPICTT9EsPQNR?= =?iso-8859-1?Q?sWe0oEmVYOH8Plvwiid01faJ7wp9IAV5LjHz8JWufND7G5zN5jXFXEDeXZ?= =?iso-8859-1?Q?26/mOZiQq9GF6cwRPJbDXBY8/q2NofzJcfpx06TlTssDC+ECRPn87+iiSk?= =?iso-8859-1?Q?eI3pAI9lQMP8OEtyyEARGt91v/LPuaUG4wwmkVSnI41SShj8C4a4RWFAyy?= =?iso-8859-1?Q?R/3bMXmf0M+vaWme0Z9UGD55VZCYGAKyR4GjWcMTzsFnKuMbXDX3xpYHym?= =?iso-8859-1?Q?2cHae+oGVkZdOmRAdiWBRdim3cMoY9bx9R/H4NvnwuDFL6jOa2rPg81KyV?= =?iso-8859-1?Q?DNv6nmP9yg3TnrOclIEO3k8NEE+ENitlm5zrT1T4nOWmvHC0cLUKJDYsji?= =?iso-8859-1?Q?g4p0w0+L+nsFDVkgvq0rUxNLQY74rPjjXlAKxVk8h2KszfrdlU9E4yrOVm?= =?iso-8859-1?Q?4BZjlNm0LuXE34uMmWg+XZD2Wfq3yPk+UCHJQUDvxUj6ldXg4Lab+nfUw2?= =?iso-8859-1?Q?dVYWCJm7wot/cUbuOb6Errv56K9y7j8GFooQblqzAAKruKLvoi3TpK1SGN?= =?iso-8859-1?Q?xAew36EAwFRhmHvtnvKISSK8ZOqXUktytGqWX/UJjCTFkKwmM+WySU4eiW?= =?iso-8859-1?Q?hG1gcQnJUvNpRU3f2aQ1XWbSvObmMFR8Abcf5OYkPEVUjfkCROo51kQKFN?= =?iso-8859-1?Q?5OXVBUtVtwZqOeMPtsa+CKSSnrMrkYbO7yy98YZAKWKrO0siHa/xYkByCU?= =?iso-8859-1?Q?9yIa0V+4d9d3+NCVc9jl7PHmeNZNn32qi1bmb/UoQ19Dnba1/vjE5MJ/gO?= =?iso-8859-1?Q?8SVAodV+YuPEyngTKMQqkkQ8MZ22zuTaxGoqcnP+jSbQ5xW7UJ2AQYQos8?= =?iso-8859-1?Q?1DYR61qiP7hOriJ7+aP38XzRvfmMYeNqsQndGTopEKMsT8Su+3EQWNADUS?= =?iso-8859-1?Q?r750M6qpvs3zhScvSDvfceGAxSE68id0GR/GEyVdOnhruLGL9E7/dA6dPV?= =?iso-8859-1?Q?tHkcat0t6xp1rOWqU4r9RUZxhs1ycvulTSsQfUVG04HdTlscHrBi+ItBfr?= =?iso-8859-1?Q?upsFpA8pEzdqTZpPh5PcTaSSq5MsMV1QzROKld9JPcTovr4yF6ljGb2ZOC?= =?iso-8859-1?Q?I+t6nrG0xL/vGHfun6KFlJoTSNNQhXwLtCxF4Kbl8xZkDiScn97AP7GP4+?= =?iso-8859-1?Q?kb9pYb04J8SXEuyEaMJbDMeN9JYqR+4+Yx5aBBvBk51vyK5rErk9FcHQoq?= =?iso-8859-1?Q?hEUuKJfxaBV16cUbvU0ZRvfOckehDSkJnhFWuqreZhH03sjbtjk2IRzUFj?= =?iso-8859-1?Q?d+tW+qN66Tal70F4u2YqWsVdtXLHkY0QQWv2XmBg1LQMtZH+6O+FwunpVH?= =?iso-8859-1?Q?YX43N6mOTiwDmGravIlNUSsq2AUZl799HClPxecHaL6a7gSHGmtJlXVHUA?= =?iso-8859-1?Q?5MTio1edad4V5tBBcDjP8AwbLuwugxOlX3M2huxow7c4z8bpKedOD/fAdU?= =?iso-8859-1?Q?zJh1m54I+c/g+6aW/wYgB75oQbnHULeds3Nb24slaR2JrvqH+VUxm6gG+Y?= =?iso-8859-1?Q?boKjY71gYr49unt5fDVVGOCJoh0WstWnScjNFUtd+/4Sef4Ol2MI8iylFk?= =?iso-8859-1?Q?vyh1np236MNaU+CAbXFmgB+uM/Zc1oo=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80c9f5be-45a4-4897-6a96-08da28788f41 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 18:05:49.4398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tcPRXvqxgklciWHs7vzgMUjt7f+JF/vwBnQl0FpaqzSzj6nLetaOpZhAYFGdP5ncyow7Q5bsAl0dvDEeXyQVubp+oGwl+uhpxaEX6V6tD+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5797 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, On 2022-04-27 10:47:03 +0100, Ferruh Yigit wrote: > On 4/27/2022 9:37 AM, Niklas Söderlund wrote: > > Hello, > > > > I have a question about the Checks that ran on this patch in patchwork > > [1]. It appears the job ci/iol-x86_64-compile-testing, > > dpdk_mingw64_compile have failed on a Windows Server 2019 build. But the > > logs from the job appears to be incomplete as it contains only 19 lines > > of output and stops without an error in the configuration part of meson. > > > > It is not clear why it failed, patch looks nothing specific to Windows. > I have triggered a new build (on top of next-net), please give ~15 minutes. Thanks, it appears to have done the trick. > > > The failure is only flagged as a warning and not as an error in > > patchwork, is it it possible that the job in question fails to capture > > all output or that it fails to complete sometimes? > > > > The patchwork warning is to highlight new version of patches needs to be > send as reply to previous version. This enables all versions are in same > email thread, and this helps reviewer to see previous versions and > comments/changes to previous versions easily. Also this makes possible to > see all versions and history in one place in mail list archives. > > There is nothing to do for this version, but please use 'git send-email', > '--in-reply-to' option for new patches. > > > What can we do to on our end to remedy this? My concern is that that the > > patch is blocked due to the warning and I'm unclear on how move forward, > > sorry if the case is that I'm just impatient. > > > > The patch is not blocked for above reasons, it is in the queue (which is > moving a little slow in this release for some operational reasons). Thanks for this clarification on the status of the patch. > > > 1. https://patchwork.dpdk.org/project/dpdk/patch/20220420134638.24010-1-walter.heymans@corigine.com/ > > > > On 2022-04-20 15:46:39 +0200, Walter Heymans wrote: > > > The 'max_rx_pktlen' value was previously read from hardware, which was > > > set by the running firmware. This caused confusion due to different > > > meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the > > > maximum value that the NFP NIC can support. The 'max_mtu' value that is > > > read from hardware, is assigned to the 'dev_info->max_mtu' variable. > > > > > > If more layer 2 metadata must be used, the firmware can be updated to > > > report a smaller 'max_mtu' value. > > > > > > The constant defined for NFP_FRAME_SIZE_MAX is derived for the maximum > > > supported buffer size of 10240, minus 136 bytes that is reserved by the > > > hardware and another 56 bytes reserved for expansion in firmware. This > > > results in a usable maximum packet length of 10048 bytes. > > > > > > Signed-off-by: Walter Heymans > > > Signed-off-by: Niklas Söderlund > > > Reviewed-by: Louis Peens > > > Reviewed-by: Chaoyong He > > > Reviewed-by: Richard Donkin > > > --- > > > drivers/net/nfp/nfp_common.c | 11 ++++++++++- > > > drivers/net/nfp/nfp_common.h | 3 +++ > > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > > > index b26770dbfb..52fbda1a79 100644 > > > --- a/drivers/net/nfp/nfp_common.c > > > +++ b/drivers/net/nfp/nfp_common.c > > > @@ -692,7 +692,16 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > > dev_info->max_rx_queues = (uint16_t)hw->max_rx_queues; > > > dev_info->max_tx_queues = (uint16_t)hw->max_tx_queues; > > > dev_info->min_rx_bufsize = RTE_ETHER_MIN_MTU; > > > - dev_info->max_rx_pktlen = hw->max_mtu; > > > + /* > > > + * The maximum rx packet length (max_rx_pktlen) is set to the > > > + * maximum supported frame size that the NFP can handle. This > > > + * includes layer 2 headers, CRC and other metadata that can > > > + * optionally be used. > > > + * The maximum layer 3 MTU (max_mtu) is read from hardware, > > > + * which was set by the firmware loaded onto the card. > > > + */ > > > + dev_info->max_rx_pktlen = NFP_FRAME_SIZE_MAX; > > > + dev_info->max_mtu = hw->max_mtu; > > > /* Next should change when PF support is implemented */ > > > dev_info->max_mac_addrs = 1; > > > diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h > > > index 8b35fa119c..8db5ec23f8 100644 > > > --- a/drivers/net/nfp/nfp_common.h > > > +++ b/drivers/net/nfp/nfp_common.h > > > @@ -98,6 +98,9 @@ struct nfp_net_adapter; > > > /* Number of supported physical ports */ > > > #define NFP_MAX_PHYPORTS 12 > > > +/* Maximum supported NFP frame size (MTU + layer 2 headers) */ > > > +#define NFP_FRAME_SIZE_MAX 10048 > > > + > > > #include > > > #include > > > -- > > > 2.25.1 > > > > > > -- Kind Regards, Niklas Söderlund