From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B40A0503; Fri, 6 May 2022 16:06:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DC5E40395; Fri, 6 May 2022 16:06:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1C2134014F for ; Fri, 6 May 2022 16:06:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651845973; x=1683381973; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0DyP5SHWi6HpcEO3Wv5mi20u5ZM/FPxUvY1n3qQJduQ=; b=SbShyCzR7WDtEL1kwxzYxczQgqUtt1TGNztJ3OH4eCGRemiwtxLY9EtX tkJR0oDzOrbHU1CyyhrKHg2wGyu1rSjqdyIi1xKjz/Js9dYRTwO1TqXMy Fj30aEXE7+xvEDsD3Jt+F9W3+y67HOlmOLwc85it7DqolEo/T7usUOiQn B/tH+viI6Z/uljIx0pQvGcjYfEgBcd8aCFAYElhuXj7tIIWmEnrvGR6OP X66DJYMdV/wh5GjQ9J8oFxb+4Zj1NmaE1uBd5wjYbBa+BOTGqFykt+oQ6 hfrFHOICSfRUPwjb1r/lnng7J5tCt8/UTfpHgd2lU8NurmtmAqdsBdA/r A==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="266066463" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="266066463" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 07:06:11 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="585988822" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.0.201]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 May 2022 07:06:10 -0700 Date: Fri, 6 May 2022 15:06:07 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH v2] build: add definitions for use as meson subproject Message-ID: References: <20211103221205.63175-1-stephen@networkplumber.org> <20211105172213.103988-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211105172213.103988-1-stephen@networkplumber.org> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote: > Some other projects using meson may not be able to use DPDK > using the standard distribution pkg-config mechanism. > Meson supports a way to handle this via the subproject > https://mesonbuild.com/Subprojects.html > > This patch adds the necessary dependency to follow the > "Naming convention for dependency variables" from the documentation. > > Signed-off-by: Stephen Hemminger > --- > > v2 - add link libraries > Playing around with DPDK as a meson subproject myself, I have some additional thoughts on how to put this in DPDK and some further comments on this patch. For example: * For static builds we need to "link_whole" the drivers, as well as doing a "link_with" on the libraries * for shared builds - which will need to be done explicitly by passing the subproject the default_library type parameter we actually don't need to include the "link_with" line since the libs are already included in the shared deps. [I think they should be added to the static deps too, if that doesn't cause any problems] * we therefore likely need slightly different subproject definitions for shared vs static, and I'd suggest moving that to a new file e.g. in "buildtools/subproject" - to avoid cluttering the main file too much. If you don't mind, I'll do a re-spin of this functionality in a V3 patch, based on above ideas, and we can see where we go there. /Bruce