From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B990BA0555; Fri, 3 Jun 2022 09:29:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 656D340691; Fri, 3 Jun 2022 09:29:11 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 828014021E for ; Fri, 3 Jun 2022 09:29:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654241349; x=1685777349; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9zFn4H2Pi/GIjzsSFFH8h2WEy1QviFDFKBXeC4No3UM=; b=IcIPJPEnKLQ9OZCHoafKXgbkW7XTh+tpD9KrUZJIdii7eM4nQjc+Mc0f Fj0Fyl1uJseMJ0Iae9b5hOLcFD9Hj8Dp15n1WeGxbdw33syDAXMIFJ5x1 kCklxnMHGuxJPrwIjXHViHIttbuyEytPZBseyPXWl7hR1kH3uK33tVjCe rzAxxRvMBENaDhMQRWML1nSvUF6r0kZWyPggw3TZRfl6tlhLoAiwSd0g4 oFLZ1NRgh7tnIWlYr4ioPrq/MpruwlcBjqscb4RZ3vRX4TaQdKGNRpkko r2uT3jIu8uNyoXGpGPtSOt/ekSvbTalhVAuNzsI15LHsM2SrXyaUYxmxQ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10366"; a="276263367" X-IronPort-AV: E=Sophos;i="5.91,273,1647327600"; d="scan'208";a="276263367" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2022 00:29:08 -0700 X-IronPort-AV: E=Sophos;i="5.91,273,1647327600"; d="scan'208";a="577910278" Received: from adzukova-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.6.223]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Jun 2022 00:29:05 -0700 Date: Fri, 3 Jun 2022 08:29:02 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Stanislaw Kardach , Stephen Hemminger , Vladimir Medvedkin , dev@dpdk.org, Frank Zhao , Sam Grove , upstream@semihalf.com Subject: Re: [PATCH v4 1/2] lpm: add const to lpm arg of rte_lpm_lookup Message-ID: References: <20220601111542.401360-1-kda@semihalf.com> <1821120.CQOukoFCf9@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1821120.CQOukoFCf9@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 02, 2022 at 10:52:25PM +0200, Thomas Monjalon wrote: > 01/06/2022 13:15, Stanislaw Kardach: > > All other rte_lpm_lookup* functions take lpm argument as a const. As the > > basic rte_lpm_lookup() performs the same function, it should also do > > that. > > > > As this function is inline, no API/ABI change happens. > > It is an API change and should be noted in the release notes. > > > static inline int > > -rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > > +rte_lpm_lookup(const struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > While I've no particular objection to it appearing in the RN doc, I wonder whether it really counts as an API change. I can't see any practical difference that this change would make to the end user - no source code needs updating for example. /Bruce