From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 388C5A0543; Mon, 13 Jun 2022 16:48:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E51EF40222; Mon, 13 Jun 2022 16:48:24 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 940B940150 for ; Mon, 13 Jun 2022 16:48:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655131703; x=1686667703; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QG7AhOlyjBLI8oz+E4APZHVyOGp396W2bTzifFUcM4Y=; b=ky33hWG5x3OhIxsrzYEI4eaqFZqO7gSsnnRMIAXWtdNZCuHrzW5FKLm0 lRDnOrOj9eyEjPdunnnAYaHc1vE7La6FbxgKVX3KgImfo/CmYCk1l5X7I 5maq8DO8Uio9Oa0W7idKnB3gV5pfoGx9MEWBzp310adimehB5+y2Bg1wH TCd54TKS4e4FLVWRo70LmAfA7m7zMoLSHfRDcCqDWOsezwavLGFVc/2Q7 PE4FWZ6qlppXsgrjGqeEVGMRYXgwF9oZe+BaMYxztcXZGksnONXT0I7d+ qf0fvd1AJXEDqveL2hNm/oOiVviO/5tcTuF6V9aMk1FiZ9LTObGmobZ5V Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="266996950" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="266996950" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 07:48:22 -0700 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="611814145" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.106]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Jun 2022 07:48:20 -0700 Date: Mon, 13 Jun 2022 15:48:17 +0100 From: Bruce Richardson To: David Marchand Cc: dev , "Dong, JunX" , Morten =?iso-8859-1?Q?Br=F8rup?= , Thomas Monjalon Subject: Re: [PATCH] config: remove explicit undef of unset values Message-ID: References: <20211216111430.699717-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 13, 2022 at 04:20:04PM +0200, David Marchand wrote: > On Mon, Jun 13, 2022 at 2:37 PM Bruce Richardson > wrote: > > > I'd like a check like (below), to avoid new additions: > > > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > > index 34a2e43845..8dae47165e 100755 > > > --- a/devtools/checkpatches.sh > > > +++ b/devtools/checkpatches.sh > > > @@ -158,6 +158,14 @@ check_forbidden_additions() { # > > > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > > > "$1" || res=1 > > > > > > + # '// XXX is not set' must be preferred over '#undef XXX' > > > + awk -v FOLDERS='config/rte_config.h' \ > > > + -v EXPRESSIONS='#undef' \ > > > + -v RET_ON_FAIL=1 \ > > > + -v MESSAGE='Using "#undef XXX", prefer "// XXX is not set"' \ > > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > > > + "$1" || res=1 > > > + > > > return $res > > > } > > > > > > Otherwise, the change lgtm. > > > > > Good idea. Do you want me to add your check above as a patch to this to > > make a two-patch set for v2? > > If you are fine with the check, I don't mind it is part of this simple patch. > I can do it when applying if you are okay with it. > Yes, I'm fine with it, thanks.