From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE6CAA00C4; Thu, 30 Jun 2022 18:55:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CAD34069D; Thu, 30 Jun 2022 18:55:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7793840694 for ; Thu, 30 Jun 2022 18:55:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656608127; x=1688144127; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=U2EdBPHVFZ0LEuM47cw1LOQCemSs7uCuLdTnCCaKoc0=; b=JF2fVVlzjEu3jvjI3pi8HLQyStho56x4DHkg6Wv5uhbvZy5o0pl62meP ehhBJF34zYYzGr/ziHZ7EnzymygmPFZ0gW15c80mjvSF6m9kQ1hBwhaC1 0Oq7MziYBhObdogq1dp2sgDTZd9EuUalxZIbfESaY2xaVNo2EQ/Om/3Fx W2trgZwEq+2yjhkSaMApOcBfAPt5Rr/EfjmpLguNsurmXo1NaThwBIy4C Mn1h5fOWbXOFz4yWI6EsFxBvlKf5SUN83wq91EOamG2zvWXHjT9xBm27n 1Tns6A5uaIMoMv2qQNETT3Xj3AMzANtdInM2v7jfo9MLr+pmNKjJBJlME w==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="283138886" X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="283138886" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 09:55:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="618041165" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.28.159]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 Jun 2022 09:55:25 -0700 Date: Thu, 30 Jun 2022 17:55:21 +0100 From: Bruce Richardson To: Shijith Thotton Cc: jerinj@marvell.com, thomas@monjalon.net, dev@dpdk.org, Olivier Matz Subject: Re: [PATCH] mbuf: add mbuf physical address field to dynamic field Message-ID: References: <57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605763.git.sthotton@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605763.git.sthotton@marvell.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 30, 2022 at 09:55:16PM +0530, Shijith Thotton wrote: > If all devices are configured to run in IOVA mode as VA, physical > address field of mbuf (buf_iova) won't be used. In such cases, buf_iova > space is free to use as a dynamic field. So a new dynamic field member > (dynfield2) is added in mbuf structure to make use of that space. > > A new mbuf flag RTE_MBUF_F_DYNFIELD2 is introduced to help identify the > mbuf that can use dynfield2. > > Signed-off-by: Shijith Thotton > --- I disagree with this patch. The mbuf should always record the iova of the buffer directly, rather than forcing the drivers to query the EAL mode. This will likely also break all vector drivers right now, as they are sensitive to the mbuf layout and the position of the IOVA address in the buffer. /Bruce