From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C51EA0542; Mon, 4 Jul 2022 15:25:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CE95427F0; Mon, 4 Jul 2022 15:25:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2BDC440E09; Mon, 4 Jul 2022 15:25:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656941121; x=1688477121; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AtctFpwJkwTRL6HQctQF/QsCj9s6YAg/9DOxysgvayM=; b=dxV5UyzezsINRIo+udHTJgz1iLMr5NfiIj1r5EDQCZyau/e/7USW9wbv eoptwTJRh+gwS8UxcZ4cHu57o86jpYJtNnpV+yyQIgvJogDIjBZOKOTeZ o1Bf7zPKFnw4CwcTDtbBv7/5BdUC5JCM3Xq+Q8DWqI55B/Tf9rtlRxPna n2QAvQ1AVDRDJNAxrW2SIT07O31WMcuUFdFl+7LKdKuT8hYtUSdpP0cIc nmTUTRLFS6Awr+tyoYdCi/PhAodbMMX+2kWSQjXdtBpdqY0bgh9odPxkD eyLQO57Ue3qjgtKaEMUCHV0HWel9c2HhVl2TaXB1kg8WS9BtHcUhlOQox A==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="283858464" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="283858464" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 06:25:19 -0700 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="619292593" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.180]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Jul 2022 06:25:17 -0700 Date: Mon, 4 Jul 2022 14:25:13 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove Message-ID: References: <20220408141504.1319913-1-kevin.laatz@intel.com> <20220703122243.929642-1-kevin.laatz@intel.com> <20220703122243.929642-4-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220703122243.929642-4-kevin.laatz@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Jul 03, 2022 at 01:22:43PM +0100, Kevin Laatz wrote: > The 'info' struct was being declared as a NULL pointer. If a NULL > pointer is passed to 'rte_dma_info_get', EINVAL is returned and the > struct is not populated. This subsequently causes a segfault when > dereferencing 'info'. > > This patch fixes the issue by simply declaring 'info' as a variable and s/as a variable/on the stack/ > passing its address to 'rte_dma_info_get'. > > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Cc: stable@dpdk.org > > Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson > --- > drivers/dma/idxd/idxd_pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c > index 9349c56b3f..3c1effeb84 100644 > --- a/drivers/dma/idxd/idxd_pci.c > +++ b/drivers/dma/idxd/idxd_pci.c > @@ -379,10 +379,10 @@ idxd_dmadev_remove_pci(struct rte_pci_device *dev) > IDXD_PMD_INFO("Closing %s on NUMA node %d", name, dev->device.numa_node); > > RTE_DMA_FOREACH_DEV(i) { > - struct rte_dma_info *info = {0}; > - rte_dma_info_get(i, info); > - if (strncmp(name, info->dev_name, strlen(name)) == 0) > - idxd_dmadev_destroy(info->dev_name); > + struct rte_dma_info info; > + rte_dma_info_get(i, &info); > + if (strncmp(name, info.dev_name, strlen(name)) == 0) > + idxd_dmadev_destroy(info.dev_name); > } > > return 0; > -- > 2.31.1 >