From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C310A0032; Mon, 11 Jul 2022 10:38:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3013640223; Mon, 11 Jul 2022 10:38:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 241604021F for ; Mon, 11 Jul 2022 10:38:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657528688; x=1689064688; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7VXBZ7dFDbCm0oRgJo4Ts5MgwR83gRO9pLCySPh/xN0=; b=HXejY7Lmrj/M6HczY9IAH+daZfr5cyHgVhPEvB7+wV85ja/jyAxLLh7i F/5b8U2W7Iz6zAcjkOzqBvxbgMqW37VzyhaRYeigXUVjakO4job0M0pG3 wPq73CeevGG9cMle3mnndvvGoC+w9xbC2rpc5vxgr+KhNc3N8D423ov7H Yi17ejs0YYNr8C2cA4L6zE2udxg8tW7kEn9bXEXQH5FhTpn1UfowpA+3P 2UpcYsYHh/kU7K3MGO0gPQsVaAtLwvXyDYmCHcoadRvmOMKY6oZ9MEQ2r dCKMrVm8USsF5Q93x9QIArHoqxoNryCp9aM4mCoSdG9s4xbmpC7gYfBoI g==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="264384743" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="264384743" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 01:38:06 -0700 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="621988412" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.200]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Jul 2022 01:38:05 -0700 Date: Mon, 11 Jul 2022 09:38:02 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org Subject: Re: [RFC v2 v2 00/29] Bus and device cleanup for 22.11 Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220709082644.664675-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220709082644.664675-1-david.marchand@redhat.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jul 09, 2022 at 10:26:15AM +0200, David Marchand wrote: > This is a PoC for hiding the rte_bus, rte_driver and rte_device objects. > And mark associated driver only API as internal. > > A good amount of the patches are preparation work on rte_bus.h, > rte_dev.h, rte_devargs.h and rte_eal.h headers, removing dependencies > between them. This is something I had in store for some time, maybe I > should have dropped it from the PoC, but I think those cleanups are > worth it in any case. > > Then PCI bus specific handling are moved from unit tests and examples, > though there is still a special case left in testpmd that may require a > new API, to be discussed. > > After this series, driver-only API headers for registering to buses are > not exported anymore, unless the enable_driver_sdk meson option is > selected. > > New accessors for rte_bus, rte_driver and rte_device have been added, > marked with an experimental tag though we may declare them as stable > right away so that users can switch to them directly. That's also > something to agree on. > Yes, I think we need to make them stable. > I simplified my series and switched to only update "external" users, > like app/ and examples/ files. > We need some checkpatch new checks to be sure we won't get some > driver-only headers included in these areas. That's something I'll work > on in the non RFC series. > > "Internal" users are simply using the internal headers. That helps > greatly reducing the size of the changes. > > Disclaimer: again, in this v2, this series is a bit rushed (I brute forced > compilation tests in GHA so that it passes between patches, but there still > may be something broken...). > Not surprisingly, the ABI check in the CI is expected to fail. > > > Comments welcome. > This is great cleanup. Thanks for all the work on it. /Bruce