From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E4ADA04FD; Fri, 29 Jul 2022 12:20:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 442CE4069C; Fri, 29 Jul 2022 12:20:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id C379D40151 for ; Fri, 29 Jul 2022 12:20:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659090027; x=1690626027; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0mi5irN8q27288QHPT/eLDCa6shp/q+PFBjrQZO/mvM=; b=g6S6HFVAnVj8MTS/kZMSGWuQw9lFsg1ncLF0HYZGvH6OHnBSRb89j8ki V/UsxxjfyvXP6YOPgc6YiQVnQ0XGzLb1fkKN8iW2LPFO7AkOc/wsYfx5Z e2kLZOw0oRrbi5/JOo/CN/eAbOYsMfyX0qBBrTdM3svmomb5mWIoUAjNu q9XJhKOHvATvb4s4LiGV7uPfQH/L8e18BcZx+0fcJ7GBB1oVyss0NVjbO RMrE7l03A9A5Z89BKcvJLmlI55qipqSH5Iz3Q/MLUt1wT0/yHLHPTsGf1 GdYrCJj7i7W09XNLmrLaJyRjM10g213yAucEU/vwKio4+Y26ff2rEUKRA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="288752651" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="288752651" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 03:20:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="928698030" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 29 Jul 2022 03:20:26 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 03:20:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 03:20:25 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 29 Jul 2022 03:20:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDIffEp67w6o6oDVJafV/KKx+2ypCnnkoJMYGIXynTc+pUtLs7wBsW3Kr1LKEfNipuldNVrZ8bjxLbU2KMaoAcH9HJmcz+R4WYkwaOMLfCYPz3BpFwRcMrs/iy1XLOmE1u19sgJ8O1j8aLbhvrHlB/p9lKmiDXe4T1SXwuibBnArx3so7pQ1p10t+DImN1dIhD7jzwaZIvdd8jsfh4j548Zo3R+Clq+dXtIkghUWIOCEAKzqfTQ06vUx0k/x3nlZwokcO4mbuYNLQ30MTWu1EKnD+km/nL98dFsgfP4wLcM4ciThfUWot/GMuOfvKozOvP8sTUtoYpl5xRdnoKPGGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Rcb17y42zXLCcrrgv0oIEaNaf9bjzsaoLK1PEHttOY=; b=kpMu2NGuIpFPtxePk+HBaJznoLPkZnO3nCgDZF8CA71HFI8uvOf45FyUlPqQw3cigJ4xBKq4tc8y8h5zZCDxTi9lp/iIIR7uIZKFZnp0lFH3MhCDgQRNJDJGN+z2iqG91dnDZ4tBgX1B49Gh+Ra+Bfo2k52+hdWoZMsCiQVj1ZtX3poaOIReF7zKtTrc2TYGHqfoEVZ2V5Rh9z1EzpbRC6RxtNJ0+YiDkSLyp0YHMz2Cqy/X/2e9Jd6Ip9ZTkwq2aVnmdvw5Tye1CC8OvQQixjDpOfCN/XbJJ7IyBnkyvrkp1B2TGx7EY9JZ3xTh0rWOk0fMYmBfz+mj71JjLf7cHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SN6PR11MB3455.namprd11.prod.outlook.com (2603:10b6:805:bb::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 10:20:17 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Fri, 29 Jul 2022 10:20:17 +0000 Date: Fri, 29 Jul 2022 11:20:11 +0100 From: Bruce Richardson To: David Marchand CC: , Chengwen Feng , Aaron Conole , Michael Santana , "Ciara Power" Subject: Re: [PATCH] app/test: invoke all telemetry commands Message-ID: References: <20220729095400.774303-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220729095400.774303-1-david.marchand@redhat.com> X-ClientProxiedBy: LO4P123CA0186.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::11) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7dd1d41a-9a0f-4a84-a852-08da714bef28 X-MS-TrafficTypeDiagnostic: SN6PR11MB3455:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2WLmzM4HGGLnr8qJhvcrKWj+WvIV+QuAPT8JhIA6o/xN4SIL+VItEkszuan+E7fv15BdLvmaO/dZVOgDupUPMkekuYq+0ViD90dSkq/+Tl0YEWUwuyL7Qxh7uW3PgSWWx2F7ohHabxcHmWYr48oWBDND546eusJqFCyWjuNtckCQbH6BOoVcxT/J1wCHH1rA51f7LsXLcEW2upOEu3EjEkstc+OQp+/k7zI1dwkeWaQpOdqOkZPJYpeYWl1he4mIzv17g0C11EBWtB8tcm21hLeV+ZZX6KuEnOixyOlAjRPpsPMxZNmddQKjxVrnz3D1S0Sz2ys/RfBPveWzdxFMNXcsLhO9hbdfQcRV1bdiEls8F2wcvO6DJ6HcOFb5+CL5sjjRcnxEjgiGq3ACwVOes77q5Spc6vGln2IgHw570eUmBX+Kx6HxF/56GZ2k9Z82Y7JgVlCZ/uKLNMSYkHlbcj0XzHvZ397FT0mJdYK6tlQXu1KfE5rKlIscJF3A9CHCufF82mRmNiyPg8EJUuViPICvf4kUUQOMrntt4CsZI+AV7xIu73yYZ4BY4IociFio/i6JaPLsasyA7B/SWuU6iXCjTeL/j2j5fmfL1TvLX8Fv1RiqajnNnTI/8HwNUK5dMlasRMiCtENXYFtABtN5DYetEmhCfUcYhFpr+0MqqVFmQQK89sbQAAch1pT8tKeu19yAEdWOP3+55IDe1FEWXzMuFvW8eO7voFsnvyRQg0I5unltfTNTqd/ob9w5cvfp X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(376002)(39860400002)(136003)(186003)(107886003)(83380400001)(54906003)(6916009)(26005)(6506007)(6512007)(6666004)(44832011)(41300700001)(2906002)(38100700002)(82960400001)(86362001)(8936002)(4326008)(8676002)(66476007)(316002)(66556008)(6486002)(5660300002)(478600001)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WYPJgTArk455855YD/JJxzT472VLy28Xf5qo7i46glz4t8R0G140+xn0+H1P?= =?us-ascii?Q?oHfdmTPmWGlU5ji40KhIB4e098Chz/lIKO00g0Vk4fdFHXPXa0ZjaDAUMXYQ?= =?us-ascii?Q?NPWJ6c/o+xu/z22YrPQ7kncvXO24i3kU5uwHI09zKURaRkrhW4Tzh9oLMQv4?= =?us-ascii?Q?Rxlt2IRzmY+pDmRLVQSFSFLjkMhXhz2cRt3EvUBOFA0Jtx7q911FNoQsDvO+?= =?us-ascii?Q?+EZDRpsyfKVxD3+U4tN4DSevN/2RbdFywjmQWNCU53VKxFG4R6OShU+sdEWj?= =?us-ascii?Q?dDryDxtByQzp+2fySgT3cgzdGQHl2YOogMY9M9i7VWJSnmzeOUlOq/bY8F+S?= =?us-ascii?Q?xD9dW+mZ/DEqD2KfcZ0V1p9yWp35/kUr45v0t1dd+mbs86EVFWBcQvdUhexV?= =?us-ascii?Q?C7crXBwMOMTzmv4kLrTOU3waoU9VYebNjQH8vlmlhg/LHf2xh+YS7jp2iX2U?= =?us-ascii?Q?ZgpJHvgVyD8tez7MHKV/tYJnR3Jib/qDwLrKW6nKD38cEiaO9tjbnS1s0y2e?= =?us-ascii?Q?tQnf366aHkfocpiVnBfHJgWdYb6LwPU1iURnfHWXNLs1+3tP84gUayit7g7y?= =?us-ascii?Q?d/lGQFspDuK1v744PJGuAG7v8IQl8eMETrUqZlKLSJJktNSPWW8PCixgswUD?= =?us-ascii?Q?Su3+rc78/jbDcfssXuJm8TYeT47VNiw7z9TCuLd0NEqlM5y03MyfbtEc28hq?= =?us-ascii?Q?gMYkBZJz630fPuLdhjMlgwRPkOQjGWVSRjD0+1NUKzE+xB0TprQNKXBxlBJQ?= =?us-ascii?Q?VZajDFieVqwr89Ut/m/pcxGwWYgDzNimA7Ko8qPwTwgfN1rU4pfehdxjg4OV?= =?us-ascii?Q?cYREJJYpB/z1xN+5HsZFBUVPYg7AHWxzKzzqYnpqKjIPwwWb5g+k9HQs6qoe?= =?us-ascii?Q?HzWiHakqsZIqJtQq7HmMBgaj16DcLkdYT4Q6iZXdbqNlMxKPviYPTLW3JSdj?= =?us-ascii?Q?mg6xI79oDLg2+3C+jK2UF1I0vDBiNAEDsQrZO2RH/CK8X+8uPj/wh+BnTG2i?= =?us-ascii?Q?1U6wXZIOeWMouQ0v6vSr76gQlD78K3p8Ls7fSaFXlkq4PdVTPEnOucCValN8?= =?us-ascii?Q?mebh83RtguP6snT5vITx+SvbTE0ftt+f36UqKwlyj7+4X5w5yeDsq1A9WFSA?= =?us-ascii?Q?pqxxpHEGtb9qmBEVrhi9nsAdNoxE4Wzo4hyjM7pB4TUKESnH75/WesvYsRo9?= =?us-ascii?Q?XwQZ8E7GAB1ADVxAUgOCnDjkcZs5Ahq4MeaIv7kScgsD8GI0Nlx34xTC0hsW?= =?us-ascii?Q?CV7qTyQhoL08G6ZUfvImhg12RQ9ro+IepIzEarFcpy6y7Ghv63UcnlSL+8rB?= =?us-ascii?Q?y72/FwcgSFnb5aUH/XiW1IV7UDEjg6jnE5qQ7Hm6eoQmuMy7aLFjXts1KFmI?= =?us-ascii?Q?2o4Gt/nlP0sfSU9xJgB4Lzj7buZcYrf6MJXaUILftipUW393AxQJiz2pkzZZ?= =?us-ascii?Q?YqPoZSAvveGcM1JbaArl7riql3kcwAoFS60ITeOczPlKV9eB2CbPY6HaT4qn?= =?us-ascii?Q?HbVWm8V4/bBoEhp6Yyxxn/7rXLvR2C0i5MXxEE7RKsUrgwb3RyGmwo428uN3?= =?us-ascii?Q?pbVGf+23/hMnR83Qco7Zf47qyD/bHOeqPoTb9PKL06t266F0PTZy/p4NX5m7?= =?us-ascii?Q?Yg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd1d41a-9a0f-4a84-a852-08da714bef28 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 10:20:17.7907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 33rNDMEH1hw9SqsOrmmDQI+RKNaw/CoucIoOSqwGxhz/jPAM/U48YMVGlb+fUUH7dQdJBggENQcKrjYVFka+A3EeGU2owvpYnxFNld+idQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3455 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 11:54:00AM +0200, David Marchand wrote: > Try and call all possible telemetry commands. > Each commands is tested with no argument, 0 (for command that accepts > a single integer like for a port identifier) and z (to catch commands > not properly validating input). > Fake cryptodev, dmadev, ethdev, eventdev and rawdev devices are created > using dummy drivers. > > Output of the commands is not checked, the point of this test is mainly > to catch simple issues and leaks (when coupled with ASan in the CI). > > Signed-off-by: David Marchand > Acked-by: Chengwen Feng > --- > .github/workflows/build.yml | 2 +- > app/test/meson.build | 35 ++++++++++++++++++++++++++++++++++- > app/test/test_telemetry.sh | 28 ++++++++++++++++++++++++++++ > 3 files changed, 63 insertions(+), 2 deletions(-) > create mode 100755 app/test/test_telemetry.sh > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml > index 6f04e7071c..bf17d2b278 100644 > --- a/.github/workflows/build.yml > +++ b/.github/workflows/build.yml > @@ -140,7 +140,7 @@ jobs: > run: sudo apt install -y crossbuild-essential-riscv64 > - name: Install test tools packages > if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RISCV64 != 'true' || env.RUN_TESTS == 'true' > - run: sudo apt install -y gdb > + run: sudo apt install -y gdb jq > - name: Install doc generation packages > if: env.BUILD_DOCS == 'true' > run: sudo apt install -y doxygen graphviz python3-sphinx > diff --git a/app/test/meson.build b/app/test/meson.build > index 431c5bd318..e60fc64a37 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -473,12 +473,14 @@ message('hugepage availability: @0@'.format(has_hugepage)) > timeout_seconds = 600 > timeout_seconds_fast = 10 > > +test_no_huge_args = ['--no-huge', '-m', '2048'] > + > foreach arg : fast_tests > test_args = [] > run_test = true > if not has_hugepage > if arg[1] > - test_args += ['--no-huge', '-m', '2048'] > + test_args += test_no_huge_args > else > run_test = false > endif > @@ -520,6 +522,37 @@ foreach arg : fast_tests > endif > endforeach > > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY') > + test_args = [dpdk_test] > + test_args += test_no_huge_args > + if get_option('default_library') == 'shared' > + foreach drv:dpdk_drivers > + test_args += ['-d', drv.full_path().split('.a')[0] + '.so'] > + endforeach Rather than looping for each driver and building a huge cmdline, we should just be able to pass in the path to the drivers directory, and have DPDK auto-load all .so files there. Passing in "meson.project_build_root() + '/drivers'" should probably work. If we want a more correct way to get the drivers build directory, we can call meson.current_build_dir() when processing the drivers and save off that value to be reused here. /Bruce