From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4ABBA04FD; Fri, 29 Jul 2022 13:28:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7EB34069C; Fri, 29 Jul 2022 13:28:34 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 421BA40151 for ; Fri, 29 Jul 2022 13:28:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659094112; x=1690630112; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DfMYhClNmWLNxnW0cP3e+xjQJzrMmowrRJD6a+g6RQc=; b=nlmmGUTXUonKR5xD5W2VWjH/o/+snzXKzKYXUlGFNKREXx9eSCWkVLOD tGIEmseUfk1pGq2xSTq2MTtgMgj0WfL4DktDukFZOkba40lfa5vB+oDHV 9WjGk4yEshEPrf2pHFo70bxFyTDAKhHB+dNVcS6+PkvqB7Ndb/ESoUAIV q4MY0+67QeyPIU21z44Yx0JSeXVbIFJZzLmFL2LWY+e56zukGgwFxlHmR 7/ti5+xMK9Eso1pP/HJsLNsid+pZ1Kv9jIxDv2yW+J93gqvtudVxbv39g H8xSledGHCiDGmbvp/puen8ilk8QFdNOWvqKVtteSyIbOUXFzTGJTlz3B w==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="287502449" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="287502449" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 04:28:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="777515283" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 29 Jul 2022 04:28:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 04:28:30 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 04:28:30 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 04:28:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 29 Jul 2022 04:28:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVLILOqs2HoN4G7vdzCf5QhMu5sScvbX++pbaRinTMln0kE1lN+lVqXGQPHPwsa88zWUN9SFcKWq7MMw+kMb7k11+RfrxHBnRhlq/TAcjmU85wU5bZZj7CyJyT1R2ctVK+NK29SZcKh2GKJYtXz1XaSj9nstQfFqZ1WsXs3+/aVqhbWVdNYsB4ysti1btHScfx4Iy5/Zyo4lwxcPqkAW9v9HCx4NE/OgtauBZ69efxorhxtAGyCdpN8oQhCzuWWY68w0WWx80shMdWhSoz13hZOA1Y0a2JcDjw8gnXQbmquDjE4l2Co3rr0VH8V2In23y7/9hlIJtDRCPRRuvyqNLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYAkeFnWlMV8tZsrL8Uz/VQwx4jhKYz+FYa1kRskM2U=; b=JqApEolDFlshh1O7tYKDA71VlBzE/QYlEPD1TwFwopypvQ9U5uM3M3nTblARr4OQZ81eQEU+f5w8QMQOudSJVKPsuugLKpnlCApESJLpEF6Jmz8ModS5x8CeIMdiQiybfMDlIPSaIuUBot06WAP8q3YThsWwDFD83EYHIQsKFUDbgNFg+csFjdBh+/z21gVW6v2wJaN18uXPc85ZQZgEv5p76WA9bTI1j5KGma0HnYexJZWO7dNZeTd6kDbbJ0FfmrqFxDwE7za3hUB6VPDue/erC7Gdzr3jp4ceTOLNbe7WdPl0Aiye9yiS3Pjb+5XVTuzgH4wOXi/DAly6X9GvKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM4PR11MB5438.namprd11.prod.outlook.com (2603:10b6:5:399::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 11:28:28 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Fri, 29 Jul 2022 11:28:28 +0000 Date: Fri, 29 Jul 2022 12:28:22 +0100 From: Bruce Richardson To: David Marchand CC: dev , Chengwen Feng , Aaron Conole , Michael Santana , "Ciara Power" Subject: Re: [PATCH] app/test: invoke all telemetry commands Message-ID: References: <20220729095400.774303-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0154.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::15) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 778c3104-2f70-456f-45eb-08da7155755d X-MS-TrafficTypeDiagnostic: DM4PR11MB5438:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kdxxvFLXE+YFSr6k9jP0/jn++2tnBxyz+NuqR9Ooob9vyUTY0apca/M5NOJ6LX3Nx6JUjIuRoiNfwxbXa6IVpb1o0FIT+4jLAVtlBbQN04Fb5MvjyJJOiZZNDIeLV+EvbFmDTw30sjgvD44vzGNDRxxP81UDvo+A+5kkjB2Pj06l+G1879WA1ijobdiQ8jHE7YBfl3duuVKvdhMCC4GaS9p/UdLFd2uR+kef5RZf4ksHzOa3v+UAk/l0/cDhrbQYfwbJeAA4PNWzr2XK/gjtXcM4ECMUsIdBTVdr9akH+cR6T+4lkGxDvOeyEbPEGPqYLmt/7PoRU7/PYlap0i54i5i0TsTPsji58MO/S0dxzommKyTE5GDwZxtC5hmoLUhcILKkrN+Ge5YPvEQUIJZ4fn3/A8jn9prTh4to2Qs+U/qEKY2o1dJ4gUxS31Mg/45xyrD8vz1CX/VnrJkuJ086fZc7HBYE4f1GscXWiRnsQqZrGSGycbTwHNn4GA1Ok5oS46wE4B1XJP+cylN+Zv8jj5pf7BM5/KoXM9svvCguGbyXwoH5Zw9WytmskxK99NKEdwhIfK3Ja1U60w6zW2ZYFpvgl/IMTOUei8CGAmfeGlDBynU/1uYYOQSiTTvfoyrtubRsiR1eCqxcZGu5pTigwlMB5FEubRE2s9/75qXcWZzWakgOIS7d1UFJMUXhE26559Ne1jYt/N6vAhv7n7q6EVBqyhJk08vqDdY1K/5yp13qzMddVT2IfObPnEmFxPEJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(366004)(136003)(39860400002)(5660300002)(8936002)(8676002)(66556008)(4326008)(66946007)(66476007)(2906002)(44832011)(83380400001)(6486002)(82960400001)(478600001)(186003)(107886003)(316002)(54906003)(6512007)(26005)(6506007)(41300700001)(6916009)(86362001)(38100700002)(53546011)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xautx96JiNCNEJO3WlRGW+hpcd71pDsNT9GIalSgAQEK1rnT2zDxvlXhgyeA?= =?us-ascii?Q?1+3WsyV4E78sxIL6UpUBUXZJrrGvK1Bk8oGqMCiHdkpws5AjC0IwcI4lM1/4?= =?us-ascii?Q?SV/P5hr3BlFqCGYTHl5Rj4Fdg6lExHyBSilYVNGqbxsOu7IcSLEIT0f67hR3?= =?us-ascii?Q?8y6vl2S9CJ6u7yvgnQ5DjiYWTqZFPirIf6tIIUo2gDtQeudXCrCSdpyoVbpq?= =?us-ascii?Q?02hU4KeUHNEovckVn3Brx7mTO5iJ4hDUT5P26ArCyYHetvleREiVplJRifXd?= =?us-ascii?Q?PKt87ConwnfI5U16OCMLDKtmCCnwfEbiTSmPujpkisWFCluC0xCfg9D11Odx?= =?us-ascii?Q?MMLZs94H4nCy4oAEmiJaY+aUTn/vLyO1OLw87gycThSL2eQgM69l7H+7jrfG?= =?us-ascii?Q?5TffXlWlslKK0suhRZ1FH2vyft+vE5/lT4KMxxiEIoYZ5LdQ/qYCSN2WtWQU?= =?us-ascii?Q?MTePqky5BF9EYZbkcbsKFGgXUiodxx+y82KutBccO5C9u7CzXtzrrYjiCGft?= =?us-ascii?Q?/A13o3gWyjrJHhlHVzzB0aWMQ+nCbNs4erXuYNo3W2DJEunXOlf542iSAGAp?= =?us-ascii?Q?GqQ/mUe0I6pTdh/pt4FPWciKa7TJvDFRVPpfUzLH0x0cmQRMYbinyA5uZ08T?= =?us-ascii?Q?lfc/yxipmwhJuW2VqCo9zXaelapEDMhooMrnf1771ZG8P9kE2O2sdzoIW+uy?= =?us-ascii?Q?naJUZf15YNmC4Sg64KkwjUzJ4TqjjSFT3n6nXGi4NaQ+aCe/QJjHhNsFbIEN?= =?us-ascii?Q?VTh6v+e1xh9YB4qJzROs+BKEoQPqOIlLy7jsmcz+bBVoQicLpUe8Rut1UqGL?= =?us-ascii?Q?pa+sI137TyTpkmdSri6yGleGh0J+NIdT8CQME4Y3kAlFSoKMm/DGZTL/Q7Io?= =?us-ascii?Q?aqjBTPHU3buI4t1FuWndBb48wrcESfdc0xUqEquO1neMlYD2fVAqvWjPglc2?= =?us-ascii?Q?T2K+zk/MeR3YnrfjuqbZqZ/3oI7WA5Bkf5xsplTHBWO6xKHieMkSSnDmcVJe?= =?us-ascii?Q?Xv05HiK/Vf5Qar5CiSQHebRyclOod9u+zVjsy/4hkftS89Q+BqgUwp6ecPuZ?= =?us-ascii?Q?fUcX4Xg8bpgefFEih1XKtmMAYWLTSWgAKiQ0u72IM41HqQ4ftFPJ9bwEE5zF?= =?us-ascii?Q?+AiMnW3W+20DRFmlgw9b4U1lA4tNw73eNbViwcYGpzoPYSuBgU4QusWJBuJ7?= =?us-ascii?Q?KScU1/GJpR/lQTFR0GGymspRzri3UEpF7wfCxDXl0hoTBW3uDubMowEcpYAz?= =?us-ascii?Q?sgO4n93NR3g7uXw90rpyHp9SDToho/BveM0a9LjMiCmdIdvVBEqde5h7/TKp?= =?us-ascii?Q?Jbjj4X1gJODJ5ihhEHU1K9PtvaTUNYFOESFQz1bcQqSI+Ftp9X+Xc/iFr90y?= =?us-ascii?Q?OCjpz27ucrGLHi/D3eZMRHRMvlEgHu9K3Drzp/nIqPwuGFVNkjp92jpOljOv?= =?us-ascii?Q?h4H/3cDF2v5GxGDfkusI2bn4VPVEMOETM6H5JWY5zUQE85f0Ql7DQeGyvAaA?= =?us-ascii?Q?TA7c+awwcRlI7Zs36/9JvofaIj2LeahjwhHtWynkS1WWDBTzUDSQXcz5/3ul?= =?us-ascii?Q?1GVsXi882waaVWNQH2KzX3tDjc//oUp/YWD9TDjoa1Z/jMySJABlSh3DmMvw?= =?us-ascii?Q?Nw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 778c3104-2f70-456f-45eb-08da7155755d X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 11:28:28.4833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EkTz1NHdjdYZClMOAHl7u1V+GCmeLW7gNEs0iV1tJFg+YFeI2BgKQaPpe6K74sAgprckT80wVz692ndNRGQtko7DTb9301hZy+LJ++mZ2Bw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5438 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 01:13:49PM +0200, David Marchand wrote: > On Fri, Jul 29, 2022 at 12:20 PM Bruce Richardson > wrote: > > > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY') > > > + test_args = [dpdk_test] > > > + test_args += test_no_huge_args > > > + if get_option('default_library') == 'shared' > > > + foreach drv:dpdk_drivers > > > + test_args += ['-d', drv.full_path().split('.a')[0] + '.so'] > > > + endforeach > > > > Rather than looping for each driver and building a huge cmdline, we should > > just be able to pass in the path to the drivers directory, and have DPDK > > auto-load all .so files there. Passing in "meson.project_build_root() + > > '/drivers'" should probably work. If we want a more correct way to get the > > drivers build directory, we can call meson.current_build_dir() when > > processing the drivers and save off that value to be reused here. > > I copied this loop from an existing block added with 207b1c813f39 > ("test: fix build without ring PMD"). > On the need for this loop at the time... I think it was to avoid > loading non .so stuff from a build directory. > And you probably handled this with 49b536fc3060 ("eal: load only > shared libs from driver plugin directories"). > > I'll try your suggestion and, if it works, I'll update the other existing test. > Many thanks. If it doesn't work and needs some investigation, let me know and maybe I can take a look at it for a bit. /Bruce