From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D405AA0032; Mon, 12 Sep 2022 17:15:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B45A9400D4; Mon, 12 Sep 2022 17:15:52 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C23164003C for ; Mon, 12 Sep 2022 17:15:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662995751; x=1694531751; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=xx5e2Svbbk1h7V0+DxBexSKbdxRpKpb4fjKL4A9gOak=; b=WxINE1sUQ4ERHG7XGbgeqn4+7LivnP6FzBiQ5sCLh5jBQjZXJ13M2AlH Ps5SxTmIcC1F2CdlURkhF8j11EDzbvgMZbNmNWI0817BZorp1958L75Fu Db8XIq6zI4dZnbLs2aeE8wfp77P5DDGkZE9f0dHxbtt76GJyH5nj3/qrY 8GMww7lD+fP1cmEQ/ap0gJV75QDy/6M8zWG6o5SNjdHdeWg4bzsSw+FUf Q31O2O9cwviTn9RO7VWxahkrubM7C5ouSb3eWuXwp+IY5lqDlOzETE5fX J3VCD+DlcYz/OvRyVUZ2AuauHDCwY8zNMC5nHk8fdEEC1T1wD8FuB4obQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="284911624" X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="284911624" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 08:15:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="646498986" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 12 Sep 2022 08:15:40 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:15:39 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:15:39 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 08:15:39 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 08:15:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhiUl1FviqwixtfAI91RJhfsGI3jw9np0Xao5tSHlSx/2VlMQUXFOdPKe+jywlNIiVBLz3EU/PQ5HEsM/CwS66i9nyLiqmzPk0UUSHdN/fINRejRS7hQ1jFiZ0HgdlJUCDAupM/qC8C5ei/axDPIHUCV8dbV1sTax3QVtxLIAJsPapc+eEA4384Tb7nvRrfUJG7esl3YzPzxctnAxSKEMhFzYUaUG356VdgnbNHg56fZzmjexj9yfPYwHfh+i4qgUOIn/YeOqnGSXGwPndR6aLjbc6E2J9YxMAh1FCJWesquMwQFv8JMxiisEL1sKi4OVeT9nSxFqnxHURvpsWE5dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XXQtbkfMtBEGytS8Z6ZlzOx6JMy1UeHb8v7ApOQ8+2M=; b=gpn6kx43zqsNZGIeNAo1SIZWUB6TeHCy8pMPKCbxQ8W7YBjv2mGpmUmkuIdHyss87sJ4fRzHjKjCSFBH/iags82hVALptGiz/gyGCwogluUM2V4C56UyxwoPUKM7furN2kNeyrCpAzF/iih5YWaA7anyBoVowH4a/t89qPi/sfl/jsCBUZf/bLzUFWytxpXB7rSxf+j9yaGphLHwRfRvGlnCXz7RpvVmRLtW6NkbSuZyQmgZphp0xLtQrQORIetvFtYLdUpt6ccOad5+tovRopCKTEAnNkK9+K+A22sS+ljaSgiAvqtjGcbmHF2CR6KbbxN1G+4yB/Nn178saE2arg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by IA1PR11MB6395.namprd11.prod.outlook.com (2603:10b6:208:3ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 15:15:35 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 15:15:35 +0000 Date: Mon, 12 Sep 2022 16:15:28 +0100 From: Bruce Richardson To: Owen Hilyard CC: Juraj =?utf-8?Q?Linke=C5=A1?= , "thomas@monjalon.net" , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "Honnappa.Nagarahalli@arm.com" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-2-juraj.linkes@pantheon.tech> <3680ad0ceb5944e6b5050d5f7b9c9599@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR0P264CA0106.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::22) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|IA1PR11MB6395:EE_ X-MS-Office365-Filtering-Correlation-Id: 34df9e72-47da-48ef-eabc-08da94d1a43c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QctxNXwbBD8MX54wNl8glBS/ajC9/dmKAa870uy+zTqbglJMAbJ/wBpQSx73q8A9vv3zipo6bvnyKPSkq4i0cTfvM8CUlB4eeMyqhPCQObfKerweJkQHQCaWD7Fc6Z2AyRE+SeY5n39tyw+Krjy4S3mt6wadScpGM/pW0Sc2j5P3IQQBD8/XoW9JwN+JmYcMd5f2wUSex/s5Ov/iQ9LNCXcr5AAjxyLA85tPfC9bDuT32PSohNz+1R3cVafeO6ZnLQUUI02lahzwkpEFuxjbUxyD86r8Nr9gO4aCHlpABMR+iEy9UEEs4rROgOMJ0jQBPq8JioaJ/oIhEYC9YD8CAoPlFaMiGh1imBrKFsnWUbqGsXD45u81/Fxu7kw+U7noFyMF0BWUUjfuj0oR/qKPpXO2bgLlbsNOt4OnnFAJSPLB6plZo3Bzgkyqg1m/ipByOBMf8vudkFCUo9V2V65aJDWjcyZ2/qfYc/4vWUnIoPyNbUAVG8BT2kRS3O4BKSkeKW1IO6iCxwNoEiYnjREpyBvaiFyq38rjEEZeFdb8Ki4QgJ1fLhaCa+PC6s3TZenFON+FGldSSPV5nE6G+a2uIV9oXL4I7NPvkG6l8yBT5W3Ay5dOtAkmK7RcpEUP7WQrjd6nBfF78FjQgDq68/LnwTyaWuSOM1Fg/6JKUEcW6BKreX1YxDei6ieb6AKov62iGsmTr5CDrkOsjEUgURvx9w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(376002)(136003)(346002)(396003)(6506007)(26005)(6512007)(316002)(54906003)(6916009)(86362001)(41300700001)(6666004)(478600001)(6486002)(38100700002)(186003)(82960400001)(83380400001)(2906002)(8936002)(4326008)(66476007)(8676002)(44832011)(5660300002)(66556008)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUlpOEN5R2hMa1pXbEtJSmFXY0l6RlFxTHR5Rk1RYWhmMGhMUUN3Sm9IOUJw?= =?utf-8?B?ZnQyZTBONE9uM0xrMXdrNXFpOEpqZHVua2l2RlNhWDg0MGMzR254cFBkS0Yv?= =?utf-8?B?eTROV3BWQndmVWVnQ040dWtPN0VvdkIrTzU1SVBvalR4c1VqTEZyVmxtZlVl?= =?utf-8?B?NGVRSTZ6WUJVTk1xRmFKS1FDdlRKRS91ZktFR1RLWGprMXFMbHZCTm5LUUFU?= =?utf-8?B?ZWgwazh6N0o2cHRvM2Q1a2FST0xNTlgwc2NDSUpBb1FZTHY5bzVud1hTNnhC?= =?utf-8?B?SUNUVHJHdVdoVEFNUXdFMFJvQmxLV0JmUWtXWmczUXBscTJ0bld5aHIyMmJ3?= =?utf-8?B?S2FjcEoxKzkzb0MySnhHUWl3cGRvYit5Y3pDQ2Y2RUtmZmRoOGhOMERDQWV5?= =?utf-8?B?elE0OWZtY2d5amdvekNZc3Y5eDZSR3owZXk1RmpDd2N5b1NQMTFzQ2ljUkpj?= =?utf-8?B?TnY3OEI2amt5L3pZQjk5bythMll6NHBXYklMMkJ4WXFCelVtSDNlVTdaZWVr?= =?utf-8?B?REZKenFLN2VoZEhhQVpmVFA1S0gza1pDNlVxR01NUi95UVlWWkVRUkNjTnZZ?= =?utf-8?B?M2JCYlhyd0xra0gvMCtZTVZFQlVrYkNTU1MvOTBWUFdabHNQcGsvNldNS09i?= =?utf-8?B?UEdocXFtV2Qyb2ZmQzVFRjdmWEtKVVArMmNDdk9qUlBiUUJmSWpnYldVeUZ6?= =?utf-8?B?cXVBeTNoUUpBUVMyc1NNTy94dXo3dXMvOThoZjZyWUJoV1ArSWpZTUw5Z3o1?= =?utf-8?B?cjdZL0ZZZy93TG9QYXFlUHM1bHY1TGJyTXRpZzRKQTkxYUJMZFBBcjR4eTRQ?= =?utf-8?B?NnFQMnFHbkprV0tHVEN6aENyVmxycDFwY1BOS29CUldqYXJQZnVhaVRqcW13?= =?utf-8?B?OWtlSXI1eTUvcVYzSS85dzBFVXNRV1hsbVVSRUVDZU5TZkttUzJzK3pySms0?= =?utf-8?B?NnVPa3M2Mzl5UmJLNGttUVdHZ1lzek1ZU1BUZjRMcjdtZGRWR01FRGlHRGMv?= =?utf-8?B?dHpPUTlkUjBHR2dWYytrMzQ0cXFHUzArQlYxUk5iUmVwRFJINXgweDhtcnhH?= =?utf-8?B?bkd6d2Z2UStkTm1TYWtDV0kydzE1T2dTaWxSM3lkQSswUGt5WXNUd212Wk4x?= =?utf-8?B?NDJRdG9BckNuTVdwZFp3aHlPWlErcEwreWlPME9tNUJvZGFwbE5Lb1E3U2RE?= =?utf-8?B?T0RxU1o3REhRcFg4Nk5HWTE3Y1NvNHdCRC9OdVBNQkJjSllEMThYUTBKQWxX?= =?utf-8?B?ZjM0em01NEw3MW9hdHJpWEhUWTFHLy81bE00N3Y4QjJtWTQrR2ZSUngxVjNa?= =?utf-8?B?Yzh2TzNyWE9RaHNEZTN4WWYxNFUxWWFtQjUwY1NrRWFFTW1PQk5ocUYrQU56?= =?utf-8?B?Z3dKRXFnSFlxZ1I1MjBhR0JzUGNRZTlvMjFkYUZFcDZmWG40T3dBUmhiM2xo?= =?utf-8?B?TWZFVzhyUzBKZXJ4K1VmK0hmb2Z1azRlMzVmSzhqamp1a0JKTTd4VzJ1ZjVU?= =?utf-8?B?QSs3Sm5SaFRYR0RBNDVOdDRlMGpxOTRkSkpCbzVlMXV4ODFscUZuSitneURJ?= =?utf-8?B?ZGlYelZuYWdUaUQ4QXRDZHBhQjhZcDF3RUh6dHpLTlpPdFZXYk1NUHlnTVRs?= =?utf-8?B?azZUaUs5MG9sQUw4RVlQKzlUUEVSNC9Xek9aOUxWalhwNEZ1dzVBa3RlY1U3?= =?utf-8?B?MTVvV2ZtOTZpbXdQOFJERzhnQnF6ek94RVFVTGRjakxvVS9ORnJ0VlA5NmlI?= =?utf-8?B?cjdrVmorcFU4VHFMS05aSzduR3JQUHpXWTE4THc0Rk5DR3NKMFM1c1BrdXQz?= =?utf-8?B?Nm9ya1B1QlJncnlYZUJPeTg3UTVMbE9ueHhiWVhPTml1SDc1bkNKazlJOFI5?= =?utf-8?B?YXJ4cVc2N0VrR3l5VWw5TzhGUTZoOHBxZnUxWmdaWlBvcVFtOXovL0ZGRWR3?= =?utf-8?B?ekxTL1BoaXB2bWJreGdJVXdJdHdQalV5SENaRG9hU3BpUzV6a0c0R0FIRDYy?= =?utf-8?B?VGc4WVNoZy9hNFlkMTZ1MUJDS3N6cEFERzBtMWdXRkNYTzhCY3V1RGV5cVg2?= =?utf-8?B?NEdyQ0FoWE5DMlJ6VGFJMXAxRkNudnlVUGVOQTdzTGdNTC8zdVhrbjhmdUZV?= =?utf-8?B?UDRXOW1YUHBOdjdsdGhKa0hWVzJVaU5McGllSVZCaEVRd2NmejIyTDVtakl4?= =?utf-8?B?blE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 34df9e72-47da-48ef-eabc-08da94d1a43c X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 15:15:35.4002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WrpeRL0aWSReuMS7Lv9REkwyiYyUTRJtnam37YiQ/FrK1chLHHahoyt7EX5FBOsQ+isrNTvclClGFsO1Bn0lODfRiFqnLD/k7sZjRLeAcqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6395 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 12, 2022 at 10:06:03AM -0400, Owen Hilyard wrote: > > E203 - whitespace before ‘,’, ‘;’, or ‘:’ > > E266 - too many leading ‘#’ for block comment > > E501 - line too long > > E731 - do not assign a lambda expression, use a def > > C0111 - Missing %s docstring > > F0401 - Unable to import %s > E203, E266 and E501 were disabled due to pylama fighting with the > autoformatters, so I decided to let the autoformatters win. That sounds strange. Is there no way to configure the auto-formatters to avoid these issues? E203 I think we definitely should look to re-enable in DTS. > I think > that C0111 was suppressed because this set of suppressions was from > mainline DTS and that has a lot of functions without > documentation. Is this something we can fix as we go, migrating to DPDK main tree? > F0401 is disabled due to dependencies on TRex vendored > python libraries, since those will not be possible to import inside of > the container. That seems fair enough to keep disabled. > I don't remember why E731 is set, but it may be due to > the rte flow rule generator I wrote for mainline DTS, which makes use > of lambdas extensively to enable lazy evaluation, so that DTS doesn't > need to keep ~2 billion rules in memory. That sounds reasonable too. Can we perhaps target getting from 6 disabled warnings to 2 or 3 at most? Other opinions? /Bruce