From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76DCDA0032; Mon, 12 Sep 2022 17:42:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 122F0400D4; Mon, 12 Sep 2022 17:42:00 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 43A9C4003C for ; Mon, 12 Sep 2022 17:41:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662997318; x=1694533318; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0RtNR0elf/EzI+vwgl9OLpT1fc3J2Aa+pzXTMDGf9PY=; b=NseV+FZWnDG6Vc2yOpJILbdHBP/xOpQpkP666u1UlEIx2IZeaiQxHaUn 3NoMHRLrjXbfLGRDK/fERIwJf8AuG7TqEwBBQ+EQZqbfY7Hi/+hmjqhit JWzEuZWPgsFidXcuxfFPcPzQxuWf7kKevHFAYAdr6n7bhOKBC+9XWgHW5 xg9lP7eauF4Epf9/jQmnZXK3aRfEqCVHiw/CIpP8PGtN7M/9T5Fb9DKC0 DGeB8oE0LBBSVEJ7nuh+FAVkO6Rkv+HTI2G8TuQJ0Y3166r5OHLy/SLOD FfFqKu20rWSpLo+bSGR++ydDwflLupCt49hoqV2hNSkzs1K9QGAH886xE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="361848048" X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="361848048" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 08:41:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="678142539" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 12 Sep 2022 08:41:57 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:41:56 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:41:56 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 08:41:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 08:41:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyhFpBMLJLJWibYRm5FVo7A2A0f59MqzZ02JQ40vqhZYZ/TIMJZs0a3iZguODsOvrzd8RlOvreZ+0Pym3jmnpIWTh1+foMd5w2jH1J7LMOLwXyOj+nonLNzj2W/yhZ/P+iuODpKuQvIzlSR8jNR99/MnYQAve9cJHTaC0IN9gkRGw5kYryd7phAVu2NWxHAm9SUnUzw0pGC70g+Q32oF23BMNvklfpyu/Z+48jogPF4OMKNRKaYUKBkrie+NiE7buWCE7202Eimnc+v4JhBwK5HPUNdaOFUFuzKrATHaWJ067OeVaOIUHCJ11Z+EE64lTsNcmG/YgaLXPa42n4q2Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=508GACRl+ERJDi1XVMOZTMpPNlhhuQp75epgm96eHJg=; b=A5Wc4Rr9DZidNfKffpW8klDhMyFA2u2VFUCyclFMRRxQIYnbtEjM39Bawvi9V0K+fY9CJActOtwVZVUJvUHoMbrI1LtHoodxFNMx3ZzG7alxDCeavnMaO2Jvr7uODbbccw/FX+PFF/dJWd2PrI5e28E4hy11kQHRFcIhiuiF/RSscOB+Av59gjiu87VY7cbGXUMPxWrKSs843ltF6QxXR1t0kraECvtswODJEfdwCmsh1CMNq15+HRBfIJDMZ+Dcd1C8aM1UACa/D6Nn1pAVlmCfwoT0anXDs9GDVDBwCsJ1kTuOTyJgoU9Khl30CaK3kJqWqrQADm2dkfbQQR2oaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH0PR11MB5627.namprd11.prod.outlook.com (2603:10b6:510:e4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Mon, 12 Sep 2022 15:41:54 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 15:41:54 +0000 Date: Mon, 12 Sep 2022 16:41:46 +0100 From: Bruce Richardson To: Nic Chautru CC: , , , , , , , , , Subject: Re: [PATCH v2 02/11] baseband/acc200: introduce PMD for ACC200 Message-ID: References: <1657238503-143836-2-git-send-email-nicolas.chautru@intel.com> <1662944938-32649-1-git-send-email-nicolas.chautru@intel.com> <1662944938-32649-3-git-send-email-nicolas.chautru@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1662944938-32649-3-git-send-email-nicolas.chautru@intel.com> X-ClientProxiedBy: PR3P193CA0012.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::17) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|PH0PR11MB5627:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f1605cd-39bf-48b0-d387-08da94d55184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6iyfZ5XtRSz6loPODTMPghlDWvUJIOPK8RMXf9dseaayHuyk4W+h7/hLUTITbmEjZRAUda3UzEjjWqycxLmXXyWqSsINDhFmM9o2r8VTTPIP9neorPpN7slzuP8q0x5AGsfdohpuL8D4g3IgmmR54Ja+OG8Im4R02xe3ABBHYInwOFfyaYJq4+Pnc+nXQ7VonhB2hJnxg+jQ8BqHnXMlioZ5+FgtrhkgB8LyMasBpbGTjr3WseSIvJrrvoDvEvDxgKkm1eZSqQwWsCOks2ATpWp6dBFiaXf9eunlqrwAX6ZSkEGjrpNt6mtsnAx5965aAdu2v1c9lEP1z8cwTTYpP+xvMfyzOC+fNY2RDpC/htwZWXGWPveWqAycfEBqnBg3w2FkGcZK1J+ww0BX9XeWU0vVIlal8KHD95hB/OKK6fQZeyBnLj9tv00JQzYhRRSuW8npLE3ce+KdlO0laTjO+D6QsXFBuvqIozpFx+RVvkjwNGg0sVfwNDU4bB7GKcgiuYjB4CLgE1mWIkiAe1IzEMRcYZUwDLMiHvfm5MmMPacXTM8gofVMzDTuLPkOXMJxa0WBCG66f5ZCShmQI9fP8UFQRVdlhPpsn2I0c5ErAhre1jmCMF3TphtiePbxQmPZXAZsU46vjfn1RByybIsCAGkWedJOc7FBLZvbYkxMdablHvVnu++OMbDh/kVFbbMxfXGRF/I+sVTnRP+xiuyqaA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(39860400002)(366004)(396003)(136003)(346002)(107886003)(186003)(6486002)(26005)(83380400001)(2906002)(478600001)(316002)(6636002)(6506007)(44832011)(6512007)(82960400001)(38100700002)(86362001)(5660300002)(6862004)(8936002)(6666004)(8676002)(66476007)(66556008)(41300700001)(4326008)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wvRC/c34OZYZzDDWNNe21PWI5Q8B8NDEuQUOpvsi4srJXScMu7RlwZMTiE/s?= =?us-ascii?Q?cK3fO/vI/IwOAWniV9ma9ligLqLSlwZ/AhcAyvo3gxGW/6o6Wq5p5wL14rbZ?= =?us-ascii?Q?v4Z65Ns7OvwXLron79JzFt0lXB8dgY6bspGvd1yX8fKu9MqqOuffkMOc1VeA?= =?us-ascii?Q?eSX3zHTUh91+T1PUnIxSiFEziJkS4thZQduUl5evhjgSkWxDdzO+oBouYjoD?= =?us-ascii?Q?oaptPx3Fcq52nu7+DOK6/td0eJN6St057eU8mhJrBSCDSDBTWXJf655ePG/i?= =?us-ascii?Q?e+A790p/KxjtfewcW0tQzpQqNkjAARzTnhkySZxV2Jn2LAuTK+h035BvIzus?= =?us-ascii?Q?memRkq5s3cYMzPsDdkkaDtbJEDpiIZMvN54/0S45OXAlv5mdP4fuZgm62IMp?= =?us-ascii?Q?IuK8oNF6OwTpV6nzv0OBHV9ZjAQmUIxz4oYxzfzbRLM7aHGN+wE0azHm8AmQ?= =?us-ascii?Q?iHMiKaOHIBRQOfo6ThFa48gbRJ1hAMmvkvqTKM0urxv4d06noFiJG+SFO5n8?= =?us-ascii?Q?CQiUrT5YiBnyn6JQKJkXWOgqre35pfqg1fO6X883TPsYChlfZ5kTsp3Ts+Qc?= =?us-ascii?Q?mgwTF6mZ2zFlFVEXpZUx1hrGxzkmcZn2uM36k3u0XrQX1PvKz8Tk4fvdQMCq?= =?us-ascii?Q?p+sDgB8MGoghyMyp+1lO8A6Q9daFpuegdG/xKVhbFxfT2Us8Q3Cu19aM2bVI?= =?us-ascii?Q?2IHF3W0DFY0iqz1x5GuoIqQqZvD6Bw6taHhOJKuUS2El8FsIWjRRMiQeXZPC?= =?us-ascii?Q?mEK9wJ6+WGU0jHdJubmVQW5gjJp2gdVNbDlsxn9GVju1VBVsc5v/7Q8eQc8N?= =?us-ascii?Q?QiZVbSaaM2J3+R/PpaBZTU37Ufxpbk0zU1oasY3p3GamwSEgAUgonOsnZjB1?= =?us-ascii?Q?E7zsNoYsI6wTdYm1Q8tN7xeTZG8vPrPRs5DAUrrdAUAWh3OP5s4kLLCMIZhM?= =?us-ascii?Q?afLD/Zn1jj7x8gCg3K9676Iyw4cSjazDpkDRpQrLhexxfSwxhWqlSZpvnNUb?= =?us-ascii?Q?fzcdHSQHCjiL3I4ciPkk7ZSG1lsLr6vgMA5oddvv79dmICmW0rlQrfwpwgo3?= =?us-ascii?Q?CpgLwrBRhRmtxIpTGh6ydeUlIRXxxjpN/x+tt0zRlI15+ahMhUtYOEDeycQ7?= =?us-ascii?Q?MG+aqKwnE4Olov8pBEdHhU009G26RlwDO6yUNo+kCeltP5MBXytzDnxt97os?= =?us-ascii?Q?WwgTnex9zAg1BtWZRGKOp8vh6RMGFjv5cU/YzMIF3RiwdBoavS20fejSRTwn?= =?us-ascii?Q?BuGkDK0spUO5uYjA7sRzCB5hl02y+jfYUQxI4cDJgCNx31eGbP/FgrDQu7Dl?= =?us-ascii?Q?ALJFu0pzM+jCrm32CUHvDRfssWEYm6+haxn+OIklRvacAuyxXDny4uN746zv?= =?us-ascii?Q?r2JnCCoGIS6LrSb1oOjsYwluDDkrQULuBteRI1cuG3KWS4Kyd2TSl0yv8sfc?= =?us-ascii?Q?9m6Q2nFXrO7f0no8ENw4geS+X1N/LbQ1lTk6iK+Tox0aDVTDOMRx233M0X8C?= =?us-ascii?Q?cRkOnrn6AFssrK6qkcKpJ0gbNTSJKsw35ucWZJrpa/OO1dkSIFJ/gH58ptB8?= =?us-ascii?Q?1n3A5sy49nTL5RTE/dlbJwFoRJLEOQVNjauKTY+i/ahf0Cr05S5lp70X3Mwo?= =?us-ascii?Q?OA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7f1605cd-39bf-48b0-d387-08da94d55184 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 15:41:54.4825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F7wD3tyPSD54RobESsw1vF5hVFj87ZQLm3UWEnBgUnCj2w4WzJ4JZdb0gXhmuN0ij+rJaD1tj5wjhHbDXTh4lGosTr3RjHRzkZmWUHuOYuU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5627 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Sep 11, 2022 at 06:08:49PM -0700, Nic Chautru wrote: > From: Nicolas Chautru > > This patch introduce stubs for device driver for the ACC200 > integrated VRAN accelerator on SPR-EEC > > Signed-off-by: Nicolas Chautru > --- > MAINTAINERS | 3 + > doc/guides/bbdevs/acc200.rst | 244 +++++++++++++++++++++++++++++++ > doc/guides/bbdevs/index.rst | 1 + > drivers/baseband/acc200/acc200_pmd.h | 32 ++++ > drivers/baseband/acc200/meson.build | 6 + > drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++ > drivers/baseband/acc200/version.map | 3 + > drivers/baseband/meson.build | 1 + > 8 files changed, 432 insertions(+) > create mode 100644 doc/guides/bbdevs/acc200.rst > create mode 100644 drivers/baseband/acc200/acc200_pmd.h > create mode 100644 drivers/baseband/acc200/meson.build > create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c > create mode 100644 drivers/baseband/acc200/version.map > > diff --git a/drivers/baseband/acc200/meson.build b/drivers/baseband/acc200/meson.build > new file mode 100644 > index 0000000..7ec8679 > --- /dev/null > +++ b/drivers/baseband/acc200/meson.build > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2022 Intel Corporation > + > +deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci'] > + Does this really depend on both bus_vdev and bus_pci? Ideally, I think that drivers/baseband/meson.build should probably have the line "std_deps = ['bbdev']" to pull in that as a dependency for all baseband drivers. Based off some quick testing, I got this driver to build with just "deps += ['bbdev', 'bus_pci']". Though, again, I think these probably should be standard deps for all bbdevs. > +sources = files('rte_acc200_pmd.c') Given that the driver is using shared headers with the acc100 codebase, you might want to consider putting in "includes += include_directories('../acc100')" in the meson.build file. It saves you having to manually specify the full path to all these shared headers, and gives you only one place to update things if those headers ever move elsewhere. /Bruce