From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC40DA054F; Wed, 7 Sep 2022 18:27:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 861BB40143; Wed, 7 Sep 2022 18:27:50 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 2AF66400D6 for ; Wed, 7 Sep 2022 18:27:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662568069; x=1694104069; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=I84aGsbJHqWaskXSQ0So5vh61Si04F5ocZ2YcExgeZw=; b=TpiYSAuPKVhCDqFo2ufuWQGA3tjtIguaVFQsbMHGj83BRKxmQ/h6iSzE bW6XQNQq+E7azbjA9Swo+AY1HUgBsSMRlUPmkarw2Vsb5JpKwjB76704Q eLbQy8zeykcj9gVgahdwF1szwKG+3BDsTUgKbIZDId2vbVCo9g9I/5w/P Tjnct5TMYgkUHhD7a6pRbxGB/j/1mlMOiuCmKPvZMb+oMvozUskvF19ZV BO3/7EfOSfCh2ruOLGKCzbI2WrIhMPgT2b6ZxtzHQmEYOvQLk/Q7SUGVN eIwQspyuBfrjNouMWYQ4Gi8YwaG6iOK9+rpBzv58fJwXvy8SqLjBi5XTQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10463"; a="360879391" X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="360879391" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 09:16:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="676259106" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 07 Sep 2022 09:16:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 09:16:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 7 Sep 2022 09:16:54 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 7 Sep 2022 09:16:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOQJNbgzGRq4pAWJTUPwbCk1f0PBA/x3JJxFGfb2hy0Kf4dUgfZ8R71XHWv2tU/6oObJp7nkUzTlyqOyGcmY7GmVn8casld9EOVGPg//gkqKZEfSvrsE2M0PPrhki4yNk1CsAahUI3bMXkuKP0ZYwFwFKjDobBejK1eROKCiAQcVSeLIvvGBluj4utOoMuvuM4HRn2lMfGRkOdeTjXf8HF1af1cg+t8CEooHgF+SL2bXZ86cJlg8qYFiBs+4gfFZRwNcFxZJapP181k3anV/y/pe7fWgWi0pMNfSOpmGB+EYGSB8NYqIoOs0mjfPHYhatPYjAikp/htU2a8YY3w0uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hi1tBsZIMEIhdvGjaq9vLTTP/giGmbqCexdSt6kLlWA=; b=SjOFfJOXGa6ROpW+V/smQJifEAdYnlKPyDMRxdBP6fxG8Q47V4N/oXbGDhofn6JSrxgYUg5KpRoXqD44Qmn7i8M7I7DhS5Y9FJFWqdQj4+0MDMOO2ruPGceaW3cQTHXjpd6ba9SKAWX0aWBrPyXa32LB0MauJCXij0/yz4jYuvrjstLQU6tA0hutFHK6Lspjra9wUGPbbw/3qdxW9qnJNfPEmjs9obXswLSKyLRLnBxvDOxJirrjDGavnR9Fr0pWIdnznEdQt1YE5Re7z4ObmYPttLXxjZFTIctybGWmpG1r/8PevgJgUzSE45jHFvjai9F2wlvDuKuxfiMzru83RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM6PR11MB4185.namprd11.prod.outlook.com (2603:10b6:5:195::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Wed, 7 Sep 2022 16:16:52 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 16:16:52 +0000 Date: Wed, 7 Sep 2022 17:16:43 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: , , , , , , Subject: Re: [PATCH v4 1/9] dts: add project tools config Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-2-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220729105550.1382664-2-juraj.linkes@pantheon.tech> X-ClientProxiedBy: PR0P264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::32) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM6PR11MB4185:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b97b9ca-4bac-4c5a-17b9-08da90ec5fe8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BIIqolvnP31yFqDekKMRPE1LBeMRP9tTiu0FAM6hDdHj7FRzBdErcMuIEkm5SqRyFGzVBg/A9kZPmjzVNorZQLp32MGlpLSvsYz0cKWhnywRd5QK8BIFHAOJK8/2BRt4RUZfi54leqZZqEbJTcYXGKxaoMASzV/ECqgsLRGts2VyuKhA8Zluy+wx/arJ0UWylmBtm2jVtvrZ5P2siJ+kMOypgmzJD/9hnSTKlQzpLRVDD+Yc3U2U9XOrQ0whbY06cb07Tx+6YGDXhpavaucbv3K18Di5UU7GeEOgh5cEi6WWp2CDbfpD+gXqIm6xxziusxcV9mYvFq0G963kCEMJU5J4FlVbAjwiPCpBUAvsnXy8J/lDd+Y+6dREC9Z/zQ45BLzAEiXAXEMaQfk4eALNhl+gExYA/kR7zg5/nLhPBLjhYVxcinYISBMA8m0f6a+T7/2ujtS2tKb8KJm66fKEiXudm1qzx0pUwQQbeShbWU1jBExk7nP0/vFJd8kj6UzYbpFXJFKGlzF2LFdxBvPTW4aVMNHFBkoLhXyH7SE4sXKyOFuNF31MN3fylsMp2rS00NKzIVpRToMXLaz8XgafuqUqBQT3xwopDvrcu3csUVIIPL4Pa8iKHm/FCTpmMxgCGzi++7vBxs8dlBy0M/LF7YLyrZk8uBpKopw8bE/uGA3kX4EkbMI2m+vE1tEP1k4yy8yIs+0zfDi/cu3f0/Mpxs4Wk1KNXHVCrfzliWOG9L0+RnnJ+H/ks++vDEgo7wO59boi3ujI/MSY245kDC+xOD3SWLU6SWX+wGR24/U+nww= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(39860400002)(136003)(366004)(186003)(83380400001)(82960400001)(966005)(6916009)(66556008)(8676002)(4326008)(316002)(66476007)(6486002)(66946007)(2906002)(6512007)(6506007)(6666004)(26005)(44832011)(478600001)(86362001)(41300700001)(5660300002)(8936002)(38100700002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUdUc2l3amwrcHJjcFBjdzN5ZnljZk5jeC9zcU1TR1REQ2VERFBWNmt6NWc1?= =?utf-8?B?dy8rTFR3M21qdHN4MzVZZ3NsRUpJdUl2VlJXcElTNHZPOXVDaWRGRDRZeDIr?= =?utf-8?B?U1ZPNUVuR1c2NnFXTUNvNHVLUm55Z2F0KzRTV3ByWnRkUjdwWHNEeGhrdVhQ?= =?utf-8?B?Nlc2K2xNQkxUM1lPdmZPWEw3enA5d2J0TFV1N1NMOGM3SlNub1hjS2dBK094?= =?utf-8?B?YmxZdXNtT3VVQW5ib0JjdVpmQk9hQkpoZktTdG9GLzVFaEdDZTE3b0UzbVoz?= =?utf-8?B?T0hCVStBby9PN0g2WGlGWWt2Mmlza1lmQzF4NmpkT3MrUEl2VEN6d1lzWEFG?= =?utf-8?B?ZDhsdHVKU2JWM2taVERWVUhUUGZ0cXFSenM1djhBTFZQejZGbHVRUGp4YTVp?= =?utf-8?B?WW9abzllV3NyRCtlT21sMDJxVlh3WTMzK2ExcFZDTmV0MzFITXJhUU1RN1dI?= =?utf-8?B?WHZPRVJ5Tm5Cd0RxcGh0TEQ5YzFPNklySElSSjFpUEJFdXA3QkVJV0hnckNX?= =?utf-8?B?NUJ3ckMwZ1NyUmxWSEZvUHUxbmFvQ3dyelNweHZ2ek9xcU40U1dGUXZLWmRB?= =?utf-8?B?ZlJjay9XTHVtWGlRaFRibGk5THl0aWVBVXdBbS93d2Nyb1RtclJpNlJaZ0E3?= =?utf-8?B?cjV0YzlleVl5azR1bEFQcWJqVmFzNkR3YlhNT3NnNW5LY0gvc2ErbDFueG5U?= =?utf-8?B?bVRySmtzaXZNNW9lZWRWdjd4QUVhMEgxTWtUckRiTkI0U1dhMldzcGNYQWhU?= =?utf-8?B?K0RYc2d5dThESnk3dzVvZFdxVkoxcXZGdzRzWW03VUdSNUZMMXEwMDdaK2Vm?= =?utf-8?B?UzN4azFZc0hic08wTUkxREN3cE1NaFhoZndBV1ZsTzVoWFdoU0cydzh2RDlQ?= =?utf-8?B?VVBId2w5bUdCRms2V3V5dmFoaUtpM0FINXd0SUhCSkVFeG04ZjUxK3B0YXhi?= =?utf-8?B?UllSRkhXa094anEyNk94Slg4Z3hmaENxbjVUaFphWDVKNjFEa1ZndjZya204?= =?utf-8?B?NkZiYzF4cDRGZ3dqTE1KZUV3Wnd5aWRZUHZJQ1dYSDFSMWJFVXdyL1haamNI?= =?utf-8?B?ZEpzVUQxZVlaSVlBVm9JQTRQTnVFZmtSSUg3YVlEd042RXBEMGVCQ1lsMzNB?= =?utf-8?B?Y3FPUDFac241WERkVDZodUdPQ25HYlZSa3NIR2VxSHhZZG5OU0JkWVc2dEpj?= =?utf-8?B?MXgzVjd6WENpeVRQd3RpNm5YWFFnNXN6V1ZrODh1THBFUGJyeHFVVnRzTTJq?= =?utf-8?B?aDFndllURXFnN25JNjRuTU9MTkQ4Z3JyOUhRTVBKZXB3dXJkMUpNcFZqOHFm?= =?utf-8?B?UjFJZmdyanhmV05wNnJ2SXRtUExXMDlYUm9rVisrTVFDVGp5TnF2STRZSkVw?= =?utf-8?B?VjZqcno2dGtXNDNPK0M0Z1hjWXRla2dDdzdiZjhGUC91OUxSd1F5WHJRcWxL?= =?utf-8?B?Ny90UWFlcTRGeWptQTFKV2E4Q050eTgxK2NyOEJZOU42VHFjL093RGNqbEI1?= =?utf-8?B?aWtEWTlPU0F5OVArZWNEcTZya3lIVkxPZlQ4cnozcGJmZ1JSUURqaU5SSzY3?= =?utf-8?B?dnlidzk1ZXJneVBWZzhQSDUxV1lVRU9sdHJnWC9BUVVxU3Y3S1VzQ0ZCalov?= =?utf-8?B?ZFRjRHBQZDB5RzYyM0Yyd0NPZlEvNnFnaFVUdzhLQ2RlRy9OS25YOHhIVXhE?= =?utf-8?B?SWMwejY2S0JCVW9kbzdTdHNzWkpxQkxUTEI1aG5TcWVIbDVWeTIweUw5ckFw?= =?utf-8?B?NUZMdmNKVEVQYWx0K1Z4LzRMRXpZaWxjdUJESXNqZmhIQkNVYXRkb0FidlF6?= =?utf-8?B?WElsK255NWd6TlVuejQxaE4vK1MyeTdML2FDWENmY3VKd3FCRzZoZUlCNTky?= =?utf-8?B?Y1hsTkN4VFVUZTRFdEpybU1uY25wTjlVTFN2RUVBT1ZYMnNQa2c0UDZIUFZE?= =?utf-8?B?T0NKMHhGS2VsWXd4eHNHQTdkWXlycDJ0UWlyaW05eDJ6SjBqdWtkbWFFVk5B?= =?utf-8?B?L1laQXdpTVNZOTdlNGNub3RkeVZ1eWEvRTRMZk1icXZrMzMxREFvdnY1dUhV?= =?utf-8?B?TVNQU241U3hvalZKaFI1MHFEaGNSVlk1SzJ3WmlTVllmM3pBdExnbVB6dDZa?= =?utf-8?B?bzBqcjVEc1dFdlRjd2hubnk5K0xmSWRmNDhpM3RlQ2xITFc3V0pTa21vbGNl?= =?utf-8?B?UGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b97b9ca-4bac-4c5a-17b9-08da90ec5fe8 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 16:16:52.3636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CugWWeMXt1nduTFhOBvUjxy1CSc/4WRoMyzTIuhosQi76KcqpIKMq1aDDnwZCclSRLOPwlAhQWq2EDmyMQeUJ0N9SkntAcAfi6j4JR9V7ts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4185 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 10:55:42AM +0000, Juraj Linkeš wrote: > .gitignore contains standard Python-related files. > > Apart from that, add configuration for Python tools used in DTS: > Poetry, dependency and package manager > Black, formatter > Pylama, static analysis > Isort, import sorting > > .editorconfig modifies the line length to 88, which is the default Black > uses. It seems to be the best of all worlds. [0] > > [0] https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length > > Signed-off-by: Owen Hilyard > Signed-off-by: Juraj Linkeš Thanks for the work on this. Some review comments inline below. /Bruce > --- > dts/.editorconfig | 7 + > dts/.gitignore | 14 ++ > dts/README.md | 15 ++ > dts/poetry.lock | 474 +++++++++++++++++++++++++++++++++++++++++++++ > dts/pylama.ini | 8 + > dts/pyproject.toml | 43 ++++ > 6 files changed, 561 insertions(+) > create mode 100644 dts/.editorconfig > create mode 100644 dts/.gitignore > create mode 100644 dts/README.md > create mode 100644 dts/poetry.lock > create mode 100644 dts/pylama.ini > create mode 100644 dts/pyproject.toml > > diff --git a/dts/.editorconfig b/dts/.editorconfig > new file mode 100644 > index 0000000000..657f959030 > --- /dev/null > +++ b/dts/.editorconfig > @@ -0,0 +1,7 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2022 PANTHEON.tech s.r.o. > +# See https://editorconfig.org/ for syntax reference. > +# > + > +[*.py] > +max_line_length = 88 It seems strange to have two different editorconfig settings in DPDK. Is there a reason that: a) we can't use 79, the current DPDK default and recommended length by pycodestyle? Or alternatively: b) change all of DPDK to use the 88 setting? Also, 88 seems an unusual number. How was it chosen/arrived at? > diff --git a/dts/.gitignore b/dts/.gitignore > new file mode 100644 > index 0000000000..9c49935b6f > --- /dev/null > +++ b/dts/.gitignore > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2022 PANTHEON.tech s.r.o. > +# > + > +# Byte-compiled / optimized / DLL files > +__pycache__/ > +*.py[cod] > +*$py.class > + > +# IDE files > +.idea > + > +# DTS results > +output I think this should be ok to merge into the main DPDK .gitignore file. > diff --git a/dts/README.md b/dts/README.md > new file mode 100644 > index 0000000000..d8f88f97fe > --- /dev/null > diff --git a/dts/pylama.ini b/dts/pylama.ini > new file mode 100644 > index 0000000000..23fc709b5a > --- /dev/null > +++ b/dts/pylama.ini > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2022 University of New Hampshire > +# > + > +[pylama] > +format = pylint > +linters = pep8,pycodestyle,pylint > +ignore = F0401,C0111,E731,E266,E501,E203 I think it would be good to comment on what these ignored values are, so we can look to remove them in future, or minimise the list. >From checking the docs, is the below correct? E203 - whitespace before ‘,’, ‘;’, or ‘:’ E266 - too many leading ‘#’ for block comment E501 - line too long E731 - do not assign a lambda expression, use a def C0111 - Missing %s docstring F0401 - Unable to import %s Some of these - particularly the first 2 above - look like they should be relatively easy to fix and remove the need for ignoring the errors. Are the standards violations in our DTS code or in some dependencies we import or code taken from elsewhere? > diff --git a/dts/pyproject.toml b/dts/pyproject.toml