From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D895A0540; Fri, 9 Sep 2022 15:52:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0ED4B40A7E; Fri, 9 Sep 2022 15:52:52 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2ECCD4003F for ; Fri, 9 Sep 2022 15:52:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662731570; x=1694267570; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6RCqlFbniOpxfuUuhcgzW7/0GJ0x/UkG9fj2ILqIYB4=; b=T1oig4MMT87wFm7tw5Q8x1/wISvZMJ+r0X0VuAoRpvwxLOkw7VaQzBHb 7aXiMVBrQGITlvrgXQJ0ZHOAHtSNIKDVUNIq75111avDoIWuRLKysRUDK EJSeWUHkGkizHBRff/OCZOJ2lRPFFsgsk+kwnYHXpixpqTe5Db58OIa2q wmL5i38qcDFeoJl4EmcJjLBMg9STDd9FFT70B5qgx370UjA4ZPKajEgmz E1xEQFKtXdZDMBHWT48zDqrv4T9XuRQnk0Sif0BxN3ngwst1qW/kiW9+K M/K79m7hP5mKj17Py2NBs5IL9kTuyWqlCcLVwuyCfd6fXythu8C7itNXr A==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="277209727" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="277209727" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 06:52:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="683644377" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 09 Sep 2022 06:52:41 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 06:52:40 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 06:52:40 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 06:52:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 06:52:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfHimEzQAmVHCASSYcMmzaRCvchP9IwfA4YNg4zlXlPWAyixL/LdMeTjaQSvgAJbNQ5COvZVr9aGlVROXFnnl3DpGxfDtS5F2gNM/D7QMuVAxOFlY1DOu4gX6sr3rTpgj3UCtdDSlx3V0Y0pcu6iuTtrQ98fWMG0eXmjFrF77DHvtnZyGiVHe1W+n6tTJWxYU5EBv0upL+N4ha9wTyKOh7Ao1qCSSTUwDMtlVSjpN2HURUuCchdBDLRatMfhlXOD58/qOL5lKTIUWfOZL6HmhUZKldgOL1Fs/RjwiJ7NwUDd9RHAGFTyL5rTJUhwgoJ3WJUwi1T9Wz1V/1q/29/Ezg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wevpNs90BTNeys8zQSzrMoh9UOJVP/KYJOhQu5RFVO8=; b=Euol3AkfpLOKXzQf/R+5tFDtFP1P/TkEcxOzHvC2zUCBFyAkv0RoLBpF70P9Vwni+v6gkaNt3HvJ7GfKFPzufXwzu6Sb3OxWAuj08/LWjmAGOfZL5Uu/JO8eJKGFRF2hwqRtJOw7ztJnQeg5wJuBEcUMSWPd8wJlBDu8Un8NWENF+BwLv62M7tWlvOGkcbGj6jsZ+i2EyOnqmZZH+tEHzSOVqWpb0EFr/rsTHqWCregh32W3RvYoaSI9vqopkgd3+5U9dJcOG+DkkhYw2g1BFQt8N+m51QDLeYXKtgXW2lXSS7kYjxcD2r2IY4pMd0RTxlBjnUqXP4em3TqZr24AoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SJ0PR11MB5088.namprd11.prod.outlook.com (2603:10b6:a03:2df::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Fri, 9 Sep 2022 13:52:38 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.014; Fri, 9 Sep 2022 13:52:38 +0000 Date: Fri, 9 Sep 2022 14:52:31 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "Honnappa.Nagarahalli@arm.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-2-juraj.linkes@pantheon.tech> <3680ad0ceb5944e6b5050d5f7b9c9599@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3680ad0ceb5944e6b5050d5f7b9c9599@pantheon.tech> X-ClientProxiedBy: PA7P264CA0066.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2de::11) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|SJ0PR11MB5088:EE_ X-MS-Office365-Filtering-Correlation-Id: ad9b83b6-2276-4808-0170-08da926a8e9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UM2i3aGkSR/aOf1NyWEsb/Pz5+W0IRsnHsncBDg3FPCePRV/NXIHXpJcbsxsxJ8F8MHiqJGr9ZskcatuE+T+PVOeu8Jk7trwWn3teE9g3gUNHPuVhTTRd21cNmBQkcVPMfqjAHf7o27XPK7oAkGtvXeIGd/V+MxGmkwjMivv/Cb+WyJ2G8GZOeo6eLDiBH1BZFtSHZOstRk6JF6x+JRxdat57dL+JzpbXjkarxV542MzT47PpqrIfox/3UC8ZcK+9UXXyYNRKFfDwCDtEri/qqQKQa2mqMgGwZ4C+YS+i7xxwxZ/iyUj5m/4sc4DWQJN+MpLy3k2wuUvxb6PN25emG5yLkTNB4BuK0nKyxSURr8edWBUwS+skdQK91fiql/Ph+Rtr06sB5MZvbU2xnFm9GdgWs7G1k/TDMd5mtEyQnId/Z7ZAvD3qpQrF+U2/GGA3I7rM5Tw8eOgOv9Pkcvrtwxaa5A5Lh3EYDhBwujR7TwLT9ep/I+srqdYlK9MxAqrcTGxY904TfsVG5TVocSenyzuEDcO8ZER7JOxlgSwBzUC0DOk6Oes2SrzYKwrojzU11v32fZWmQ6Hfjki8TfxdRMqWN3dcGzdzcUIOiD7a8A+LQjnOjvdTzCpp504i8a5tn6a7PK4P54U4aOnlCOkL58EijozL6uSBB7/3aZRD/urkVEoEB2IKTgDpQ0ptYCuzQs3J2sfHg9/VDRtbV/4+dvsgKFIw+DW8s4B486hIQCOd2leRR0g8fprT9wuUCWrQ2gkrb+jdu+dXG++VtulPP9K9kDb2BDvCsNqBYW0vLk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(376002)(39860400002)(136003)(396003)(26005)(82960400001)(83380400001)(2906002)(186003)(4326008)(54906003)(6916009)(6486002)(966005)(66556008)(316002)(66946007)(66476007)(478600001)(8676002)(41300700001)(6512007)(6666004)(8936002)(44832011)(5660300002)(38100700002)(6506007)(86362001)(53546011)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVhubEU2YlQ5S3R4b2Q1bldJLzk0ZGlCWVNaaWE1RXZvcTl4K3dORTZMaksr?= =?utf-8?B?VjVCM2JTQzVadGdvbmNtdXYzUS96RVM0dEVMZGI5bDlxSCtCNmVCR0VqWmFP?= =?utf-8?B?ZUw2emtuWXpadEJRRHhZZUpPQURlTXhzU2RIemZ5Yk1XVlVaeGI3UEhQb3R5?= =?utf-8?B?SThCcmFVTHFIeVhMS1FqTFh0UmNJeDZFZFo4WDdKczlZdFByaXc3dTVsUjli?= =?utf-8?B?eGhnWEhzTTg5OWU2MTFLVGNQSVBsQUNWYTdzVG1hdnpyOERzRk9GbTRqbnBz?= =?utf-8?B?RjZjRERBVEFWQ2ZQZUZ0ckJHK0FnY1RubXNMRGN1Y3NXL211ODVkdDEzVUxv?= =?utf-8?B?L3BJRHdiVElBVmlxOWZyalNuSHZhZ2Q3Qzc2NVdCaXVEUTgrdjhKYmpXOFlH?= =?utf-8?B?U3djR3MvSXV2aXQzVllrenNXQkt3MmZzYWRnOU9hMG80aFhWSmhvVVdnbzE2?= =?utf-8?B?eVBzU3NIa0ZISHcxU1VuejhzZWVzODNuUWwzYUx6VERIMC80OGhlY3N6cCsv?= =?utf-8?B?Y2xHb2JOMVR4WXRWb2dpTG1kemR2S0JCQkZhVzY0ZkdZYzZSVEhGZndnNE1Y?= =?utf-8?B?cFNrcGdOTS9SNTd1SXlUS2Z3cW5ydVoxUmVIUk5NTmthSlZVNWc0eVR4QTJQ?= =?utf-8?B?SExZanFwSldhQ3FhRFVucUxud2VMYzFkeVJoQU9EZ0dGWlpLcFhNOWN1WitM?= =?utf-8?B?SlJyNXdoemJZdTNrbXVndGtXZVZjNGQ0ZzVlV0NBRXZEWnpNaUpjc2U1a2k3?= =?utf-8?B?UW15QUFDcHQ2a0xaUFU2RU1vNTVnbzIzcXF6ZGFyRElFQ3RzVVBvdThpYktn?= =?utf-8?B?b1cvR0xMUEduY0thS0hJeUpCTTEyS2JTMGNtb2daZk5KY2p1eTE4ZDQxbmli?= =?utf-8?B?VFhHdEIyQSt4Yng2ZStrZThPYzVVTWw0dUNGTjVzL3c3YklFK1hxaFpuZk13?= =?utf-8?B?T3IrWXN2WEZwS1h1OTVVR1BzY0NEY2RQbGZGYktjb2VqY05MYjMyYnRZUW9v?= =?utf-8?B?WXFFQkdkTEYraTB4T1BFTnVqaEdzQ21VZkh2dHJXbXJyZTJKR09hZC91eGhI?= =?utf-8?B?cFBqdk54T2RkTFIvQk1IT1lySWhVWklXYlJ6UUxQZjRlNy9yR3N6L1Z0RmlK?= =?utf-8?B?ZDdOdWthUGtXSzdCNHJOaFpoc1RPbTRuY2FpbDVtemxtdXg2bGNhMktMKzFu?= =?utf-8?B?M2FhRTJYY3AwaG8wcElGcUh6aUcvb1dGNVJncjNjSjNCN3B3cklKQ1FkZmtP?= =?utf-8?B?Ulo4cTFHMlVJYnJaMjJLbEh6UTBPcFdFUDdnS1hReldoaVQzSURDWVh6NGZM?= =?utf-8?B?dUZPK2hHcEM2ckRGUUVCSmVnaFhaeGN0VFJNbUpiRVFIUGZzVnNqVTVlNEtS?= =?utf-8?B?a0s3Skt2WHNNeTYrSW9ZcVZ2RDBDOFR0b0VpS3hTVkwvUDIwZUxZOU85UWdu?= =?utf-8?B?aE5Jc1BsL0gzbXM4eUkvdEhjSjRTNGZNL0FxODE1bWhzaVJzZU1wNU41WVlq?= =?utf-8?B?UUtuaGZzWGh4eVFrVWVHR2N1ZTVuekx5WVRYZ0poRVZHcm5zamRYYThPWk1G?= =?utf-8?B?NmdNOG1GditUQUZiNEN2dnB3WDkrSkxoWlNyZ2g5VVZ2dDFKVjBCSUdPTWZJ?= =?utf-8?B?QTg5QVZPcEVnaFBteDlRN3hJb2c4WDZwU2RJamNxWTc1WSs0SEVraXpuOExJ?= =?utf-8?B?RlI1NUs5M0ZMaXRtRENyREpRUXBDdEFBczBucWJMb2J3UlJ4M25VNUR2T3J6?= =?utf-8?B?MnQvbC9KY0RZRkRtTU8xaTRkZzlhQ1J6SEhFRmNoVVF5eUVieEtCOTcxd2Y0?= =?utf-8?B?ZWNlR3JId2NvTGdVdEs4SHRHSk1CTnpIYnF2MUM3K2dlNzE2SHc0dklvZlN0?= =?utf-8?B?QkRndVdIQzVLNkRScFNvRGJqc0xIR1paaHQ0bEorWTFHZTNNais3TkpmT3pB?= =?utf-8?B?alo3VUttMkVnYm9GeFlwaHZpTkhBU3AyUFMrcHhvZnd6ZTRZaTVmdUZlbkwv?= =?utf-8?B?ZXNOSE5RTzVjL0htY2N0ekxtSTVKcHRHQ2tXSWI0NkNpNCt2ZFNqenRnak5h?= =?utf-8?B?MDRCQmVCalhTZHdnT1FZY3Y5Qnc2bUVkeTAxelFzVDF5bGRDeC9ycW1paWRa?= =?utf-8?B?WHFPZUZqcEZNOEQrM3BWNys2cTFxeDJUdXRsQk1TN2M3QlVFOEVRWDRqMFFK?= =?utf-8?B?K3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad9b83b6-2276-4808-0170-08da926a8e9d X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 13:52:38.4751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0FqLz5B6G/n4gdH2/RJt6huMKA73x21LAV4f07tiypg9AAUv/Iumlic0r9TpbwFARXIf66UJgzPCBBUQ0MuUIjHVfnTP4aaHNE+yyrD3N6o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5088 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 09, 2022 at 01:38:33PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Wednesday, September 7, 2022 6:17 PM > > To: Juraj Linkeš > > Cc: thomas@monjalon.net; david.marchand@redhat.com; > > ronan.randles@intel.com; Honnappa.Nagarahalli@arm.com; > > ohilyard@iol.unh.edu; lijuan.tu@intel.com; dev@dpdk.org > > Subject: Re: [PATCH v4 1/9] dts: add project tools config > > > > On Fri, Jul 29, 2022 at 10:55:42AM +0000, Juraj Linkeš wrote: > > > .gitignore contains standard Python-related files. > > > > > > Apart from that, add configuration for Python tools used in DTS: > > > Poetry, dependency and package manager Black, formatter Pylama, static > > > analysis Isort, import sorting > > > > > > .editorconfig modifies the line length to 88, which is the default > > > Black uses. It seems to be the best of all worlds. [0] > > > > > > [0] > > > https://black.readthedocs.io/en/stable/the_black_code_style/current_st > > > yle.html#line-length > > > > > > Signed-off-by: Owen Hilyard > > > Signed-off-by: Juraj Linkeš > > > > Thanks for the work on this. Some review comments inline below. > > > > /Bruce > > > > > --- > > > dts/.editorconfig | 7 + > > > dts/.gitignore | 14 ++ > > > dts/README.md | 15 ++ > > > dts/poetry.lock | 474 > > +++++++++++++++++++++++++++++++++++++++++++++ > > > dts/pylama.ini | 8 + > > > dts/pyproject.toml | 43 ++++ > > > 6 files changed, 561 insertions(+) > > > create mode 100644 dts/.editorconfig > > > create mode 100644 dts/.gitignore > > > create mode 100644 dts/README.md > > > create mode 100644 dts/poetry.lock > > > create mode 100644 dts/pylama.ini > > > create mode 100644 dts/pyproject.toml > > > > > > diff --git a/dts/.editorconfig b/dts/.editorconfig new file mode > > > 100644 index 0000000000..657f959030 > > > --- /dev/null > > > +++ b/dts/.editorconfig > > > @@ -0,0 +1,7 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > +PANTHEON.tech s.r.o. > > > +# See https://editorconfig.org/ for syntax reference. > > > +# > > > + > > > +[*.py] > > > +max_line_length = 88 > > > > It seems strange to have two different editorconfig settings in DPDK. Is there a > > reason that: > > a) we can't use 79, the current DPDK default and recommended length by > > pycodestyle? Or alternatively: > > b) change all of DPDK to use the 88 setting? > > > > Also, 88 seems an unusual number. How was it chosen/arrived at? > > > > The commit message contains a link to Black's documentation where they explain it: > https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length > > Let me know what you think about it. I think it's reasonable. I'll move the config to the top level .editorconfig file. > I have no objection to moving this to the top level, but others may like to keep our python style as standard. Realistically I see three choices here: 1. Force DTS to conform to existing DPDK python style of 79 characters 2. Allow DTS to use 88 chars but the rest of DPDK to keep with 79 chars 3. Allow all of DPDK to use 88 chars. Of the 3, I like relaxing the 79/80 char limit so #3 seems best to me as you suggest. However, I'd wait a few days for a desenting opinion before I'd do a new patchset revision. :-) /Bruce