From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7DF4A0032; Tue, 13 Sep 2022 16:18:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C84394021D; Tue, 13 Sep 2022 16:18:30 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D433440151 for ; Tue, 13 Sep 2022 16:18:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663078709; x=1694614709; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5AGtJoy6w4eWbGGAFxiXkUJp48SfSkLf6TF/JG8iFqY=; b=j8q4W9eoUqBOJV2fUvqepPCP4ZoTJrM4IxmhN8hhX3C9BnrzIciLSijI FmyFl2YcGm6CMBCb+TTuvwJwDQesYWxIDT3VwpvdJmA9e4Eyaxb6D72wc oIL7EdmWD2aB1/3tn2VAEHSl0fJb8u87Uh8DUMnF4dfOfVVaS7ypgN/P8 I0qLbHPYnl/LQYQgFfh5p+znou9gHX/+XczUe3rLpY6/21L7vzGSF0Avw iCoD+/ppKpoFtG/UmqLcOanc5xy4yQ5eAu70FH/n5UEt4v/r7LWJCkDQq 2A69BukoVx0MzFTTDMMolLWP8nbVGLCYjf5bJf2JPqgqqX8Uv/6cDggsQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="362096192" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="362096192" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 07:18:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="758810594" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 13 Sep 2022 07:18:27 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 07:18:27 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 07:18:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 13 Sep 2022 07:18:26 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 13 Sep 2022 07:18:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hb83yEmqDURhxe6yIM3zh382q6LaKbZTxSrIwoeLem1tGSOzupSyCVdhRwEa9IWjUn+kSgVmKsA/LpFl4X+95RWhxSqj9+t05Snd0iMIXj1D6L6nQHja6TM+aEhXofPArkyLWfgxxAIHZzdAAGMbA3rPX1JfIwPdG3QrGKHLGkc/jTG9Dy2F9jeEog7vYlHi2TRfUoYpjKypXelga9W3W5P9FHEaiOj5VIgos12b9c6wXxN8fiJK2Q/3ZiM8yn7RsJDm/YNiEZiU+FFnx6ZA9slgUUUsChnTUiY2rWd3HIZqECuNNEMbVSIGA73uc/KI7pvrNgOGaofITKzjzvhm5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TJvEJcqPs7HZfzXhDMwogxcknV8oTlxAYLccYqGLbY=; b=K1xhrzHrsH84UrYJI1csufqwEa8VLb5jgKplUKTxy5bhJsFhS9DRnEaq0+mGBIZvVT7n/7s02GB9QYlfsccsZ2NbZnlL64cxleMCrTQwL6J3lWjkTRCzJjldS/9TGJJSd4fwLlGIXc4J4L01Asrsdkn0vjA/djY2iyJS8navLZswmJf09WyctzTiwts0lNgLzOma0zE9h50PVAXuZCSZd+6TYE72/pyHuxNn09sKjuAzY2y/V734JTupVTMac4qI2IctesWum7sDQ9qUWb79mWp1hrUqIJu6SvwVP36GpQHumzFrFQMTLxjavuEyNBDQxWobsk+V0RBLGEOxEjP0NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DS7PR11MB6080.namprd11.prod.outlook.com (2603:10b6:8:84::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Tue, 13 Sep 2022 14:18:24 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 14:18:24 +0000 Date: Tue, 13 Sep 2022 15:18:17 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: Owen Hilyard , "thomas@monjalon.net" , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "Honnappa.Nagarahalli@arm.com" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-2-juraj.linkes@pantheon.tech> <3680ad0ceb5944e6b5050d5f7b9c9599@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR03CA0081.eurprd03.prod.outlook.com (2603:10a6:10:72::22) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DS7PR11MB6080:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b331b5b-78c6-4104-513e-08da9592d173 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7IaQEvsloe04x4Lq97HmoQJ9+qaqwnbHytgUhRs3/MdQrHmNN9dr5bPqs5aC6k8+kZ2R0Qmy1xZz3X9kCshcEN4S6v7ssDZjgo6qsOxIS0wk6FI33+USXvbwTtaqsPmMtL4k0ZqPF3RZhXt8xLTUbnpOhxs2fzaH6aAJXDkHwh+s3KmUpHEaryTNblcGkL2vktYmOKq33Q9M5iuVTOexVmdaSG41r75thfdSXUnTw9igB+7aHPhRcOUJDnjDNHyyCLvxCF/Hpf6KzkNrCVfumemo8re9w7bvIzpKsJBT+Kg/zWnX0wkFbgRtJntFekoFqiU8YtkmUfsBPCQlAmptAZqk/Wq2hv1QbvnrS9S7xVJs6zwCRSLCNnQj0I7WiZDYEx8o7tAAbJZw9PV+TCjSGLvSbq7/RHKwzsJribiulejSgLo+7xOItRINkPdsdF+b6H3IiMJzKfQ6/UV3G9FvJLVdOq8csVtHKyjwE2FkV3X5dQASgHO/Rw6/YU2kXJSosHRaPJFf6UsrOz+PtOQWmtXaTXAz4tWP2j72xA8qsXftjn3FThMcbgJ+GCkqZGRHPOfgFiM8AKZcin+khhnIvh+eN7Iq7kQR5nlbaaapcF4+ZqvfiD+GGgEP+W99OXkSsB2LzDOC1a5bPZ6Y4U01LQrw1veGVALiqWta/Ka/ozg+tbq71wNJbXzY11x6QOLnjeH31O0Yc7pjEvgmCW/XPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(8936002)(82960400001)(41300700001)(86362001)(4326008)(66556008)(66476007)(66946007)(6506007)(8676002)(83380400001)(54906003)(6486002)(6512007)(26005)(6666004)(53546011)(44832011)(38100700002)(186003)(478600001)(2906002)(6916009)(316002)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M003L1dDVHI0bzhqKzFrL3RKTFNsenVaSU5LRnMreG94aWZZWjNrVjlTUklG?= =?utf-8?B?WStiVG9uTmQ3ZkpjbGJ2cDZPRUlIVGw0ZDFUaUsvK1pGRXRoMmpuUHZTM2Ja?= =?utf-8?B?VzNQcUZENlZGSUtlSWpkaWwyNXNRNFFoSk41dU9NOU8xV2RoanNRYXM5UXo3?= =?utf-8?B?WTdVRWlBZ04zSEJPMXJOY0xxbHgvQ2JmMTRVN2kzMi9CVGNTNlJlTHMvWGRy?= =?utf-8?B?dnY1TkwzOGdheXN4djk5RGNKcHY1bnRjUnF1T2pUWHc4aHRhSmE3d3c2RFlp?= =?utf-8?B?d1lPb3NBbmZnVm02S1pXMG1Nd085d0h3NDVkWlYrRVdSTzRpRFBHeHA4SDR3?= =?utf-8?B?cm1qWVdDa241b3RDQnlnV2NFSFptek5UcG9WVlNMNHd5cnJBdlloL0RvdUQz?= =?utf-8?B?aTdvWFUzckQwSW1rUXNMbDN6UFJEYWtIU2hFMHhXUUdHbHliQkx0UlFyRWs0?= =?utf-8?B?YkFicmduTmJvclBuWk5TcWNQMmpQL004eHdScStVVGZaallzUytCMTUrYUdB?= =?utf-8?B?WlN2anRwRnVPVkZ4T0tZcFJiVnlWZERrS1NsVzZzQlJjM0FnNHJ1WnBIbUFt?= =?utf-8?B?ajV4dTBXV2VweUdoMVBvZThxNDJycjFHUVo4OFE0N2kvYmMwMGFOdURhampj?= =?utf-8?B?M1REN05LV2lNRFdjaUs2bVFvT2htZTV2VCs1b096MzlmRHNFTUlXYWVSY3FK?= =?utf-8?B?T1hIMlZmSlEwNkJJZndWR3hvUVl0WGM4MFI0aVFZZS9JR1FhRWQ2anE0WWl2?= =?utf-8?B?OUtwUkdJTHc1ZkJPaXlORTdyTDZQNy9iZ0RDMmNtWHJtSjVrUk0vWFJyMzVj?= =?utf-8?B?TGs1NW5sbTFNaFJtdlBuc3FhSFNaYzg4cVdFdjhSdmNwOGk4a2lXbnh4VlFs?= =?utf-8?B?M0htWkFkang2bDBJSmUyamQ2eUhTOC9qeWJkY3ViaWJ1SE9DcjdPNkVQeGZN?= =?utf-8?B?bTB3UnhrTHdZUzZaNEgwaHo1VFRiVE5qZzJaalY2TVNhbnc3ZmR3MGhyRnFH?= =?utf-8?B?Y0pGeWZVeFJXcVJBN3VzME9EZlhpK2JiOW1FQnp1SGx0Wi9XMTYrTHo1QjJI?= =?utf-8?B?alJ2T3VzR2Y4M1VtMHJVRDNpMWJsRUFYRVpKWnBsT216cEYwTGg5bjF1cFdP?= =?utf-8?B?VW1KdW5SdnhxUE1wSlJYMVp6eDY1Z1Y5bUZKOFM1WEhERXN0Z3VsVUxQNzh6?= =?utf-8?B?Z01YSTdFZ05DSGJUc3pGUVY3YzFjY2Y3MzFzYjczV2RTYjZPR2RRd3FWQjFW?= =?utf-8?B?SWNjck9lTm1FMU1ucyt2SjIyd1pwK2V5TDcrbEplZjk0dlRLQVAwZWs3eWc2?= =?utf-8?B?a3h5VXAyT0ozTkU2VHhEcFYxRDRTZXNXZ09BY3ArVEgzTW96ZjlmVGNqNjkv?= =?utf-8?B?bVRQc00vWW5oYmJCS1VxUVFlUFp6ellmNlpNSHQvNUpPbTk3SXFZTXFFYlBE?= =?utf-8?B?OFM4eW5xbUo2ZVE5U2hkL2FJSEFXREtWdytCeUpQUHlNbXl3K09LMG5jdFU0?= =?utf-8?B?Tis0QzIxK2IyUlQ0a3pXdjFiVExpWjZNbUNNNUJLMmNOUmsrdlAyQmRYbXll?= =?utf-8?B?Y2tYT2c1VUVPRXVXTi9BMkd5ZFMvMzhMbW1FYWtHd0NvT2V5V2lPbjZMd3Vi?= =?utf-8?B?a01ueEIwalJrNmhBNVM0VGdFV25PWm1kb1VaaHJKem5KK0lCSlN3S3FraFlC?= =?utf-8?B?QW9DQ2NsUksvSDlhK25mbUEvQXdvOWw5SzU5czlKdi93M2JvdUM0MnFkYXZB?= =?utf-8?B?WENqZGU2Z0dsNDdoKzFTRFE2WlJiSGF3anJ4T0ZmeGlnRnRnU2pRbTBlUnhO?= =?utf-8?B?MUlKNllXbmZpQzMxSG53M2NoUkJKSytHNWRTZ1IvWi9GOXZQdXdzT1pYZU5F?= =?utf-8?B?K2R3dDBUMm9YbVVEeFpGUGFxaC9BekZWREk5ZERBdzZvQ0UrWUNocHlOZFZD?= =?utf-8?B?UW15YVlIU2grSDdFU3ZEMGVtSVlXL2ovZHZOckcvditZbG9RUWRCYjRFSUpj?= =?utf-8?B?NzUvR0k3UUVJd2VpRjZyZWxDSTVxbW5Kc3c0NHc1aTBXa05DQjRNY25rWVJJ?= =?utf-8?B?RUNoeGJCd21VNTg0NVBMK1lXZkJOa2FuNnN1cVBsWDJZdWRFUzh4cUxYd0JC?= =?utf-8?B?aTZ2d1NSOVpDQ3BpTldFQlR0TENoMklEcUg4amw4N2lSK0gwS1dVVjlPRTN6?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b331b5b-78c6-4104-513e-08da9592d173 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:18:24.0449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: stZrk471581YwifY2g9dcwqO99uAunrggXI/wkYMSbIegNRjiqn+5b6c3dzcv7jk1Cz9PVboz1eeNezWJeNjmNB/PCQl8+7daaAOoi9t678= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6080 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 13, 2022 at 12:08:48PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Monday, September 12, 2022 5:15 PM > > To: Owen Hilyard > > Cc: Juraj Linkeš ; thomas@monjalon.net; > > david.marchand@redhat.com; ronan.randles@intel.com; > > Honnappa.Nagarahalli@arm.com; lijuan.tu@intel.com; dev@dpdk.org > > Subject: Re: [PATCH v4 1/9] dts: add project tools config > > > > On Mon, Sep 12, 2022 at 10:06:03AM -0400, Owen Hilyard wrote: > > > > E203 - whitespace before ‘,’, ‘;’, or ‘:’ > > > > E266 - too many leading ‘#’ for block comment > > > > E501 - line too long > > > > E731 - do not assign a lambda expression, use a def > > > > C0111 - Missing %s docstring > > > > F0401 - Unable to import %s > > > E203, E266 and E501 were disabled due to pylama fighting with the > > > autoformatters, so I decided to let the autoformatters win. > > > > That sounds strange. Is there no way to configure the auto-formatters to avoid > > these issues? E203 I think we definitely should look to re-enable in DTS. > > > > > I think > > > that C0111 was suppressed because this set of suppressions was from > > > mainline DTS and that has a lot of functions without > > > documentation. > > > > Is this something we can fix as we go, migrating to DPDK main tree? > > > > > F0401 is disabled due to dependencies on TRex vendored > > > python libraries, since those will not be possible to import inside of > > > the container. > > > > That seems fair enough to keep disabled. > > > > > I don't remember why E731 is set, but it may be due to > > > the rte flow rule generator I wrote for mainline DTS, which makes use > > > of lambdas extensively to enable lazy evaluation, so that DTS doesn't > > > need to keep ~2 billion rules in memory. > > > > That sounds reasonable too. > > > > Can we perhaps target getting from 6 disabled warnings to 2 or 3 at most? > > > > Other opinions? > > > > We don't actually need the ignorelist at this point - I've removed the ignorelist, fixed a few issues and the tools don't report any problems. I'd like to start here and disable checks (either globally or in code where it's needed) when we actually need them (in a future patch). > Great idea. Thanks.