From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F41EFA00C5; Wed, 14 Sep 2022 15:11:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A72F44021D; Wed, 14 Sep 2022 15:11:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3FAF040156 for ; Wed, 14 Sep 2022 15:11:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663161088; x=1694697088; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=iCylczfpFqIGFOsaZ7m/K4k4Vmo+F9N5q1jSJa1XnmU=; b=gqStwJ9T/qptZoY538Qnwei/QAoRhSFYVkruW0GPN9ILL/zSuhnkNRPm HVfB3zAuZnHkMIR/66gLQNCz5xfKi9GaCUKv8RI+zKQmE1DR36MRUgFNb sU3Wko8TF5I1CRL2UKVUiwNAuLRwMm3XVMmuuJXBSB4LAC9e13Brj1m6A ZnUTe/OT2ohg8IrDA6FTIYuWy0DP3PW3a4sN4ZL3AKAMMst7hEHKOI87I z4Yg466S6JhIioydAl4+rkNFwga/PB/KyLeG35mlPXZqEpRvJreGVyzJW ln6bucu9k53eaXGuWU0xuMHsQQPFzYJ/wXDNzED4HavoaO/Fp5ntwuqPv A==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="298423483" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="298423483" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 06:11:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="647387177" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 14 Sep 2022 06:11:27 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 06:11:26 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 06:11:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 14 Sep 2022 06:11:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 14 Sep 2022 06:11:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arwrcsVXD3BryLrdLalBzzC9PO75rLwiBLgobql/CRR2M7jfmw1uWrldeG3DeUo5t46TDuG+8om2UAYTCJjW8nLyWhHYc+8chn40udfeIe1zdHUXzLCKgHfghSx6v8Tc+SI3jyCTJR872eqgcM3SUNelzNBCL467WgHstmPsvfeQMaxHE1g8waNgpzRU/DbmaPvXXzuXpUjsKQiJXNp+j8sf79JDl6ohbql3fBVrFpJxZfnYi6gb8FEc1Bi6mDFzn/fLSjtkdlU1uICTcpd7Iu629TrWO0c0nOM1S7DQQnpqsa45vveDiTJgospYcmUQ4ZZHmjj+jmL/LogKOJgy4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VSJ6Y3yvyPQFVMMCVPHASQ7Emn2QH6JlbNNeAiua0oM=; b=PNxsGCOr4+oLjjhgRDLSMn300rhf5x26g2DxsJ9VFUXemRLBDb+DQzaKuzSIxqw1xOS3RgoG5rFS+jIcQ/G7NN3XFYYpBJVg2kiX66XIrKeE+Q9kbY4hkhapXVK6AlsK76q06UO+4V8R4sQe9+PowSsbO2rknMho0SJjawTSsHics+AhlmMEPtgoukTvogcy1EEzBpp/MBvLXwz2eNlZGNFMYA+/6tiacdBkaaUlyoa7TS4V5pmHhLLUStwdl0fw7x9oDoZAY2Yuit2lur8vEmB1M2W1EiscYqoTPFqfV6ScDoD33ymuL8NZz0ElxAjSogPbAwD5rG6QBibZ9dhNsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CY5PR11MB6414.namprd11.prod.outlook.com (2603:10b6:930:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 13:11:24 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 13:11:23 +0000 Date: Wed, 14 Sep 2022 14:11:12 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: Thomas Monjalon , Honnappa Nagarahalli , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <2599934.X9hSmTKtgW@thomas> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0036.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::23) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|CY5PR11MB6414:EE_ X-MS-Office365-Filtering-Correlation-Id: 3af178a8-b33f-4915-c30a-08da96529f9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rih83LaDlEywExJAxP6pdn8X8E5kcaWU5pol5EhrU1SL1/y9C3eFqfXPdFNfsjDL+68VeZh7QwIkx6xJehz5YvtWo7zdqdftC5J0PDk2a98n1dGG8owyPc7VRLC5SMwhCalFMQR6vazrdyro2qUT9dujHyJoZgtW8IvTnXA7UBOr4423zyJRJswIuIPzRF3W/TmiLnZZtjFejXAiw6cEz+ngVlp4KlV8hJbjp5855n16A6sKp/LenjmwIncIe/gF3ih6JcKAM4DsF+If9p+wDkmV3ADwBn/JsHZYwiFsB6vzfVkE0C+TsABKCz8s/iVLTO2UYpSrJZdBbi6dZmnHOqieE+qhzmeZqKfVRYmDcOMjsN/ucuG20m0Vy1CVigK7l00TMY0a24+lK3Xkfaa3uLLuZ3Hz7XttEYCWusUvNu3N18UcNYgAad5+YesBtHOMZzOSgTdqtbbtA8KeVTRS3v++IzQlZGxNtyC345aKm2qsLWvKp94B0TEW1IdxWZoZ9QIWAsrEMWaYqC78CYLWgkrTKJv2+1N+xzpnUGzLSm7NzezVm82Tq8me6hsJfZkvFbGLGYED1G7uvtN/00e1souCFeaILWfsmYL4oYv3sZmwVtXEk+IXYLht+W1MKYDq1t2Yma2QE6l+zPRzG2IUnYwpPPmX1aVRfjIpIEltQw2XSmLGjrxuThjL7fK2YZsVm58RkuYjRD29mciVH4bzLGLZNhfwER7dglXmhb+9FX4f0Cm2HJq5S3Is/a92X8mG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199015)(66556008)(83380400001)(6916009)(316002)(41300700001)(44832011)(478600001)(82960400001)(8936002)(6486002)(66946007)(66476007)(4326008)(8676002)(6666004)(53546011)(26005)(6506007)(2906002)(5660300002)(186003)(38100700002)(6512007)(86362001)(966005)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmNlSmQ3S3RFdzJ4dWNDTE9hNjdNUWUvUWJWZlRQcWtmTTBidUYxZGJXdTFx?= =?utf-8?B?V0dSMWVGOVVMdEhuSWsvV2JMRTZNQWtPMWlVbUhoMTBRTzc0TXRkWVRmWHNF?= =?utf-8?B?SGxXN0ZDdEdiakpvaHF4WE15YlZ2UCtvZUtiSkR3ZTMwSU1oMFErTkRGOHds?= =?utf-8?B?RXRiOVh6Mkh6ZEVVVDJRZ29NMnhIbWN3dTV6RTFDa0EydzUvTVFKWHJ6d1BJ?= =?utf-8?B?djBydUJHQnNWZXRXSXNJYXk5dFExR0laMTNRNlFNcEFTSkt1UEVWYlZmQWNY?= =?utf-8?B?b0Zja2ZiajU4dFFYbWREVE56TC9JcE5uZnlINGQxSG9ZY29vanJpZFE4N0Rx?= =?utf-8?B?UmwvTjViSlQyUUJUQWpDUDVSd1ZrRGhVeHBnL3lsZzN3OTJOajl1TUhpMG5z?= =?utf-8?B?WkhVUklQTlp1b2tVcHgvazRsMkFVK3dTZWRmM0Z5NzROMlRFTE1JZlNyY3RO?= =?utf-8?B?N1U5TFA4REljSHU2THpKQmg2d0FCcVJyMDNsSHorZk10RG42bGZ6YVBYZlNZ?= =?utf-8?B?Qm1mdHVjZU8wcWFvdVlHSEFNc2FpMjRPUSszaHlrUGZrbDRCcWtQVFZVd1pj?= =?utf-8?B?S0srdGNmT1E4RVBiQ3lFTWpvK0p0ZlFWWGR2cldMWFlOT2habUw3Z3NyeHFa?= =?utf-8?B?VXZIUUd6R2J0bTc2Wk5ENStHUmFNSXhyaDZ4eHROenZRcTU4VkdBOWVucU5D?= =?utf-8?B?VlllWGRwY055alhYcUFVWjkvN3V5emx5dUxFbmxmUGNJNGdLRStOQmRkSzZ5?= =?utf-8?B?eXRRbUNOV2pXRXNINnpuTnVURWhROTFWLytJU3BqWGVqUjFNZjFQaWl5a3J1?= =?utf-8?B?RldZejFPc084NmNUcFVVZ0EzY2lnSHprLzB2T2dScklEdzdZRVRFRDNhbUFO?= =?utf-8?B?NFhLKzZNUmJKZWpFN0pKZExWVFNmNExQVTU1eXljeDFLSnRwUEluQTNoRDFB?= =?utf-8?B?bm9BQU80STY3SUFyQnFGQ3NRZ0pqZ3BDLzMwdElqcjhGdnVPN1pIL3p2a1Ir?= =?utf-8?B?NGF1VU1QV1diYm9Ed04rU3FWSmFlRnFkTEhpUjRpWUZpRmxOL1E4amJITnNM?= =?utf-8?B?ZkFPVGlYbUpjdXVGaGtyS1pUN0pPMGg4SDMrczdpM3BQK1IwRUFkZmtMRVdH?= =?utf-8?B?M09nYk93dTJ0TmpvVHNmY1JIZTdDVURRa3RIOFBEYS84SmErMEN2YnNBTXVT?= =?utf-8?B?bXhlMGdJRmRob1ZBZFdYZFZhN1VUMkRsa0ZUaUo1NnIwR0diU1p5VW9acm5i?= =?utf-8?B?Wksrb3pzRS9temR2VFBzRUlCVURoU1NTVW52dFd2bGp5MmtPVzE5UXkxRWZj?= =?utf-8?B?NUVNR0JyaURqMjhSd2VFQi94c09GRnZWNjkvbVlEY0FoS0VxbEhJYlBSVWNr?= =?utf-8?B?aHRScmF3Umo4dklVSG56YXFsSk9uYmpBSjU3aXQyeXdvQk1tNU1sQmpna2xo?= =?utf-8?B?SmttVUo4SlN2ZWtyZytJOE0rN1BhamdxS3lxcnBMWkpmTjZLc1pqV1k5L0pi?= =?utf-8?B?ME4xTlZtbzRIUm0zNHZ4NDlVSCtEaFFWdFZTNWR6T0l6MWMzenBZaU9UNzJG?= =?utf-8?B?R2lzdUwrdUI2NUlvaG16N3pOVHp4ZWh4REU2bjBQOXdsUzhNYW5pZ0tZalNz?= =?utf-8?B?NVAvRktYalVqTkh0M2dUU09SVzRIRTZoMlpNMjRXU0JzUHFOaG41YnVWcDk5?= =?utf-8?B?NjR5YkJhV0RUNjY2UU5JR1N6RmNOaElhRWhBTzZBRFczVmxWdXRmbGNpbzJM?= =?utf-8?B?VGYrcG1IenozeExvejkyWExabFhiZW9zVHNRV3RJaEtZYW05azRUS3dSOXNK?= =?utf-8?B?U3U3QkZBc3U3empsVmtIS2s5ZGYwVDROMXZ4WmVQajN5TmE0cFhrSTk4dHh1?= =?utf-8?B?Q2E2VFhKZHF4eU8rWmpBT1p1T245V3JlU1BaR2YxVFZzVDduaFRWclA4bnBi?= =?utf-8?B?Q2cxUkZ6U09PV0ZZeThzUStTZ2hjcDFDQXNFczFxMStVeWh5ZWxrQWlCRUhR?= =?utf-8?B?ZWpiUWVqaWdWV2FqeUlhQWdpSzl6Z0F2NWhFM2RraXpBWExZZGRRR2tBVmNQ?= =?utf-8?B?aGRPR08ySy9MNFo4RHl4Ym81QnZWRFJjZzlKRmVvb0FpR1RYL3l0bTlnMERk?= =?utf-8?B?TXl1bVZKSjltZ0JQM0c3NXoxQ0Z3ZG5HekhGMXlYY3I2YXdaaEtxZlVtb3Y3?= =?utf-8?Q?fsHpiTLJuvmuSL4h1Zdnu94=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3af178a8-b33f-4915-c30a-08da96529f9f X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 13:11:23.8690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8UCj4oYGpv9rBUgZvKBX3dZJUqhFj8YKHk/MW2nqU6r2gqbFhEz+l342FaJ5QGtFsg0utqjUPBxeIdlyqB4CVhnBfcxLxSglECtVHXptvoI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6414 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 14, 2022 at 12:55:21PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- From: Thomas Monjalon > > Sent: Wednesday, September 14, 2022 11:37 AM To: Juraj Linkeš > > ; Bruce Richardson > > ; Honnappa Nagarahalli > > Cc: david.marchand@redhat.com; > > ronan.randles@intel.com; ohilyard@iol.unh.edu; lijuan.tu@intel.com; > > dev@dpdk.org Subject: Re: [PATCH v4 1/9] dts: add project tools config > > > > 13/09/2022 21:19, Honnappa Nagarahalli: > > > > > > > > --- /dev/null +++ b/dts/.editorconfig @@ -0,0 +1,7 @@ +# > > > > > > > > SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > > > > > +PANTHEON.tech s.r.o. +# See https://editorconfig.org/ for > > > > > > > > syntax reference. +# + +[*.py] +max_line_length = 88 > > > > > > > > > > > > > > It seems strange to have two different editorconfig settings > > > > > > > in DPDK. Is there a reason that: a) we can't use 79, the > > > > > > > current DPDK default and recommended length > > by > > > > > > > pycodestyle? Or alternatively: b) change all of DPDK to > > > > > > > use the 88 setting? > > > > > > > > > > > > > > Also, 88 seems an unusual number. How was it chosen/arrived > > > > > > > at? > > > > > > > > > > > > > > > > > > > The commit message contains a link to Black's documentation > > > > > > where they > > > > > explain it: > > > > > > https://black.readthedocs.io/en/stable/the_black_code_style/curr > > > > > > ent_ st yle.html#line-length > > > > > > > > > > > > Let me know what you think about it. I think it's reasonable. > > > > > > I'll move the > > > > > config to the top level .editorconfig file. > > > > > > > > > > > > > > > > I have no objection to moving this to the top level, but others > > > > > may like to keep our python style as standard. Realistically I > > > > > see three > > choices here: > > > > > > > > > > 1. Force DTS to conform to existing DPDK python style of 79 > > > > > characters 2. Allow DTS to use 88 chars but the rest of DPDK to > > > > > keep with 79 chars 3. Allow all of DPDK to use 88 chars. > > > > > > > > > > Of the 3, I like relaxing the 79/80 char limit so #3 seems best > > > > > to me as you suggest. However, I'd wait a few days for a > > > > > desenting opinion before I'd do a new patchset revision. :-) > > > +1 for option #3, it seems reasonable > > > > In .editorconfig, we have this default: max_line_length = 100 It is > > also documented in our guide. > > > > For Python we have this exception: [*.py] indent_style = space > > indent_size = 4 max_line_length = 79 > > > > I'm OK to increase it to 88 as it does not exceed the default. In any > > case, it should be documented in the style guide. > > > > Where is the best place to document it? I'm thinking of adding a DTS > Coding Style into contributor's guidelines, right after DPDK Coding > Style. Or do we want to have separate DTS docs? +1 for having it in the existing contributors doc. We want people to submit code + DTS tests at the same time, so having the contribution docs combined will help with this. It also should help us to try and align the two coding styles for python. In future, we should perhaps update DPDK python code to align to DTS coding style rather than having two styles in the one repo. /Bruce