From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DBBAA0543; Thu, 22 Sep 2022 15:38:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D7D340156; Thu, 22 Sep 2022 15:38:48 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6E196400D7 for ; Thu, 22 Sep 2022 15:38:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663853926; x=1695389926; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=nma0VZTAW/wl3JgnlRjz3x1w86NgQjc7CaE7N9ZcZeE=; b=AkfmPs6ImSJg+lvrOORFc4pLUSl8fB1hBOH59LXDaw9U5jZOVs2pREh2 OHVE49RmqU3hkwbLh8KBc+0Y4MmqdZ+ImmlSuZpHabzxr1Hx+MKBTLsG5 FCfFgZxucSbdAfEJReTMibHvAL0tCgmDc6io5FkbDbWlmbGtex/HkSpjB lS7IAcanzMERS+How1VotqTIX/QX8B5c00HkqqsUDVDIvvzEZSY0rs/VX N61A4d3m4D0ppugr8+pbV9d+t+KxwV39ui+PYup4JJhiAcQ3pmomznNMY Z2R55dsszVZgiGL6Kmau8owCYldqcZi1GY/PT25OiA4zRQ3NToeNDfRbL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="362064722" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="362064722" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 06:38:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="652969797" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 22 Sep 2022 06:38:45 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 06:38:44 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 06:38:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 22 Sep 2022 06:38:44 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 22 Sep 2022 06:38:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UV3yjiSGfNE/ml5LHj03tm6T04L8N8THk6lvyNzDLvl+ZVkSNMWXsJ2vxXM7L/+Pm1FN4V23z2Gvkq8GQFuV8SmXV/GzMfiQEhGxuNrJRI905p7oZUNmpHuTMy6xbsfbFxYHTahLEevm5RaeQGu+I5EvMLTgwUFjW2KjANLa1R04HisZCyiowHg69HSOsSuhXtVdShzW8r0FGfLT7eESL3IJq/tLlmGeZ+dWGsYBOQlCDVP5/wFomi/c2aqEOFPb3z4B3im5wnV2E/7eT6fmOx/Y7PfDqyAPdicCQN6DvBcW4ekotyhO2YbGn5P+m6US01HnSIAs6lvPkb2+4bf3Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v6RkYyQC1505iEs2ex5Lqk750mG2DxrMlKNymz3yO10=; b=hf2XSe1fw/j/GGpapVBMWDvjvDjRLvN8MIUo/1CpvQ9cPDvOLtIpIGlOVX8pois3Ii11XQZ8HYtXBHTlWlQvGrRRc98Wbw4oNU2GGHrQM0L2rhzQG7q9hK5nWUPWOu0ucwqjaBecb6awBQglOW96upphGX/QxCYS7QQYcPNxQpbnrFbcqG57Dq3amVveKCqkSjIOaKompEspqya6nEqFljxgGn42zAwFxvQqMf488Zas6tG6xNIF13x9MvH6XP7RrZ512Axq0r82lqLa3u0O/Xmab+WJoP32Xo7KhAEsHiWvLrufVRuJLPfR0FN2FP7Evu8zuXrowKIfLBNZed7wlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by MN2PR11MB4679.namprd11.prod.outlook.com (2603:10b6:208:26b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 13:38:43 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5654.017; Thu, 22 Sep 2022 13:38:42 +0000 Date: Thu, 22 Sep 2022 14:38:36 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , Subject: Re: [PATCH v3] eal: Pointer alignment check improvements Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D8734D@smartserver.smartshare.dk> <20220922132730.5178-1-mb@smartsharesystems.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220922132730.5178-1-mb@smartsharesystems.com> X-ClientProxiedBy: LO4P123CA0443.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::16) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|MN2PR11MB4679:EE_ X-MS-Office365-Filtering-Correlation-Id: 73b81b01-45fd-418f-2ad1-08da9c9fc3f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KcmWtaUZgNRklFxf1PWNAWJTb3KWnglmZfEtEbxRJAQojZRh3f7Is4ghLo6TfK3K0G0yZSK9w4WG+uaow0OHVx9lCtCBtnT/8C0d/V2DiB9SN31C8e3tl6PHHpb3gdiMo7/6l2p8+T5f/iJeeZXFHdWHZ7xv0XwABMtRJ9ERVrM9JSzhzBNhoSG8/fZzRKON8PYI/CEFhBzeFBk3d4ckdaWAaoZXF+LW6p2mg7fuTgOSVRqX6vSUmt4ZsmQI+23BZUtfxNxBepcoCPfdJycd6Yz+OOsjgSdCHS4RplKT7gLr6ilkhqQMieLrnlKtA/7yj0y2VFJU7w5mDpHHL3w/pkJYknxgYQ2Pn/fOaQJugP8OzSBnM+Bpe0N1MvHQWnvjo1OCNHwDxL3ZzD9SGvuEM7ULvb04yRgrQ5cJ+MbY8xveC/4RA4GkD2GwSbZyRu6FV2Wc/ROrFs8CJZG9Kc7OCpSOinsP97ysAVcgDUSQ1QAGd9nrQ9E3CqiR99k1GCa0hU9G+b8opPxJ8ucl+oz6OVk2D3zDDAzrgJyGmrrQI1ytAdqvKv8g8wUlzreqy2xo9CT0d0P+OxITj8WQZRH5+vgasZCbsu5Mx8+WlUf8A8OjSas8GjpyzDkwiMFZuwvoVLYtS0IFuEn17SOguSESeglkyTinfYpJT+DdENKVBrkEVkyq3Ey6jJ+7Ubirk0pze5LDz5YZ/pE1tB4DcXrnVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199015)(41300700001)(186003)(83380400001)(6506007)(8936002)(316002)(6486002)(86362001)(6916009)(66946007)(82960400001)(66476007)(38100700002)(478600001)(8676002)(66556008)(6666004)(26005)(4326008)(4744005)(6512007)(2906002)(66574015)(44832011)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?HhndnmoLvXhOcxv1ztIC1C2Iv24q1hcnRQ3xCaVgQUz3N/9QuWrMd/B+dK?= =?iso-8859-1?Q?bwp7lI8FFWhXmAqWh8LAFIXYMhoXRZPfdNgyVD7nlZpknZ/OblDNF1sSUK?= =?iso-8859-1?Q?tHPME59ku+kx/d+UNicfOkBtEcojQpvhrm5ARq5rzSbznkpK7jMeIslGIL?= =?iso-8859-1?Q?XAFNjlT3MvuIwwaykTu/C+f8C8v0nLI5s29Hh8QjJuewvYiIakKDGMzKRM?= =?iso-8859-1?Q?tMUUBfZ1kZFIC444OFznQqoQaP2Bk7SQm6qNoWAmdom/UDPLxUb7NHKWPL?= =?iso-8859-1?Q?fMYFsvKLxIFE41SfsFA8uicLgkLNM1Rz2pcayRAIWTyboSiEfr3wtLQs3C?= =?iso-8859-1?Q?rg0jmxVc/fK/MA62N8NOTuRFQsuCu1iy1uWcPgZ5qMPDyGF+aj99uAnCBw?= =?iso-8859-1?Q?JlLz21W0EcGyREByoEL6ojdTEmCdtznzsDPwjpsre1QsvWrJEtgYHefgYC?= =?iso-8859-1?Q?1Zij/ATMsmmoI43SBTumpFKrSkiiCwnxfa1UXl0BqK901rx5kjaOhodGcm?= =?iso-8859-1?Q?kmp2aj6Jhpjb/guLecLgci/Zc4DuhgOOFBeOFpI8tEcPIoBlFXtIqzmv9+?= =?iso-8859-1?Q?wFiB0kyJQ9mc6LIMFv+gLdtn/zzbT/hbX5EmNt9dQuzmSv558lkodF1B22?= =?iso-8859-1?Q?CdJ0oDuGLuz5geRjoaHTDex90rY4z4HSQ1F9mP2sONSExHX6jGvzBb5SdO?= =?iso-8859-1?Q?DG3+G/PpZrSOVGIXgOu+yjQLzpysj+N4k4kUkO3RD1gxEISpSastuMBmdD?= =?iso-8859-1?Q?0yvkMwFtWDCxM6GDj6uRlGGA/ZZNmSyrP09+eGxpthgT4QFotlUxzeGrfw?= =?iso-8859-1?Q?OWuDPHQjt86wcrzaGS9m2dDS+90owE1YKOZBX8YBjtCsiiAk5gns3ghl/L?= =?iso-8859-1?Q?X/k3HIX3Wd4rEXWt0MhiZJxADkBCLkjagT6Ht9ZFyxTNMvkfoetlzsfqoD?= =?iso-8859-1?Q?Ew/Blb/rdLnKv5jP0AK8FI/+Q/HYq63ArZNh1YRtM+qeO0Wea7V70tl8U9?= =?iso-8859-1?Q?Tjmm98/FslsPj5I9q9qiRpUUMgvCVpw7++MSMerGahBxUUMttez5hJadFA?= =?iso-8859-1?Q?wcmzvqAcTAjpWxTb3qHm8PaYwCT/S6Og+/yMmGJcU3AawdMPxQ8/U2pk6N?= =?iso-8859-1?Q?EkoJeuTBg0t1Au32O0jd4/jAT5/VftfmuqWXPXhE9yOyHA1hbLvMjzrOIN?= =?iso-8859-1?Q?V1fSYPhhzkIzHtPUQaah+x6G+Du84zYP8TEq31r1X958yA6HsdGZbGm5Ax?= =?iso-8859-1?Q?chzDEOvovuVXOCM4ZKFlwUWTj15B9/nJ0ZoQsZwXS3+PSNm2P7NW4P/Ibw?= =?iso-8859-1?Q?L7zbWh4VQdhhkBhzC3fOOdipnP967Qp7rw9MdONbEyOfm1HDOmQESY27cy?= =?iso-8859-1?Q?v09diHzsDUJ2EL+EuZuMg4YgLkChYEN2IHMV6LtRpgmJL+pDnXKgTFZcFV?= =?iso-8859-1?Q?cfrokhkHoLnVJj0OMadSH1kjAqWwOfFwTclM/+DhL6Yle0fAp95ykfw/Ks?= =?iso-8859-1?Q?M9yM1zgIkEtScst4KL2XN+MhZ7UiQC8Je2g7zG1FXpF4IMPr225J7uxryw?= =?iso-8859-1?Q?FBJ95ToZoiWmxqk3YFB7GBMyUSUxAjEVUoiKptjeb2a5OoZvIHa7MYaXIN?= =?iso-8859-1?Q?NO7XaJBLuXokylIUgxHlO6q65M+uREzwFTB5PMK48Q15lXVd12z23z5liI?= =?iso-8859-1?Q?WtGQBBO6AAzhZZN3IHA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 73b81b01-45fd-418f-2ad1-08da9c9fc3f1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:38:42.8691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3TgDosIDU03ywADeDJr/25r0MnobxU1A+z27KXQvpDIxMt4E+4Tv05DRDOgnf4BMCGWcMuEGksnZX9GuWkZxU2mp/cR2JqH/Di4bAloY2Dk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4679 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 22, 2022 at 03:27:30PM +0200, Morten Brørup wrote: > Checking a const pointer for alignment would emit a warning about the > const qualifier being discarded. > > No need to calculate the aligned pointer; just check the last bits of the > pointer. > > v3: > - Make the uintptr_t const to avoid potential future warnings. (Bruce) > v2: > - Remove compiler attribute ((const)) from function; > it was a coding style issue. > > Signed-off-by: Morten Brørup Acked-by: Bruce Richardson Or perhaps it should be "Const-acked-by: ... " :-)