From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C56A00C4; Wed, 28 Sep 2022 15:07:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0C754113D; Wed, 28 Sep 2022 15:07:50 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id EE5BF4113C for ; Wed, 28 Sep 2022 15:07:48 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso1205629wma.1 for ; Wed, 28 Sep 2022 06:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=tbueilvzgWqPxgU+FlNBJb9nppCPuZkIO5ZRh4h1Gz8=; b=CcO6an+zkCTb2ArKXJiwv2xfSnlzCGvhlNf3T0zEmeW0/jiP0PA1fmBkHD7d7jRveO jEG9RTq0u6cEqBE4FmhuqNoKyB/xlXzlEsxKt2gIC2BsRENi2oZzwmEqmjPl+LQW5i1n pjbv6W/sOGLQiJiQkRlr3s3/bpXBFa/0OuArbyhAyYypOLT1Aa3KkQBb3WT+WdCJnq/d qPflQmJZYJPll3SNUUGhv+Q28BJrUjk73brU7nzIkNRGQ3EVB46swh/b/VTHzSqpjOEd kPxcrHBTUhnsrHVbrwGRYISnS73PmoVwGtLFyJiXONS+nhSvjG62Pcf5rh9pOefXQqZE xmGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=tbueilvzgWqPxgU+FlNBJb9nppCPuZkIO5ZRh4h1Gz8=; b=yP19eEcOX9Z9GZvIYftSZNjK1zporXjLTYoa3VDBRRRG17Ua5AjtKtLdLBJCAxIEvl q+rrI10KhH8o+MtVIzdB6+RBhOuX/oICMbMcJrZTc3ZR0ob9nvYYKU+yT9twRj4Xftqo OIr71bE3fRmEn+nULL6CCQ8NQKqdl4Raq4U2qa5ByF8cqTZEpEb+Er9BVBP4VUdrdZx5 oK0PCfLRBaWQxPL79MxXaSMoaYhzW8QGLfddW5qqQa6FA4XROzrD248ayvPwwQuQjvfX jlV1OE/lFEPkWyJn1S7lHKmY6pKjSY/H3OQyAAykoNvgs47SkBadptOLt+vWrlaLqXKy Au7w== X-Gm-Message-State: ACrzQf3PTmY6kswxAS+EJlp1LUPlysNAAg413iDyvvNSrb935vGW62qK MfLhLKFRK42DqD7uTb5itKgV5Q== X-Google-Smtp-Source: AMsMyM4SRdt+ZgFiAsGlct5oKZz7oH9VI8GzzgPDbzB16DWrBhS9TnaA8sR3eP0/GT7U/FVFbj9pvw== X-Received: by 2002:a05:600c:114f:b0:3b4:9a0a:6204 with SMTP id z15-20020a05600c114f00b003b49a0a6204mr6746829wmz.132.1664370468681; Wed, 28 Sep 2022 06:07:48 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id h9-20020a1c2109000000b003b4fac020c8sm1650223wmh.16.2022.09.28.06.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 06:07:47 -0700 (PDT) Date: Wed, 28 Sep 2022 15:07:46 +0200 From: Olivier Matz To: Jerin Jacob Cc: Thomas Monjalon , Bruce Richardson , Jerin Jacob , skori@marvell.com, Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, david.marchand@redhat.com, orika@nvidia.com Subject: Re: [PATCH v2 1/1] ethdev: support congestion management Message-ID: References: <20220713130340.2886839-1-jerinj@marvell.com> <21900891.hxa6pUQ8Du@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 28, 2022 at 05:53:06PM +0530, Jerin Jacob wrote: > On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon wrote: > > > > 28/09/2022 13:14, Jerin Jacob: > > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > > > wrote: > > > > > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > > > > > ++ > > > > > > > > > > I feel EAL is not the right place for CMAN definitions. > > > > > > > > > > After a discussion with Jerin, I understand we could use the same > > > > > definitions in other API classes, not only ethdev. However I think this > > > > > .h file should be better hosted in lib/ethdev/ with its own namespace > > > > > rte_cman. Then other libs could include this rte_cman.h without having a > > > > > strong dependency on ethdev. > > > > > > > > > > Deal? > > > > > > > > > Would rte_net also be an option? Alternatively, is this related to the work > > > > > > Looks like the net is a good option. Since it is just a header file > > > any place would be OK. > > > > > > + @Olivier Matz > > > > > > Any objections to keeping rte_cman.h to lib/net? > > > > lib/net/ is supposed to be standardized packet headers definitions. > > Since it had lib/net/net_crc.h, I thought it is OK to keep it in lib/net. > No strong opinion. I will keep it as lib/ethdev/rte_cman.h then. lib/ethdev/rte_cman.h looks better to me too.