From: Bruce Richardson <bruce.richardson@intel.com>
To: Anoob Joseph <anoobj@marvell.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
Date: Thu, 29 Sep 2022 09:27:54 +0100 [thread overview]
Message-ID: <YzVXCvwnHniKylFe@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <PH0PR18MB467298B3726919AAFE4B3770DF579@PH0PR18MB4672.namprd18.prod.outlook.com>
On Thu, Sep 29, 2022 at 03:25:44AM +0000, Anoob Joseph wrote:
> Hi Stephen,
>
> Please see inline.
>
> Thanks,
> Anoob
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, September 29, 2022 3:51 AM
> > To: Anoob Joseph <anoobj@marvell.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Jerin Jacob
> > Kollanukkaran <jerinj@marvell.com>; dev@dpdk.org;
> > sean.morrissey@intel.com
> > Subject: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > On Mon, 29 Aug 2022 22:21:51 +0530
> > Anoob Joseph <anoobj@marvell.com> wrote:
> >
> > > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same
> > > by including the required header when RTE_LOG_DP_LEVEL is set to
> > > RTE_LOG_DEBUG.
> > >
> > > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> > > 678 | "%s: status: least acked token = %" PRIu64,
> > > | ^~~~~~
> > >
> > > Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> > > Cc: sean.morrissey@intel.com
> > >
> > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > ---
> > > lib/rcu/rte_rcu_qsbr.h | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> > > d81bf5e8db..b0f1720ca1 100644
> > > --- a/lib/rcu/rte_rcu_qsbr.h
> > > +++ b/lib/rcu/rte_rcu_qsbr.h
> > > @@ -37,6 +37,10 @@ extern "C" {
> > > #include <rte_atomic.h>
> > > #include <rte_ring.h>
> > >
> > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h>
> > #endif
> > > +
> > > extern int rt
> >
> > This is not the best way to fix this.
> > Just always include the header file.
> > Having it conditional can lead to more problems
>
> [Anoob] The header include is only required when RTE_LOG_DP_LEVEL is lower than RTE_LOG_DEBUG. I'm not sure how the tool runs, but it may still flag this include as an unnecessary include. But I can make the change if the tool can ignore this case.
>
I think the number of build configurations needing testing has made the
automatic removal of header includes too problematic to use further.
Therefore, I think either way - with or without the #if - is probably fine.
/Bruce
next prev parent reply other threads:[~2022-09-29 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 16:51 Anoob Joseph
2022-08-29 16:55 ` Honnappa Nagarahalli
2022-08-30 8:38 ` Morrissey, Sean
2022-08-30 13:17 ` Honnappa Nagarahalli
2022-09-28 22:04 ` Honnappa Nagarahalli
2022-09-28 22:21 ` Stephen Hemminger
2022-09-29 3:25 ` [EXT] " Anoob Joseph
2022-09-29 8:27 ` Bruce Richardson [this message]
2022-09-29 10:27 ` [PATCH v2] " Anoob Joseph
2022-10-06 10:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzVXCvwnHniKylFe@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).