From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CD1FA00C4; Thu, 29 Sep 2022 10:28:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 515E84113C; Thu, 29 Sep 2022 10:28:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 66D184113C for ; Thu, 29 Sep 2022 10:28:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664440091; x=1695976091; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VwemeQid8QgEbY4zkOXvyUQYa6al4yqpGZO1JkWf85o=; b=gQd8WYIe9ZIPR9c//X9yOCJNW/SpubpWOebq+xmHxHVUkK4EN5rAQKZA Ax33G+ayMHAdQXainLBI8Cr+SihfGr3YDjWcce6XuIUaIzyv2XKoMDDzE v93wTNLlea397VZML3gTknsJ6mHs5HLyb9+OtbmaGxJOKFqJnaqI7vegS sxHjfQiZuUQns1wToHBrO5QDQJx5I572kZgscfhMlmbR9WZ1RejtF2MF8 r8UTUQimue5EQjbnr/fF1b0WBDCP2dWr3S7gVO5VM7gxUFNIRbMxwtUGv oECuiLahwFQP6qjcivYBrffVIQgs1GHY3HQ+NaVCIY1XP+rHkjcEiGu9H A==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="281545905" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="281545905" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 01:28:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="653022074" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="653022074" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 29 Sep 2022 01:28:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 01:28:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 29 Sep 2022 01:28:09 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 29 Sep 2022 01:28:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gdWJVVvkMypOCclc4aq3PkJ8sGJEd55pr1sy2r5JPIy0iMu/L/WnQDuRcw8u9JqtBLXrWBC7trEj/XT5E8tx2kN4JhmREhST3jAAurY6LHlENqdUZc2z+jPrtZOqYUln6ybV4FI6WVy0nxRq1JhSKdJRX7EzdvP/ERTxYh13sS2XkeCa7WctahrUyIqTfsuOHDUXtgm7YXy6/xS5ewbLuuzHARMyqdljLT8wUg/bIVqSZm9bUFAEe414fRbJRvEgfTq8rKuPEwjJDL3oTj3/LNa4Fy5xRLGJSnY06WYKk6v9AWqiGxmf0FxG3vANHd5GF34cYBVtfoJZzsTlNoWerA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FlfbowNm8AfB1AHC/zU6WHwVKwSVTd8aDgccXSC18CA=; b=W3QUrnf3L5KYwTYL6Xyf6y6kDsgoZsbpe2xm/afTihzBfna88WlDFDD6A4xWkNu3dkvnlJWEtiDtsJlCc0NeTVSg9iw0R4sCO2Yq9JuficEMbZl4OKUse/X/h/UbpZ/rc00EBhv0pc/gikSu2Ue8LuDIy2Xo5RfIzStjMKp8ynR67uL4dXuNUT9ucb2NOlwGbFFPXY/eLh6L8oSKWv+va2ZseEoEagTEYSpcZSn2oonNXTHMx0jUcYqVYwlXWyMuLYs2xui6OHAZUPoZNmiXdZzr8Il0l/ig8GQA7IrRhvBI5+rx54Psy5+/0Ia1sEoPUKej0m+Gn2S4circ2ZMZ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM4PR11MB6142.namprd11.prod.outlook.com (2603:10b6:8:b2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Thu, 29 Sep 2022 08:28:02 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 08:28:02 +0000 Date: Thu, 29 Sep 2022 09:27:54 +0100 From: Bruce Richardson To: Anoob Joseph CC: Stephen Hemminger , Honnappa Nagarahalli , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Subject: Re: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level Message-ID: References: <20220829165151.472-1-anoobj@marvell.com> <20220928152121.064f6023@hermes.local> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::18) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM4PR11MB6142:EE_ X-MS-Office365-Filtering-Correlation-Id: 715b6767-769b-413d-fc64-08daa1f48625 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWVKZjFfVJ4VktraxPUiIBvNzFptk9Tq+FEyAUKCMRUhfCmEjIdZ3gA9rVI1/2TbVT0ZKkGzJvHTWdC/pq9wURfmcXGOkh6u7WXMFO/9BcuGgYun/qcB2oAjbPVnfpc8IFZRUH/DFX6S/S5JQaSKKk+yjF/PSYXvFRDKliwNZRD0gjOVWATSQmu3hE+6HTkdLA8b04qB8Z3E0Sc9i/dSgUZPNZNKT6sfWscNZ0TjLZyacAJxTyDeXvdc+W02s4slw7sOC2wXDSuZEeNGNnhGEAhOpqj+pp8GU5p5FS0XMGkYTjYNR7QJJ3xlMky6gT9IS0GncLfdJaZ+s8iNjjFiVaEX0y85rcg7sUNrxHf1CcA/ZyXZcUWgBXXn92FshPgfX0za0iOuncUuGWt9P3QrzNYRNpiPuFM7rg8GwXoCdYKy7htQislg62ORIp86r39ROCCTij//Ypm4DSQcfEN7aXWpy/c1NmCjow1XvsGhdKEU5Ta+xCjUys8EA4zTqYghYdtLWtoPlHAhCVSJUtE4Nh0HL4kqyTGn8ws6FxhqqOmx57R+POYRQ0Aan7NpKU6FBFshdf+JA2Wh2M0DSDOiFXzgYZiMvFjyRPBjvMUgjZbz36nqgfamE4+bDvhzFtjm1zett8PIu8bkOEIVtTQuMrb+qvZm89gIpy/GPiEQzLoXDhYg+eARPKI4HXKanLnkZhTAjh0/jAcInN0F9tQkpw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199015)(86362001)(54906003)(478600001)(6916009)(6486002)(316002)(6512007)(26005)(53546011)(4326008)(5660300002)(6506007)(82960400001)(44832011)(2906002)(8936002)(41300700001)(6666004)(38100700002)(66946007)(66556008)(66476007)(8676002)(186003)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXRTZVN6UE5ZRFRJTVFEOXRIcUh5RzRBZ3Q3MUJ0aG42UjdQYjZ1WUhFREJZ?= =?utf-8?B?OWc0TzZrTXoraitaS29aUGFnL3B2ZEIxa3pNNEJzeFlmYmZsNkFMTHdrOVVz?= =?utf-8?B?MmNJZG9nNGtiL0NBbElFWGNlSnNBSXhieFNlY0d0SER5Wktta1F2cy9OZWtZ?= =?utf-8?B?NFI2bEtrWUVuRjROSFZnbVFDSU83bUxiZExINDhmUy82ZGI5QUsyNGFIazlk?= =?utf-8?B?SmNWbnQ4aWViZ0FmRWFKanNaR1EzY2ptZUtYNzZPNzRrcFJycUNhVVA1OXJz?= =?utf-8?B?clFPaHR4RHA3ZTlzelVKd0pTNzVYUFVZMjFSeWlWeC85M1N4QkxtN3A2TWU2?= =?utf-8?B?eHlWT1RTcmc0NUM2UXBZUkxUd0YrUElZRGw4RGdKeGlZZFVmcXpxSkhhdEd0?= =?utf-8?B?QngxTWNmUm9obnBmODNkUVVyOENMcUE2b3d1RlpTNWhiRDJxc05Sd0N2NXVW?= =?utf-8?B?SWp2Zk5IQTA1c2NuMVZneisyNEc1MXF2ckhQR1VObnFoQkFJVFF4R1BveC9P?= =?utf-8?B?c1IrT1ZQUm5GYklCVVgyOVdwSmRRSWVETDZadXZqdHRBc0U3WTgxbGRMalox?= =?utf-8?B?ZTMxc0hVWnBQMENPVEN3OWZPaTFJRnZYTUQ2aEhFTkFhQmdaTDM0SG5WUU4z?= =?utf-8?B?UVZIM2hOclprcnBvNzhGcVBEd3V1eHV1ZVpmZ1ZhL3pNSUp1aUM1MHBkM3Yx?= =?utf-8?B?T3VQcXhCS1FId3FEK01XbE84U1UwbzJOU3dlYlhkYXMzdHVHak9pUFJWMjVJ?= =?utf-8?B?d1l0QWx3NnZqREhBdDd6UTRDRnhxeHRibTY1MjRQVkdIZnZJaTIzUHJUK3dw?= =?utf-8?B?dnpxQ2NCeC9XdFJ0c1ZiMlBkMmJMVG9ZbTgvUGMrRXE1OXRPL3VObytscnVS?= =?utf-8?B?K1B4Wit3L25jdXJWZGN2MmxJT3NTYjBNVktCUkhZc0RvVWlnUEphemJxMEtj?= =?utf-8?B?YWhyOVRiU2VZbld3UGp3TWRWb0p0amFBK0pibXRQeDVxMGRFRktFc2VGOTY4?= =?utf-8?B?enNoU05TekZ4QUxRdXVQeW1UakxPMTZNaWpRaE5wa0lMUVJjMk1NVFp2QTBa?= =?utf-8?B?MW9wc0daYmk2Y2REZ1htcjltVVpMcUorNGUzRmxHYmZZZ3ZNcCtnWldNUGRw?= =?utf-8?B?dzBxVlRGSDFBTXB3UVpZNkwrUC9ac3JHRXZ5SUJGZ0FBY3ZTY0dTZ0h3ZUJP?= =?utf-8?B?c3FCWTJjVjRwbkNMT0F2czZsdXF0SFJkMHJLNzFvSlV0OVFQYTFTbXJuL0Q3?= =?utf-8?B?cmJydU1zSGYvcU84OGExOHBoOGp2QnMvSVVDbFlOb3ZFRDFhRkJXVHRydTNF?= =?utf-8?B?czV1R2pMbStWK0VESCs4cUxnZy9CVEFidGZ4YnYyMTVFQnZINEdSenNIeVlR?= =?utf-8?B?MEJpZFUwOWYvd0lXQk8zTEJ0WlFTd2FJTHUvTlRRQ0tOa0lSSnVlZURTMGpN?= =?utf-8?B?ZXRYVFp0SytuQXpFa2FuaGpoSnI2bDJDdjkxSWk5dE4rODhnQlZ4Z3U1RW8z?= =?utf-8?B?bWRMcjBOUWZybnMrcmpsTWc1d0FSZXV0clJ0a0NVb2dBeWpKelhxYiswbzJ4?= =?utf-8?B?Qk1WcWY5TDdtVUg1REppbTc1MEJKSlhqSFpvTCtDNktMNW1waGowbDlXeWht?= =?utf-8?B?bUhiZkZRSVY0aVpNbVFxMXpKVUtKKzJIaC9Oa2s1bjRiRWowQmpTWHk0T0FD?= =?utf-8?B?UlpYUEEwUlh5eW1xRWk1Q1lzU3lsenArRUQ5U1k1U2lTNk9Kdm8wTjNHbmVx?= =?utf-8?B?bXpFWUlDQVpYb1VKZlJNNEI0ZlJ6d25LSjJLUWZLcGYzM2F0ZVFQcFBwVmh5?= =?utf-8?B?TUVjZVFmYnBpSXBESGRnVmxBOVIyaFpHcVBGTmlUTm9EWVVXa29XbTBiNWVw?= =?utf-8?B?M25NUnRSZElwVktXQXJaYWhTN1M0ZlNjTjBrRHo2aDBXVWFGRWIrMzJLTzhY?= =?utf-8?B?NG1XUVZITFJZV244THNkZ0kwWGptVk0xeVVhbDU3b2l2ckRGNkRXc0VxbDZr?= =?utf-8?B?RlR5YXozQzJNMTdicmlnSFhVcHlZYmgvNEw5MDZubmhmOGJkWlZOMjdQdkMw?= =?utf-8?B?dlVFS0RSRlJXcmhHZ20xa25qWkxPZ2JrVTBuRDRNTWUvTkVEVlpmSWJJRUw5?= =?utf-8?B?Y20rT1krclJVTkhqT293RWR1d1lGQlMzZGoxTnpMTHBOUm9WRDdYaXJucGU5?= =?utf-8?B?WHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 715b6767-769b-413d-fc64-08daa1f48625 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:28:02.2949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +CUqa/dPfoy/PsrnCEArCMfuoMYbhsSlvAGhvQPcFg0WpNlvnLIAVSIgV/IpvWicNQrbdd++mcY/eXwebixv/9tL7ZCFdbOfwZZoRSeXZgs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6142 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 29, 2022 at 03:25:44AM +0000, Anoob Joseph wrote: > Hi Stephen, > > Please see inline. > > Thanks, > Anoob > > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Thursday, September 29, 2022 3:51 AM > > To: Anoob Joseph > > Cc: Honnappa Nagarahalli ; Jerin Jacob > > Kollanukkaran ; dev@dpdk.org; > > sean.morrissey@intel.com > > Subject: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level > > > > External Email > > > > ---------------------------------------------------------------------- > > On Mon, 29 Aug 2022 22:21:51 +0530 > > Anoob Joseph wrote: > > > > > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same > > > by including the required header when RTE_LOG_DP_LEVEL is set to > > > RTE_LOG_DEBUG. > > > > > > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’ > > > 678 | "%s: status: least acked token = %" PRIu64, > > > | ^~~~~~ > > > > > > Fixes: 30a1de105a5f ("lib: remove unneeded header includes") > > > Cc: sean.morrissey@intel.com > > > > > > Signed-off-by: Anoob Joseph > > > --- > > > lib/rcu/rte_rcu_qsbr.h | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index > > > d81bf5e8db..b0f1720ca1 100644 > > > --- a/lib/rcu/rte_rcu_qsbr.h > > > +++ b/lib/rcu/rte_rcu_qsbr.h > > > @@ -37,6 +37,10 @@ extern "C" { > > > #include > > > #include > > > > > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include > > #endif > > > + > > > extern int rt > > > > This is not the best way to fix this. > > Just always include the header file. > > Having it conditional can lead to more problems > > [Anoob] The header include is only required when RTE_LOG_DP_LEVEL is lower than RTE_LOG_DEBUG. I'm not sure how the tool runs, but it may still flag this include as an unnecessary include. But I can make the change if the tool can ignore this case. > I think the number of build configurations needing testing has made the automatic removal of header includes too problematic to use further. Therefore, I think either way - with or without the #if - is probably fine. /Bruce