From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB442A0543; Tue, 4 Oct 2022 10:07:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C3FD40DDC; Tue, 4 Oct 2022 10:07:58 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id E149840A87 for ; Tue, 4 Oct 2022 10:07:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664870877; x=1696406877; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TT1CCL01NTJx5DJzkDYvOp8rzKrb8sABnblyLnq2osc=; b=H78sPZ4DFbl8m2dg2k2Pdo/FO9jbE70smnxMFoih9dPs2fJyX20ywxkX FXbSpKo+LltXar7IAaI1I9kOZUjAcwSGRVo8zMv/eL6Yagv6Kjt6AJhU7 vgEy5xleG7jWt1m0S6xeOThRvnGDACuGJLl6xl9zhFe1LewdMwhGi8cId JfOtfsSw48yNuk3KUxdjVe1PQdPTJ6O3uUu5yjI3NXwIcrHHmD0P5RD78 QkqjYeRmFEFMnC3deQ21Vs0VyUTvA3ZuAOoIfaPg2tg9FbUavV+h7tg8p laqtzkhgOUX15pUDtPqM6kTx8KYK7ODhMw5ZAO5u3mAmxzLXDoCEBSQT2 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="329258155" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="329258155" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 01:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="749295636" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="749295636" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 04 Oct 2022 01:07:55 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 4 Oct 2022 01:07:55 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 4 Oct 2022 01:07:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 4 Oct 2022 01:07:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 4 Oct 2022 01:07:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G3GZ+gx/HryH9Oow3S4VrqRIGX5Nbhhizfdzq+PYnU+BXuu5cw4ERUWQC1iEPKge7nrLtE1q6ZKjywbRz6sk9MbHjyMNwvYd0pS9o8p1QJ0vmfoOhJWt3d7SYy/SJX2qQR8rnljlIM3cukyZL3IkJXGURqGjOJHrI8E8u8zMD1eWOamDhfAclMa+2cypd4eCBeW18rh+KxCHwAbl/tjEKnBmkqFs8V5drYD4oHSw65B/t86O1AOKcv7MJmvesUvgFD+Z5o59gXJq5ZoM3ZcEFqAD1uhYoXW/hS6URNEXJFqca5ncyruWHtjrg/L+ECrXF5QZtQOW0bOrkeVHHdaBdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sk1sSBGt3ilNiB7l3tH7BXlt0QB8/QuEjhUC31rzna0=; b=eQ2eYou4FVFmMS6Y7MOLULwLw1wVIndtSNE9L2sHzmSkFd4H1V4ICLok3NRZ6c/wL+ArtlXBpIpSjnsi57VhYp/TE7altXet4mZ1iGrvowwV7SwYbfCujLYcWvbR1sqErDOIjlREXJ2/2QRE80Hdw5laDoYYzF7PRcOHWjK8p8Qn7VT2Y63pGywpVeVSrMlKv1eKxAeCFX1dfAPFo/BzkfcoPE6FUhDIECESIzNLyb/Dd8DrC8viC7xUpzA7HmNmIY046uku1jVCWTUwSck8MSrNZDAH17aS/kRvqn3HtjtFUBX+F40KNa2ODlPgGiUvqzTccjTCHg1def0zrjwBew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by IA0PR11MB7404.namprd11.prod.outlook.com (2603:10b6:208:430::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 4 Oct 2022 08:07:51 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5676.032; Tue, 4 Oct 2022 08:07:51 +0000 Date: Tue, 4 Oct 2022 09:07:43 +0100 From: Bruce Richardson To: Omer Yamac CC: , Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files Message-ID: References: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> <10e1b3c74bbaba4bcca8fadcddf8a7a4@ceng.metu.edu.tr> <0f7fe73d49f820e4a1a1d56f9b535bfc@ceng.metu.edu.tr> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f7fe73d49f820e4a1a1d56f9b535bfc@ceng.metu.edu.tr> X-ClientProxiedBy: LO4P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::21) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|IA0PR11MB7404:EE_ X-MS-Office365-Filtering-Correlation-Id: 538132c6-0f70-41bb-bc89-08daa5df8879 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3AzaMuh3fx2UMYAhlkr9k8NQYKu8k5GHAPBgCt/kXLfVaFbQenq6dq3YoOjYLgl+jpYRxqLyEGRzIJ7Lyf9+jkt2ag84LPXXvuBt8f6ulM0AwnvCps57dV0AqhURNwLYIoRnHdlHo/tGCdrnCSuBGpms3uduecz4TnRORPm24b7Z4w5HNTs9ltARUKtGpmOplBzphhqrcEQqz2yMt7GzOkB8XqvYhe+40uO9wrmlB/wqUBEhjrsl5TDDlMAttdisLjiO2KviyEoyZTFp7xdtddaMjpWJAgo+ms8o8sp/Z3PDDPCtAHrmwEm5RF9NICti3HY2CLdamIkWqjaksJ7PfP4Hk3meB2NtPpKkbZ0ALnnskA5UgKsNqtvx/LwGopIB7iGJ2oVaydxik+Shni/S09peR5fzokjMcLrdt7G2gMNY0xO1EnIiF01abiCeJDJ1NE2QumYiBN6jve++zWMYVkkrGVfMoSk6t4sfPldizSFcvVZIE1YzxEpuNpVIOu0webaUsNcr30vjWCto/uQEQtcDAF9lsF/GSqhr/kjQHRLD/1pofTqDGZ8rje5LiLpcn7/iQtx4Or+fZApa+8N5IQ+62Vt0VekA1S5XReuatK3MowWhPZ5O0NmkEj7+8O6fNU/Zt4wGy15hbQJ15y0NOmUi3pjOQmx5cinpySOIc0iQel5T1TNqSUeINmQhTn5MEMWt+k7rTG1vhJnyaxKmJBgNt3X0oB1XH1Rv3CHfIqwfXAuYiXJgdmfOZn2LrH2X X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199015)(4326008)(82960400001)(86362001)(38100700002)(186003)(26005)(6512007)(2906002)(41300700001)(44832011)(478600001)(6506007)(53546011)(6666004)(966005)(6486002)(5660300002)(316002)(83380400001)(66946007)(66574015)(6916009)(8936002)(66556008)(66476007)(8676002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?INImnzwJs6gfBDdjKYqpjKMAZdkNJ+Zv7qEIlnjF6WXu7Ra7GDiZPFB/Z6?= =?iso-8859-1?Q?Yeb5o+AYU3xvl/Daf7WSOsk80AD/oBL6XdKooV6TD2SRav9XZ+Cfewn/fj?= =?iso-8859-1?Q?ODZnW54nhvzNq9xt+ykHZrO/DuPITx9hg+RrKAUenMFA0gmW6Oaa5Fh/ai?= =?iso-8859-1?Q?8JVyZPq/ZUhA5QMYjdGqqd7NYk8ZxI0iL7Q+o5h1QeQtD77XEdjucnXX5C?= =?iso-8859-1?Q?Mzo460GBhlDRLbcIYs8H6wsgqg1J+k6y/nq/BEwgkT1SRNKDbrLZIJRXcD?= =?iso-8859-1?Q?nTtCgH/D2OpA3dRt1ehjDtClhPb5OsuJfgzv25c6N2aY+LfEUyQn4GFcyH?= =?iso-8859-1?Q?BPcIX6sez4ZMrL5RjYzZNAWagmPQgBGEQ+ycHRSpoxnnpJnIxKvTdOJU8+?= =?iso-8859-1?Q?J61pv4YpjfdASoglWGKpltjxYhmwkU23SOSc4F7h/3ztqyHT6TfwyCB/Mr?= =?iso-8859-1?Q?lF17CeZ1AIXciZKxFNpFfMGDrKZSZLZ8HAl+Tx9JXoC1weTm4s3YYEg6kz?= =?iso-8859-1?Q?9jJCqKAuF/JT5eF8+dOw5AhZjMtr6oWa265ZQYFA3zjlueVAA3CXRjxSEb?= =?iso-8859-1?Q?glTCwcoKp9XUk5eR7RK5SREcRmRr+FcF1CacojWrvZO9KS4e+RKu1Iuzok?= =?iso-8859-1?Q?h9lyoZ7+LTFYx+r6ywY+dhADkUmyGzp5x10FUUbAv8Xs4TMBbBGP7PXVza?= =?iso-8859-1?Q?PXStcYxyERDJgN6HL3b8VBQlPHQmLbEZydAqnRZnjI1bWkg8/eUQdjsUi8?= =?iso-8859-1?Q?IxyIzFnJF5BzC4ib8Yc6Fe7l7F+YSuiatO5k0lDfWZE5IrR8CEByWWkdls?= =?iso-8859-1?Q?Tk4/6EN0LRoIwB+F9l9qljuPocMsGAYHYJbPctRFol8X5v8A9819rPfBj6?= =?iso-8859-1?Q?mSekjGMNKP/PA/JuzyLbz4iy/D9rDqmWaqia0ICG2NJovItAHl160ONx9w?= =?iso-8859-1?Q?5yeB0m85aHl1NwBWcekxYBcifUF7DkEcEScLPzKViIrbTiAeajU1S/Loyc?= =?iso-8859-1?Q?u9jXtiEzubXzp5r4x/5BfHGI7s7rcKzcoTsClLqN2GQm9f14LTG4bcUHWR?= =?iso-8859-1?Q?QxBtvByRWjGShhST/0vxkCRvEAJ7R6J3nPn+vZn160EFDy0K+kzhPjQDih?= =?iso-8859-1?Q?OzJsOJtJFLsKRgefEvQUKn2eJA7ehTjzCAUodiQ+oRcc+VnvODijK/sjvS?= =?iso-8859-1?Q?6Wy8XWquPMmFY8Dzfu2lhkE2rEYstRHuUAxi40AJXf3O4gecRChVXSVq5n?= =?iso-8859-1?Q?PwFA5BGACdQ11pl2aY/9BhiZJzKOFRGAk7cUHnOPQmDa/aYnjyoD9kQmIf?= =?iso-8859-1?Q?g/yM76z2fao2gRwaqgtzB3cwRg5SsqYK6mWLubRMvFwDWL8irGDEXxRqtb?= =?iso-8859-1?Q?FS0w1JSQoSzLNLkoCQlSAxmvwJW+xdf0fSP+a16SC6Dsxzjfrzngi6l/AQ?= =?iso-8859-1?Q?7n0W59pVFtXuBuC3pU8VQjdrR1ZMQG9Fh4UdezI6n3Y3J76Uv//helkCfe?= =?iso-8859-1?Q?uxIdd1NORUSf7VO13m9D7m0aGEZylSfM632waPYJ/QW51IOHZpJzND4i+7?= =?iso-8859-1?Q?Wj5Oa+l6n3vktBKlOOSRaEj1Z5yWFldGiEjm6LmebTUeKfdRQ/ppUsENYc?= =?iso-8859-1?Q?n/syjyVy/Hl9ci1hFq886tL4fjOuVrvEopQQLPYy8OJtll/LNQ/wtQ2A?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 538132c6-0f70-41bb-bc89-08daa5df8879 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:07:51.5909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LSECpq6XOYAdiaiRwDvOyyRPh3bBDtjUleII71Sx2bfGMy5Heb2V7WDBmZKA9pxxgJKdU7h5PxsdEm5LuWavcqVdG5JlVi1v2uBNH9ZKEIw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7404 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 04, 2022 at 09:30:39AM +0300, Omer Yamac wrote: > > > On 03.10.2022 17:01, Bruce Richardson wrote: > > On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: > > > > > > > > > On 03.10.2022 12:19, Bruce Richardson wrote: > > > > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > > > > > In this patch, we remove all version.map files which include > > > > > only the below part: > > > > > `DPDK_23 { > > > > > local: *; > > > > > };` > > > > > > > > > > Then we modify the meson.build to be able to compile without > > > > > version.map > > > > > > > > > > Signed-off-by: Abdullah Ömer Yamaç > > > > > Suggested-by: Ferruh Yigit > > > > > --- > > > > > > > > I think you need to flag this as depending on us bumping the meson > > > > version > > > > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x > > > > versions. > > > > > > > Thanks for your warnings. > > > Instead of using fs module, I will use python script that checks > > > file exist > > > or not. > > > If it is okay, I will resubmit the patch. > > > > I'd rather not go down that road unless we really need to. Right now the > > empty version.map files are pretty much harmless, so there is no > > compelling > > need to change. Therefore, I'd rather wait to have the meson version > > bumped > > to 0.53 and then have this patch applied, without having to worry about > > using script fallbacks. > I understood; but one thing I'm not sure what should I do? I don't know how > can I flag the meson requirement. Is there any special method or just a > comment in the commit? You can just put a note in the commit log, under a cut-line indicating what other patches your patch depends upon. See https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies Regards, /Bruce