From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0E4245E06; Mon, 2 Dec 2024 17:14:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49175402E8; Mon, 2 Dec 2024 17:14:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id B0F75402CC for ; Mon, 2 Dec 2024 17:14:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733156053; x=1764692053; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=nq1oyH6Cz4VftyKmNupe2QBO/prgXr9jSHDdGP8dLEQ=; b=L24TPnm60WO8Do4+zX1y2IoXXAoqTk6PBV5Zciaxvo9JODHV89yU/shz vUNh3hj7RiO83jfvx782Gp380NAI2JfwDLqLkmdrNJqJ5mp1Jlit2fmSH WEcLYIudBfZ596DnhKmKM5x6pwvMJZsZTLuuHRt14jvaZ4deHTcK9hLh2 P4H0mUV+4tZMimCYvLUpXviXLKOJUjwp3mlTPomFhDud5pXvG6F3F/gnN 4skpYzp1x1+gtC+C9GYXhHHtiN0XhDmgTkqPWqloeisuN42d0G1C4pM1W Dc/pt9kLCs4ZHmZWYpicLL8w1iTAx1Yn5AMUKpD0IswPQIiCEppV2jaOj g==; X-CSE-ConnectionGUID: kk3jVqq/RmeTTIyzKm72rQ== X-CSE-MsgGUID: LYA0pdd+ST+q6grCT8+sGA== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="44713669" X-IronPort-AV: E=Sophos;i="6.12,202,1728975600"; d="scan'208";a="44713669" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2024 08:14:11 -0800 X-CSE-ConnectionGUID: VZM8AbtPT0KRt6rRJ0zBgQ== X-CSE-MsgGUID: 3JW3/hxERcWoQ79+p/5Erw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="98186382" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Dec 2024 08:14:12 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 2 Dec 2024 08:14:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 2 Dec 2024 08:14:11 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 2 Dec 2024 08:14:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aHKjb+6KktuKP/ubcn9MIumJXsGOu1NZ7sTHgk4ErbhHg0nzRZr5TyZWNjojfH5HRamEQyFKqyG/7xkDjBjbYWAnr2E3tT8/5fmwBV0NENefNgRX/HE126ViENUw663mZuf4nSJcGz5gkiG9AJkivPkklWr88WZfRczfOctRFqq9hvGG8+J/dARSYm3z4bLDqGUYogHORc37NYv8OnD5GkFjiuimPWWcBdbq4G7b7Mp8QLmNduqxYMOQOvdukYC4kGSL5HmnPbHLfWSYN5OfeWvLHs6WIcOyhbBXQwGHx2T8nxFstvjA2XbL6eEVPnH3s8e7zz9qLCdv2nDLveA8Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IwNoCPvFcuce0UWtaTo8SaSUENNSxmWZ+MjIcJN7/qo=; b=K6o4kVoDJ/NVJ/3Tkl0yfW9Rb2RLGmYl2q6qQVd8nco/8jJfm1ETXzYNBIjEltMsCX7efV/SVnYseMXe/hdsf1EiHHVQ8dbl5JPirYGjObTaVdhQXV6RwwVB5xOU0zE/qJDyudSVK7JQPerKhXY4h6dTaLdrQjQ1U80DY4r/NE2qJuxEQj2qwM8+SfLxIAZma9SYKQRnby0FvpQqIle0taHAYaK4Z+1plQyq+BBES1VultW70v+7kZ9gcekppcQ3Bq47mZelEp4rG3moJB+bpXqa7kJ8fCkv8aBrYykUP6nA1dIhNpma9A4lO8c6DLNlQITirfdsUS5JW+N+7uHOAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4890.namprd11.prod.outlook.com (2603:10b6:806:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.19; Mon, 2 Dec 2024 16:14:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Mon, 2 Dec 2024 16:14:08 +0000 Date: Mon, 2 Dec 2024 16:14:04 +0000 From: Bruce Richardson To: Anatoly Burakov CC: Subject: Re: [PATCH v1 0/1] Rewrite devbind Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7PR01CA0045.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4890:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e0fbbdc-8a0d-4ccf-2992-08dd12ec59e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?w3/SR5Gamwsjbq3wdIiimn5mC01A4L7oL2sykT28kpZEo+zLu/VuxGSysMSo?= =?us-ascii?Q?Y1NoBkfoXGllGJIC7I19nb9yBWI1IZOuPiXnhXytudqBdAo33uoAg1KPujNC?= =?us-ascii?Q?2f66bx41X34Qw79MfqkCU96Cusl5SR3p7nMY/pnz8z7sYItxI/0kB4k68IU2?= =?us-ascii?Q?INdRRX9DaQXFFz/QIv+I/OVz/C0YUyed8UA0AHzmfYW89ZaZo7yE9WqvNhjY?= =?us-ascii?Q?GwGrI/3rjZfYQX8KXhbgNg4WFOSw6NYXUeG7utPTvF7a0WmououUZfRcrS+I?= =?us-ascii?Q?CLBsnh1UueIW6NNCqTo154yBX7oPbMfGkdiHkzZ16/LPwkZzBa/aEZMZbeoJ?= =?us-ascii?Q?1lft24lvoLclz5dTtJWPl1O80PJG6bxiOhgVdXBoqit9BvtFa4QaTU9h/TWc?= =?us-ascii?Q?TFmmpYNPXwbJSSGduy+IXa3AAwy3hfTC9MCRHqsR7nfuejc48os0WFBQ2tRr?= =?us-ascii?Q?XoRrdTFp72hwRJ3JNs1xXjpN9EQo/NhGlIGX0A7wCXtSf6V8AFAOIYJzlmzA?= =?us-ascii?Q?VhA8Mr9C6WqLTzbdZXdOzw+L8cCNs5XfYiK5xkThspGftNaR1Yzz1so8q/X9?= =?us-ascii?Q?U1ml73mAt3zVHa/EEsQUjePET7Ecj6nKi7lTm1+2pCJJuYByP1Q3MfS2r/nn?= =?us-ascii?Q?z89XM2mDpsxAyEN1ZYETO0XOwbCrG+Q8dD1V03Xt6/A3JU/eOiU9ZxlPMbUl?= =?us-ascii?Q?9QVADwDZstkdOfmkbN4HRk2uSWeWDefY83O6LnCGpxWZLD7Z9BMoSP8Ic8l/?= =?us-ascii?Q?RI3PkafzjI8ofSCRkGaMsz3gRa1aFxMadEtpjeNJnMw5zmQ48wT6xuQSpPYw?= =?us-ascii?Q?P9nU/WUgUll/Hj0iVFX8wiHpwzLLeblJjNqZ4gzn+jRJ5J15dE8VzT8klgSw?= =?us-ascii?Q?lgXsWz0sS0trB4euVGQjtfhy40sC40aP+sIoLk/qDuYSvi3xaT7FYu1sGP65?= =?us-ascii?Q?b5/1Homc+fTZt58GBVdSr/LZYEacVwrGyKijVmxcC/HYvizKJUWMgkh/PQt2?= =?us-ascii?Q?xk+ew4MEBlQCqMZouTkCD3W6Cv4faYJsBNYEseZHnpCzTTCp+ObwhzI+4JL+?= =?us-ascii?Q?iuKMZaeB5HWtqT17EdfyQjOqldbeJYdeK+HN65/y4qr+2yGC9CkK5hZ0MOVb?= =?us-ascii?Q?AbwtNJfaIV6YwBxILhU2RnK1H035hJOjOzqyFQ7/jmdf2x2SL94zL/7rfGK4?= =?us-ascii?Q?kIIoDP5GZo3SyLOfK28v7W/AeRVlrv541vJh00iEC+yK7PEQ0Jmv+WgkXsxx?= =?us-ascii?Q?jkImWiy9+/3h7WUR2QAdBG7x98OvCHutwlsfj/z2FNEg38qEVH5Ya6Hob8NI?= =?us-ascii?Q?Fma3egaBHpuG7GpBQSKeZ6+JurV918caLC3qzdNrwMcH8g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P7R3VWtisnoQSSIuiiP6LKTCT18umi96uFlqcnN6ybjhfH4XhrwIWveeksuS?= =?us-ascii?Q?fa352+GQX1IeTFfQJAu2zDrQMM4KKqE+SK2XG0avx9ktxhUbkv9IFgJMSOUd?= =?us-ascii?Q?l199iNnLQ6xCvTBOLKVhLeRxrh/pvxRj6U8ugqlke8srbBxxcOIxm277wKy1?= =?us-ascii?Q?/WzUVJGbVoCWWi0r6ZQleQvzrxbhMZBTZiAx+tXRwV4kMefxEroBr4EA710i?= =?us-ascii?Q?zFjVg8tI1NXbFuzrNX70KqAiSFzNVvGOrsZqjlScsH6lrxfm6Nve5a8Q987/?= =?us-ascii?Q?wM6fVALfkc9XJ4xtDxm6ifVDlE05vODSPlkcX4bTJhWXifrj/PClNadBW9Ic?= =?us-ascii?Q?l1rGCxOuuwwCl5Y7QSBeCCnchA57J768kOGivozEFqBfR9ktXO/2+Q0HOKoG?= =?us-ascii?Q?LnZbcchnh/OZX1Q6bwrm4GfrRdX8I05xa57/+k933GNMUBWHniaOJVFaCwUL?= =?us-ascii?Q?XFsw8mNZFIsnJsKUIxdK4AqFy6CN/uX9/stW2vDyeOLZOYrTXitpvrc/pfgb?= =?us-ascii?Q?6DCEGxOO1JIJwm9LH1goQ8pZgIBXSLeeNvz5H/KfNVb4U6acJ0xB9HkP4aa7?= =?us-ascii?Q?bflbEH3m+Q6XmqmfKWr1Ara77N0VopkhuVsCb4sehbVxwd15F8dgfSqanhAI?= =?us-ascii?Q?2f76vQ3P7vjfZbg3xYrCNgPA+tSoEa/dJKF3/MmN+DUkxPAkXSbxuSP2vfyn?= =?us-ascii?Q?ABAQFgGXTyF8wr/4AjLzu19T2E1vUxbs288tI/PPrX7DIr27jvuKLwoiRbGe?= =?us-ascii?Q?kYEE3m3HcM6HYfNbx2g5eboFprTJ4J5mr/E0MNhwlmftjKlDtzRNMGMtNcw2?= =?us-ascii?Q?SnseMqfYehZvDJ1yxHcllVWtMQ0MXBNIj9NfVTTut0KhsY5blrGmJo9YI7zt?= =?us-ascii?Q?L8yTZaGw4cVsARYoz3rCGVdeyGGIfQ+uhbFRbKR7Pisu2QnEbmaKy4c/YD6e?= =?us-ascii?Q?dgvaMMFG3DgTbXZMuxWPxY8NS+hXV7HvYR7tVKkBToJee7lf+Shl4J1f7J0O?= =?us-ascii?Q?+fGNZexAByfDkd3TQIRo+h4oOGEn6KjHdyHhROFgp9BOh/jIbVQFH/+fgF1w?= =?us-ascii?Q?UuyD7iVkEcJwfmJcTFizq3MhTf4l4giGP5woo/e6fulXJwvK/jkTmfjQatk5?= =?us-ascii?Q?ENRMkgnldqXcesZbehQZq+RMVbutA9m+FuMQQT0GaYUoiglqTrTvpeMSpwdu?= =?us-ascii?Q?qBzzPduR+pktuI6v16AmN95jf1nwlMUPqnS7BICZTyHqZ7UEma55IjFlzAWh?= =?us-ascii?Q?j6tfHqNPkytik7u0Aee9gzBtH841zCanhBZjdEq+pXiwkLZEpUoH6p5HNMbn?= =?us-ascii?Q?n4W69y6icyrzJCQf5OT9MDR0/tkIMr1BLr14qR9s04zcCNrCTli5WDanke+6?= =?us-ascii?Q?9gU/+Me3KFVlRRWyO7rYr68UWrVyFAeyx1Afev7uLOiJKf3t93hiAQD69kjC?= =?us-ascii?Q?5tH4BR8NwzylNtwGPpzM8hJNaV4Zly7Fn0kPWkj6lrpmQmPZOQi8T7S8MGIU?= =?us-ascii?Q?QcNQs9Q3YbVcQqWtZ0JE4DDgSrcq+TLlImVrLQwJOPlzVToTEbCO9nL+q/WM?= =?us-ascii?Q?9YABvKVvPT3l2R9tYWab1GOg3bPb1CCG9meyKw9B65fsF5EHL7VBCpSiy5uV?= =?us-ascii?Q?Pw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e0fbbdc-8a0d-4ccf-2992-08dd12ec59e2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2024 16:14:08.7517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ybo266zHQuqvCvVTNDvltvwOcrhZ2CfAjX5HBgmox4fJVl8+DXhCVVQZyDhClZBiSs+mgVCUGzk3bUfRYrOCYU8T7LhFtPPu1hkirKHJ0E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4890 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 02, 2024 at 03:09:33PM +0000, Anatoly Burakov wrote: > It has been suggested [1] that a major cleanup/rewrite of devbind would be > beneficial in terms of long term maintainability of the code. I was in a > coding mood over the weekend, and so I've went ahead and rewritten devbind. > > Note that this is one giant patch, rather than a series of patches adjusting > existing code. Making it a patch series is possible, however the internal > code architecture diverges quite significantly from the original devbind > script due to its copious usage of string operations/pattern matching and > global variables, so it is unclear whether subdividing this patch would be > worth the effort. > One suggestion here which might help reviewing. Since it is essentially a rewrite, is it worth making this a two-patch set, where: Patch 1: introduces a new script called e.g. dpdk-devbind-new.py, which contains just the rewrite without any of old code. This then can be reviewed in isolation Patch 2: moves dpdk-devbind-new.py to overwrite dpdk-devbind.py WDYT? Regards, /Bruce