Re: [PATCH v2 1/3] net/ixgbe: initialize PTP to system time

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Nov 25, 2024 at 11:33:24AM +0000, Anatoly Burakov wrote:
> Currently, ixgbe driver initializes PTP timestamp to 0. This is different
> from what kernel driver does (which initializes it to system time).
> 
> Align the DPDK driver to kernel driver by setting PTP timestamp to system
> time when enabling PTP.
> 
> Note that ixgbe driver always uses zero-based timestamps for PTP, so we
> would only ever update the internal timecounter and not the actual NIC
> registers.
> 
> Implementation note: in order to get access to clock_gettime on MinGW, we
> have to use rte_os_shim.h header, which provides a wrapper around that
> function. However, what it *also* provides is wrapper macros around various
> other OS-related functions such as read(). Due to one of the mailbox ops
> in base code being called "read", MinGW will misinterpret a call into
> that op as an attempt to call read() the OS function, and produce a
> compile error. This is being worked around by using parentheses around
> access to the read op.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>