From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA27745DB5; Wed, 27 Nov 2024 11:38:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73B404021E; Wed, 27 Nov 2024 11:38:29 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 9A167400D6 for ; Wed, 27 Nov 2024 11:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732703908; x=1764239908; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=b7ozbEi/GoYeuz7NRiPJmGOFoQn4CjddPvQVuPJuUdk=; b=X91eWIK5tV0Pi2SISIGWCrZG8+OlKIV4i8aoPDdjOEaHO68E3OvUNYdY To2KMWwqfrK4+OPihebNZhk+WCyB3yqf8LW68sef3oz+9u54VdiaDL22U FUvYJRpD9BTEz9lECz7e9ZJ1nqfp46p/nszTb3Z9uWZy4kflPcGH9X111 198lNlJe0bjo6DTX0lIkmKx08h6Wryckxg3nXOmI+UEJdwyo/xNGMXfFX BySHl8//9c7cEljvmjSFLtJXOmQQOP5qYsD1IF5McKxZ0eYtW8GAODdI4 q+z/OqAszVA2k2I2kPapTFLaTZ4AMR/PrXKrUAJDnIeN+xmDtyiAGgoke w==; X-CSE-ConnectionGUID: fblUmEB0SaisF6TxdFt9jg== X-CSE-MsgGUID: rR37ctMPRHCcg56zde9sOA== X-IronPort-AV: E=McAfee;i="6700,10204,11268"; a="44282267" X-IronPort-AV: E=Sophos;i="6.12,189,1728975600"; d="scan'208";a="44282267" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2024 02:38:27 -0800 X-CSE-ConnectionGUID: e5ndm3r/Rzu/e/MS0pY9HQ== X-CSE-MsgGUID: XgU9fDekRHW57MQpJyB+qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,189,1728975600"; d="scan'208";a="91785772" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Nov 2024 02:38:27 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 27 Nov 2024 02:38:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 27 Nov 2024 02:38:26 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 27 Nov 2024 02:38:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qUggGXirpQSGvOsV9+Ld8oQx/N6g0ryTFJRYU7JTIS0eIikuu0G7lq7eBoxML3TE32u6deTGAcHGPVFmzieBtdOivt4ip/4nDwRJ4H5PISINylN2Q3YerRuVKon1iQ01t+fNcs9DTlLHWjsLEOqFqin+8+SHi1e4HoFmuZZnJiBdbVqa8oOYFJ3Y+9sjdckZCt7PQIGJuOrFEdWgslijktB6RAL6gh8eZ0atruYTl87++oo2fi1MEvq+cWyqjFmY+pjrZQrjwF9HxifSl78TRY6duQyIjdkvEHT/CG5RCkAzSFINtw6+wfQTyoAcp48cFj8hm/sADqXjwkW7DeEBTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=78ZggWn9Gl5ior8vGgTfWQBpJELd25RZYJ8O1lqTpzk=; b=d2WrkuGYbgD+6avH81hW1JRkPx2jj2mNFgdRYIBzBuq7wa6Ms9x96TjTKuXsQkKTca/26/53wQM8CyM4lTJ6IU2b/XTrzslGiXacuNjx/XFgZvgezfPaomJjHfF9r4IBMS0d1O9HKi6TADzaBGB8CUqvB4KVUzG7jdvlVBq2xlWdcYLzeX5+rICzVKLn/PWkZOUqkoPTMBreMHjNdvm2L91DQMrujs5qaV2rXL0B6mifQchA9QvQpQ6xMAUMZB5AZiCteguwfqbZhiE9FALOjhZThdNne8teUaznQ7gY066SlO9Er3T0eopgo5JJlvOMRxdLTetjiMjvXRBjHlIiCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB7597.namprd11.prod.outlook.com (2603:10b6:a03:4c6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Wed, 27 Nov 2024 10:38:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 27 Nov 2024 10:38:23 +0000 Date: Wed, 27 Nov 2024 10:38:18 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Daniel =?iso-8859-1?Q?=D6stman?= , Naga Harish K S V , , , , Mattias =?iso-8859-1?Q?R=F6nnblom?= Subject: Re: rte_event_eth_tx_adapter_enqueue() short enqueue Message-ID: References: <903aa783-5956-4020-b2a0-48def17fe03f@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <903aa783-5956-4020-b2a0-48def17fe03f@lysator.liu.se> X-ClientProxiedBy: DU2P250CA0001.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB7597:EE_ X-MS-Office365-Filtering-Correlation-Id: a44af19d-f8d8-4012-ff4a-08dd0ecf9e46 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?JhX4YK1C0sQE6ywH5IR1GLDNlJEBqqhN1HRpD+GKgqdeYjFG7fv8qS9WrK?= =?iso-8859-1?Q?slHYz32Mon1NqVpoGubAonkwMm2/nZmaklxDpHv8atI7SjaMeP22bAXJD+?= =?iso-8859-1?Q?EEk9up0M6tmGEr8e9oX3hRupYp4soxENXB1+ZKDpaIJMC3fdkR+s+dmi3s?= =?iso-8859-1?Q?8XscASMBzU8jsDJfvqdfmfAVLcPOPmK0ziwYln31xL6PfhD/cFLOho80xO?= =?iso-8859-1?Q?xDe6s29M7XDQkVERLk+lMHKsOmafg4dTk3xITr6nnTQ/MmnIvFKUsXehEV?= =?iso-8859-1?Q?h9ovLdwPltd9ZyLr6uajMFSDnuLUlahDEQdKAUSeAS+nA9nY/Szkg4Laj8?= =?iso-8859-1?Q?FtudSGuSzdqYjpG7OaZ8WAzPrwO2N+K/E1XAFrLUlIIctAeV9Rded9/qK3?= =?iso-8859-1?Q?bn+36DrCSEZaiB/6Wibmu3ua/lJu+6t/eObMlu/qZIjT/usQ9n0q5+15ZZ?= =?iso-8859-1?Q?QkiYxnYv/nDZUS0DRIiACk/EPPv16wQTV7OnWCJcgFOb/K04pdbWyiozbw?= =?iso-8859-1?Q?eST9vrKAo++eJ12Bc/x58Li9PRFAkirijUxQ2SbZmZhfkEg5AzAx0IMI27?= =?iso-8859-1?Q?DdYx3sNHHyFBGbSU6hHN0po3ow49lqHldpC+7jVFu2u/RWMAbBnTkIZH1s?= =?iso-8859-1?Q?4z3YSteXQuDRtiSgcTm11vbltzONKCeUKm0GS0/Vd0Jisxib2gNdh/15ws?= =?iso-8859-1?Q?LolnXfbo9SscRy11ay6d6qlIE5xNGf+gqnS3h2voTb9u2HwguIzvFidLFW?= =?iso-8859-1?Q?oyfGGnvFsZKiie8CAbK+sET2H0M690ebSwQegoSh4f+L3ME9VvBq6dl/FX?= =?iso-8859-1?Q?oGFC7rAck6274O0Jv/BVJpCWWMfOL1CFQPx0NU3VzS7iAu0Esw4YGOdfN9?= =?iso-8859-1?Q?0PTr5X3AdRDYs7qZcv6SswwH/feRYiMsnnncxL+It9Zhc9oZbxYzTL4k9d?= =?iso-8859-1?Q?4nwELpujc0GR8wOzGPSILnJqFstWSczJparlqJ5Zwpmn3LJmCx/zUpiFF6?= =?iso-8859-1?Q?7en1WQ6KN7NUZMRG/pRePR8l56q9yot9lRAthGI8QbikyAqaV7KxPLlzU3?= =?iso-8859-1?Q?Aijgb7AgPDuvluQggPMImVnuCYdvcNVDXyzii4qQrk3dn0xqhbnMLYd5sc?= =?iso-8859-1?Q?Q/CR/nxbeqE1p05CzGdg1ZI0An5TfmcdtZV37RU+YQpFizfUzOJea9KCYp?= =?iso-8859-1?Q?0jeVylpQy6e1cHCaooTpiKGQlkdXE7vX4trNK90x9HwJxFlD+/1J0Zdq8M?= =?iso-8859-1?Q?9Zlh9YvjzwZ44zbFF4lvcGl8tIzxR3FxFj3/+8guTxmWDRqiWDiLPJHRcm?= =?iso-8859-1?Q?QNaJ63u3/34FzVUPFgc5d4hR6TL1wSDPZ2M7dNI+Beym1AljmGG1ybwciR?= =?iso-8859-1?Q?bIH73mJb+M4MrNxJIrJuHQMuMK65VPQA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?KRP22/sx9PLqK/R3D7r708yY2bQE0/D6IIS/kRH1gbYW9dfhDFLm0O+CUt?= =?iso-8859-1?Q?+4A3nmFuG1PldyrLTGiZhODUdG91VYSv7f+UB+2Tc7mzHEOb44skDb/t0v?= =?iso-8859-1?Q?AZWKpIi64ldRJppXhWJc/lVyKrfu6Vh6+sDHImCDV6hgwrfFCUyOe8D4zY?= =?iso-8859-1?Q?Ieo8Z1J2RZYP3SVndk8fzmEXAAFgXU9SGd9erGyIlHk334SFIWFmBoYBSh?= =?iso-8859-1?Q?4yq7JcuIVZ+Se1um9hj2Eu8NQskJV/hcWPpNQSLog+VjX/DkZq40zxaFc+?= =?iso-8859-1?Q?k8VEIogqWqlvzk0kLG8TDsawEvUJvzPMAvWLbMI9YEKoqQB4W38svYZuZi?= =?iso-8859-1?Q?bDIVarUdHIZ09jG+rIfVENQY+fZ1ycTwUXVPeGhoqlPP0ATr0foFoDvrAp?= =?iso-8859-1?Q?rqfNYA/U4IECNKxgWkFCewQ+GiLdz7k1YY49OEjHktjU3cBZWEW+5vHEgF?= =?iso-8859-1?Q?jkcTjd6A7GBndLjTyX45Cm6GoO3xegH4o7rQvvgAPMiYEM29Y9Yr5lbZdw?= =?iso-8859-1?Q?axEvZfbLCHDNpPaEzaMyslbrAr2cOAo/nfNqL4t3SqyjoBHPeMZOSKVA3J?= =?iso-8859-1?Q?1ujNZYsyFG/dB24bjZw8neNLeTkNuU9nbic1ZJYAepHeiSaZEsSHStKke+?= =?iso-8859-1?Q?803qoF7Cvt/l1X196SOF44q58hMLBinx5JqIqfXfX8YECCt/ZoXzXpwC5x?= =?iso-8859-1?Q?vZGClBMzLZoPYc/Hf2BMS7EXnas4yPqp7nEkvRJxW8r0Fm3aDgCbTaFyZe?= =?iso-8859-1?Q?VgH5Nq4huoI53dyJH6qGT4zcS0jQ8W781jyiEbBFMMg8PHUV5rWoYPCsRg?= =?iso-8859-1?Q?Luu66KfVr+N6vNI2DflwxyriRYM289qgue6yO/x+SvYReI90snw4bBEgvc?= =?iso-8859-1?Q?PBTkHDwXUDVhZPIwy/8OM/oTePhYbo33ANj6SPl5fQ+hcVnq3UNNX1fKz3?= =?iso-8859-1?Q?UVB8JX57yfYYDfSMKTnzZOsfxWcMBrfe4ClDs0IlFRiV81SrT+JpcRF7Nq?= =?iso-8859-1?Q?+sHj+ahSw5NBknMZRF+XK2L0UcNUwmFV5wXWJYGfBzGWbdnc+FxHOntL+Q?= =?iso-8859-1?Q?xntsb970K5occt7cxSzVAcsYYDXznWz8NHJIdlAatNEqqqmHUrHdeO3U9B?= =?iso-8859-1?Q?FfmN21zrv5ND1d9ciC6jOExGCYGsyxpUcf/7+o3ExM32yV0mGTZI3MCCNK?= =?iso-8859-1?Q?3bzE0K5wGWjFLSBTlEgNez4ruXD3yPsgnOaYDPhZbu4Qtdy3ss6oueElo8?= =?iso-8859-1?Q?i/T8MV4Ic79RaH9l5dEzMPwb+/vungb5mmAi8UR5tSVwjFTfQbaqZjO/p2?= =?iso-8859-1?Q?TgktRSqaJhkydm4bignxl2iC1HNhDY9qY8CfiLV39FO7oEU4487YfmUF21?= =?iso-8859-1?Q?F5/Efxkuk5eWtAGfqXyze4B3Nr2ggRRYbS3HYrcIXyDPm2Ovd8KicVBwGv?= =?iso-8859-1?Q?ZBjFVGZYXrx46Ufw/cWKy3v3M9k+5ysm+ohWcz9ZGui7c7eGdQBbp4pZ1N?= =?iso-8859-1?Q?AG8NW2X1dazjhiOgDuq/no2U0/Zp3yVJRx4EnzvlQhArlGRDsqfwCWGTWG?= =?iso-8859-1?Q?3JYEA25g8fujDi8SaYx9pJmOMtmhmZ2ACLPImW53YOivQmIGsuuHjgcTaf?= =?iso-8859-1?Q?3vJyVeJkySgrSBvTEmMOv5luMx/IU4AxP0Syd/aFdT4wCCetw6QwcCng?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a44af19d-f8d8-4012-ff4a-08dd0ecf9e46 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2024 10:38:23.4349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mfgTt7DRlwdR9MyHHg8icb7Lwsw04+akGqChNf/RgTsRfCTdDtzCqHlv5YIaSw5nVFR8iuoSASrPS1XP8t0CBBQOjSgq7I3hYHQAaKixl/E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7597 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote: > Hi. > > Consider the following situation: > > An application does > > rte_event_eth_tx_adapter_enqueue() > > and due to back-pressure or some other reason not all events/packets could > be enqueued, and a count lower than the nb_events input parameter is > returned. > > The API says that "/../ the remaining events at the end of ev[] are not > consumed and the caller has to take care of them /../". > > May an event device rearrange the ev array so that any enqueue failures are > put last in the ev array? > > In other words: does the "at the end of ev[]" mean "at the end of ev[] as > the call has completed", or is the event array supposed to be untouched, and > thus the same events are at the end both before and after the call. > > The ev array pointer is not const, so from that perspective it may be > modified. > > This situation may occur for example the bonding driver is used under the > hood. The bonding driver does this kind of rearrangements on the ethdev > level. > Interesting question. I tend to think that we should not proclude this reordering, as it should allow e.g an eventdev which is short on space to selectively enqueue only the high priority events. Only caveat is that if we do allow the reordering we clarify the documentation to explicitly state that it is allowed. /Bruce