From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 408E345DB6; Wed, 27 Nov 2024 12:43:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ABAF402C2; Wed, 27 Nov 2024 12:43:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id D6D8F402BC for ; Wed, 27 Nov 2024 12:43:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732707794; x=1764243794; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=bhwxfuHLYYynJ4aK4WPRXssOv5sDaep2T58eHiowehI=; b=c7+RbQ3S1NBbEF0k560v5RJ8F/T+vP+KMb0gIDKfOp9qYDQ6fQqnC1Ll buu+SuFyRrWLw5MTWaKjvKv3PbqXePkh0X0ulkrKlwrPEM1jZe6eOJ2f+ zYRbIIAuzW5B77ZoDJ7MXE9+AeUBZyYLvlXuljoNde7hpKzVGRWYV8hHV yUQI02UEIvjPLVkYzz42/lLWRbiyfXPMiIzJxln1DwLgAvrXsqW5HbgXq DOa9W4nNIM0Vc63glzb9KcM+0mTebQBoYA3dDBeRZbpHVYoL4yGcLQaql MxTI3pIDKhzewsCvTOScgR4TPlBwA4N5tMiTGpWC2L7b1ibvF0gfz+Xou w==; X-CSE-ConnectionGUID: sm59LseiQnyPUDuBqSiqtA== X-CSE-MsgGUID: aKGWjlpPRiiGm1QSis+URw== X-IronPort-AV: E=McAfee;i="6700,10204,11268"; a="20503472" X-IronPort-AV: E=Sophos;i="6.12,189,1728975600"; d="scan'208";a="20503472" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2024 03:43:13 -0800 X-CSE-ConnectionGUID: NuOc0iTzRN69WMcDTUtrRw== X-CSE-MsgGUID: xhm3hGI5TRCLdmkeW1eLAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,189,1728975600"; d="scan'208";a="122883843" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Nov 2024 03:43:13 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 27 Nov 2024 03:43:12 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 27 Nov 2024 03:43:12 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 27 Nov 2024 03:43:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iejs1oEHhjdL1uwgDEfHEG04mvNDrSthjGyYu27sLR6+UhqNE1arUk2EAfpzJGXv+A5EoqGc+/3cMZe7StPogqyL4gdi+H0BF9kig3ZVyd23JMcqffbGv3OkSIboheNaIO54ZtdwYv6x7xOeurLs3wVHXWRTXwraHhcgYR8MpwEsZqEDS0tDDlAwfdxeYf+HpXBLevyv1YOdLp8wUSUzEGn6TGkL4crhvkV90mOQYPJcHi/CO8v1Ec1KY7AhbrnPDoofITyNebRWYLRzYVX/eLFE/zKRdE1TDHNCP0YCVVFkydeA3qZ+5FKd/BZ3jSsYiFK1Ofr/ciRSyuA4u2dCng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gbzTLO8jUHkgCYzicjigEzUAdxgaPPbZRQ3WesmaOeU=; b=mVUJV8AbRnfI7fO+ByrmluEetfU5bwfkcT5w1AT0LgS2QJSvpvL7SmNHGTRnrOTtq/MOZvImGHw2m7llO4XoqYswjcI/UNToHTT8hHbj227tmnRbR9Q7EimD+3qrLFoElcVv940f9NHxovYQq7qg2PNQ135QEoKS7fII42Ymvf3SBzWE+RpXcxlv3pFc+lN1ikOLUkvNyofJzcdN/+PSh8E04ue8ILR1RMkrRugqSRTT2ZR7Xj/SCgumuI0U7ANP1Itke5ZuakzfA1SKicAeLHOma3DQ4EkaHQRioRkohXKDXfCDYbBDpGNjNxa/XFkOd3nlbX3FNIQU/oeU2WrncQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4603.namprd11.prod.outlook.com (2603:10b6:303:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.13; Wed, 27 Nov 2024 11:43:04 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 27 Nov 2024 11:43:04 +0000 Date: Wed, 27 Nov 2024 11:42:58 +0000 From: Bruce Richardson To: David Marchand CC: , , Konstantin Ananyev Subject: Re: [RFC 5/6] build: install indirect headers to a dedicated directory Message-ID: References: <20241127112617.1331125-1-david.marchand@redhat.com> <20241127112617.1331125-6-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241127112617.1331125-6-david.marchand@redhat.com> X-ClientProxiedBy: DUZP191CA0066.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4603:EE_ X-MS-Office365-Filtering-Correlation-Id: ba86987f-ba37-41c3-7a55-08dd0ed8a73e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9rx29dMUTMx1oJ0HShAbwBCryYmz85TENgArPV0I5NOEbiojTJ0glMhMi5s9?= =?us-ascii?Q?xCSP9OzVDoCAy6tXOIE3NBJUvgOL6oMCtIcumdVm4QZ7yhVew3uMKyuw6NjV?= =?us-ascii?Q?zzSxZdl08enYX0uJtBa5MH4HfEczF1redSVZqlNWLEhdgyfVWYMv+rgwSQbC?= =?us-ascii?Q?/guRwXPDUFSVVahwkecnsYvUwpOw0Kc//8u5gKpHk/BDPJHY4/Tb5w0BF3Xf?= =?us-ascii?Q?WizJQ6eQGNt9DuTzHahgPB0S+iEoYGG5W4B5WXQ+3gazNpV0Ae2JFMrx3S7K?= =?us-ascii?Q?HiPmi0ZV2MjBcNO2W/7y841K9p2CPMuP4ggWMai+tVJ7l3X770TopGtxyjQp?= =?us-ascii?Q?cZHMU1pLCWk4CaNTH+b3OLsPpYDLTrrBKLtN1LelnDTAIbk1bp1bcq4Zc4BJ?= =?us-ascii?Q?SsmyWeqCbzfATJFc6UkNC6bQd1a54J8MC2zLdLOFBo8bCx7eWtZ/mcGeM8Zt?= =?us-ascii?Q?Mdcw3Y+/dCQz96yn74KOUq9QtTwcbzfwNMJzNSzu82NVQ67Ai+/4Jjem2nl7?= =?us-ascii?Q?F2EgXyaN3EqgwiBZKWe7NyGO9p9h/hJgdGT3JDaerJqc+6USP/O9l5sgGs1k?= =?us-ascii?Q?HXePbRU4XPW4Tz/R2n6aFlsfz6o6jnLYCTRQqbIbJSnJEx12py6CBwAftBcO?= =?us-ascii?Q?yx2cvJfNzf4Z2BF0TdbOHP2JGDoq9Y3g2OHaPMIqKyCq3py0L6mNW8CI6woQ?= =?us-ascii?Q?Eh53uiR4VC6gEyFyYBkwD7YVaXT+V5Q2RzK3vyYRqM8kbXJ71hv0icefwV37?= =?us-ascii?Q?agRwzjeg+P+oEZLG8itN+dcv8Gsth1k4EGWLLaa4OqIaiLve6oxAMGGG/FOn?= =?us-ascii?Q?NH7lB4ZXNGf5BVRQCYBHkkwiehMDFcjLL8pVRFzPR/RfRuVBRQ8AMjJClG+J?= =?us-ascii?Q?4KHAxzUpraPrRIf/EbWlkG8HsSg4IMLl+5d0ZYvwP3jHCCVFKA2zXIs5hFvb?= =?us-ascii?Q?bDD/XWxEPYD7oh6gY5TE/rNeCLPH4/XV0jvmbhEz6ZpBRwYmVSoZY5nkRrP3?= =?us-ascii?Q?8Kr7Hhw8FU8wTqDI2DfiU+wPYgcF4yJnpx9b0I4pp3wjZwFWdK3M0NXbkMi6?= =?us-ascii?Q?YxHitSMb5nhuDmVubzPcGGEZB+y3qWitdvIdddCuWn/loU8cQX5nm6hDWXvs?= =?us-ascii?Q?z3oa+TNCjbgSihEAOppFNFNYNCzF6VWY3dNFivjcwGIwHRRKXXHb3mbnff0H?= =?us-ascii?Q?hrjOc3sTp5qjLubfOXwstec9AbaRW5bVUP/xri0n8J2/yvMdSjdImz6lZrKN?= =?us-ascii?Q?rtrn4FkMFltuK+wWXnWpqUX8K9VnVWW4RqCCbD8yKgRCemOr2+uwIXhOS71g?= =?us-ascii?Q?2kPnTWZN1sabge3ehbNi5+lf84RpojweKdM7H8FQkHLXiQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pkDalUT33vkMszZmocp30/lSK06pJABxNA4wmXoN1g69pEE732WLIJdJGVOJ?= =?us-ascii?Q?3FmEkDAbEeAS5wggfN5aN1ZOEbGRCjkpisJF4Tj2amoR8pcbqoeS7F4p5+dR?= =?us-ascii?Q?T7/6KH8l1bZlyF1djNyInnZ66EE5+RC0cMqzz8mR0scPeo8QvljNUwgPzS+x?= =?us-ascii?Q?uDfcExQmTYxPKPCO1YEF4lrWJGpGQk8euT5yNjfWJr8f7w65Da3e18EaALrd?= =?us-ascii?Q?EMmLVczqm3hi6D0cEYCY8EqRE9J3E5fQ9w042glplCI3khWc4j6SMkqw0PJX?= =?us-ascii?Q?V9GwwHNJhakI6aD7HI54TKx+cIoPJyA6G1vTPfl8eqoI0Zu2ZN4ful3IWa6D?= =?us-ascii?Q?WAu4KlMLVruF8wxTWBpNZ4KlYGTwjau8y+3VsdLdGNdtEa+uc4EMB0l87KwZ?= =?us-ascii?Q?na87OL2OAGTSPZKJVpUZ85xIUSeTbOdVAMgFdokw0T9GplgvJQ1NuUjrddLL?= =?us-ascii?Q?da84yRpriPDCoEMFnzPUsOaVophiwa8JxzVDJipegocB8cFUdn7h6DdR7OF1?= =?us-ascii?Q?8bhXqGqK/Ntp3VxZ3ipT6bU4Z1PxRRPDq/YHiAslFrG/YVl6CoyT6GEaC7CH?= =?us-ascii?Q?hWxf/WxLiCK9HWTyc0KjrxA+LUVMZbql+ghzPsCrQfNklLVU4j8rBu7iyQwM?= =?us-ascii?Q?nFVlqmfLmFERkyihBXECDYfrcwOC2ScXvQ411ONvIgDbQZpRlRdgrq93LKbT?= =?us-ascii?Q?8ZfthELHxrE4zel8eXe6jprmW/SZsC5HN8DIawY0R2QWQtwuNJD3KQOGe4Ua?= =?us-ascii?Q?ytgFc5oKEXQH2eKJDgT4u9QhjwJMjIB1dST48P939BdC19YKyceOFi5kcHqL?= =?us-ascii?Q?dthzKUYZKHMxJmB2IBTnDdD86u5+2G8wHj2PPYPHN3IUXw3k1aYKl98eZkyy?= =?us-ascii?Q?zblJA8F7DIficd/Zcb8qR2N9zReOVtqY1rxwh1EbgvH/uHOGEi5IMvUoAdiY?= =?us-ascii?Q?hupAeEJYXlVH8eTXy2GgUUz/HIbwl5jd6WbZPJnD7E75gzg8GkeHCviRsB5e?= =?us-ascii?Q?4QX0WPRGkmRLuKKjFnfbDpoSQn9NOrKEPlzP6s3eogIgvKF5XhOXaRLjHO1b?= =?us-ascii?Q?pbw9GKKg/O/6uysV8NMpo9SubdktMSSVXZicZ07ak5dV6MMmM5RgOWGGrjbL?= =?us-ascii?Q?reg/enZdW00zOSeBzH5emFTTPHvp7VSmGTdES7hx8xP4hlxwfcD+lQ01jCRh?= =?us-ascii?Q?7vvbT3y2Zl9f6eO81FuoM/SB9F11Hlod0WBmvjIMJMaJGbg3bb6hRTHqYJVq?= =?us-ascii?Q?SQqsCzxW8Ead735NeEomOykmJoP3qBFZR4Numk2yNG+KBBkZ3FCTwSkQM2gO?= =?us-ascii?Q?6VYRKeAAEQzKTP4JSqFYuRTgIZDNdC+abwz4eNq0CoSzeXsllhzFOeZ2w8K8?= =?us-ascii?Q?VBnUZDie5XYqUmUR7LflDInEJSu96fRV+mtG8/1JLKscRGCjDKy098tiRasq?= =?us-ascii?Q?AZ+OfWxggs2N1zpdgnctoQLtqDDcjO/5luJ2BkljMKZ8tE9PuUi4BvrFYnO4?= =?us-ascii?Q?mguhKPRrUCGgxfez95pMJqYa2b0a2T8g6yt44vmN22UiywZbDdJbDIJtCBa1?= =?us-ascii?Q?l3roFW2agGzzfJtnlOBKl+rQheBVr/hRE5Ijq1of0QrtCsP6eAMjpToySlcC?= =?us-ascii?Q?iQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ba86987f-ba37-41c3-7a55-08dd0ed8a73e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2024 11:43:03.9287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rbPnEG9/znXA7glfxiW+JjK3efKi2Ph6fNNUUmRn+LuD8rmLpRq35ism9lmf9FaIVgrLvkVzT5mrDymfD/c2fSL/5l7rbFWGSM8+McsBvY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 27, 2024 at 12:26:15PM +0100, David Marchand wrote: > The headers check currently skips "indirect" headers as instrusted via > the indirect_headers meson variable. > > This headers check has some limitation that will be addressed in a next > change by inspected all exported headers. > However, exported headers lack the information about "indirect" quality. > > Separate "indirect" headers by exporting them in a internal/ sub directory. > This also makes it more obvious which headers are not to be directly used > by an application. > > Signed-off-by: David Marchand > --- > buildtools/pkg-config/meson.build | 8 +++++++- > lib/eal/x86/include/meson.build | 3 ++- > lib/meson.build | 2 +- > 3 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build > index b36add17e3..809706fe3e 100644 > --- a/buildtools/pkg-config/meson.build > +++ b/buildtools/pkg-config/meson.build > @@ -27,12 +27,18 @@ endif > # are skipped in the case of static linkage thanks to the flag --as-needed. > > > +subdirs = [ '.', 'internal' ] > +if get_option('include_subdir_arch') != '' > + subdirs = [ subdirs, get_option('include_subdir_arch') ] > + subdirs = [ subdirs, join_paths(get_option('include_subdir_arch'), 'internal')] minor nit, I tend to prefer using "+=" rather than relying on flattening to extend the arrays. > +endif > + > pkg.generate(name: 'dpdk-libs', > filebase: 'libdpdk-libs', > description: '''Internal-only DPDK pkgconfig file. Not for direct use. > Use libdpdk.pc instead of this file to query DPDK compile/link arguments''', > version: meson.project_version(), > - subdirs: [get_option('include_subdir_arch'), '.'], > + subdirs: subdirs, > extra_cflags: pkg_extra_cflags, > libraries: ['-Wl,--as-needed'] + dpdk_libraries, > libraries_private: dpdk_extra_ldflags) > diff --git a/lib/eal/x86/include/meson.build b/lib/eal/x86/include/meson.build > index 52d2f8e969..a100330208 100644 > --- a/lib/eal/x86/include/meson.build > +++ b/lib/eal/x86/include/meson.build > @@ -22,5 +22,6 @@ arch_indirect_headers = files( > 'rte_byteorder_32.h', > 'rte_byteorder_64.h', > ) > -install_headers(arch_headers + arch_indirect_headers, subdir: get_option('include_subdir_arch')) > +install_headers(arch_headers, subdir: get_option('include_subdir_arch')) > +install_headers(arch_indirect_headers, subdir: join_paths(get_option('include_subdir_arch'), 'internal')) > dpdk_chkinc_headers += arch_headers > diff --git a/lib/meson.build b/lib/meson.build > index ce92cb5537..78ada7782e 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -202,7 +202,7 @@ foreach l:libraries > dpdk_libs_enabled += name > dpdk_conf.set('RTE_LIB_' + name.to_upper(), 1) > install_headers(headers) > - install_headers(indirect_headers) > + install_headers(indirect_headers, subdir: 'internal') > if get_option('enable_driver_sdk') > install_headers(driver_sdk_headers) > endif > -- > 2.47.0 >