From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA04245E4C; Fri, 13 Dec 2024 12:15:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6820F402BB; Fri, 13 Dec 2024 12:15:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 97BB940269 for ; Fri, 13 Dec 2024 12:15:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734088514; x=1765624514; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mXMPLxQ34mFpp6WTzU1SId6WU5Y2qecYcJKRRbcWqCg=; b=MHFp2VJSUj8zyRxDJVBDeNC76XUTijHiDVG06syMhfpKs9UWMqFOcrm3 YxMA1GYHzfDZv/NLlO1gV5BwNXtw07B55s1GVs8/pL4c+y3sOWaWDl8c5 s6rBlLxj4w2A+CbxaNr1oAKPyiWspt6txXgd3PZ80XUmzhwEsqoJIhB03 7zOL6Meib6tq7q7qtUwPQ29owmEb4XNBuWBgpF8uBwuJi+4Y9r1wbox3L Qv+m1PsAZlOCCaIHJ4s/2d5u/lE22k1IOpIU7O8Ck6c34q2gCujRaPKh9 PQ7pGBCGrihvIyI7CqOZOIeyi3VkpsUFAW7JtVmn3gf3PyVJ0KbRskMh2 Q==; X-CSE-ConnectionGUID: 3sMY6RCaTwKsuhlZikQmVw== X-CSE-MsgGUID: 74ljVrs0Sdu76TnZzNJO1Q== X-IronPort-AV: E=McAfee;i="6700,10204,11284"; a="38315088" X-IronPort-AV: E=Sophos;i="6.12,231,1728975600"; d="scan'208";a="38315088" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2024 03:15:12 -0800 X-CSE-ConnectionGUID: RyPBBLdCSMG+dKZVrghYSg== X-CSE-MsgGUID: KQfMqFqfQ8+Jjzs+FWfWKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,231,1728975600"; d="scan'208";a="101357414" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2024 03:15:12 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 13 Dec 2024 03:15:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 13 Dec 2024 03:15:11 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 13 Dec 2024 03:15:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=suQYV+gOiEgDWDc3yPUcklCr4SomehDqri5egAzGZLrYA3qsvi1S+FDbbp6k9sFwylNyXh4m/YlqC5LZtE5xV3qaDmoFQ8REF57saEo41UNnvUarmDyw3G/ygcyQEEQXznurKJ2fDJY0EFJwraBmFRdnmPKfwAGRoUu88cu3zQmpPkR1XPUQChobDP0C6CPPWbDO8Q20S+4mvrFzN2vnalBQ6BCfRehQlPUKKlj+cWILLnhslwrGZW9CgQiMVFkgj6yusJGfA7aXnGZvEayhrgjL4yP0g8cRdLO3rRMh7+3qtPZWtaP7/Ftu5eNYOg5wPFERR5hJkovdhjnZKoMOcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KLKA57l/zFl4ig+Ub46KFV6yCgfQJL7ZEi4jKPquEHQ=; b=HsFgNyxpAMxXVHuJLWt74JTU9bIwCPJQZ8CoE86w3t0rhwNUngF2HZpMu5HZ/EEGC+QOprtDBH+yC+9dRoBKsjdIP6aMYuGQaUMVvstxW0PbdUwgUT/4TvhqiuTkbwxs4vVEYR/bERoAGg/MNxr/dTNTtWXbK4wnY8gYNAhJ/4ZY/TJwDR/aikEM6CEtoXaFbRD/ZbsmuyVkUuq3rZIPUYMrsclQ0/qXU7CdsxYK8YrltfnkUhNa+Y1zUZoz/l84+rkyaW//Pwf7onpmjzcWlMx0uwWfIblmsuO4vbX0KfhFOZTaojCQJPH4jQO0t24dGvo7+YIrbx1p1ajOp1s0Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8211.namprd11.prod.outlook.com (2603:10b6:610:15f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.16; Fri, 13 Dec 2024 11:15:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 13 Dec 2024 11:15:06 +0000 Date: Fri, 13 Dec 2024 11:14:58 +0000 From: Bruce Richardson To: David Marchand CC: , , Long Li , "Wei Hu" , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Hemant Agrawal , Sachin Saxena , "Vladimir Medvedkin" , Ian Stokes , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Jakub Palider , Tomasz Duszynski , Gagandeep Singh , Jingjing Wu , Stephen Hemminger , "Akhil Goyal" , Haiyue Wang , Jeff Guo , Michael Baum , Jerin Jacob , Shreyansh Jain , Nipun Gupta , Xiaoyun Li Subject: Re: [PATCH v2 4/6] drivers: fix exported headers Message-ID: References: <20241127112617.1331125-1-david.marchand@redhat.com> <20241213105010.1527683-1-david.marchand@redhat.com> <20241213105010.1527683-5-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241213105010.1527683-5-david.marchand@redhat.com> X-ClientProxiedBy: DBBPR09CA0024.eurprd09.prod.outlook.com (2603:10a6:10:c0::36) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8211:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bc7be33-6cfa-4d62-3aa8-08dd1b67661f X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|7416014|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?81ktJ/dTPf5UMf30Gd4ROOML39b5pGON9A5kZpJgrIQKBKSKBguNm7bHxwgO?= =?us-ascii?Q?cSh7oKGeRiSweYy7oEh0UUQMtNuEm2DuluxDmOTEP8XC2yu+aY43zIK9LKQQ?= =?us-ascii?Q?ogNUzcfvxVWGUu1zOHeuqgsQhzraE6L7Pqblx9VuEbBRcPIMWSZXbqsIi1rE?= =?us-ascii?Q?cu7pe4khvC421j/W/sYJvE7D3winUWXIFVxOLCUHpTNppiGR0Nj5TlHQZio7?= =?us-ascii?Q?39XnJRZpTInP6h0awNFZKLtL0czIHlSMGE65Dz1O7/5FUcyZcSSfcRK+UQFH?= =?us-ascii?Q?z3pm55CpKf3HygLuJRULnOVGerdJ5VaCtUlB+ZFkBrPx7zqOr5NMJ9DqFIIX?= =?us-ascii?Q?xcPx3TZipZ2+o1kInghJTSLPFZcK1OKomkdFbJje0tMnba5W5Roy4iH55gCW?= =?us-ascii?Q?ceDk2l7jCp29MRO5DNobtvnOd59o3sO4q94Wy9uk/ycPOt3FBHeHnW00SZc6?= =?us-ascii?Q?YXgerq3ef9VKLwrqn4pBG2cLx7jerlQF8G7cA1PnDqyQkFFMkdXi/mC9Laa2?= =?us-ascii?Q?XcR198EM7aJTzj26ayzHNQT1u2vkdIEpksWqCcfjkSZaDlantGGkmp0Nm6ER?= =?us-ascii?Q?LC0DkgPLqYY1sLUqNZE1efpYeZl/lWXHwxXoug4/iUo7ZNgXyWku+2/TCncW?= =?us-ascii?Q?v59cC0bLVvmL2sCeVnGVEVOetad9YD2PXGMkjHfhGbBbVkrsoaYz31YPR6pL?= =?us-ascii?Q?N03AkdbA9l6dN7BxLHxGaxEggEaNVJ70nGArvuZer5WCrISR7G6XjwSiwCrl?= =?us-ascii?Q?3o4etrwAi4U+n4MLCzsbfmpxn643bIAL2U+lDRU8e+xyBZE5zIXj1CIEQhpS?= =?us-ascii?Q?qXfc6LY9Fa8WreiEYtpiH0+g/ae2B0T3Y+qRcG+5+x61U6B7dfsz7q3fVZrp?= =?us-ascii?Q?z0nkAKyYq+8gJlVPTdH8U/RIMxtLaZnIpe2rQGgI8Y6BZ0qNEveO4ISiI23B?= =?us-ascii?Q?08+40ys1rGj9k0LjcsLL7bCevlWaG7CNJG0Vj2jx2l/aznKtMCZZbw/YP2SC?= =?us-ascii?Q?0EvBucDgGbwQbtQeAmIaUnosu6JZdiBWZMu4QSWIuK9pKJqjbXaM9fnMeebA?= =?us-ascii?Q?yd5tWpJjXJklnoILgNtj4LyajHSNgqxFCEJMhww/a9DTO9y8iH/1UXs2uw2M?= =?us-ascii?Q?DodyOhokGfX2jZsOb7mEzluHhnc13sv3Vc4SJoE12tA8lsrizNXkKcQSBU/I?= =?us-ascii?Q?V292UjAsODostZAs5JMB2d70KMDUR6Lwwi8FKfNwmjZwd9ONSBGU+7Y6Hg1M?= =?us-ascii?Q?HlJtbIwxHv/Elhzzqd4nljBOEYirgMKik6m2lxj8Wy/McD7NXNxPHSqX1nxe?= =?us-ascii?Q?rSvFkDn3PBJwwmweKDR/XHmA86X3v8R72XAJ8r3N3EoEjQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(7416014)(376014)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HbXhxlQDqgH/Y/XcaS8UfBJdL0LmQllQjnC1YKzqOn8I/Cdgu8x/xF283NR4?= =?us-ascii?Q?x/BSg2vMTR/wbCKKwYT8d3pQCW9W17M3ByKetvR01fN4ciHsnW0YLvcNrT9c?= =?us-ascii?Q?93DcztTk53GOfOC3dlaFMo3a7hIg4gT12Zyu0PD+n+T5Amyn+7G1OL642wy7?= =?us-ascii?Q?ffFL4FEORuJtdusuUGDBxGCH3r5EukvQI9tCNcKwFXuLqAmUqd9b6fPnxiK9?= =?us-ascii?Q?bnD6UJSGuiMPC6aQLrnB33tQTmzoadHiHxMHGUpv/dY+xnB7Jjtl1m/YXRPv?= =?us-ascii?Q?qhH7vZrkd9mi9aHH+eHldzmqWVI9UFRM4L8VLuAaQTvNCasXDpBZ7mwMKafQ?= =?us-ascii?Q?VqzscNQrPeYSS8S/uYzfK5sgX3j2kLgc8WOrMUD4h2z0JU7vFoC90t/WeTIP?= =?us-ascii?Q?K5hp36IOmGnisCWZL91WI0Js5a12WdFz5xPoK+dqGBcmEgn3P1I1cd7eSJj9?= =?us-ascii?Q?IjbwZlabztocwuAd3QmnjNLjiVFnzXr5XQQhPm2gRW6htJJIa9VUVlQkfwww?= =?us-ascii?Q?n0BWfC03T7NoxgYpqbiIscjvfyeQRWiaD5Avn5W4noKBxs3W9vIrX+yqfUbj?= =?us-ascii?Q?jRN+xBkqmaaxoZMk7sHFfua2Y4nQJOY0pfV/9IJ+6ynRVpiE4jQNxoD5lHnJ?= =?us-ascii?Q?WTrTWQLIRDGOCfrKe4G3yWFIiB5KSj4okfU3XbUcGimGbwu8F4HXK8MwyvtX?= =?us-ascii?Q?idhK/7KE+Z73KwGoKFX9NsV14smVHnQnxCIsGsWwP0If10YjfJ/SlKljgrrd?= =?us-ascii?Q?lmW22AdDvGtZGPKKMWjZwPNSSaHiKCWL7ltrsxqyGkz/GbVX6fSvJvmONRMj?= =?us-ascii?Q?zuLpd0Ob53CkMvnTbfWaRkJgdPHfLM+tNZssDd8m15yPmKNr9vyowgynJh28?= =?us-ascii?Q?VFeqia5inbuSSZ7yHK9lxEWKSksQQyXuVckzQ2Btx5RMaFVsIROzLZMvDuMm?= =?us-ascii?Q?E1qIb+NbY5Y0Qd3jXcyVXR7xbDdNwV7K4KVL5sGuaJori71nOojqXuEcowI/?= =?us-ascii?Q?EkBCQAtveEZlkaheIkzZj+3AgxHphnpgnSOUpSgpFeMGOrdPuuPrmPE20wZT?= =?us-ascii?Q?kJSLAoiUdy+p8JvzPct/bjwaFwuyICZhcIo+8xo/HNarpGR8mKCyA86wQccd?= =?us-ascii?Q?7Y9NiKZFkaaghkXXr67dUePvLY/mVtiYnsmyRnSqBrpoh6bvKD8PxLUkIyIH?= =?us-ascii?Q?A3quWuJXYrYbpn0RTyBtrDG2TwRt/oxjnFZodjX/7OfjSglDSBytXxXg9Xm/?= =?us-ascii?Q?a6Rk/6VoT/gLZzHoetE0/tmSF1GpiFiqKktlhOJjBjSvO6zdAB495Q3q2p4N?= =?us-ascii?Q?Pe8PJNBRoCAl2us1neQtsUGXYfuLYDAxf5kBTk6N9p1HipEi3doH2nsF2m/o?= =?us-ascii?Q?Wce4FYpPK0dgRSuVgn7tlldWz7oKrEkm9JmpaFlMO32GFU0nDTVKH01Td0H5?= =?us-ascii?Q?vVrrFvbWSWn8PeWqLZzp9iYYdKbODZeQ4ykoFsTfsgXKAU5RbodGGIdi2XY2?= =?us-ascii?Q?jinIypnak0pZukSnm490uHVzRp4gj0DFgf3A+YPk0L1FYdYV5tSDLZW2OfNX?= =?us-ascii?Q?pOT4RxONMROehI3tcXnpo1vQ1p6EfgkZur4KhugTN2KXxVlZIIUwgq2FBHtY?= =?us-ascii?Q?ow=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc7be33-6cfa-4d62-3aa8-08dd1b67661f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2024 11:15:06.7012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nCEmd7AULbSE/8NZHfLoU8coQOn3YRzGGR/ciXm7bKvfw2iKAmmsP24/K41I1Y93OvbP31N50160BNRUS+gPmgo2HYbtZ2RWFNR8epacCJA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8211 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 13, 2024 at 11:50:08AM +0100, David Marchand wrote: > Those headers could not be included individually as they were not > including their dependencies, or were subject to some build warnings. > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Fixes: 5b2a1a02dcaf ("crypto/cnxk: fix experimental version for PMD API") > Fixes: e5abbeeeefa5 ("crypto/cnxk: add PMD API for getting CPTR") > Fixes: 3ca607402c4d ("crypto/cnxk: add PMD API to flush CTX") > Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") > Fixes: 23f627e0ed28 ("net/mlx5: add flow sync API") > Fixes: f5177bdc8b76 ("net/mlx5: add GENEVE TLV options parser API") > Fixes: 7cf197684589 ("raw/cnxk_bphy: support interrupt init and cleanup") > Fixes: 633dae698070 ("raw/cnxk_gpio: add standard GPIO operations") > Fixes: 53c71586c789 ("raw/dpaa2_cmdif: support enqueue/dequeue operations") > Fixes: c39d1e082a4b ("raw/ntb: setup queues") > > Signed-off-by: David Marchand Generally LGTM, some queries inline below. /Bruce > --- > drivers/bus/vmbus/rte_vmbus_reg.h | 6 ++++++ > drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 4 ++++ > drivers/net/dpaa/rte_pmd_dpaa.h | 2 ++ > drivers/net/iavf/rte_pmd_iavf.h | 6 ++++++ > drivers/net/mlx5/rte_pmd_mlx5.h | 3 +++ > drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 16 ++++++++++++++++ > drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 3 +++ > drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h | 2 ++ > drivers/raw/ntb/rte_pmd_ntb.h | 2 ++ > 9 files changed, 44 insertions(+) > > diff --git a/drivers/bus/vmbus/rte_vmbus_reg.h b/drivers/bus/vmbus/rte_vmbus_reg.h > index e3299aa871..95c8eb29b4 100644 > --- a/drivers/bus/vmbus/rte_vmbus_reg.h > +++ b/drivers/bus/vmbus/rte_vmbus_reg.h > @@ -6,6 +6,12 @@ > #ifndef _VMBUS_REG_H_ > #define _VMBUS_REG_H_ > > +#include > + > +#include > +#include > +#include > + > /* > * Hyper-V SynIC message format. > */ > diff --git a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h b/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h > index 02278605a2..2bb0ff9e95 100644 > --- a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h > +++ b/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h > @@ -11,8 +11,12 @@ > #ifndef _PMD_CNXK_CRYPTO_H_ > #define _PMD_CNXK_CRYPTO_H_ > > +#include > #include > > +#include > +#include > + > /* Forward declarations */ > > /** > diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd_dpaa.h > index ec45633ba2..0a57e2097a 100644 > --- a/drivers/net/dpaa/rte_pmd_dpaa.h > +++ b/drivers/net/dpaa/rte_pmd_dpaa.h > @@ -5,6 +5,8 @@ > #ifndef _PMD_DPAA_H_ > #define _PMD_DPAA_H_ > > +#include > + > /** > * @file rte_pmd_dpaa.h > * > diff --git a/drivers/net/iavf/rte_pmd_iavf.h b/drivers/net/iavf/rte_pmd_iavf.h > index 56d453fc4c..04b86a5dd7 100644 > --- a/drivers/net/iavf/rte_pmd_iavf.h > +++ b/drivers/net/iavf/rte_pmd_iavf.h > @@ -15,6 +15,7 @@ > */ > > #include > + > #include > #include > #include > @@ -184,6 +185,7 @@ __rte_experimental > static inline void > rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m) > { > +#ifdef ALLOW_EXPERIMENTAL_API > union rte_pmd_ifd_proto_xtr_metadata data; > > if (!rte_pmd_ifd_dynf_proto_xtr_metadata_avail()) > @@ -243,6 +245,10 @@ rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m) > else if (m->ol_flags & RTE_IAVF_PKT_RX_DYNF_PROTO_XTR_IP_OFFSET) > printf(" - Flexible descriptor's Extraction: ip_offset=%u", > data.ip_ofs); > +#else > + RTE_SET_USED(m); > + RTE_VERIFY(false); Is panicking the behaviour we want here? Seems rather severe, no? > +#endif > } > > #ifdef __cplusplus > diff --git a/drivers/net/mlx5/rte_pmd_mlx5.h b/drivers/net/mlx5/rte_pmd_mlx5.h > index fdd2f65888..f2c6aebe0b 100644 > --- a/drivers/net/mlx5/rte_pmd_mlx5.h > +++ b/drivers/net/mlx5/rte_pmd_mlx5.h > @@ -5,6 +5,9 @@ > #ifndef RTE_PMD_PRIVATE_MLX5_H_ > #define RTE_PMD_PRIVATE_MLX5_H_ > > +#include > + > +#include > #include > > /** > diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > index f668e6ea82..c200c935ff 100644 > --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > @@ -391,6 +391,7 @@ rte_pmd_bphy_intr_init(uint16_t dev_id) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_IRQ_MSG_TYPE_INIT, > + .data = NULL, > }; > Why is this addition necessary? Is it for C++ compile? > return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg, > @@ -411,6 +412,7 @@ rte_pmd_bphy_intr_fini(uint16_t dev_id) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_IRQ_MSG_TYPE_FINI, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg, > @@ -470,6 +472,9 @@ rte_pmd_bphy_intr_unregister(uint16_t dev_id, int irq_num) > { > struct cnxk_bphy_irq_info info = { > .irq_num = irq_num, > + .handler = NULL, > + .data = NULL, > + .cpu = -1, > }; > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_IRQ_MSG_TYPE_UNREGISTER, > @@ -496,6 +501,7 @@ rte_pmd_bphy_intr_mem_get(uint16_t dev_id, struct cnxk_bphy_mem *mem) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_IRQ_MSG_TYPE_MEM_GET, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg, > @@ -518,6 +524,7 @@ rte_pmd_bphy_npa_pf_func_get(uint16_t dev_id, uint16_t *pf_func) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_MSG_TYPE_NPA_PF_FUNC, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg, > @@ -540,6 +547,7 @@ rte_pmd_bphy_sso_pf_func_get(uint16_t dev_id, uint16_t *pf_func) > { > struct cnxk_bphy_irq_msg msg = { > .type = CNXK_BPHY_MSG_TYPE_SSO_PF_FUNC, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg, > @@ -565,6 +573,7 @@ rte_pmd_bphy_cgx_get_link_info(uint16_t dev_id, uint16_t lmac, > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_GET_LINKINFO, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, info, sizeof(*info)); > @@ -586,6 +595,7 @@ rte_pmd_bphy_cgx_intlbk_disable(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_INTLBK_DISABLE, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -607,6 +617,7 @@ rte_pmd_bphy_cgx_intlbk_enable(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_INTLBK_ENABLE, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -628,6 +639,7 @@ rte_pmd_bphy_cgx_ptp_rx_disable(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_PTP_RX_DISABLE, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -649,6 +661,7 @@ rte_pmd_bphy_cgx_ptp_rx_enable(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_PTP_RX_ENABLE, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -720,6 +733,7 @@ rte_pmd_bphy_cgx_start_rxtx(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_START_RXTX, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -741,6 +755,7 @@ rte_pmd_bphy_cgx_stop_rxtx(uint16_t dev_id, uint16_t lmac) > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_STOP_RXTX, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, NULL, 0); > @@ -765,6 +780,7 @@ rte_pmd_bphy_cgx_get_supported_fec(uint16_t dev_id, uint16_t lmac, > { > struct cnxk_bphy_cgx_msg msg = { > .type = CNXK_BPHY_CGX_MSG_TYPE_GET_SUPPORTED_FEC, > + .data = NULL, > }; > > return __rte_pmd_bphy_enq_deq(dev_id, lmac, &msg, fec, sizeof(*fec)); > diff --git a/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h b/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h > index 80a37be9c7..72d138ab1d 100644 > --- a/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h > +++ b/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h > @@ -261,6 +261,7 @@ rte_pmd_gpio_get_pin_value(uint16_t dev_id, int gpio, int *val) > { > struct cnxk_gpio_msg msg = { > .type = CNXK_GPIO_MSG_TYPE_GET_PIN_VALUE, > + .data = NULL, > }; > > return __rte_pmd_gpio_enq_deq(dev_id, gpio, &msg, val, sizeof(*val)); > @@ -285,6 +286,7 @@ rte_pmd_gpio_get_pin_edge(uint16_t dev_id, int gpio, > { > struct cnxk_gpio_msg msg = { > .type = CNXK_GPIO_MSG_TYPE_GET_PIN_EDGE, > + .data = NULL, > }; > > return __rte_pmd_gpio_enq_deq(dev_id, gpio, &msg, edge, sizeof(*edge)); > @@ -308,6 +310,7 @@ rte_pmd_gpio_get_pin_dir(uint16_t dev_id, int gpio, enum cnxk_gpio_pin_dir *dir) > { > struct cnxk_gpio_msg msg = { > .type = CNXK_GPIO_MSG_TYPE_GET_PIN_DIR, > + .data = NULL, > }; > > return __rte_pmd_gpio_enq_deq(dev_id, gpio, &msg, dir, sizeof(*dir)); > diff --git a/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h b/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > index 483b66eaae..7731fc6363 100644 > --- a/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > +++ b/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > @@ -12,6 +12,8 @@ > * > */ > > +#include > + > #ifdef __cplusplus > extern "C" { > #endif > diff --git a/drivers/raw/ntb/rte_pmd_ntb.h b/drivers/raw/ntb/rte_pmd_ntb.h > index 6591ce7931..76da3be026 100644 > --- a/drivers/raw/ntb/rte_pmd_ntb.h > +++ b/drivers/raw/ntb/rte_pmd_ntb.h > @@ -5,6 +5,8 @@ > #ifndef _RTE_PMD_NTB_H_ > #define _RTE_PMD_NTB_H_ > > +#include > + > /* App needs to set/get these attrs */ > #define NTB_QUEUE_SZ_NAME "queue_size" > #define NTB_QUEUE_NUM_NAME "queue_num" > -- > 2.47.0 >