From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B03AA45FFE; Mon, 6 Jan 2025 11:54:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47C0C4066A; Mon, 6 Jan 2025 11:54:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id E89A04014F for ; Mon, 6 Jan 2025 11:54:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736160897; x=1767696897; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=fP3FYxKu1fI2hgxfTZ/OPQ/jShznjlIMBgsY2d9OSLQ=; b=O5wvh2SnF66BWS8LUmIDct04SudhubcF3qacm4B6yBWpik8xpREnWQwr 0hcTp190j9W00oVCPY3x5WzCm0in3jMDBX55aA5hod6WCB2zrSpQ0WjYN Fj6dXR/wA8xfgAaPdyf8W61/Wt5U9tIj1bblJ18ZVn3P1NwOU28QOyUHT k1zkOiwy9Qd9kERJcWCejsKM0p/4GflXqaH2OaWjbovNUwq+C2V2lemsb NQloK6RC7jc3t1kDNpW1aYI4oKWEXRpfSXHKswpc8z4WfjhgEUzmh6dDp 4fJe5TfAx4EUuoVC1Y4pt1InXbkuvD+SehyZApcis94UhO4XYSqfRI/je w==; X-CSE-ConnectionGUID: 4zn8XTbURFmr1vRRXVBFxA== X-CSE-MsgGUID: 2tSGz0puRWmxsJg2b4qmuA== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="36465149" X-IronPort-AV: E=Sophos;i="6.12,292,1728975600"; d="scan'208";a="36465149" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 02:54:56 -0800 X-CSE-ConnectionGUID: qA0So76qSAuGEn82LTFnDg== X-CSE-MsgGUID: Fj8A0Y/4QI+M2Aomn19Feg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="133324931" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Jan 2025 02:54:56 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 6 Jan 2025 02:54:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 6 Jan 2025 02:54:55 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 6 Jan 2025 02:54:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ca7iubUDuyg6jEG2rqmYhYv5R3Pi3+HbP+trHx3TQJ5iRwyXuCXisN4mqR2QJReRvyavIoL8aq6RCD2ZtqrPbormb4krjGtlF3q3nA66xpRTabvlByNK6ryk2nkb/WrWEqUo3YWU5B+u0NpxLqRXmhyYWbpcK24IajFjZiOoj/zhKfnc2208v5Mjf2KNwaQwq8HO1lcoSB2xhEWrKvjZZX8kTmaSFO9wuQ9YpvWY1ZckOmTHQbwr8ZHRjQzm/nOsxQQHeBwXsz9tBoiZzQewoBziTxQW5dHkG6KDDWUcjGGLZ4rJqqRVAGePVtG2+ZucEWEkayihsFBeE64zIyuLNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9KWon/v2+m1FOJtKGnQUAIuEX0A9XPi5z5zCBJ35w5Y=; b=YgW5DQsm+gReoZI5o7B4PT6G/YHvCME6G6m24oK8iPHo80jApLKQeaMhmV4+QTYv3RtlpzjHQgbn1btucMRFxKrK4S8qMX9XiKRYXgVWXv7X0NxLoSWZjE+A6VxCR8Ygs+scGpcBjMjH8fEp5UYK1dVnlLdFm2wyXnRuoiV/O/H55HghcFNO2LSsC74GFSyCy31I45iJBwFab1RYEddSqQUHBTcXgb4s6MB20VJ58+p9gX0T6L881tGqJAM/nbyBoLuyeNU1cDl03C6oOSCO00D8gsee/V2cfKsrQva/LszAl4O7P0Qwh2gAML5Ql1Gd0j6ui6QpNL/1ShfS2SK0jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6090.namprd11.prod.outlook.com (2603:10b6:930:2e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 10:54:48 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 10:54:48 +0000 Date: Mon, 6 Jan 2025 10:54:43 +0000 From: Bruce Richardson To: Andre Muezerie CC: Ian Stokes , Vladimir Medvedkin , Anatoly Burakov , Jochen Behrens , Subject: Re: [PATCH] drivers_net: use 64-bit shift and avoid signed/unsigned mismatch Message-ID: References: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DUZPR01CA0047.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6090:EE_ X-MS-Office365-Filtering-Correlation-Id: f62679fb-a02e-498e-384e-08dd2e4089f6 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?I2i5avNNzAb2LcBLD6nhgnY80Xni8bO0hXlh7+Bpyvj9vqcG/yMyo3JFJ/B8?= =?us-ascii?Q?VeJWH5GTsmBVv94P1VG9X3tljR1fuFAjrAL2fr5hqiRQaiBvHF4/iOWECveB?= =?us-ascii?Q?xpa9T7bWWNzrB5kM9NbPSalD/knmGP0nQXuXgOImM1OVIoJqVtmgdReT75rE?= =?us-ascii?Q?vGQCSBUdGTwWEY9pwdZ/sXOvM3HNnSo6KS16SYuspeTjvs7z0VuHAoLITzvL?= =?us-ascii?Q?AH1XxL9mMvo2m8zbltyGDSbDuDNewcb0gcCXm337yh0cZnK01V5xdn7OZbT5?= =?us-ascii?Q?VbNWIx0tgwsQjufUAtL5vXtNwNj8lOXmTNPZvgVUKbt5fYmN1HdCSg82mU1h?= =?us-ascii?Q?OrrRIJfJC7SWWgMiCzt3ttTSblVpZea1SeY//vn3mRQGPh3/JUbMStJG0h57?= =?us-ascii?Q?YhQCrhC98itxnR7mPHyX7yVIzrK38prm/fZRtzUJhiOMhIGpYT7rylGo3JCV?= =?us-ascii?Q?YjXsPeSLbq8V4hnvarCB+3ZfP/FXxetwOIzB8FIBndB7FKKi3mo6cU8REoyt?= =?us-ascii?Q?rLeK3xU0gKtl3RPTXbMvJZm+I/2CR9gYyEaSipnaVNVKuNZdmPI300j6tc71?= =?us-ascii?Q?d5TKEd8tuL6TtmAMqLwa6aRm/a+beanofuO+YC21eVsl1RN/4BfSYWcAkFlH?= =?us-ascii?Q?84pWKLp8Fj+C7kxmzhnzdEnkhS+JsrUFCB2CQmdXgyk9w0RW2ZZqO6fmrZ6e?= =?us-ascii?Q?8oTliJ67obhnsdQIqhpRARHWiDUml3sKHD6QMv8JwvJGAtbQqkPoDBsJM3eu?= =?us-ascii?Q?OG38VNH+hpaCEKzuifaIYt4SAMgvHPjv6VcbQa+VZPrVYfR+Yjq0pe2xNrUE?= =?us-ascii?Q?ZXdedQU8oZFk+DlkBAk4Ra0SHgHx2kDRiPdeScxL6MY50tIED3HefqWu8KJZ?= =?us-ascii?Q?kw1uLMCcI/PZRHzP3JK506cvgZ/VTBXUsrw/ieGc/h6WjT6MnuqK0zC1ke3V?= =?us-ascii?Q?o9eZi4EMs8NUQlwEDnig1LEz3pL0qU5acXNilZes+2DyZAzrF3SXcJuCx5Kd?= =?us-ascii?Q?AT7Z2zio1TRi0qPnsBLyFgs87Fxvu6q7hGRSmF6a5/xXDeM6GUhDtvFTrK45?= =?us-ascii?Q?01ch+AcbuOZUT2JRXgddcmDJvgUZrjTUeJLAcEO+xPeICLVth9Tn2tKVkkW3?= =?us-ascii?Q?ls3CHQ7vqAGKnQi4n11qCxirsxdSGOxFJDd1ftYsAmhW+pxW3gtujMp7OewG?= =?us-ascii?Q?fswpb7IfyvZajbuYbPOzMCtuWpFDZTImGY/4MNBWCR6yC7trZEv2IhYm8c4t?= =?us-ascii?Q?z3cV6QXm0thoYeVwhJY8e/KFZMDn7dLo8Sjb2L3ryN7Zei74LG+2/z+6xqfe?= =?us-ascii?Q?gJWMvSlKaZRf+0DAMEMUaxN9BZzarrbhujIMy4Er+jWJNxU0yZG3ozWkXpKK?= =?us-ascii?Q?w61Ff2fP4Zzff0bV55hRkLWRlVi3?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zJUOVXMNl1pl6s4n1s0owSRhGUwpc9vPuWuvt53TGWQdxSB5x+7wZ6adDyCz?= =?us-ascii?Q?Y6eOxMdhBQ2FeSLqJLUmTJfhAzQYyghSxqxcJcloTqYGzEIYPecWixV4vYRT?= =?us-ascii?Q?YRJKzqgNcdgmjTyU0X4NhPHda2bE9EsFSlD47n4F+PouTxXVPrl5xdDtVxqM?= =?us-ascii?Q?UjEmyJN/cTwJvDoElgEodttfHwHJPOdPERiQEfLPrWjTE4G2PVr7XLR4k/Ex?= =?us-ascii?Q?qEc7HCfonr7hCFR6f5A7DI7flirEzYRT3e86tuoIwyu92gE+eOc3XPGU6EQG?= =?us-ascii?Q?bmUcYoSsNlG/cb0rx1Wg78N8PXND3eejIgDfIxg+FpNsF/rBYDfqKlOu2tCG?= =?us-ascii?Q?lruebVqxSUdFyOUC2OHU0csfkwRXaI/0hX3qXHLOOA7fvvsL71IxP+siRobB?= =?us-ascii?Q?v6GJ7Re8mKSbU4+1FBd3GEDgTjuBEPgbuswWRraiOEYE5IEO/EXogzsFWv63?= =?us-ascii?Q?WuhIv9EqANV0jTQh+gFGemyBp7pTbsG0+7v6IWhGkaKBBoZ0cxfXse9KD4YT?= =?us-ascii?Q?mtj5W3IkmsAX9T0HL5TO/vtLo9FWc4DY1vwepRS2mW6MuJzOJVAItl2yQu9j?= =?us-ascii?Q?Hco2BRT1F09we9SeT3zeqVKUMHNFMpdphowr9Imzwn6Xf0cJvjfuHVYBlpL2?= =?us-ascii?Q?wZZ31hMXZz8gIEcD10hQd9GSsLhvIucMc/48WvYkLY0yMRYWPReJtGjFQdl8?= =?us-ascii?Q?UHQPR6oygSs4NegBzbgeDxDU+SnUBvTfey1GbbuXFHnbXFQZXThJRSHCstrE?= =?us-ascii?Q?jL8lpeDzrLIM2XPoeJ2yvKm5Usrw7GuOl0JDKAJpFpIDls89oSWK6DaeO/7P?= =?us-ascii?Q?akx4cFxVbF8XbW2X8paT+d4ecAbnNCh+q/42xBI4W9qT9vtI6N30jTK1RtSN?= =?us-ascii?Q?GfmaIzVmI/z95zOisTuvNNlTVpQPP6ECYTPYyhvKDmyJz+95vtNn7P/y1nrL?= =?us-ascii?Q?kjyPsa3gHKjY0Z5U1Jft6WZNlt8zBiUxVtUCEIYyDj/xDxcHa5Xr4H8+zXm5?= =?us-ascii?Q?EtO8RaANOJwP5iNAkVDjTTZhxwlUjgz11nrdCvyU2AX2cHVUtVBVdppngnuD?= =?us-ascii?Q?AP6alNbAB4BTuAABRwoxMZwe2GxuBwIkaGRWnlbEZIm9auhi4SWGty0ZR9qk?= =?us-ascii?Q?dFz2uMei18GnfnqhFaaW/fwD3/ipiC2SCEy/qddVnlKD3VfAFCqk0QRtrMWt?= =?us-ascii?Q?2yIkE0g9tFIjaMgTB0qBDj1bkNGzEeO711Mp3qsJp9oFCbWq2Fyxd80tY2Rt?= =?us-ascii?Q?c47Gc9WL4mSCfDxXqHRWL4WKOWWtn13OcW7OkkK8dqH/f0RgDrzIM/HvSb58?= =?us-ascii?Q?5rJwuQbHX+ANsPEg2Ov3t4JYuCrJ6lGNWDo+/r59bPq9SXlNQCTxB5ufqZXc?= =?us-ascii?Q?5OtG3OQjXAkATgwFakYGBJQRNQTXF7iQ37pCUKDcn+O21DUCDhoy9Weh21P8?= =?us-ascii?Q?LnjGSUkDlvkbormq/+0otqoAjnuPHlInVmq3n2F9qQNQyTvnj8fvt1m9MOe0?= =?us-ascii?Q?ZtAei/H96IjBb0uixSBFZvWmKj3ieBdB76lkCK+t39ro7m1MnPBXExPaxL6J?= =?us-ascii?Q?m/pi1WzhABPiAz9Iw/NX2dvTw7hDzth29XKx0t5jGf8e8z6TmKDY4pguNlnl?= =?us-ascii?Q?fw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f62679fb-a02e-498e-384e-08dd2e4089f6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 10:54:48.5055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j+vzVAw4pYsgcBR9iG1zJ2ZC8CvPD3NjRdtKrgDRKO8xfxZypKitshpe5Dj+ogT73kkKi6RGxHhytul9zrrPLgpPme23cp3CvXV3yBxaHFY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6090 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 26, 2024 at 12:59:30PM -0800, Andre Muezerie wrote: > This patch avoids warnings like the ones below emitted by MSVC: > > 1) > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > 2) > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=': > signed/unsigned mismatch > > The fix for (1) is to use 64-bit shifting when appropriate > (according to what the result is used for). > > The fix for (2) is to explicitly cast the variables used in the > comparison. > > Signed-off-by: Andre Muezerie > --- > drivers/net/i40e/i40e_ethdev.c | 22 +++++++++++----------- > drivers/net/iavf/iavf_ethdev.c | 2 +- > drivers/net/iavf/iavf_rxtx.c | 2 +- > drivers/net/iavf/iavf_vchnl.c | 2 +- > drivers/net/ice/base/ice_flg_rd.c | 4 ++-- > drivers/net/ice/base/ice_parser_rt.c | 16 ++++++++-------- > drivers/net/ice/base/ice_xlt_kb.c | 2 +- > drivers/net/ice/ice_dcf_sched.c | 2 +- > drivers/net/ice/ice_ethdev.c | 4 ++-- > drivers/net/ice/ice_rxtx.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- Most of these changes to the intel drivers look fine to me. However, for the base code files, we try to avoid modifying those as they come from a common, shared internal source which we regularly sync with. Therefore, for the 3 base files, can the errors/warning be suppressed instead? Regards, /Bruce