From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 574C7460D4; Tue, 21 Jan 2025 15:52:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E527040280; Tue, 21 Jan 2025 15:52:40 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 929744021F for ; Tue, 21 Jan 2025 15:52:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737471159; x=1769007159; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2Qh+IsrDCj57OugfJzbSi3i/YDLC7896cdeATFAEQUw=; b=Vd6CUo7qABpDOv/gTKlwvr7/k3SuJhQ3pJoXmoV3HsdXpZC1nc2l7ozA LRZaH++rrxA+YaDvFpYOc9F2Dr5udTVDJQIeuQPAK9ThQDsyJ6F1KhBk6 xaeJIKNzDvV6WboNfOUbovM33TsROKu99MLQQ36FZSIl3fieQNZRZkGxR 7N4XzUsQSwJkzK1pMdBW30RkCZsl64amqgAsGvmVzAymCfOAbakMUvlGi 9dcgT3W/YZLplfYyIm73wr04C+pMQ1vMZQCrq3HWy4aOABOb98vEDPSuL cWcVLTAONYF7+s/Fb6FJm+m6uOcEPWocvcm/SA8PcsEh5xlqihGTQj3Nr A==; X-CSE-ConnectionGUID: qZr8rU29QOqC6enHIpY3Cg== X-CSE-MsgGUID: hxxSfiJHSgWQID63rlL0hQ== X-IronPort-AV: E=McAfee;i="6700,10204,11322"; a="37763267" X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="37763267" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 06:52:37 -0800 X-CSE-ConnectionGUID: B0MHSaHaSVyFIsSZRjNGqg== X-CSE-MsgGUID: o4Fsd9n+RL2e013Bati2RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="106754663" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jan 2025 06:52:35 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 21 Jan 2025 06:52:34 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 21 Jan 2025 06:52:34 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 21 Jan 2025 06:52:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DtcpL/+M02j/Y4K5B9pEGJa8G0ru3KOLGGWIaR+0ziXgZwOieJ0SS5WgyNXjQfuRKKPgm/Zn6hK/T3xclBjQdTldWLRonTclLqRgR/+eQDpMQN38DuBCFLDI5iGRRyLsItG7m2pd0FAB9DAXwYHyu32Dy4P/c6CFEkQKQodZ0qr80LEOLiA9Tm2LwRU7/5pK9J6o7GWz2d0v5rKKFtRfTNa1YoFndiWyawtgCexMXpFwMfotcg3OcygJbJmy4jgcax7A+OYIk5UNd6zEf8V9hRHR1+gkW+sD51N6xSOtZO/ou5z+Cq1r8WjzioFfuG4j41T7QBcYW/d56E1rGL2nkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mhKlqJU9btetzKTUDfE71obN+ey2Z80fGiHDaWhE7o0=; b=XQi0n8X/DKGfW6yuydVltoN4agPklTI0tEE7uDM4MkyWuBAnHd+o15iGmXwwf/a97rjj+V4Bd1Aqs+t1Fd9/bernQcBUEHuvXJYzrSg0eA6GgIEi+v/pHI6Dy07qTCGT4yHwmf0oPII+Efg6VXetGNJd85cNN8+8dif9GsOX4CdETzWyj8D60f00Im6B3Jaq+zIO0lWJd38RmxYW2Uk0dVmf7UGaOUjCe0A1yPWbk07DOVWVykFjagUNO+UijV0H+MQRt1r5EwK1kYpsl3C5jKRTcIZnQ4wyfCSg9H7efVJQFRaaKSQlgBTrhsIoy/jQByVxWBr54wptJaj1vahWKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB8184.namprd11.prod.outlook.com (2603:10b6:8:160::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Tue, 21 Jan 2025 14:52:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 14:52:31 +0000 Date: Tue, 21 Jan 2025 14:52:25 +0000 From: Bruce Richardson To: Soumyadeep Hore CC: , , Jun Zhang Subject: Re: [PATCH v1] common/iavf: introduce hardware clock ID in PTP caps Message-ID: References: <20250115072323.1117429-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250115072323.1117429-1-soumyadeep.hore@intel.com> X-ClientProxiedBy: DU2PR04CA0308.eurprd04.prod.outlook.com (2603:10a6:10:2b5::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB8184:EE_ X-MS-Office365-Filtering-Correlation-Id: bea75ab6-8b18-4000-b0ef-08dd3a2b3b4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ONQI0YkMVtzB851rs/DAH4KENs45xOLeUnF+X53Z787d0DM7r8FMxyPyxlTs?= =?us-ascii?Q?kplNTB0+HMcp/E4lFajLQx6E2p94PHxDioZGDeTdYyJi5+eaIdhNFbsjeR1b?= =?us-ascii?Q?kxjITyaW7WJVmGIH5Jn0a/5xMiU0OTscUkmfeOAcXl28Pz9cNvyuy9gESyQF?= =?us-ascii?Q?WPE8eL6w+FiLRiSlNERwKV6LiWPgtlYxITXJypVSZ5YARNl3/fgzoEwYOL+w?= =?us-ascii?Q?XdjPzTtfilbXZSa2TY9qsY8QUjTEHvA3H1r7MFCwod+gKgxl+fdKaRnKlTio?= =?us-ascii?Q?xF1Pfenf66z2tEmjFeLUyhHmwhK9s6C2NSeVlrrPofPTGQhvoE/dfSF/oFM4?= =?us-ascii?Q?v+JKEG2guJvVc4KZSJ0eOsqr5sKxmtLaaM5gjuda/LzPh+fdLQcUQ2X/kY9g?= =?us-ascii?Q?8JrV2Q89mTcpm1ry4/+wbV4MDosN0JuOSqlcnuJVVjCuVF45TaqOtxWzedfJ?= =?us-ascii?Q?uIms36fDsfp6QigMLtjIYu2YhkRzOBF0H3wzL2B7ORYRK9CoAm06JpVodgNg?= =?us-ascii?Q?r2zdudXdSnO8beFEDuuhO4O+t7fkBCooQKO4EkGmE3tVfwMeO4nz6RLYbZRx?= =?us-ascii?Q?Up7TImri0pUkiHigLPtvhleGdkukJVr/8oKRv16NEMwjwjnXJzcp8VY3uLkI?= =?us-ascii?Q?yK6COu6RaJsMJButtdL0p3ukBqA0vPLiw+jrOj9Y2KibfbRyHVUki5Nqd8w7?= =?us-ascii?Q?OBfgvLHA0g4RTNL9PUadA1My3YUlbUeSNj1DddH5p1g3qvo2m+u4P7ENmIgB?= =?us-ascii?Q?qpRZCuWX9i1VqWpr6HUVD7oGqkztyYI42jMqw+cxuQW8AGlrDl1ZBjwrMNC3?= =?us-ascii?Q?WiqVUKDdH6uv314n3qFyw32MqALu1bTDs67Rvbj/b6U0xyZK/PWh8Sd8zo8+?= =?us-ascii?Q?UOAxqyaHATKrD9C5lj3N8T9FCdamOd4t4zuTW7ZsKYRpWxK+KmzXa7O1a9PJ?= =?us-ascii?Q?4tVf6wSdq1QNRu/mTss57ZQljQP3XKAx1zH+A2JQfXVdv4rn+EEUR/v+Pqbc?= =?us-ascii?Q?ryK+3Rxutsaw/06N2Yp2RMRl4CtCXwwL8DprABVX3Fro3cCFBh3P/XcDWVHn?= =?us-ascii?Q?KtMFJL37CAhCWBRKlCnu3NUpwsRm0yMrkY7xq+1djzuBMyYeeJEa+FxLMmpQ?= =?us-ascii?Q?Vy86R8OhglMOBxGOo4w8SXImnt4GZQ8kKxR9Eeb+nkN+aXAiE8/j8VtVPlVr?= =?us-ascii?Q?RUP5rVLmudz2Iwg+ABvvI+1Q/Ck8m4cr443JyzhdfJVZnE7j/svSWSlNSfJH?= =?us-ascii?Q?CfofDNqvYwDOGvET9i8/qrgRepbVGZiETt1BJDog9lMCirR1evQlL9uFj6Ms?= =?us-ascii?Q?SztoCq6XEVzNdVh2c/k6UY9VzSzgkRBzO+anp7VzuTQAhMXw0528QtC+RikY?= =?us-ascii?Q?N0q9d48l4BK973WKbpPSu9kaKG5G?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xub+TKZcMXshClgU/MCWVeanIu9iTxbMZwdGfC3pyDbbGXbzc7B/yD22JUKS?= =?us-ascii?Q?fhhE+0DjtWXJD6GZShHrBHQWZtshBPjVfRUi4xJUP1CCOyh7fhuXbCd1kidd?= =?us-ascii?Q?lTAfl9+/CZbT0dGbu4u/vTpdSYN2Sn5IzIrti/+Ge75LXaMvYZb/EMhTLz7P?= =?us-ascii?Q?R7Cobp1dSd/aV2uiMWWiQVsWpWjr0+7fNgoizO1pLRWB1ddypFsWKEkqs7/3?= =?us-ascii?Q?/cynPB/UDY+Q5BWeRPVM3XbczGsB+Spemn/BhZ/96cDCtALTtjHzJBvDnWdI?= =?us-ascii?Q?4lw9b8kUKXbLL7lQtRivcWO0J8Kj8Wa+SOUeitsJrU4mEowCgH1TRH23q69e?= =?us-ascii?Q?0EVhxcawhSbCezIveqE7GLv7VH+hheieDXWbi7u5XqJ8hAPfGdC8fu99OUk0?= =?us-ascii?Q?fZUaXqSh7nQMvUQNrLAQ9+qRgpkJmw+/ADo9igxK94B96XfauZl84jMUkVp3?= =?us-ascii?Q?cKMzbn5jaaDwGXZlDG2ERF2/PkmaLHU30Rv8+oOk/G/D6U7L8Er9zX7sE2xK?= =?us-ascii?Q?wV+8xYdatdiLNH2JLtm3uo9oETY5IYZaaX9XFVUHOEs2jkab0rTaBM8MFTHI?= =?us-ascii?Q?jV9GfEYoswWWo6bCXBMRPFHscfFf1qHwnmBAHEVFLwazPTohuS7ShDwODPXk?= =?us-ascii?Q?bHy96lR7YfHSGii+yrZmDROw/oq++UpjigiIvsbHq5y4p6S9Zc21LCEI1vTt?= =?us-ascii?Q?q5G3pkM1+LRy3B7fYXGN6GaCla8BfFh9UF/9AwExXBGdweC8m9HeeeY5Jp3p?= =?us-ascii?Q?eaf9mvjW8RkODlSj9HYLsgF9XdnsyEXgtIu7Y0FOwcB5FimgbLKIwv10P0WS?= =?us-ascii?Q?buB/WE3qNYU6c99qSb/EUHDVWqZyPcGH1mUCOmSH13/31MnR28dVRmmGNWH2?= =?us-ascii?Q?qN6YGV6Dq4QdrlRsx0+q41BxUXml0S1ezM0gyAZSY0n+a/RAIDt8U0Zagu5W?= =?us-ascii?Q?IsKiMrOC1tzyuR0RXqjt7WwmvKQj6WKEvkriCOjoj/KY/K6Ds7+tmKUzfXjC?= =?us-ascii?Q?BmUEZlifY5Q6Go3e7ngE+Py0WPjgji1/XQhp+42MwHjJ34lZ4bFmQrJAyCGL?= =?us-ascii?Q?GXHrdDin9TzmnkJBFPpUTvgZoE0PJwojBltwdA5J/5HuivxwcQ/dm3hWJB9t?= =?us-ascii?Q?zbsGbkMQNvFDtELx7rJ+SUdBJ79o78hCSkPrjBwnJ99KHekzKH0VKGkw4CUU?= =?us-ascii?Q?Tpc9gw910tvK1F9NjVF/RAebZFWCFFPVDs7jN6U4/qyOdMpWmNiekxUYPo88?= =?us-ascii?Q?t22CxQvNgqMVfah2PUlN1RULzhIDj4HSWcWxaNuGcV8iF+ymNhfD4CptqKJH?= =?us-ascii?Q?ILTjqlyFI8mGfMkMwpDJfi0S7GsDY2ewMVWcq9pndB0yY+lyCtKAZfhyn4cL?= =?us-ascii?Q?X8/OpkSROrra55sR3L0WHvX5m9+H3ThgbNpoHk4k2Z2/3G7LEqb/BrWV7CKx?= =?us-ascii?Q?rzGTQ4WeYzaT47FUguI5h14slVh9XPJYb0HNgTxUDFffkkIxDPKTdhB/K9j5?= =?us-ascii?Q?loqXR9+UnKU8t8rihocXsFV5zmi9ODLoeJJAkMvUkTb7/aRPgnXlo6S7NmRY?= =?us-ascii?Q?1+uu1tK2a1OmcDTGqSXqOmEzkq/N1GifUt2YEB28HihrWWw7N/EAcmaL5dn2?= =?us-ascii?Q?4g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bea75ab6-8b18-4000-b0ef-08dd3a2b3b4c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 14:52:31.0589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Olk26/YxHidz1IbynidzsT1Z9hl+LDnz8fIjSamwaNqbNQWmTSMp8PZyiNS1BHHdCQ5G9AKrZ+7d92RW+vRvnepeJNMOV+YDMzmFzHWl/3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8184 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 15, 2025 at 07:23:23AM +0000, Soumyadeep Hore wrote: > From: Jun Zhang > > When there are at least two VFs on a single adapter and both are used in > the same VM, each of them will register its own PTP clock. However, every > E810/E822 adapter has only one PHC clock that we use. In order to register > only one PTP clock, VFs need to identify HW and make sure they come from > the same board. > > This patch adds a @hardware_clock_id that helps in this identification. > VFs from the same board should receive the same @hardware_clock_id and VFs > from two different boards should receive different IDs. > > Signed-off-by: Jun Zhang > Signed-off-by: Soumyadeep Hore > --- > drivers/common/iavf/virtchnl.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h > index c0d52ddd32..f4ca2cc9f0 100644 > --- a/drivers/common/iavf/virtchnl.h > +++ b/drivers/common/iavf/virtchnl.h > @@ -2224,6 +2224,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_quanta_cfg); > #define VIRTCHNL_1588_PTP_CAP_PHC_REGS BIT(4) > #define VIRTCHNL_1588_PTP_CAP_SYNCE BIT(6) > #define VIRTCHNL_1588_PTP_CAP_GNSS BIT(7) > +#define VIRTCHNL_1588_PTP_CAP_HARDWARE_CLOCK_ID BIT(8) > > struct virtchnl_phc_regs { > u32 clock_hi; > @@ -2248,7 +2249,8 @@ struct virtchnl_ptp_caps { > u8 n_per_out; > u8 n_pins; > u8 tx_tstamp_format; > - u8 rsvd[11]; > + u8 hardware_clock_id; > + u8 rsvd[10]; > }; > These definitions look fine to me, but on the other hand it seems strange adding them without any user of them. Can we defer this patch until such time as we have a patch with code which uses these fields? /Bruce