From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45734460D5; Tue, 21 Jan 2025 16:10:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0D6740280; Tue, 21 Jan 2025 16:10:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id A6A1C4021F; Tue, 21 Jan 2025 16:10:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737472208; x=1769008208; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=oZu1vIopk9VNQaTeT74DzR4xK5cKjnYFhQ09aBsFRHE=; b=KL6dZ166Yn4AZAjZgAXRYrxBxxmCWjnnPrIp5p9L1Yb4HFUSTqGP3h4W s3OrhwsAU4wsyXhGTm7oVYFHiX+Pr5QJjOAKA3dvAwe0tNbjwSIHmuRpM qCAmbf4R9p/kZka/8KwVnegst4AuxiM53+j424UCeiI8mJoXEa8C0RIEP Qfcp5RGRZSlPvhg4kiyQE5S7A2m5bjonMYTVUz5BEzAQSwE0O+bY2SeMh JJSjJmA17qdg6pKOgTsYLSdoKrICKP8SVgKwfO4qK0RM+m1ywr6RGgDgm iOg+TaPbs2jaZNviqJzHhn0bvxiGiSPvhYjfvKYVt5NT7Omf+ufmtjYIj g==; X-CSE-ConnectionGUID: vAFQo1hfRvCt+ogjELQJuA== X-CSE-MsgGUID: ZMhjLq3IQrGYXBOVJ6pbWw== X-IronPort-AV: E=McAfee;i="6700,10204,11322"; a="48555449" X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="48555449" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 07:08:04 -0800 X-CSE-ConnectionGUID: liyyEfTdTRWMjyHxWm580g== X-CSE-MsgGUID: 7H04IFNARKmQ03B0oldxJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="111819434" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jan 2025 07:08:04 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 21 Jan 2025 07:08:04 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 21 Jan 2025 07:08:04 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 21 Jan 2025 07:08:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hMhhtmYKsdm8Ou/L60ALvmkoD8L5hwcu0nhqK6hF6nGzZamMfn4d/96NE9Um4EICB5QfZAOQM77eLPashAgusVHlycf2iv0LfsIYuqrGQsRrweq3vCD7+3jkUJE/P3XKXoFE+GGrJiOKoC1LOsfIBv6zEH5UTaF+QaxTdmG12Iy0B3lRDLLOiRKD04GOiDTLw2LmeJaz5KF8fiR6wgYboW+5rTdsmu+D9sVu9/mZr2MI7RnbVHXh6dE+qQf6xPTTfeDDJM6PZCjSvDkxF2n3GvUXUEW7BfTcc0675LW8JZDK8DXMr578ZroV3JSMT/MOesFb+/+ozIHK8g2TMunI2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lUaEh41dstwXIo1pKpFJVter7vMa1rfwrrD3hPumTe0=; b=pwT24rYGdbE+PwKIPG8hX+rQghmRhxzHG/mzFJk//FDopLxWSOVyAlJdG+OsX3xM68p1J6dmNMX8YD5A1yE8/VD05dEwLbx8DMeotxDjYz2sARXOJjbhHZSIxjmo8FHed9moDDDGC88X0TVVmQoT6a1YX5Iw9OA3eeSpFvBdWAhBhrKJoG34u+WzDg7sueTXqK2NMHKGLRoiZ7FOi9zNG2F4HVzIZb8SEM++TG70RmCup6nfXNlQf0rB4qOb6HtoF1yCI79/jochvlSoxK7U/jfUWl4enygjzYNsLlhfmmjL3KwGX25MCEAhlkwAPwzwJ3oVVRhFQePj0lm0pUauSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV2PR11MB6046.namprd11.prod.outlook.com (2603:10b6:408:17a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.22; Tue, 21 Jan 2025 15:07:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 15:07:42 +0000 Date: Tue, 21 Jan 2025 15:07:36 +0000 From: Bruce Richardson To: Vladimir Medvedkin CC: , , , Subject: Re: [PATCH] net/ice: fix memory leak in scalar Rx Message-ID: References: <20250117175205.1598739-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250117175205.1598739-1-vladimir.medvedkin@intel.com> X-ClientProxiedBy: DU7P194CA0008.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV2PR11MB6046:EE_ X-MS-Office365-Filtering-Correlation-Id: b15df73e-188f-48b4-634a-08dd3a2d5ac1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KLIdRDKpshe45j+ZfUWeHyOlikfDP5zQPimm6DJXx3oGLqdHp6KL3Ar4Gsq7?= =?us-ascii?Q?0PuWFULgyukddt4uI4v29fu+Q1wS+MGTK82Lkki4UwcZyGq1N+pqlPaHHVyP?= =?us-ascii?Q?XKJXMHxRvIAjdHu1mKqohra724leSB6k6Dm8s2F7NTzvMweeep6VwAV5jl2M?= =?us-ascii?Q?gxeMIoCEthOVfbQ4tMni6LDJs6MctodTiFFKsDT0cwX/qbHGJbXb0MvC7Ro6?= =?us-ascii?Q?BernuAAJpHI2ThH2uByBql4QVtgCvZCmS38cMPi6pb3ULzzQDbPI/QY9z4pE?= =?us-ascii?Q?dn+Xn536rdu/hdBUxMwFDRCyaWaPoOEMBZ8UnbTge7kAJ6/3DSxvvkpUG9oN?= =?us-ascii?Q?UuzN+W8zWu86ydQLbedn9r2kA7jiG4s9ZdcGVnlDvhds+txr7DzdX4P5T5Bb?= =?us-ascii?Q?x/8CiWgn8i3MGdcRUzKy1gtb7F8NxcBYFJplmCdbHHAhz+FGP36FGZu6akaG?= =?us-ascii?Q?UqeYCRL0EEvjrity6yf2wDrnetXH0V0pev86kRXZJnIgt5sbuAVO4r9Yyz0L?= =?us-ascii?Q?KGENrV9uCXpAc5OF0dm3AsatPL4xh0xAOGMX1wetlfnH64XqlgOPbqH95eNR?= =?us-ascii?Q?XxXywivF1ywmXpNFNrA3e7biXLKjMryBZ56mvus5jjOWXVjIxuWsWiw/brDa?= =?us-ascii?Q?IcjJZdNrqcm9LUwNj4mtMRmeoBo4p8TYStS/DgBbyoEIX8mTjKkB0Q+MQs2x?= =?us-ascii?Q?3rjQgM/7QukhCe4rAdTKv/JRkBcdg8ZtQhQSgOjMYjBBe8SRA1JT3OvThfoL?= =?us-ascii?Q?NDTISe0xbM+GVjltRbDHM7e3VV8YJKtRTuCdP1DfEr1AzPzcD/gHvOOHUY3v?= =?us-ascii?Q?ZXGdLWHzwjnlD9EMkb8e8loLf8sQdURJaBRYHiie+UtBBw6STpTs4QEK2jx9?= =?us-ascii?Q?FcahSQV4fNU1av/7ccdzzuGYAfNBkaJbE/ohmcywFy+NLzQjWnzwQ4ltHptN?= =?us-ascii?Q?VnTCIXdDYbhqZvkmX8KV4pCzygwdaEWkEUck/tXNRQwLNekRzlHZ6xRBcvZh?= =?us-ascii?Q?Z1JtBarpwJdsVHppbedmTErtVxDAY4hSIjbqDkQbABnKThzg8wrg6NXo2l8q?= =?us-ascii?Q?uQLxoHCusKW3hi4jxW8X3b8egeliUSpNu22CMixRjoHuyuIymlTm5byEBb3U?= =?us-ascii?Q?SJIQByGUX+UrL0rg03v9R19osOYRhiMOT/+xeWQguVkms9coA7jLOozdll+t?= =?us-ascii?Q?5jhhsUZ2V1BR4Fzp3NkE8UbVEd914iZWGgcUhzlOVJNAZXxcmx640ctvjfBG?= =?us-ascii?Q?No/kUER+W70sBxR7zsvVKW+NE7K9tXwQohZd0XSo4qMcYu4Fezd3L0swRDmR?= =?us-ascii?Q?hL0MN2sslEP4Ffd/DD9kB6ZbPU+5CZo2aX/WZ4StPIMxnaJTTfBG6nhWE5bX?= =?us-ascii?Q?LOvpp6XXODwSGEfT9L1sgYY33jRu?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DSdU8v7qEH/XL7ThLrsLkNnGkXniniIz9U6S68em0Y69jnKvQDUFH0BT6MjB?= =?us-ascii?Q?2YsZLx6ivwY8gFcZYwgupw8e7UxZaqwOasU+0bLLAeqMFh5orT5JW6t8f8C8?= =?us-ascii?Q?DeOcc0Dvk0zOp2dIRMriQADkjzi9UHOltoMyDwJ1useTydO3xmeJR+U0Vpul?= =?us-ascii?Q?Q8GFreDyeBXhx9jf2CtzCCzR8iILamoFlsXYh9YP01ODpaZER/6eQXZb14qm?= =?us-ascii?Q?3vzwEDPxP2iVHN+HS5/UtB5vGieKuGpiE7l+If45u92tp9RIOIb0p3wXsTce?= =?us-ascii?Q?x4jVzcTwfThMu+orkOEwhpRD+9WL2PUnMAmcYRTBp34iqRI9Jy6e+YMCHZIK?= =?us-ascii?Q?HWAcdc7PAU9ZgXwxwugi7u6IMldKB0+NilMhph+ytnrtId4HDt1XSIkX3yP5?= =?us-ascii?Q?4TQ4wItv8ITXtnd5QXVgPCy4ISB84MR9N+UkSRZ1pBBsZN13KuFETu53FzNW?= =?us-ascii?Q?91IEYyPa8j5Ri7ihF6me7JpLeyppynJo5rpQIaSczqaF7SgdS2/RjRZmVC86?= =?us-ascii?Q?NDEmOj+wUU8vqHeWoaQJ/z2Dytufm8X8iMCDySkt57YWTrMdp+6oXs9ekDok?= =?us-ascii?Q?OfVdV5kHrIRSt99TXn7w9hGee91khn45IT5JhcmboNdEcn/0ch1QNZ2nlBN+?= =?us-ascii?Q?r4sf9hSPVhKKQ1Lia+icN37fbeGj7LfBM+FE1VYAA3xpXdODV/pu+3cDlOvF?= =?us-ascii?Q?BCMyvoIPneX7oxEPzd6z/Sp7U9ErGzzHgiGjlwM3+qpnwyUL51K+6Supt+YD?= =?us-ascii?Q?ECJUW67Ap6HOjsf8uamUCeJ8v+746KDEWARtc0xoyOO9pApRJhFr9DKf2s6b?= =?us-ascii?Q?o2LDgzqB4+KfQ/OQrETuH357BVFvbICbWPv9PF9dn1t1kTXctcuuefLJs6I6?= =?us-ascii?Q?ArDh/iOeIe0ZiTJlKs4RD5cNBgpzlqdsTv374Z0FDmVXRpWXDlo9yYu80ErK?= =?us-ascii?Q?H3O6zU0cv15GCgA8QfRcjcrvdtKHloM5S+WDXeL7KjtIiLhkqYM5isjr+RFl?= =?us-ascii?Q?XDNFEn7rqq7No8/pb51Uc3j8CLWB44/7CkUKNArjfVpcFJ291mV4DCText+B?= =?us-ascii?Q?KzAkl9iHv1V7v/8OmTl8ajLAYrfwHs8ksbjfCqA9os6BUiLT+3IRFPewgDb3?= =?us-ascii?Q?U6iem8wlk+jc6dFSWgcacBoaFxz6YvikXyiJCrR2OJPzXIXSkkuYjncIIIws?= =?us-ascii?Q?V712rmGU2Y5kRAbbhLWDXSvd7/8Z713f5qdJ9JN77N9HCLxHGDY6caVhkvrk?= =?us-ascii?Q?dUG8JF4YJ9EG8XqNOwvoDfgzukHIsUHE+0rEFwBMgPGHq07ecInJVEUJrO8E?= =?us-ascii?Q?D0ZYtuCLQbcrT+YiDNgCZUxG9xlZP3iRBuVM/m4rHQY19/qvikYAH1wMYcLM?= =?us-ascii?Q?sRf3UJFqJ6RnE0LdTc+xqyAAig3aAVmruwqhvMT5PQL9qHe8w4lKZ5MzBY+c?= =?us-ascii?Q?/H4KeUSBHGPLQ5wXuvzCa6yEEEBxmG3YCwkcT4I7fniZXYvKYxo9NTZyTbAQ?= =?us-ascii?Q?8hb0mzraQXo161jRCPWMBflsD68PGnXcy8j5XG5iHuoT5k4i2marZ4gVy5c4?= =?us-ascii?Q?DnMSjAsEy0nE3IFgYO7orOuOklRTWyDUR2mAxZ7UidU6GvhTPvRziuMnc7c2?= =?us-ascii?Q?0Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b15df73e-188f-48b4-634a-08dd3a2d5ac1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 15:07:42.8422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 08/loPkOrJ60x1ZzOdU9oQYHp7gEJx4NWqbDFHiLdUUUjXal1beLrvS6AvgbXBcruEyVx7yRIwJDVBNOmedFng3YxcHc9+mYxuG9v6XyeMs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6046 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 17, 2025 at 05:52:05PM +0000, Vladimir Medvedkin wrote: > If the buffer splitting feature is configured and the payload mbuf > allocation fails, the previously allocated header mbuf may be returned not > fully initialized or a memory leak may occur. > This patch handles this case correctly by freeing the corresponding header > buffer. > > Fixes: 629dad3ef325 ("net/ice: support buffer split in scalar Rx") > Cc: yuanx.wang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson Patch applied to dpdk-next-net-intel. Thanks, /Bruce