From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BA56460C4; Mon, 20 Jan 2025 15:33:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8ACB440E50; Mon, 20 Jan 2025 15:33:01 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id E90554021E; Mon, 20 Jan 2025 15:32:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737383580; x=1768919580; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BHY3Mchvzgjiz603RyHSVGhx8ZN8ho2RMZpP93KcI6o=; b=hIQnfQEhOJH6C1UmW4J6HhpKhs3ZaAq2qiyyYHbxJxlLECH0cyL73gBa NIfd+VjtI6TOghOhw4WLwr9SEtxcGrgZ+PGv14qwALT9bheWw3I3TkpTX hLfEW7OCe5b8qLIFla08fZCuemUm5OIW/U69NmUd/VRog8yNdauu2BmIn J+6gKhH2AfH8Dz/4pjI6JfCAzQhP4RwIUzZOBXOqZ3zqKhQkzp31JKcad IQXJ7j2t7dmQQ/3g2iQmvaRxqCRU46SOWAWwn7LGT8e+QJzlQkeidL41r 38PsGGoR+3zhjaspqPcYhPEk4aSPridX762Kkp3SFZCOCXXek80UL5MI0 Q==; X-CSE-ConnectionGUID: paKCCp0GSPm80GrPr6gtCg== X-CSE-MsgGUID: DzUFm/xQTOWWhjgXGdTwxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11321"; a="48371180" X-IronPort-AV: E=Sophos;i="6.13,219,1732608000"; d="scan'208";a="48371180" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2025 06:32:59 -0800 X-CSE-ConnectionGUID: PuXJIpRZRNCav7I5uoS78w== X-CSE-MsgGUID: 3ICM0ky+RG2b38Bt02XN4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="106367717" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jan 2025 06:32:59 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 20 Jan 2025 06:32:58 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 20 Jan 2025 06:32:58 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 20 Jan 2025 06:32:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=leYOU7IgFxKb6G9JG5dgBM2oDsoS/pz5dEkzY9H5EbE5qbWVLyA1Dd1OmHPQvF3/HHbHDWaoggQQT9xibWZWcrRSo6gyn392i4EyioAfQDBgRMskBJ5y0DV1dzJzw5umOtcyVuF+6NQZaJ+9wjGYRUQxCL6gtck42LcKrcD9mhhtidOQCHu3Ncyc7jpjspcXNk6/oKUeWu/RSqd5B37u6YpebdSIqotw3SjrEo8Sb8lhIkRtOY/lD6/to10jJFReZJHFWxy3s58QJPixMMrQropAUHs5SsHhtrSe0yyzuoI3q09/MsCROrBVmlSiVwrD6XfH1DhHiWqFXf0LwjM2Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hxiK0f6IvWsMvZ7fIFB1ld8n2VxuT1E+FCAznDxxKtA=; b=y1N8iakqhiOd7v24UGJ04tyneVv9KxDvNk5FhZXzkpXyyH6E6NtHMF0Fuvxp8DpN/om4uR6kak/JHJl6wE++sJpN/0qDvpttIPa/D5VXCBoDYPAgtXSbxktayXbVx83geyRGmiP/m4smZ+QCAQ7z+bnyYSj7xhAq3ENqx3/E8kVfHuTE2dDyic1Buk21FpMOT4XH4po4hkE9yBx3mR/l71N2xl/e3ZynyZEegxrAkOQu7bQq0+H+Gfw3262IOgsN14oWUkZBPyIAy2gY4c5Watgi4fTs6UZPd9Q6utcf7l3qrcS1UkSydysakRNtZyW28xgL3dw8C4XOld/PLXo8Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB6726.namprd11.prod.outlook.com (2603:10b6:806:266::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Mon, 20 Jan 2025 14:32:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Mon, 20 Jan 2025 14:32:54 +0000 Date: Mon, 20 Jan 2025 14:32:49 +0000 From: Bruce Richardson To: Stephen Hemminger CC: Praveen Shetty , , Subject: Re: [PATCH v1] common/idpf: fix heap use after free error Message-ID: References: <20250113085404.1447006-1-praveen.shetty@intel.com> <20250113083001.611db94d@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250113083001.611db94d@hermes.local> X-ClientProxiedBy: DU2P250CA0021.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB6726:EE_ X-MS-Office365-Filtering-Correlation-Id: caedd2f5-537c-462c-1d82-08dd395f5386 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?L3GM0Zy+eP/O7z8k+Y0l4xtlNBXqyT2ZZIgXeL3KqEasnKzxx92yhdOsimxy?= =?us-ascii?Q?BF+7A7Hy23gLFsRYWQ8DnD6QJ3nVuerumTOmj/AD63gaiuW/4PtW9C894V3W?= =?us-ascii?Q?SA66GW43cA4jqARshswxf2Z7ibSobRi0/p1/+bVMiEf9txFzYWvetHhwMUl/?= =?us-ascii?Q?61BDTcacNKpMTeR+4nPMtJiHIXpCmHWfS9d9wCchMK2udQqkJjyMqaK5LP9z?= =?us-ascii?Q?w1aZVyHrfAuaIkiiwwoY0HmxBMEwrh9bYLeh96jUMZxmYuJ2waskaDGMcEsS?= =?us-ascii?Q?WnWr0dpLcZRtf1lyNsElu5Vmj9afJn9nwhtHB3MV2XkmADMQo04eR80I15eM?= =?us-ascii?Q?ZZae+rruy4VXDznHLgXeDJLRYa3xMdoODC13tE43qvR0n+e2LaahzOHF6QYM?= =?us-ascii?Q?hCOkIgyxUXHXcILoPWUgRV+EK2OvbmTPvV0zVJFD47Qxt6YgTkvPw62b8usL?= =?us-ascii?Q?H94i8z9wk1oSMJ2pgGYwCCfdeEE4kyF2q8hPwm7SGRvK5vKPtAMQGFKvee7e?= =?us-ascii?Q?YGZIYn78Noy0/lzCNdrT3+pbdqw1EiToqQHkP71dqdooekTDKiF9rmtyU0kK?= =?us-ascii?Q?KJ1t6OV7nglU0fVl2wDwqYL8F8pBNu+gB/IcE4AYt+2UtZKNteeeCQSSdIZW?= =?us-ascii?Q?F1YPXgHx3hrtjnNMUlZlSf0bHTKV70LykcGFxifWSZyJfukDWX3t0bZMwHH4?= =?us-ascii?Q?KYOqiYxxDnj+QdCMf1/hVDCeEpDsSH18G5KHnb+WgNo7v9u7jEjTno41PG+l?= =?us-ascii?Q?kCam5Q/XHZfuWFDyo8hLvpowfnxODSbwzmyTT3ohszvwOo5YKVUocApwVtGC?= =?us-ascii?Q?MB2QQWHAfpmoYPYg5sNR/7eOtd+IsgT7ZgOSKIZUIL+1pZiAsDjwEQicFa5r?= =?us-ascii?Q?A1wKykJlxMgB9kOIOjC3GX+UGi61j0uoK90FsiIGl6Bq7Cg9CXadNepTWOfr?= =?us-ascii?Q?+KWAhOYaR00WAjK5l66MB+ychlisoKfvJkvWX3Lrkai/e+XxVsy8WMHdEsGH?= =?us-ascii?Q?a7Gy1+zasbuMLw/cwccpLl+R/QwOvCmcPk71qsdgV/XwFnlo1mRUigX04/U7?= =?us-ascii?Q?M9GumSRDVoyXVdWqZGHDtGwlTTjQuXWJBZd1C+MUfIpovhOAVBHmzezhymHZ?= =?us-ascii?Q?mrFuAV1692LMaidsST+/xDDHBB8kpaHkDNN91IIk3WqV1OOTnys2/woAsEfd?= =?us-ascii?Q?8/O9oR8da8+ari/UGAbrCKSzcKDOdjEwqNjxCaxO0GKtVCVl4BpCJxblVqX0?= =?us-ascii?Q?YvS3328ZaCUzsbLFTe8s1WaOVlFXnuukjNxcRWxvDi9JgvpFqwpcfVfXaKKD?= =?us-ascii?Q?/7hWpsZWVjqw1I+lZgirYyZivIvfXh3yxlPLJzXIzZJgLRGZwN+niPdFDdeb?= =?us-ascii?Q?QTbUoqIjUF7nKmAnqnrV/Mz2z+p+?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gek/cUOD0AteFTfJ+AzP1bLUZ961Z/MMP87wOgc3kKo5bpOOd43QWW+gCmKs?= =?us-ascii?Q?XgJwgT9SV0Em0ohlpcscddZiyaGMcmIvVmkChs7kypbYpPtAzlrv4aKZHmqP?= =?us-ascii?Q?XWu70i/N/npUGVRzxXtmZMZ6RMhJB6Zaj5/7gNd8SS2eqznLIWD+sA9QztE0?= =?us-ascii?Q?LKuCe2c7++9uAL+35CXl63gsF0pR+1t1kQJ/JTYlbr+rXyStx/3R6NmmHM+g?= =?us-ascii?Q?1Nm2lZe1gD+mtrNi2jkZQrkSH0CRgOcyvYHXKg/nu2Oh4qjGtF6f/xSHuIO1?= =?us-ascii?Q?NsEX/QV9tOeRtQPJS+e5ZxfB7CqjZWW77c9mVdB4jbFeV91yjc8wE8F0fo1E?= =?us-ascii?Q?/TZoDulXsAFEK+Po4zMgFqtp++RPuzDzY0g89nmiGzhL76WlCZMrxZ38i2oP?= =?us-ascii?Q?r+SfOBQ57t4qCkxi4h12gXPNM2WCQ9lkmbx+qBLu/2sEfmYez7GFJp4ysYVL?= =?us-ascii?Q?bYtR+xiFDbelMdCMZzjcG829Yhcg53tay2Zb+OuPh4x2wv/r+PFeC6NWdGv8?= =?us-ascii?Q?A7WbrDQpsQLNO008S05jSK89Uz/p22dywlxnG1/PgrjdvfjI4hP1X57NN78J?= =?us-ascii?Q?MPBoF8iGjNjcK03gulPJBrC0kv1ONgPZdzr5su/iWEwlj+5B1k8PuICMuZkS?= =?us-ascii?Q?eQ+RDpZVkdVHVTOZq/SN2JZTAElfWLLu4RgkptxuK9G8nOGmt6hoK/dw1QlC?= =?us-ascii?Q?WC8muxyBbYk9VKyjv3Jpz6skK7A2sDmYRQVMGWfbRfGYcjv/nBKY2p8pVhVf?= =?us-ascii?Q?rnB5py2qnWfWOLsAqBniVe2g6OJ/bO1ZXET0udiuDMAniJclcXC2T5rxldRy?= =?us-ascii?Q?+Cp++ungJ18nzZaqf+kB1FE1LU3+Oz+61yiq+BExTRNQmH8ZVDEK7KO2kXxI?= =?us-ascii?Q?sYkzIFIyf2yv1TKDzFSvq8uj84l7/rEcSjS9gWY6S3hbpzKGGa1IrGBnmxUb?= =?us-ascii?Q?SEKskH5HUFUqDzk69SNNbxjCThGSiJr4wa1P5FG/0PJI4XLS/HbXSTzh7Aee?= =?us-ascii?Q?oLPHHDvDZs5y8n2Ru0syxqt5mcTBtjn97TuZP30DfUMeMBSp8O1vkrkf4O/H?= =?us-ascii?Q?7A2HUGkDubTH9rNAPUHq/gdjZ2hnXrDPzmVoTCLeitfSRnGAzspa4TycMU6W?= =?us-ascii?Q?773ydswdxQY4BXF7lUCCJ60krVOpfsvrrGRoREtYAOKRaxL9R8r8l0npXfF3?= =?us-ascii?Q?bQBcK2WELeXj1bbzEbEHgd/EFV/nxpT/jY9ZJQ7YixWMBp7i1/vTK6VAm/Pr?= =?us-ascii?Q?AOUCHoz+8NqCTBpZJSdEswzl/dKm3IjKFhU9xn+QX2qeBOyUGUf7oIP2NGHv?= =?us-ascii?Q?Xauvndh+pFKKF576oF4BgdcG8lA7XzmoApmbpEiu/8BAEv6vYbIN3P7tlm9K?= =?us-ascii?Q?Ii8W1S4MZM8yWBHajhDFXo5IlnBzwrTymOhauo0lIJQ3Km84qOGQm4yX9ndJ?= =?us-ascii?Q?5gOmFWaodD9vV5jNwRUeyjurVTpC34eD5lpoDLwVxyzZe/wxcBEbWqnzpGG7?= =?us-ascii?Q?0U0BYq9Sx3AzOGIrmr0nHi7UlT0EyIpzhqoHGs9iH/Vhe3PvkGuOaF7pKAEs?= =?us-ascii?Q?lr314jFcHbLQ3F5Vy1LQy54M/PrwxS53XAO++GfMI07e14yFlGorIFnkDBOm?= =?us-ascii?Q?Lw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: caedd2f5-537c-462c-1d82-08dd395f5386 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 14:32:54.3635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hn8v5CT4hLOeNJ/9l7ipUT/zT8hpC1cvuaI2SEx1+EZqUxlC8D6OXX0igq25Pq15IfGzgoxyi0csCo3n2AHYT85y3qBCZ0qdDXfFGXSv2QE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6726 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 13, 2025 at 08:30:01AM -0800, Stephen Hemminger wrote: > On Mon, 13 Jan 2025 08:54:04 +0000 > Praveen Shetty wrote: > > > Heap use after free error is detected in AddressSanitizer while quitting > > the testpmd application.Issue is due to accessing the empty control > > queue in the idpf_ctlq_deinit function.idpf_ctlq_deinit function is called > > during the rte_eal_cleanup routine. > > This patch will fix this issue. > > > > Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") > > Cc: stable@dpdk.org > > > > Signed-off-by: Praveen Shetty > > This should not be needed. LIST_FOR_EACH_ENTRY_SAFE part, don't understand. I would tend to agree. Is there an actual confirmed bug here? If so, then either our standard list macros are broken, or the code using them is doing something rather strange. /Bruce