From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFBE5460C5; Mon, 20 Jan 2025 16:18:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DEAE40A77; Mon, 20 Jan 2025 16:18:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 99B574021F for ; Mon, 20 Jan 2025 16:18:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737386309; x=1768922309; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ZSI/hZGYfk4cKtHkmR+s4SNbbVnQsFlGqbjI86Xz+PI=; b=lcd4miwPcZeBrUZoUhoh6jikEdwZDE5rImcI5Lkx905Oy9QHPWy6RKQA 0l9qD65tZljra8j4yWrhiT+9m/sTo3QP/hmnTqeM+ZF1dyycrDdAqLhKh x4zAuksyKfUDO2gfEYUyPiFBuXG7IYt23jFlz9vRyKi+B8iqIsMV6XJam qZYYwkaq8zlbynoPSVFqtPRqG6JozGgg/O9Pzct2aKBEhe39wDBv10PcJ QmxX0Z3zqkcE4SKjnUuahbBXMeS1po/DoAff46zfW8W3QlvVyFoCfMXeJ okLNNp73e5ClwCmgtgXtOGAazFke9iGGQ6ywm6ay/+9oc2oQ+8qs+qQ1V g==; X-CSE-ConnectionGUID: woXNLjhpSR6HbK6on6mqdw== X-CSE-MsgGUID: 98Sut1m2S2i3ww5Ukt40Cw== X-IronPort-AV: E=McAfee;i="6700,10204,11321"; a="55192962" X-IronPort-AV: E=Sophos;i="6.13,219,1732608000"; d="scan'208";a="55192962" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2025 07:18:28 -0800 X-CSE-ConnectionGUID: IP682x6CS8urAaJYFr23Gw== X-CSE-MsgGUID: Eb5Y1W7tQBulwj/kg8dJLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,219,1732608000"; d="scan'208";a="106354176" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jan 2025 07:18:28 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 20 Jan 2025 07:18:27 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 20 Jan 2025 07:18:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 20 Jan 2025 07:18:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rwjcc/nihgQCkPi7Yh1kDQDoeQteNchC8tLh+yHQtix31X3UvtRjwo8qxh0UCwfh8vppxj0LSbEIsbbh0Vvr88xIp4i5k42L+DWnDX7Lo26mXP2Qp2r1G3YX9CgY5kev5CWfQ0C+sVJYtkmexq/TWQNYIPTeNBmYX2NNktkerUPBj7wy+kwhyD3IKS1vyn188wsMa5gmavNZOXizt7aTCKi8r0hQm696A5Y4g3WW5cflRoA5Z5n+PlqKZoNf591Rub2Feughmex3oNqj/1/cwni2dBwgBkL7eE/HbO9gpAicA2teXWdFesHNbqU31IVs94y+svRTlnl8hElsIL8Ovw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zyFH51FDrpq78f8AwDl6TwaGBRoweFCxUjlt8zkKNNw=; b=JzkWVXpaaDGgnDEqTl8j7Y1/lISmTYqhwPdgnZ/XZa18qlep0rHWYTki95ARlD21HNFnsu8s1RfFc0J1WDw1QGxmt1HGQEXOKsfIW6nCljRalaj1ycxebm0hJR+GG9Y1/RXzkgxBOXPJ2cGnsVn1EatZ37aBQY4jR0M0/i5aKHl+imE55/zV38GpkwWwpdHypr+/Hikqcjt/C009WrX8BNChFdn8wdBPAwzgfRQDRKEaUtdys6A4ENz4CFIEOpWIsIvmAtrPL2fZbbcLPot+m8C0U5u4PgabnltfvZ5QjCgPZUOaam4QPAnwjz7w4rlhpJrTRdXx84tXeTAdSij9Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB7132.namprd11.prod.outlook.com (2603:10b6:806:29e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Mon, 20 Jan 2025 15:18:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Mon, 20 Jan 2025 15:18:24 +0000 Date: Mon, 20 Jan 2025 15:18:18 +0000 From: Bruce Richardson To: Yuan Wang CC: , , , Dan Nowlin Subject: Re: [PATCH 09/10] net/ixgbe/base: add missing buffer copy Message-ID: References: <20250114101024.159941-1-yuanx.wang@intel.com> <20250114101024.159941-10-yuanx.wang@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250114101024.159941-10-yuanx.wang@intel.com> X-ClientProxiedBy: DB9PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:10:1da::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB7132:EE_ X-MS-Office365-Filtering-Correlation-Id: 9555713b-74d0-491c-94cc-08dd3965aee6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0XQjyD9EHJU774n5q0CVeD/zO+uL3oGGV0x8TIolAu3CbtROn4sC3tdkBLRx?= =?us-ascii?Q?Hl3tHZTG9gu4lR74Cfl0JNMapDu3u/eludgLb1HiBkAHuWzYhL96J5LiVAHj?= =?us-ascii?Q?lkPPv2PgfhcOtsjFjM1dw/78BBcjE4WPAs4Y62bAwEwRdpqu+PovUePcBSFN?= =?us-ascii?Q?+2pP7NY6+MYuVaKxLFKFttwc7XJVxIDzLr9mAIS3nJE89deaUIWkkljN+qje?= =?us-ascii?Q?GCucNIiQZWEJtuhlVGoyJMtkCqO8wr5dJ/2dZxyeWYVt0pzaAqwRALiSrsUy?= =?us-ascii?Q?P4UG6EcRIbfOseKtP3QDmvqjvAAQEqMWoyyW56ijgNQLuRxHkIOnxV7boIh8?= =?us-ascii?Q?nhzjLH3vrQ2LMCARUiJb1Y1FJrBDDY3r7dg6R6lAffepWJcNost3thCfQ2iI?= =?us-ascii?Q?SW5Yf4YyI2BZC7aNjm4P+6aDcoOGfmBHSvx9EYkIhRRl/i0tAMq5bWartPe7?= =?us-ascii?Q?ZimR4reNrZutY6NL9utDZ87PnVt+G0Y8VEDEMiHlKcC852Ik5ZTBXKHjzkiD?= =?us-ascii?Q?czj3dmYBfPnMnZakeebyVnj8KOHt4wSsTvgVYkvthJJrW9BAbfusjFturkgB?= =?us-ascii?Q?Qp47K0t1RjFyBtyrq08jNFS3jjQpgSfTz7ESNB/Kajyckouel8N2IBaiQwhQ?= =?us-ascii?Q?U31VWvgnj1VyDbHlBxaJXHJuSgMQG9sNHS97ix0ucAzhKi9QkjB7ecQCRntG?= =?us-ascii?Q?tDMlPtIcv1BcTpBUQhID3pdUgSqhq/apJFE/BQzc+QAwpZiUyulAGgJ/XUKv?= =?us-ascii?Q?ussVYJ8hepgBa2Zzsl9ml9D9CJtgLEljOxW0+umTKcl3Gk8TK2jlNHMN1Awg?= =?us-ascii?Q?AgmikHLxeK/pkG6PUIXxv1NtoLFYbmI8l1b9ViEfq+DqjAdSNW1X/+49Pavg?= =?us-ascii?Q?4NJQ3TVzyP+k1XP8agA1oBlp//IOhs1FI2uSgrSCT77gprDMBFG6XLAVjNIM?= =?us-ascii?Q?J5+kwB3Md43NH2qHiZAFerlVS+hjEnhmddSQSdw/h7w53towi9RRd2rxQmwf?= =?us-ascii?Q?syCM3nLj6dhmLLFftAKmwM6v7yi16Ozw4eOIqP6y0exUxBWcz6FNF8wipOP6?= =?us-ascii?Q?rOCYo2rrV9qGPJT6+luUMBZ5Ymki8irWDW9LwVjMW5CknrafR+lXf3AS+jkv?= =?us-ascii?Q?ILlmrsjA73FknkaO8/JDm5KyeLPerS7d4/8kZ5xCR5OVMOHqBqjaWAClnJLa?= =?us-ascii?Q?qnMmk5LOCfXAvOaa7q0XGSbcR23NU0vrITS/9nmjbi7ZsDlBsHtkQ9LbORfN?= =?us-ascii?Q?bovBhGjrHn3UiLelfe6aTJB9uKG17ABIrz26SMrKO8Ti+Fb1uqi04KzHg6QM?= =?us-ascii?Q?EZo5WPOiWXJYiSsyA2DZuGRuBzj6Y6jZGHPsRKxNOyWOc5oPQt7i6gxxLM/o?= =?us-ascii?Q?hbdoSKpIBx6BdXRkiLOdgNEj4Wi6?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TyRCuFcQqYY7oxoHXUMfzd7RiGLWQMJmTgJKcadImHmHnA178Xh5tBV2Pbb7?= =?us-ascii?Q?St3Zw3xoT0KnAynCrCfMU6rdcYSZt47KUv1cLr4LI0d4z7nhRGAjnhLOlRDt?= =?us-ascii?Q?5LcJpwHdXjmnjTuyo79FtYiiHalhoH/JwHEjR/l+FWgjtMZ4t/a2B5pYAnEK?= =?us-ascii?Q?XEam5MlxZzHf4aDCyHS8XHcIcP8zOckNd3hYCaeBiw1pz5h3nyPHk9z/ukVJ?= =?us-ascii?Q?2bLab+znSuUfqrOoRnBQHReBilIFSsoHWeuZx1WMtE6uu/Voj9QZ7N7qB01R?= =?us-ascii?Q?ZP1iKwS06sVSsJoFo/fnu4V0Ubgivc46p1XEt7j2GLUr1DP/0IyfPmgWiWsw?= =?us-ascii?Q?tDKzOudXjsI7qB4i8zEJJns3XAH6PLvJpTuNjfOyiObLtdg3IaAsT2VvSJkC?= =?us-ascii?Q?4wl1utf7NKxXF6J+STxhvRFTSLErik4L4m9VErd6/QtCKY5GcL6upOgiwrBE?= =?us-ascii?Q?GnBo5FdW5FjVXKsVoMhuvtDS2KURJ8ZaufjH6b5PmXeod46I+iGDvMeJKo/E?= =?us-ascii?Q?2K/hEV8j2PULnE8Jy9fQAZ7BWgCweN3gQRmA1Ab3RF1l4qUE7ItComTZMTQl?= =?us-ascii?Q?EEXfr2rKCWOHiZPgkz4mnr3QegiPenQwqtPG/K1tV68KtnBcOgIjcHmyATmj?= =?us-ascii?Q?Frm7Y1px+ANLcY0h4kQxd0QJeOpWg6Ivyqnw63ZkZdV41Mm520+5Q57x1QyC?= =?us-ascii?Q?3UXAD3+fUHo3JHKGUeK/QFgTFiN5rjsNd4VT/dHbt2xMjXd2f3s7I+9MF7Nh?= =?us-ascii?Q?K78Q+uKR2wEti401Drs/uqRtLkUP1sNWubS7Pj05MGIy6E2A7WOWJyMStU/Y?= =?us-ascii?Q?+Fzao6he9RpZnEktbL4WPpECqqskVadLYg7L0ASc3+DrSyflUPZPzPCBIBvH?= =?us-ascii?Q?aCTQLFlifvv8l+HUZfY8LpF/mDDIQbxnjUeEOFns7e5gYyKH/xiy57S7WrF7?= =?us-ascii?Q?qtITXB6zx+JY4RW1INiwirNS+kainufrY8mBB4YBXIeHovexDS+iIT317kZF?= =?us-ascii?Q?nrr7TqCfIcwr9OVkrYOsAEQpVm2a14EpcD0wl4sUQmibBBPtV4AUVGbPUet1?= =?us-ascii?Q?YlX5iGu4WnWK6naLskL4ZhBAjsJ36GIAKojT7MPsTOd/egoxHHVPn2v7lu87?= =?us-ascii?Q?JLLyLtFy8bDdLavV1AcToFEUl8IeN/Q0QKOyuPtTWaPiSqcRxYP7vBheOm1b?= =?us-ascii?Q?qYJG1It7Jw1vJOPsJj7H9TlE2iEBfpnNdr3/Vz1nnYBhXDue8YG3clkaXhn3?= =?us-ascii?Q?meqbQFQchyTzd6HOHI1F7WMpRxIMMpka6FMEJ7p5UVIGqS8M6DR3zwhkCqFx?= =?us-ascii?Q?TvWGDreO+u2rEecWTS2dHXf1meNJiMyfqjZ0QKKcwbGBV97w2FZZmv45Dlvz?= =?us-ascii?Q?diCKmjQHFpPdljuid7wpQUxt9+rSh8cYnZqWTiSNOD94zmnzosKrcEPnIhS2?= =?us-ascii?Q?7Ipe4MpJJrbufuTFYHQDmuptXj7EgiAF4l0qOZkVc/au98H94m24hG0YfyCI?= =?us-ascii?Q?a4eV/ern6tNLqxY2zEFjYpUU1OzM23fD48trv8W8qxzKCulgQqDda9G0PVMK?= =?us-ascii?Q?gUHIco15emmnUVT+9drkdgY6WJx1GElVK4SvAZ9omvGLoHEdu/O/CeZM1iwA?= =?us-ascii?Q?Cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9555713b-74d0-491c-94cc-08dd3965aee6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 15:18:24.7285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ePBPLnNgflfUf58aYAEVeMb2c1JFg68GBmweD7DTx0JEuxMA5Q3CXdw6tgiGY9DL4yQhr8r/CiePTU01nbSf28ZFY7TO8CDZzg3zBN4+0Tk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 14, 2025 at 06:10:19PM +0800, Yuan Wang wrote: > From: Dan Nowlin > > Add missing buffer copy in ixgbe_aci_send_cmd_sc(). > > In ixgbe_aci_send_cmd_sc() there is code to retry aq commands for > certain commands. To achieve this the function makes a copy of the > original ixgbe_aci_desc structure and allocates memory to store an > original copy of the command buffer. This allows the original structure > and buffer to be restored before attempting the command again. However, > the function didn't perform the actual copy of the original command > buffer into the copy buffer. > > Signed-off-by: Dan Nowlin > Signed-off-by: Yuan Wang > --- > drivers/net/ixgbe/base/ixgbe_e610.c | 1 + > 1 file changed, 1 insertion(+) > Fixes: 25b48e569f2f ("net/ixgbe/base: add E610 Admin Command Interface") Cc: stable@dpdk.org