From: Bruce Richardson <bruce.richardson@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, Ian Stokes <ian.stokes@intel.com>
Subject: Re: [PATCH] net/iavf: remove reset of Tx prepare function ptr
Date: Mon, 20 Jan 2025 15:43:56 +0000 [thread overview]
Message-ID: <Z45vPJVtwlNdRiCV@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20009eb6-1e85-4fc1-89a9-b97e5420f6da@intel.com>
On Mon, Jan 20, 2025 at 03:01:47PM +0000, Medvedkin, Vladimir wrote:
> On 13/12/2024 14:33, Bruce Richardson wrote:
> > The iavf driver only contains a single Tx prepare function, so when
> > selecting the Tx path, there is no need to reset and reassign the
> > function pointer in the ethdev structure. This fixes an issue where the
> > pointer was reset to NULL, but never assigned back later on function
> > selection.
> >
> > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> > Fixes: 08eb6a9cc2e1 ("net/iavf: fix Tx L4 checksum")
> > Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > drivers/net/iavf/iavf_rxtx.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
<snip>
> > - dev->tx_pkt_prepare = iavf_prep_pkts;
> > if (no_poll_on_link_down) {
> > adapter->tx_burst_type = tx_burst_type;
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
Applied to dpdk-next-net-intel.
/Bruce
prev parent reply other threads:[~2025-01-20 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 14:33 Bruce Richardson
2025-01-20 15:01 ` Medvedkin, Vladimir
2025-01-20 15:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z45vPJVtwlNdRiCV@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).