From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C065F460C5; Mon, 20 Jan 2025 16:44:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A3B940EF0; Mon, 20 Jan 2025 16:44:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 2F6A740A77; Mon, 20 Jan 2025 16:44:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737387861; x=1768923861; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=z6cU0DcbZfDm8JpZGG1lVMSEZR3OP5RdcyfWQ2rY2CA=; b=kemOIxQzGMTKt2yp9+2++SrFTZq1S4XqYyJKDwfY89fciMRKU30LQBxH SWXt0tncl7vn+Epq8a09aDwvCH9p6w4sFB/5BnkNgINkd7uXs949G43nT KXYbhllBaaVb89eNJdg7JEs6kYKc31fptvXJI6Pr9i1M1vyDbfD8d4DU8 hU3YUY0NLB9CTnD14CTmppGW70B8FJdxNHWdMed7exh+BIpHk7xoeVaO6 Qw9MbNdh60qKD7NvH6x5PMQx2HNY7zLgdIoSuUZyMuX1KAJQNYDzMoRvd vRoHSiW+8ziYybpn/4mpiIQAhHhJtHbj4zg7bjQKd9HgR8wnpsK9vDTMO A==; X-CSE-ConnectionGUID: wqyX1fuvRqams6pyKE2Qhg== X-CSE-MsgGUID: Vcv/p5kNR6yBjwE2FgCeUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11321"; a="41460186" X-IronPort-AV: E=Sophos;i="6.13,219,1732608000"; d="scan'208";a="41460186" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2025 07:44:19 -0800 X-CSE-ConnectionGUID: Z2LIqgwDRmywab9mG23EzA== X-CSE-MsgGUID: 2yLzYJ5LT1+7IvmdbB10qA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,219,1732608000"; d="scan'208";a="106367643" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jan 2025 07:44:18 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 20 Jan 2025 07:44:18 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 20 Jan 2025 07:44:18 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 20 Jan 2025 07:44:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pDp2VQGwphTfvWBG+X4Dv4q43ZcbJjwWfdrJaGhsnBqG/0/sF3zNVQ02nnaEjguPy3PIO909eZkIMd9URwh9eK9Uoh0Tkd0092uV2xaRvDGZqLyzTQpve9xCZ6veETxg+OHfjfCm+v03b3UnSzLjr9nvIDxysU2WWXlPyHGUIgj9eDOVO0fmEHc6CVB1EHWpZQAFNMBWPP8o+WOSU5E8WF8ueaWah7TyqKJjjAElaPbTf4jKGwFuMvMBbBxuEV1AdMkEc9mURrni6M4OL2egiG6NP3T+FS0wyKvFtdULt2+sqZEhweQmpl1LyzL8IuaQ1OonKGvIWjlbDPSedtBSog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QqK2rlI23ErqJtJ13ZDrou5HS1ER3LqBVqSyf5pSZU=; b=IVcQpOkHDDIcow/lyJBh8MFzLz5PEddnqeqsg3YpxRIrYO06sY3WEubfK9QjfvPhqRb2YxR0EsQ5GbKirl3EMYYJ3xKi7ge9xd9lRyIwsvupBhYO+jSupU7qP8urKxzsmT4GYaqYHniTMkySiaoRLNbuxRNWVUlsBJ+kE1PsM3R/e78/fJkSioDazzfiPsjduquTzH4M1p8WDxfvv8s/bqm1/05gpHQYV/FhmI8+b1qsYJjN5cZ3s0jXEUpkAEwO3zdy+L3VIhw4gE1NxlPeTL+TaQKH70wTAz1AFI/Cz2c+AFHD2Mjrg0suZq9666UaFe5USeRA8lTB8a/P7e5wfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB7040.namprd11.prod.outlook.com (2603:10b6:806:2b7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.19; Mon, 20 Jan 2025 15:44:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.020; Mon, 20 Jan 2025 15:44:01 +0000 Date: Mon, 20 Jan 2025 15:43:56 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" CC: , , Ian Stokes Subject: Re: [PATCH] net/iavf: remove reset of Tx prepare function ptr Message-ID: References: <20241213143319.686365-1-bruce.richardson@intel.com> <20009eb6-1e85-4fc1-89a9-b97e5420f6da@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20009eb6-1e85-4fc1-89a9-b97e5420f6da@intel.com> X-ClientProxiedBy: DB8PR09CA0034.eurprd09.prod.outlook.com (2603:10a6:10:a0::47) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB7040:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fc8695d-5f76-420e-6f6f-08dd39694315 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BZ98uPV5qTWs2HCTQSmRQ0TeglE/+3yk4gT7Axg89UFj1tXuQGFKd5sFs7PQ?= =?us-ascii?Q?Awo8TTanZYsxRRff/qkL7NLEGa0y8zS6fkHR1xI789MKdnKVw8FUNqCEytVX?= =?us-ascii?Q?q0d+iZFovnh1b6DHLQCt/gpiCCtKz3FQ52S2X6GFn+jXKwVjFyDiLfdA+a3u?= =?us-ascii?Q?FwbaDVvtVjl00tlUnxH4IOSgPM5ae31kuGVGe6sM1Ma4eGqoVDoWSyyEqsCw?= =?us-ascii?Q?E5qRQG5jbvLXa7VRPzGiCuPKyVxHsYvvSnC+tX9Vaw368v7IV0g1EsdixETJ?= =?us-ascii?Q?Y8WEUZYlv5r9Ud546uiwkZ5/oZo/jx1q9N3OGWa9CfuMlADRJBQQUNdIvBFX?= =?us-ascii?Q?u+4oE8m7TkDETXOudqirkJRdZIU/+UBLmsintVQ3D94QSegK9YycBWF84oI+?= =?us-ascii?Q?pK+GqZf10Ltm7plpG8SKRrkW44gEhMcAhYnagUbbvqH1HBXwhvlRsidL+qQl?= =?us-ascii?Q?vXHYmbtcsmB77YK6kdXAJlEQtUnKx/vVIbQ1biy+rnFFP8bo+uC8+KWOr2lQ?= =?us-ascii?Q?crK52cYRiyuLJBoAIvvQBNlGTJEBTgB1MrDXYrGSvQUQZNMhrfTRf7XYEuk0?= =?us-ascii?Q?/+6jfOGNmeaHK6D+fN0BaXIWGn2S6HQAwf6QfrSrIJsIoz+r+mkgRoJ5HMMa?= =?us-ascii?Q?0YHSC5FK0NAo7B0Ew1feW1LMY3s5eJS6P8eW7SfARXS810Mqe9PKZjoENrKz?= =?us-ascii?Q?SMDUrpvFEGkFYn8H1TttQSlih0Q1VxpxHjQDnU3Ky0rLMZ7erHTpY/W7ltew?= =?us-ascii?Q?AZDJghBihRvNPb362tEZN23mV/raABkxo479mrMwRaynYFTR0P8Q6CatlG+E?= =?us-ascii?Q?AZtnde+3tUahoki/JN74RrMUxIA5ROfJBvq6RChwPnu+J9b6EY9rRjotBFcC?= =?us-ascii?Q?ocgrOZHxG0cJhU0slfoLeBuIgcbVssvwkH0/y2lyrHhFhekARHS0sCULhQ1h?= =?us-ascii?Q?JRNkuAE5zr/SPZCFUp8m3FMY8V8UW7NU7D6N9qo39r7hwuH/bojYsUIN2/kP?= =?us-ascii?Q?4wi64JFQHbYgvjrz2hA4nUiskaFuV+V9mMb5rbZ3Vq2UoTXXPh4alYmujHfU?= =?us-ascii?Q?emXzYn5ape9t7A6aFRil5kM5yXCf/xh3WXHPHmueXxbUh5FZV1JgrAVrGxMV?= =?us-ascii?Q?TL/wduiSyUFyRZJGNEx8R7o2tOdzMkapoMDxRCX2MzJBWvKPPveiFytS3iwu?= =?us-ascii?Q?pKj6rFCP6+BJkt6nND1GTanMGOSJyVhigTZnZh3raBW845PIPdoXiY5smMTB?= =?us-ascii?Q?c73KF621qy8p/NSkYYFpNoJ/wNTDkChpQnHOTcuoUDhkRvqx+hOON45LIOgG?= =?us-ascii?Q?DprXeAYUgYVxKjpovXlAEF+CNy82HmDXplqOIAbS+flOuwuYlpOkaKlcd5tW?= =?us-ascii?Q?ApDLPHF4ifZXsYwW+JuSkoRvhwgr?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1deL3K5mGREM53Uc95NK1lGdtGxrhLgezqnPndAKjO0f8cIWRYnwlRHM/k1w?= =?us-ascii?Q?HGoZFR+PKdQQuVvV93QW2V35vcuuEvT0vfQO/1kmzR+Z7J36ZnpDl3zCZv+3?= =?us-ascii?Q?NC9AAj+JgdRRe8EW9D2mFtXoq7Uk6DYF6NE8KxCvApJepk2qg8gdeLyznt67?= =?us-ascii?Q?GwFAU81sA3/IUx0U1155S7lmWPK/vo+BU09bfDEeU+Jxbm+SUnk5nKMQ9QwX?= =?us-ascii?Q?QlB4FSVmPDTdYQIb0VHDXrhawB8WlH3y0jXPvtZKQmbTuEC49oJY9BiIHTry?= =?us-ascii?Q?SvF8ll4k0UsTNMMgw7FLQAuU0b6zRbaSnRkEHEk7O3ULEXoeeMjEftc8zv0L?= =?us-ascii?Q?s6FuDMgnxx8JMg5Js19UWozdBlOK2vZWAKmx/c2un/6rl3ghf9GaPN1xqmAV?= =?us-ascii?Q?P1zj1KmycmZG/bTveCLCq4qnXgj11PmjsCtBoDjp0ZuJt5LGXyMA9wfw803j?= =?us-ascii?Q?t+WcUVoPILK7o6O6lvozljz0gPdOuLZOFdKHa8sbDDOAcCHUR5kWGkEYsz60?= =?us-ascii?Q?g6lBeerrFzkv07SDZ4vz+IAKXxcDflFXl+DYJCW/IhiCI1Fq1Yvhi2KQq9/r?= =?us-ascii?Q?xk9KZc1XRw1xl5ltU77IeGEkQ3IktgjvHWhj4MRC3Zb1flgi112fiy6fxyb9?= =?us-ascii?Q?u1pJJds+z8Tu8bmkWxnzHBsbxy/cyKGh75zShUHw6SPwgKu37bx/F9tfRdFY?= =?us-ascii?Q?GN0Em4Vh54AYCMCa2muAyLRaSp3smCAUun+msHmL5JotAR4JNCVcMkE2WE4o?= =?us-ascii?Q?nnM3tcg0Zu1uiyoJHXh9KldMp3EYitwi9V3AlnoZ/5rqLwciXn9ARKf1gF3H?= =?us-ascii?Q?+LoEY3wmyinWeD/FVv2obQpzEs70O4t4PZgQ7sxA0Q0VJw7pJfO63HGqCdMF?= =?us-ascii?Q?XkfZ4BFzHbakIrsfsjevXuWteQZ3nD3KbPOv9W2MNwjscqU6yKZKQFTntuVZ?= =?us-ascii?Q?dzYGf+sZh3J+/RPjP9RgXgTyjCAT12+UPE6N1jBTqXbnr8p2Mm1RWWTm+iq+?= =?us-ascii?Q?DlRSTjVKPwFWuJ1uFIuUSkUEwbN9c7qtVOTbdwRXInQCnqehxJQ2oCoWNhwm?= =?us-ascii?Q?VeoUFID8HelDGJWWj9yeMAZyK/KxavnIhMgYwlot1SQ2FcZ1sVePSAhdQqUw?= =?us-ascii?Q?WExcptFPJCdRdDhRpNnF2iKkMTJYcjROnyXMsxTtvXRCPUpTdz9yBxWqKnZX?= =?us-ascii?Q?g8PJLBJh8CmUDgiAlWI0ClSO8fIxuTIcYmhroqze8jJQgqdPUU7KxK88YBej?= =?us-ascii?Q?1xRGAOFdIoaP03uFYfcX9vOLZ8Ku0A8eJ+tk62BGn5GuEtN5G0nF38+XCGS+?= =?us-ascii?Q?aolymmtwsPFOAr2y3Ba06Riru03nB2wZNGxGGOUYjzRIVdzBsnCecnFfFhFj?= =?us-ascii?Q?XWMLHeIFjddbP27012IMeQgj7Wf7bHkpOGBpJFfOP5VGblKig0ohgseoNs3y?= =?us-ascii?Q?5YLyd0n5ae6JAICSO4snj0HJdQH1Z8azSov93InpQXUgn1zAsBFEzCbIlFoS?= =?us-ascii?Q?MGQ7F8UaO7amyGVLmMFK+3/f6wAnFBxJw680EtSrnC+96b8lOzqPLu1UME65?= =?us-ascii?Q?drdTdVDSU3GocfqMwBWrhBQlrKwwinWYrFiWslH2XsFDuO7wL21cp3p7YFu6?= =?us-ascii?Q?Lw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc8695d-5f76-420e-6f6f-08dd39694315 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 15:44:01.7530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pbZmzevayL9R9hN1HO9CaWi8Lgvx7qNUWBNsnbqGwROS5Z0vqM12yJgZZfqOVGI2x1PJ0dnkZNlwg7x2g9gJKNtknZxKoIOQHqTsVM+6HGc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7040 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 20, 2025 at 03:01:47PM +0000, Medvedkin, Vladimir wrote: > On 13/12/2024 14:33, Bruce Richardson wrote: > > The iavf driver only contains a single Tx prepare function, so when > > selecting the Tx path, there is no need to reset and reassign the > > function pointer in the ethdev structure. This fixes an issue where the > > pointer was reset to NULL, but never assigned back later on function > > selection. > > > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") > > Fixes: 08eb6a9cc2e1 ("net/iavf: fix Tx L4 checksum") > > Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > --- > > drivers/net/iavf/iavf_rxtx.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > - dev->tx_pkt_prepare = iavf_prep_pkts; > > if (no_poll_on_link_down) { > > adapter->tx_burst_type = tx_burst_type; > Acked-by: Vladimir Medvedkin > Applied to dpdk-next-net-intel. /Bruce