From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B2AA46075; Tue, 14 Jan 2025 17:32:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4A3740299; Tue, 14 Jan 2025 17:32:53 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id D229E40298; Tue, 14 Jan 2025 17:32:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736872372; x=1768408372; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5C5UkCI7KCrFU90uCNAQU1+ESE97lUWoJR4cxcs7JWw=; b=Rl62OhMB+USsqjTVpWq0Bx2R6teaa0R1luGJD0jtGgU8B63Yqb6jFXNF 5u80PgBlacJK5tmNSk9/rp9Ek2a1Lnic5rQOr+uBpnBokqoTA2VPAwEok XpgsiWoQaCEacI0kGTTCqr+8vh7+wucKFBbLho6qvKf+DTkYMJM+E61gj WzK7ca/RDdRo39Kp4XzbYqUiMiZ64VhiI7cU/BewO0MmJCqzAqUrVv0BB cIRNSpr+Ta8qC+mURRze9AY9qbFJ9xz/+pnwfwnI24qHuOcDGg82pgU0L moXdISzne05+VO2GxXmxMf585+OLS/gkcwH3LY5gVuj5+jpC4muLnrBcT w==; X-CSE-ConnectionGUID: LMk3g7jFTLKXBxV54prvTQ== X-CSE-MsgGUID: mKdz/yXZSNqkEhVxpMz7ow== X-IronPort-AV: E=McAfee;i="6700,10204,11315"; a="54718854" X-IronPort-AV: E=Sophos;i="6.12,314,1728975600"; d="scan'208";a="54718854" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2025 08:32:51 -0800 X-CSE-ConnectionGUID: 8pEZ7hOGTSK0uKcgtsUj3w== X-CSE-MsgGUID: GH93N7sVTt+v3t/IRnrfMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,314,1728975600"; d="scan'208";a="105367734" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jan 2025 08:32:50 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 14 Jan 2025 08:32:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 14 Jan 2025 08:32:49 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 14 Jan 2025 08:32:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZmHh81dwcd56sgqlfu0DB9rQp4JWq7tAhQlhKWKY76Spp3XtBv45s0cW1GSWEDXnMVR0qVP9f2MjK+GmeErwDss3NhyPW826BwQK8wzY0Wo8AJa+88DlTetd9zsfJW7opXulcnuXgyxFjj97OfXN86dNNIqZcTVK7ERegKdwxiKt9RgSVpyxl/OZJCe4Cmt4PzLrnuWir301o8rk1+apnuZnkRKHNxkXehVB5RzFR+pKmdbhNXRFywXrJlOHGtyYIGq+RkMNPETLlpVS0R2+D/NhZ3pS7NSE9vzy2PwN93XXP24ZTb/X+Fn8ZiY+JRjUsuPECKXb4ADqCkRRRCnVZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mEJTqSIBlupl3x/DzAOBRZmkbfzYS4R6b1TIf8kN/Tc=; b=y9Qsc8psDsWllnas8FcWmGC6sG5FeszfZVoRcAJ87pj/qh2MT0g5ZbMz/20PzHjuxLuTbOgbfIsIg7mu30UTgCls0+B4XU3k6sPoDGmwrVt6HfhgXLB0hkXLNLzbfnuAOog0wSjilEmVU2TQxCe31zmsrXXBpWEiffinsi8nyO5QNiV5+JHHbW+r2uEJntFzCBFqgGq6A8uiqkrqsOluxB2c1yPQU3qLb6TKKiOfnjhm7s6FlbUWfWvXp69T0fJdfovNfB1NK72i6Yc0p/qvOdD1rsBUKycuzm2bUMvQ23Z4v9UEQwOiZF8vpBjJHGdTRWljWIyA9sGQpnIql91Y9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6346.namprd11.prod.outlook.com (2603:10b6:208:38a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 16:32:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 16:32:18 +0000 Date: Tue, 14 Jan 2025 16:32:12 +0000 From: Bruce Richardson To: Andre Muezerie CC: Konstantin Ananyev , Neil Horman , , Subject: Re: [PATCH] eal: fix undeclared function error on old CPUs Message-ID: References: <1736871673-25398-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1736871673-25398-1-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DUZP191CA0067.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6346:EE_ X-MS-Office365-Filtering-Correlation-Id: 5972df46-c6fa-4fb0-d70f-08dd34b90362 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vQmM8k5NEY5Q9yMw8seQ1/vsd29K+Cj7yUBP0TKDaWkF78VOyKyrm4LS5yZM?= =?us-ascii?Q?ry1Hwm7AX7ok6rYg3PAkiP2EstsOeNNzScjoFqTcsvSH+xRK0Q9vu9ANw7Sc?= =?us-ascii?Q?vvyI0fH7lm0KTr+jGhAp/QjEUIUq9OdF2k4GWKtZeHNyQ12+DnP9VFMGSXY3?= =?us-ascii?Q?gglnYfBF5MBQZ3IzIrmv9GGpYrTEZ7JdO3ZeHvnd+descBj3oXcEVZIldt29?= =?us-ascii?Q?g6CNvFTzfpXq8lb2JtX92k4RbnxGbAQTcX2WrIQ5kXpIGBZNlPez9hzcXbVC?= =?us-ascii?Q?QQtTBWV8BgNLYAeVY1b4yxZKVNAEljQTE0fJYpYYZ4Hi7njTmp9jh/kzEGIO?= =?us-ascii?Q?0S5tV6P1rJiCUbwTB8dmztcjJL2m0zD2KDwV+CY3/YrpNw5LBT07B4ZMhDTG?= =?us-ascii?Q?aPjzitmDKKuk7nQJ8g8DX3hSKzfWBHKFFV0S8qLl7IpPCtojX2XBz1GinVrZ?= =?us-ascii?Q?8Mtz9wHZVoFfb1QB48VppBuwe/Gytlkdgcp/kw9hq1qb0CuMug02muyH90qf?= =?us-ascii?Q?N7OMTPHLkYWixAXURvrW/567yImsXVf31wEabPUaENAELjgwj+IIwH2OfsJ2?= =?us-ascii?Q?HB/s0ygVa9r1XDn/ITtj5BQE1yH4tCCKAlMgMr+DnJVsISsjfiHcqWsYOKpK?= =?us-ascii?Q?iFi9PqrGkBlkShY2ycS1hpwZAzJRGwS1O0e4434rYI6+/+VWQlYSw8IIYNG3?= =?us-ascii?Q?+NVsQJTGYE0eVsIdrOYHpmGA/FAds4zV59Oy5VvUWz50fQ8u31AjxsalPBEC?= =?us-ascii?Q?L89UGyAqeWniyPM/RxF1xoQ5D3avij5axRoLHDCoOUKttZ80N/58Zu+eAeRz?= =?us-ascii?Q?5I2bCUbSt2KyG6dPEGlzHsyu9uxut0w9e1VTl9fEEl7X6U2SxNsJSyG3doCA?= =?us-ascii?Q?og35IPMABa/bVxJfDMqn1Dh20ceTtTfW4wt9djUsoWdNIbLk6W1SPs50oIqu?= =?us-ascii?Q?oNyMpAynBL8gfS+bD2iwXFcMzqDJAgWwdCo8LKyiujvFUE0a9HcO76hxX3bU?= =?us-ascii?Q?cUC5MqkX1s/r6g0BqiyA2TTnrFQRfdT0r2kkACIEGfGbrBqYevtycjTbGZ+I?= =?us-ascii?Q?DoTdo/diZ3fg+JU7+kkGtKjsFkLzxqzHiheddbF4RNpxn6gGwnqkkU0yAA0L?= =?us-ascii?Q?MVRDlL1PwqlWV69IDJBanX2nehCzdspaI8Fkr3HWtKHAiad/RORzTaedjxpy?= =?us-ascii?Q?84NTHyKzMOyLq7QNWrdUJaO93E4en4kEB4kyLH111c4abmOFiA9GdPYSHnPD?= =?us-ascii?Q?D4qOkmLZcP8VP58en/fJB9KSjFE+1qoFwwM27ktT9d2QItXCwMb6wxEfD30Y?= =?us-ascii?Q?E0F7ZVEsYjSgKC3jTYEnsNWy3YchaXubxA5mU6+wBZsfo3dySID7ZgtwxrDD?= =?us-ascii?Q?kZRSDKDPPTMnn7UY0CVa2fdXs9Kj?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4sAtbHi2PB4Nxy37NYtzMWXOqkJBiT6yPdEgD8U0sbPoTaST6vSgodk6IvBe?= =?us-ascii?Q?ReKDb6tdjRihPOIahAgv+QpDV1utH4CAShZvZYGGeMbrA8aGQi9d49vO9C5K?= =?us-ascii?Q?z4vsiwE0KMgDDOamZqf4cKigxuy3F91/1o+eO3BuJd9Rbx39gAP3Lxq+QZ9d?= =?us-ascii?Q?tR76Psy0ZmMTwXgsyrd5r2rCplHfsRLCv9pTo+Qqb13LxD3c7Ws4zNpduoc9?= =?us-ascii?Q?IMYTTZYgi7gOCb1qFHhnGC0NE5y0ICLsqNF+n24qv1o7zALz5hA1n621XmPd?= =?us-ascii?Q?fu3s2GFGXYKcn7jjsFDty7wPSoDFmYukaL7cD3IGJKMD804fR0uS+Majjxog?= =?us-ascii?Q?OuzZAn/SfD7PxaryF5EzbbuyQsjuSdJFCQzVfNpC334kHZXDgC3u2r3WaNVv?= =?us-ascii?Q?jrtfA+C46rDCMrRBZbHBh/1xEsWPNfNSH4ccxNp/4mExeHhqH3vq/a56w5E/?= =?us-ascii?Q?UVaOus2c1NV5V07EwVApQJW+oe+mXjJ7ki7FlpAY5kVnAY/WdfpfySySC2nQ?= =?us-ascii?Q?DdgJAL5CW9QyBvpIl7UQW0jDzghH3tNqJkkGse+k93CfvlVgRNMuPrd4+sy4?= =?us-ascii?Q?TNCqGfPiiAeXpOSR8Hmhy1upN85OkzfPYucNNhWEnQea5efaMsEIVIQN6Jg1?= =?us-ascii?Q?e6P4tKYB8HWXHZzQqniemayNJWb6oa80q+N1ZmSwTyZAs1ICUyEJ6QvngVYU?= =?us-ascii?Q?Bc/TKlygOQDwBxFObAHOZFKIkg6CgQ+pVjVHFMRwS2x8eqveuJLFVT7lrsHO?= =?us-ascii?Q?lQrjp4gBDzulw1Kuyz+XBJo8qA1kYrAMvIZVsgzGDcJ28gs+5G7mHK0Ia9ok?= =?us-ascii?Q?pkQgc3izAUe+5WpTnG2S2w1K0Zizyjy7GLLZsbiDK0WCgGHuBj1AGLsvlQKt?= =?us-ascii?Q?33LcICmP+KakWpm8U66t2z0e2HjxmdUfwszkBJyJfXXXrLWWEoZYvIZo/Zqo?= =?us-ascii?Q?OIiYrOGNnjznuXu2hGFrjSaZhWqMg1EKiXvarqh1sPHC7EdrUSXRT9HTG/Dd?= =?us-ascii?Q?waX1MUNu85GNUCF82Ecza9fwhHRZXVdu65hFJNYm0Kr+rKNU2ZC+xFouKMue?= =?us-ascii?Q?H44zty5V/wmG/ik1+bqxK1kMroE7cmD9S1kX5I2hLG2RaE7zVXUNvRTb+CyY?= =?us-ascii?Q?FWW1QjiUmal57u3fn5WwOBUUSL53QLLqCu8se1wz8CeC3+CML1yc4v6OQNrq?= =?us-ascii?Q?QlqYmUslZuPr/zVbgTV8HK9mYtyu8eoLlk5QCRM0EActloFfib0dwjKlrE5Y?= =?us-ascii?Q?coO7Oo8iHF3JCEw6bs9b97goV5ugihryaIH5Nenq9NMbqSsxp4djuGyFzsMa?= =?us-ascii?Q?UIhUh4U2RqPteYJKtgIrOGHNdetTInC3ami8nEwcaF+YChtXF4e78gof4HB+?= =?us-ascii?Q?kRe5B1nzpuFmSYFMOAfEGBSR+Fm5HFjkf+i160vNyLB9reucr+huToeof1P2?= =?us-ascii?Q?U0nQGKlnbUhIZHeQhfcVO49XkwQ1O87JNplorvcXwFlRwBRtFwveU3p/yfK3?= =?us-ascii?Q?Eo4P7ur22v9SAdzfZTrs0w5Zsq7V1Mxwd+hp8cPz06ibjwhlAxx8AXz3LF/K?= =?us-ascii?Q?OGggR/qXA7E0td0EqxwAU/X6tctWDi68pQuZ73Aenj+jvZZ/p4efQ42RxwsC?= =?us-ascii?Q?Cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5972df46-c6fa-4fb0-d70f-08dd34b90362 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 16:32:18.8324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RyMexDxGj6jAofvP0+J1Vzsq0b13iS86/BPOOOQgOIHz9GGsR6LrHTqJjkaLVGz7YaT4L3AL36pu1mz5GnLlBbJgeNalQNxD34j7cmqtzYI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6346 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 14, 2025 at 08:21:13AM -0800, Andre Muezerie wrote: > Error reported: > ../lib/net/net_crc_sse.c:49:17: error: call to undeclared function > '_mm_clmulepi64_si128'; ISO C99 and later do not support implicit > function declarations [-Wimplicit-function-declaration] > > The fix is to remove the unnecessary ifdef around the inclusion of > header file immintrin.h. This header also contains functions that do > not require AVX instructions, so should not be included only when AVX > is available. > > Bugzilla ID: 1595 > Fixes: da826b7135a4 ("eal: introduce ymm type for AVX 256-bit") > Cc: stable@dpdk.org > > Signed-off-by: Andre Muezerie > --- Acked-by: Bruce Richardson > lib/eal/x86/include/rte_vect.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/eal/x86/include/rte_vect.h b/lib/eal/x86/include/rte_vect.h > index 5ac3ccfd82..5fdcd632ac 100644 > --- a/lib/eal/x86/include/rte_vect.h > +++ b/lib/eal/x86/include/rte_vect.h > @@ -19,9 +19,7 @@ > > #if defined(__ICC) || defined(_WIN64) > #include /* SSE4 */ > -#if defined(__AVX__) > #include > -#endif > #else > #include > #endif > -- > 2.47.0.vfs.0.3 >