From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C7ED4609B; Thu, 16 Jan 2025 09:57:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3863A4025F; Thu, 16 Jan 2025 09:57:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 10E5F40156 for ; Thu, 16 Jan 2025 09:57:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737017864; x=1768553864; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Zl3GI4qNXi4qyeNYi04MQ+EZf2y5p1tPLemSaIuNzbE=; b=QIs4UD+hifRfuH5GNQ7Uu86sh0LP/sI8wXt5oYEQkjDVqupFOVwUBdzW Ws40Y0HncyFwNp4R1YvzS8ktZ85CXVRawJk3lP0OQvMYl+y+DNyOtZeT1 kEE5uaOzKbDLZTctuV1H16S2rAmNzITNVZ2F+FMq9AvSZD1BuFT2fm0El ndGhURTQAeYQSa8LaL07hwaCpFhRrVjlosrpb1tS9RGKStua9+x/WllZK tw0Fl1bKZbAJyBqVOH9nmNLgSoLjX/bbxTHZ6ivoKfYAmy0mkAUlcCnZh 2EhjWIsikEX0BxsRfKnR/bbISs8Xt7RGiUwa1RFzxonXoxRyvrLoA4mW0 w==; X-CSE-ConnectionGUID: c1gJGRxGRZmpm4VnM62V6A== X-CSE-MsgGUID: BYO1Cmj8SXqyiJJGZHAOCA== X-IronPort-AV: E=McAfee;i="6700,10204,11316"; a="37308953" X-IronPort-AV: E=Sophos;i="6.13,208,1732608000"; d="scan'208";a="37308953" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 00:57:43 -0800 X-CSE-ConnectionGUID: GbSCiGVXQ2KuuVa/qqmeMg== X-CSE-MsgGUID: msSMygaPT4mqZwsLxBlCXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="142678913" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Jan 2025 00:57:41 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 16 Jan 2025 00:57:39 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 16 Jan 2025 00:57:39 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 16 Jan 2025 00:57:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ypszd+7AIQf49L3AGWnKlI85B9pfZCYRvxjXK8fvaengpJq0u5BzFZVoX7+9sQGS0vQsUzG7uzu7qgAE24oU++X+pQapayZnhoPZ3zgb1A0wIkZvgcPkImKCVVRMzkJbGdpF9aI9JmG6j+tIqluArorU691Xc3NIPR6WxiivJdeNzDNm0BYCoYwm6VEoDv/qq5jSBxy3Kg07HvG4dh+aNbbWdSnO0n65kYjhM580xqfy/J9lJKDZ6g4Q1yEas2zX7NxLfR4yt315f9+H2t1Dm7926BmLELPuKRp6G9n9i/oPBj4dIUu7/q9lPLwI0yeNpJZs0YouFtbuE5904rKsvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eOsDfaUtWL6pCjuQ7xMmEAgyTa9Iji39qjA5cxD00c=; b=uJH/zo1RSNzife2KDjf4aXsGKjkIAfC7DPIESqMUNChpQ/sQKtqht5NHS709yQL+EUt5mUtCi3W/Mir2h9RZgMcNO6WoG1JDH6pgINfJKJUeVRngKoBeXivFMb9so2yjGboLHEwErhMyi7t5L5WdR0Jxb6lVyyX3NxI+8WkAe6Ylna5PsbgHrLOm3DAuju7FG3faazzyNOJqkMU+PjcokVfu6IRgYbbe0/5EM29rm15ypHYErwkDYMuN7pjVBXGuwnqzq7UfnZgJ3XHR92yIM1QqCRhcPoiInCA1aO+OfDPgVDFPhW70avWynWM9gpoTbyP5gq5LdTHkBjcqZMBqnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN0PR11MB6160.namprd11.prod.outlook.com (2603:10b6:208:3c8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Thu, 16 Jan 2025 08:57:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.010; Thu, 16 Jan 2025 08:57:31 +0000 Date: Thu, 16 Jan 2025 08:57:27 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Subject: Re: [PATCH v13 3/3] drivers/net: add diagnostics macros to make code portable Message-ID: References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1736992511-20462-1-git-send-email-andremue@linux.microsoft.com> <1736992511-20462-4-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1736992511-20462-4-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DUZP191CA0049.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN0PR11MB6160:EE_ X-MS-Office365-Filtering-Correlation-Id: 764ee032-5e89-4a9a-78b6-08dd360bcf97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?U2YXNaguKDszfc4Kj3sYKN5y3RkHUGpFBFNXv6PdbK9hKlzUSpjwwUl3TqKw?= =?us-ascii?Q?APVnTqT9aXISkzTfa3gkJRpUXNbVE/Kd1X+Pn5b1poSZumb2Tmq7zzUQrkA6?= =?us-ascii?Q?kR6HhqDHKw3iN5vdPcYdv3oUGbwzHFnsY+AeJKsMYUPRgWKw5ck5DPEhYJYf?= =?us-ascii?Q?PfEa+CRQ2hernQmtO9W9Y9pq4eGYmCZsLDO9lxdWeUfwh45l4imlQreeJndx?= =?us-ascii?Q?+jZYlLn0N8sr2oniMc1jWh7sHitunyOxjDy2RUdoTPJilUN/bMVpAz8AwqwC?= =?us-ascii?Q?Qty8NUurA9xeh8m1P0WoFeVWTpM9plDSD4zP0+KPgPS6bgi2XCguorar/o44?= =?us-ascii?Q?fqyLn6ABhbF/f/7+uyXNI2hqzezbV/4HLLx8yWyXfQ76aafnMZf1zqEuKGdf?= =?us-ascii?Q?+Gjwlm2hl7YfkyrvE0AnpGMIOfBnIaudDpUELEoZCUvfUuE4EX5MCvCEPWzv?= =?us-ascii?Q?/YQGT0B/CMiVFnFEWa1zQvmTRuYsVKEhYQOv9ER9ueppQgMBlN1XAOlNx0XY?= =?us-ascii?Q?7oojKeQHazwLVVn1P8XliRXnwoVw9DK/LZSQmUVMgnfp0P70RZlpfPPf/elI?= =?us-ascii?Q?cvUoBnweu9veUyNH9N/1BKuAl3Cl6vulKHJ2oSRKP4JcXGtYbx6a0z6Mohdj?= =?us-ascii?Q?Fixe1GPiTUaIXFwXkTvuxA8FLGvqtSq7xMRs0Rigm0xQE+RE3CRjxw0/BHy2?= =?us-ascii?Q?5nKJfDi7p6Wqb+TRu0rO/9gzslIsNvJlesdbVizW+CsYzVGmhecpJ5dZWHws?= =?us-ascii?Q?M2ONME33E8Ys2V8vO0HatIfbPbvWXbWZJ4JMzrrXP7rFKUY7tLL3pvzrFO6D?= =?us-ascii?Q?gYaOEQCftWpIB/j4wBzEe1y8wKpk+sWdp3M7QpcQayLj4hCOlvBnmIKaLIsT?= =?us-ascii?Q?eL6SYZHHHn+82PeOcfSjqRhfodCJdjX7onrYYVHVqmSc12fhAMW5Vv5c2XX6?= =?us-ascii?Q?aSKtUYReAZ+bYPr6nnVszIUTrUNi0mXjUugL4Iyat1QBUwOQbmcXtHJeGEeS?= =?us-ascii?Q?way1393Veqf5KpeeOJHh9/FhYXbOjYlW73+0/hQn0+D9Vs2tG7oPrGrsn151?= =?us-ascii?Q?sfihGIG6EGTA7Ptcp99hI/I51DE6W6fYeYEDWj0FS7Nr2pg/RxCnQ9uIyUK9?= =?us-ascii?Q?Y+pGy3QQwYkjekDe6K2BpDlFYPhUbTnQg5szuBmtfwmivN7maW/k0DGhKHmO?= =?us-ascii?Q?1w97YQIHZ0OztGhsvvdpqEfgQvoJg0K1KBCiiFZJ6xdKKgshQB+Yjsbxern0?= =?us-ascii?Q?JLBweUR1DqAcdQx4cX8URJIlOM9PN0wv9duDOx8zurnlzX3GIy00RywkSSEO?= =?us-ascii?Q?ZD+cvXCY0OEDAOATU2RB78bAS3PGOCBKaP1cpdQQlCUTGg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?39lBps76ZBlV2StY2MXbheDP1OlV9oetvkhzDHx9lampqWvqm0xSePpswFCA?= =?us-ascii?Q?mKQEGsQ4lSbXO6XvhXLnORXUhymN5kFQXzulaulRFzeCGPsWfJvYUrBPPYGk?= =?us-ascii?Q?/VWY9q94kh7UncS+cij0GbzQ8NhaQ7g3/eMNjtGHPz6N6XpqKrSQk7bGDjYg?= =?us-ascii?Q?T4yY/ycWMFxz7b+Xp/Bx/AVbLyZ309YRTksZtYBSBlNg4B3NFRrusS5PdVTT?= =?us-ascii?Q?gPhjPlOPxZciGhModqmQaaIBFiS+3MYFGlVry1ltv+pIDA42JLvMV6v0AVd0?= =?us-ascii?Q?AbLXrJvqHhEL3KgRZE3D5LMDMelx4g1BvJng1xF4YEW5jb46nnIcIEBaaZ2g?= =?us-ascii?Q?LC84xjt8uJG+GNwcgeg2179yRanGkw/58fbBQBlEnbRmNJ7wQ4t/tutaXxnh?= =?us-ascii?Q?0KTZ0TRy7oZstzK+hp4TnmKTDg76MOf7HwCoqyG9d0nD1FcgTW06B2zXuV7b?= =?us-ascii?Q?sCHgtlpdoW8q5yb2MQpyjo5Q2+dgiqMbLMxUtMuumNTB+1SqaEE+dOKwOMWp?= =?us-ascii?Q?eObJW/gr/0yKMdPpF3L8caS2xuYgHzpIlBv8OUfJ2xJBax2BxMD7mTjJzFhT?= =?us-ascii?Q?z3a3Ud+Y0+2n/ipyqfV4zykxRE4pW5S/j049C5STyDg5JlWgEhWVMov+B8yf?= =?us-ascii?Q?3hSvE33SL/DZJ2KDdHNCT/Ja1Uh5750+tD+6sMKeB5JeFNOHgI/ZJErqzXp2?= =?us-ascii?Q?gpapZGQCPwGKR0j/c7qZaly2vky2EoPbKlh2KTbvQY5K6WFnMKDnHAs14CdC?= =?us-ascii?Q?qBWCpLzd/+BJ3V3epZ2dJ6ycksarddOkdv6MV6A5QorT2mSjvQX1aPk0Oo/U?= =?us-ascii?Q?qN5vcv9s5JhvSFApsmKlPTvgMuW6KPJ47EkIIDE759scgmUe08N+hLWcAErK?= =?us-ascii?Q?gXtHzW4UKyw1BZ1LpCL1zdMysOHJcUOjr6zxGiTVbHMiEn6inH6tMchxKHoD?= =?us-ascii?Q?DDYO24WxWY8urxCBe1VEm0pcb/S3AIzp7L/RHP2mVevh5JwdWsAyGG+Mwx2l?= =?us-ascii?Q?U38vJqCei/ZqhVoL69HMqFYfMLroM29N5eNNo9a/9S+ob2L6am8XC79uJ+Vc?= =?us-ascii?Q?wTDZNZaww0kZYQjUSgV7GJ0aVz7fHuFQMwViiYCtjADhVoP30qvn/F7ZtSXQ?= =?us-ascii?Q?k+bUCMIilzWQMfk/QceWFVylUDxNjDB6zwrd/VZuLp21acO3oTsWEMkeQx+l?= =?us-ascii?Q?qqDHaeN1wn+1u3R1G26WR5IIMu00XfhJ6IFtT7IAbqJatsU8AEnGl4S+QBgn?= =?us-ascii?Q?IhJo+a/FTT4an+St6d4uz30qQzZqy7cOxp5dQU7TPccGSwO/uF2zTOMf7ffS?= =?us-ascii?Q?aVuTdbTOm3oY/QE7IhESRnElhO60Q9dOoI7Nw6Pq3k/6VOwZOYcZ/0Qbuiki?= =?us-ascii?Q?QW2TOK0fSFkcp7xU+Ll4tCr/WH8oUygbi0H7ADzIedc5kRVy/NVQs/moyzFo?= =?us-ascii?Q?tI+X+EdXeLw+bsCF6bd/4zRZfaB/j5jJWqmDGf+rH/yzGO7AE/MyQTm8Ji/l?= =?us-ascii?Q?aEtKrnGEy5g8oAqhmpd9VXzddgOzQqyRncDiABICKJi1maVeTm4l0tiSDm/z?= =?us-ascii?Q?WISlxzHaqPCPZ9fFc9HEEC0JfG9FmyTmjpYgyMgxBI4+g0hwfTmplgbFFz4y?= =?us-ascii?Q?AA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 764ee032-5e89-4a9a-78b6-08dd360bcf97 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2025 08:57:31.4202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H8tq/rDjd+t3+niPDnfG3eNuQiLIVFghBteCVHjFn0LqexdZZOoUyaMXaVpmMWlua/o8x3wIcJdJXs3qOVASl5sZLox+wKfpkVOBCJopQSs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6160 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 15, 2025 at 05:55:11PM -0800, Andre Muezerie wrote: > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC's pragma for > compatibility with existing source code, so #pragma GCC diagnostic > and #pragma clang diagnostic are synonyms for Clang > (https://clang.llvm.org/docs/UsersManual.html). > > Now that effort is being made to make the code compatible with MSVC > these expressions would become more complex. It makes sense to hide > this complexity behind macros. This makes maintenance easier as these > macros are defined in a single place. As a plus the code becomes > more readable as well. > > Signed-off-by: Andre Muezerie > --- Acked-by: Bruce Richardson On a stylistic note, I think you can be slightly less aggressive in wrapping the new code in the patch. DPDK allows lines up to 100 long without wrapping, so please don't wrap at 80. Thanks, /Bruce